From: Greg KH <gregkh@linuxfoundation.org>
To: Pragat Pandya <pragat.pandya@gmail.com>
Cc: valdis.kletnieks@vt.edu, devel@driverdev.osuosl.or,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 01/18] staging: exfat: Rename function "ffsUmountVol" to "ffs_umount_vol"
Date: Tue, 11 Feb 2020 11:27:01 -0800 [thread overview]
Message-ID: <20200211192701.GA1971434@kroah.com> (raw)
In-Reply-To: <20200211123859.10429-2-pragat.pandya@gmail.com>
On Tue, Feb 11, 2020 at 06:08:42PM +0530, Pragat Pandya wrote:
> Fix checkpatch warning: Avoid CamelCase
> Change all occurrences of function "ffsUmountVol" to "ffs_umount_vol"
> in the source.
I've said this before about this type of change, but there's no need for
the "ffs" prefix at all for almost all of these functions. Can you just
name them sanely instead?
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-11 19:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 12:38 [PATCH 00/18] Rename some identifier and functions Pragat Pandya
2020-02-11 12:38 ` [PATCH 01/18] staging: exfat: Rename function "ffsUmountVol" to "ffs_umount_vol" Pragat Pandya
2020-02-11 19:27 ` Greg KH [this message]
2020-02-11 12:38 ` [PATCH 02/18] staging: exfat: Rename function "ffsGetVolInfo" to "ffs_get_vol_info" Pragat Pandya
2020-02-11 12:38 ` [PATCH 03/18] staging: exfat: Rename function "ffsSyncVol" to "ffs_sync_vol" Pragat Pandya
2020-02-11 12:38 ` [PATCH 04/18] staging: exfat: Rename function "ffsLookupFile" to "ffs_lookup_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 05/18] staging: exfat: Rename function "ffsCreateFile" to "ffs_create_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 06/18] staging: exfat: Rename function "ffsReadFile" to "ffs_read_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 07/18] staging: exfat: Rename variable "LogSector" to "log_sector" Pragat Pandya
2020-02-11 12:38 ` [PATCH 08/18] staging: exfat: Rename function "ffsWriteFile" to "ffs_write_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 09/18] staging: exfat: Rename function "ffsTruncateFile" to "ffs_truncate_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 10/18] staging: exfat: Rename function "ffsMoveFile" to "ffs_move_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 11/18] staging: exfat: Rename function "ffsRemoveFile" to "ffs_remove_file" Pragat Pandya
2020-02-11 12:38 ` [PATCH 12/18] staging: exfat: Rename function "ffsMountVol" to "ffs_mount_vol" Pragat Pandya
2020-02-11 12:38 ` [PATCH 13/18] staging: exfat: Rename function "ffsReadStat" to "ffs_read_stat" Pragat Pandya
2020-02-11 12:38 ` [PATCH 14/18] staging: exfat: Rename function "ffsWriteStat" to "ffs_write_stat" Pragat Pandya
2020-02-11 12:38 ` [PATCH 15/18] staging: exfat: Rename function "ffsMapCluster" to "ffs_map_cluster" Pragat Pandya
2020-02-11 12:38 ` [PATCH 16/18] staging: exfat: Rename function "ffsCreateDir" to "ffs_create_dir" Pragat Pandya
2020-02-11 12:38 ` [PATCH 17/18] staging: exfat: Rename function "ffsReadDir" to "ffs_read_dir" Pragat Pandya
2020-02-11 12:38 ` [PATCH 18/18] staging: exfat: Rename function "ffsRemoveDir" to "ffs_remove_dir" Pragat Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211192701.GA1971434@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.or \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pragat.pandya@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).