* [PATCH] staging: exfat: remove exfat_fat_sync()
@ 2020-02-19 16:17 Kaaira Gupta
2020-02-23 8:07 ` Valdis Klētnieks
0 siblings, 1 reply; 2+ messages in thread
From: Kaaira Gupta @ 2020-02-19 16:17 UTC (permalink / raw)
To: Valdis Kletnieks, Greg Kroah-Hartman, linux-fsdevel, devel, linux-kernel
exfat_fat_sync() is not called anywhere, hence remove it from
exfat_cache.c and exfat.h
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
drivers/staging/exfat/exfat.h | 1 -
drivers/staging/exfat/exfat_cache.c | 19 -------------------
2 files changed, 20 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index c4ef6c2de329..e36d01b6fdc9 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -647,7 +647,6 @@ s32 exfat_fat_write(struct super_block *sb, u32 loc, u32 content);
u8 *exfat_fat_getblk(struct super_block *sb, sector_t sec);
void exfat_fat_modify(struct super_block *sb, sector_t sec);
void exfat_fat_release_all(struct super_block *sb);
-void exfat_fat_sync(struct super_block *sb);
u8 *exfat_buf_getblk(struct super_block *sb, sector_t sec);
void exfat_buf_modify(struct super_block *sb, sector_t sec);
void exfat_buf_lock(struct super_block *sb, sector_t sec);
diff --git a/drivers/staging/exfat/exfat_cache.c b/drivers/staging/exfat/exfat_cache.c
index 3fd5604058a9..790ea4df9c00 100644
--- a/drivers/staging/exfat/exfat_cache.c
+++ b/drivers/staging/exfat/exfat_cache.c
@@ -341,25 +341,6 @@ void exfat_fat_release_all(struct super_block *sb)
mutex_unlock(&f_mutex);
}
-void exfat_fat_sync(struct super_block *sb)
-{
- struct buf_cache_t *bp;
- struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
-
- mutex_lock(&f_mutex);
-
- bp = p_fs->FAT_cache_lru_list.next;
- while (bp != &p_fs->FAT_cache_lru_list) {
- if ((bp->drv == p_fs->drv) && (bp->flag & DIRTYBIT)) {
- sync_dirty_buffer(bp->buf_bh);
- bp->flag &= ~(DIRTYBIT);
- }
- bp = bp->next;
- }
-
- mutex_unlock(&f_mutex);
-}
-
static struct buf_cache_t *buf_cache_find(struct super_block *sb, sector_t sec)
{
s32 off;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: exfat: remove exfat_fat_sync()
2020-02-19 16:17 [PATCH] staging: exfat: remove exfat_fat_sync() Kaaira Gupta
@ 2020-02-23 8:07 ` Valdis Klētnieks
0 siblings, 0 replies; 2+ messages in thread
From: Valdis Klētnieks @ 2020-02-23 8:07 UTC (permalink / raw)
To: Kaaira Gupta; +Cc: Greg Kroah-Hartman, linux-fsdevel, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
On Wed, 19 Feb 2020 21:47:38 +0530, you said:
> exfat_fat_sync() is not called anywhere, hence remove it from
> exfat_cache.c and exfat.h
Yes, it's a leftover from the fat/vfat support that got taken out.
Acked-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-23 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 16:17 [PATCH] staging: exfat: remove exfat_fat_sync() Kaaira Gupta
2020-02-23 8:07 ` Valdis Klētnieks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).