From: Jan Kara <jack@suse.cz>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: jack@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, hch@infradead.org, cmaiolino@redhat.com,
david@fromorbit.com
Subject: Re: [PATCHv4 1/6] ext4: Add IOMAP_F_MERGED for non-extent based mapping
Date: Thu, 27 Feb 2020 12:44:28 +0100 [thread overview]
Message-ID: <20200227114428.GA10728@quack2.suse.cz> (raw)
In-Reply-To: <8bffe1aef219916d3962faffd2e75cd7e06060c2.1582800839.git.riteshh@linux.ibm.com>
On Thu 27-02-20 16:40:22, Ritesh Harjani wrote:
> IOMAP_F_MERGED needs to be set in case of non-extent based mapping.
> This is needed in later patches for conversion of ext4_fiemap to use iomap.
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/inode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index d035acab5b2a..6cf3b969dc86 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3335,6 +3335,10 @@ static void ext4_set_iomap(struct inode *inode, struct iomap *iomap,
> iomap->offset = (u64) map->m_lblk << blkbits;
> iomap->length = (u64) map->m_len << blkbits;
>
> + if ((map->m_flags & EXT4_MAP_MAPPED) &&
> + !ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
> + iomap->flags |= IOMAP_F_MERGED;
> +
> /*
> * Flags passed to ext4_map_blocks() for direct I/O writes can result
> * in m_flags having both EXT4_MAP_MAPPED and EXT4_MAP_UNWRITTEN bits
> --
> 2.21.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-02-27 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:10 [PATCHv4 0/6] ext4: bmap & fiemap conversion to use iomap Ritesh Harjani
2020-02-27 11:10 ` [PATCHv4 1/6] ext4: Add IOMAP_F_MERGED for non-extent based mapping Ritesh Harjani
2020-02-27 11:44 ` Jan Kara [this message]
2020-02-27 11:10 ` [PATCHv4 2/6] ext4: Optimize ext4_ext_precache for 0 depth Ritesh Harjani
2020-02-27 11:10 ` [PATCHv4 3/6] ext4: Move ext4 bmap to use iomap infrastructure Ritesh Harjani
2020-02-27 11:10 ` [PATCHv4 4/6] ext4: Make ext4_ind_map_blocks work with fiemap Ritesh Harjani
2020-02-27 11:49 ` Jan Kara
2020-02-27 11:10 ` [PATCHv4 5/6] ext4: Move ext4_fiemap to use iomap framework Ritesh Harjani
2020-02-27 11:58 ` Jan Kara
2020-02-27 11:10 ` [PATCHv4 6/6] Documentation: Correct the description of FIEMAP_EXTENT_LAST Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227114428.GA10728@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).