From: Ritesh Harjani <riteshh@linux.ibm.com>
To: jack@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org
Cc: adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, hch@infradead.org, cmaiolino@redhat.com,
david@fromorbit.com, Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCHv4 2/6] ext4: Optimize ext4_ext_precache for 0 depth
Date: Thu, 27 Feb 2020 16:40:23 +0530 [thread overview]
Message-ID: <646479a04296e6284b68788b5f04ab5284017454.1582800839.git.riteshh@linux.ibm.com> (raw)
In-Reply-To: <cover.1582800839.git.riteshh@linux.ibm.com>
This patch avoids the memory alloc & free path when depth is 0,
since anyway there is no extra caching done in that case.
So on checking depth 0, simply return early.
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/extents.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ee83fe7c98aa..0de548bb3c90 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -594,6 +594,12 @@ int ext4_ext_precache(struct inode *inode)
down_read(&ei->i_data_sem);
depth = ext_depth(inode);
+ /* Don't cache anything if there are no external extent blocks */
+ if (!depth) {
+ up_read(&ei->i_data_sem);
+ return ret;
+ }
+
path = kcalloc(depth + 1, sizeof(struct ext4_ext_path),
GFP_NOFS);
if (path == NULL) {
@@ -601,9 +607,6 @@ int ext4_ext_precache(struct inode *inode)
return -ENOMEM;
}
- /* Don't cache anything if there are no external extent blocks */
- if (depth == 0)
- goto out;
path[0].p_hdr = ext_inode_hdr(inode);
ret = ext4_ext_check(inode, path[0].p_hdr, depth, 0);
if (ret)
--
2.21.0
next prev parent reply other threads:[~2020-02-27 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:10 [PATCHv4 0/6] ext4: bmap & fiemap conversion to use iomap Ritesh Harjani
2020-02-27 11:10 ` [PATCHv4 1/6] ext4: Add IOMAP_F_MERGED for non-extent based mapping Ritesh Harjani
2020-02-27 11:44 ` Jan Kara
2020-02-27 11:10 ` Ritesh Harjani [this message]
2020-02-27 11:10 ` [PATCHv4 3/6] ext4: Move ext4 bmap to use iomap infrastructure Ritesh Harjani
2020-02-27 11:10 ` [PATCHv4 4/6] ext4: Make ext4_ind_map_blocks work with fiemap Ritesh Harjani
2020-02-27 11:49 ` Jan Kara
2020-02-27 11:10 ` [PATCHv4 5/6] ext4: Move ext4_fiemap to use iomap framework Ritesh Harjani
2020-02-27 11:58 ` Jan Kara
2020-02-27 11:10 ` [PATCHv4 6/6] Documentation: Correct the description of FIEMAP_EXTENT_LAST Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646479a04296e6284b68788b5f04ab5284017454.1582800839.git.riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).