linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] iomap: fix comments in iomap_dio_rw
  2020-03-18  9:50 [PATCH] iomap: fix comments in iomap_dio_rw yangerkun
@ 2020-03-18  9:23 ` Christoph Hellwig
  2020-03-18 15:06 ` Darrick J. Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-03-18  9:23 UTC (permalink / raw)
  To: yangerkun; +Cc: hch, darrick.wong, linux-fsdevel

On Wed, Mar 18, 2020 at 05:50:22PM +0800, yangerkun wrote:
> Double 'three' exists in the comments of iomap_dio_rw.
> 
> Signed-off-by: yangerkun <yangerkun@huawei.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] iomap: fix comments in iomap_dio_rw
@ 2020-03-18  9:50 yangerkun
  2020-03-18  9:23 ` Christoph Hellwig
  2020-03-18 15:06 ` Darrick J. Wong
  0 siblings, 2 replies; 3+ messages in thread
From: yangerkun @ 2020-03-18  9:50 UTC (permalink / raw)
  To: hch, darrick.wong, linux-fsdevel; +Cc: yangerkun

Double 'three' exists in the comments of iomap_dio_rw.

Signed-off-by: yangerkun <yangerkun@huawei.com>
---
 fs/iomap/direct-io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 23837926c0c5..20dde5aadcdd 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -534,8 +534,8 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
 
 	/*
 	 * We are about to drop our additional submission reference, which
-	 * might be the last reference to the dio.  There are three three
-	 * different ways we can progress here:
+	 * might be the last reference to the dio.  There are three different
+	 * ways we can progress here:
 	 *
 	 *  (a) If this is the last reference we will always complete and free
 	 *	the dio ourselves.
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iomap: fix comments in iomap_dio_rw
  2020-03-18  9:50 [PATCH] iomap: fix comments in iomap_dio_rw yangerkun
  2020-03-18  9:23 ` Christoph Hellwig
@ 2020-03-18 15:06 ` Darrick J. Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-03-18 15:06 UTC (permalink / raw)
  To: yangerkun; +Cc: hch, linux-fsdevel

On Wed, Mar 18, 2020 at 05:50:22PM +0800, yangerkun wrote:
> Double 'three' exists in the comments of iomap_dio_rw.
> 
> Signed-off-by: yangerkun <yangerkun@huawei.com>

Looks good, will stage for 5.7...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/iomap/direct-io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 23837926c0c5..20dde5aadcdd 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -534,8 +534,8 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
>  
>  	/*
>  	 * We are about to drop our additional submission reference, which
> -	 * might be the last reference to the dio.  There are three three
> -	 * different ways we can progress here:
> +	 * might be the last reference to the dio.  There are three different
> +	 * ways we can progress here:
>  	 *
>  	 *  (a) If this is the last reference we will always complete and free
>  	 *	the dio ourselves.
> -- 
> 2.17.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-18 15:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18  9:50 [PATCH] iomap: fix comments in iomap_dio_rw yangerkun
2020-03-18  9:23 ` Christoph Hellwig
2020-03-18 15:06 ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).