From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: [RFC] fs: Use slab constructor to initialize conn objects in fsnotify
Date: Thu, 23 Apr 2020 00:40:50 -0400 [thread overview]
Message-ID: <20200423044050.162093-1-joel@joelfernandes.org> (raw)
While reading the famous slab paper [1], I noticed that the conn->lock
spinlock and conn->list hlist in fsnotify code is being initialized
during every object allocation. This seems a good fit for the
constructor within the slab to take advantage of the slab design. Move
the initializtion to that.
spin_lock_init(&conn->lock);
INIT_HLIST_HEAD(&conn->list);
[1] https://pdfs.semanticscholar.org/1acc/3a14da69dd240f2fbc11d00e09610263bdbd.pdf
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
I've only build-tested. I am not very familiar with this code, so I
kindly request the maintainers/reviewers to take a look and see if it
makes sense. From what I see, the ->list is always empty during
allocation. The spinlock allocation also seems unnecesary.
fs/notify/fsnotify.c | 15 +++++++++++++--
fs/notify/mark.c | 2 --
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c
index 46f2255800091..55ed450da3295 100644
--- a/fs/notify/fsnotify.c
+++ b/fs/notify/fsnotify.c
@@ -385,6 +385,14 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is,
}
EXPORT_SYMBOL_GPL(fsnotify);
+static void fsnotify_ctor(void *addr)
+{
+ struct fsnotify_mark_connector *conn = addr;
+
+ spin_lock_init(&conn->lock);
+ INIT_HLIST_HEAD(&conn->list);
+}
+
static __init int fsnotify_init(void)
{
int ret;
@@ -395,8 +403,11 @@ static __init int fsnotify_init(void)
if (ret)
panic("initializing fsnotify_mark_srcu");
- fsnotify_mark_connector_cachep = KMEM_CACHE(fsnotify_mark_connector,
- SLAB_PANIC);
+ fsnotify_mark_connector_cachep =
+ kmem_cache_create("fsnotify_mark_connector",
+ sizeof(struct fsnotify_mark_connector),
+ __alignof__(struct fsnotify_mark_connector),
+ SLAB_PANIC, fsnotify_ctor);
return 0;
}
diff --git a/fs/notify/mark.c b/fs/notify/mark.c
index 1d96216dffd19..d388e7f45e2ea 100644
--- a/fs/notify/mark.c
+++ b/fs/notify/mark.c
@@ -479,8 +479,6 @@ static int fsnotify_attach_connector_to_object(fsnotify_connp_t *connp,
conn = kmem_cache_alloc(fsnotify_mark_connector_cachep, GFP_KERNEL);
if (!conn)
return -ENOMEM;
- spin_lock_init(&conn->lock);
- INIT_HLIST_HEAD(&conn->list);
conn->type = type;
conn->obj = connp;
/* Cache fsid of filesystem containing the object */
--
2.26.1.301.g55bc3eb7cb9-goog
next reply other threads:[~2020-04-23 4:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 4:40 Joel Fernandes (Google) [this message]
2020-04-23 4:45 ` [RFC] fs: Use slab constructor to initialize conn objects in fsnotify Joel Fernandes
2020-04-23 5:24 ` Amir Goldstein
2020-04-23 10:48 ` Jan Kara
2020-04-23 13:24 ` Joel Fernandes
2020-04-23 11:40 ` Matthew Wilcox
2020-04-23 13:20 ` Joel Fernandes
2020-04-23 13:21 ` Joel Fernandes
2020-04-23 13:51 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423044050.162093-1-joel@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).