From: Al Viro <viro@zeniv.linux.org.uk>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Remove duplicated flag from VALID_OPEN_FLAGS
Date: Fri, 22 May 2020 16:47:19 +0100 [thread overview]
Message-ID: <20200522154719.GS23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200522133723.1091937-1-kw@linux.com>
On Fri, May 22, 2020 at 01:37:23PM +0000, Krzysztof Wilczynski wrote:
> From: Krzysztof Wilczyński <kw@linux.com>
>
> Also, remove extra tab after the FASYNC flag, and keep line under 80
> characters. This also resolves the following Coccinelle warning:
>
> include/linux/fcntl.h:11:13-21: duplicated argument to & or |
Now ask yourself what might be the reason for that "duplicated argument".
Try to figure out what the values of those constants might depend upon.
For extra points, try to guess what has caused the divergences.
Please, post the result of your investigation in followup to this.
next prev parent reply other threads:[~2020-05-22 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 13:37 [PATCH] fs: Remove duplicated flag from VALID_OPEN_FLAGS Krzysztof Wilczynski
2020-05-22 15:47 ` Al Viro [this message]
2020-05-22 17:01 ` Matthew Wilcox
2020-05-22 17:18 ` Al Viro
2020-05-22 17:32 ` Krzysztof Wilczynski
2020-05-22 17:22 ` Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522154719.GS23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=kw@linux.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).