linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vfs: remove unnecessary assignment in do_sys_ftruncate()
@ 2020-06-27 12:17 Chengguang Xu
  0 siblings, 0 replies; only message in thread
From: Chengguang Xu @ 2020-06-27 12:17 UTC (permalink / raw)
  To: viro; +Cc: linux-fsdevel, Chengguang Xu

We have already set error to -EINVAL, so don't have to do
it again.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/open.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/open.c b/fs/open.c
index 6cd48a61cda3..f1ec0c1ad135 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -177,7 +177,6 @@ long do_sys_ftruncate(unsigned int fd, loff_t length, int small)
 	if (!S_ISREG(inode->i_mode) || !(f.file->f_mode & FMODE_WRITE))
 		goto out_putf;
 
-	error = -EINVAL;
 	/* Cannot ftruncate over 2^31 bytes without large file support */
 	if (small && length > MAX_NON_LFS)
 		goto out_putf;
-- 
2.26.2



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-27 12:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-27 12:17 [PATCH] vfs: remove unnecessary assignment in do_sys_ftruncate() Chengguang Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).