* [PATCH v2 09/24] virtio_fs: correct tags for config space fields
[not found] <20200803205814.540410-1-mst@redhat.com>
@ 2020-08-03 20:59 ` Michael S. Tsirkin
2020-08-04 13:36 ` Vivek Goyal
2020-08-04 14:33 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-08-03 20:59 UTC (permalink / raw)
To: linux-kernel
Cc: virtualization, Jason Wang, Vivek Goyal, Stefan Hajnoczi,
Miklos Szeredi, linux-fsdevel
Since fs is a modern-only device,
tag config space fields as having little endian-ness.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/uapi/linux/virtio_fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/virtio_fs.h b/include/uapi/linux/virtio_fs.h
index b02eb2ac3d99..3056b6e9f8ce 100644
--- a/include/uapi/linux/virtio_fs.h
+++ b/include/uapi/linux/virtio_fs.h
@@ -13,7 +13,7 @@ struct virtio_fs_config {
__u8 tag[36];
/* Number of request queues */
- __u32 num_request_queues;
+ __le32 num_request_queues;
} __attribute__((packed));
#endif /* _UAPI_LINUX_VIRTIO_FS_H */
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 09/24] virtio_fs: correct tags for config space fields
2020-08-03 20:59 ` [PATCH v2 09/24] virtio_fs: correct tags for config space fields Michael S. Tsirkin
@ 2020-08-04 13:36 ` Vivek Goyal
2020-08-04 14:33 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Vivek Goyal @ 2020-08-04 13:36 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, virtualization, Jason Wang, Stefan Hajnoczi,
Miklos Szeredi, linux-fsdevel
On Mon, Aug 03, 2020 at 04:59:13PM -0400, Michael S. Tsirkin wrote:
> Since fs is a modern-only device,
> tag config space fields as having little endian-ness.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
virtio spec does list this field as "le32".
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> include/uapi/linux/virtio_fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_fs.h b/include/uapi/linux/virtio_fs.h
> index b02eb2ac3d99..3056b6e9f8ce 100644
> --- a/include/uapi/linux/virtio_fs.h
> +++ b/include/uapi/linux/virtio_fs.h
> @@ -13,7 +13,7 @@ struct virtio_fs_config {
> __u8 tag[36];
>
> /* Number of request queues */
> - __u32 num_request_queues;
> + __le32 num_request_queues;
> } __attribute__((packed));
>
> #endif /* _UAPI_LINUX_VIRTIO_FS_H */
> --
> MST
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 09/24] virtio_fs: correct tags for config space fields
2020-08-03 20:59 ` [PATCH v2 09/24] virtio_fs: correct tags for config space fields Michael S. Tsirkin
2020-08-04 13:36 ` Vivek Goyal
@ 2020-08-04 14:33 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2020-08-04 14:33 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Miklos Szeredi, virtualization, Stefan Hajnoczi,
linux-fsdevel, Vivek Goyal
On Mon, 3 Aug 2020 16:59:13 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Since fs is a modern-only device,
> tag config space fields as having little endian-ness.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/uapi/linux/virtio_fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-04 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200803205814.540410-1-mst@redhat.com>
2020-08-03 20:59 ` [PATCH v2 09/24] virtio_fs: correct tags for config space fields Michael S. Tsirkin
2020-08-04 13:36 ` Vivek Goyal
2020-08-04 14:33 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).