* Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-02-05 20:43 Hanabishi Recca
2021-02-06 16:44 ` Oleksandr Natalenko
2021-02-06 16:57 ` Oleksandr Natalenko
0 siblings, 2 replies; 5+ messages in thread
From: Hanabishi Recca @ 2021-02-05 20:43 UTC (permalink / raw)
To: almaz.alexandrovich
Cc: aaptel, andy.lavr, anton, dan.carpenter, dsterba, ebiggers, hch,
joe, linux-fsdevel, linux-kernel, linux-ntfs-dev, mark, nborisov,
pali, rdunlap, viro, willy
Can't even build v20 due to compilation errors.
DKMS make.log for ntfs3-20.0.0 for kernel 5.10.13-arch1-1 (x86_64)
Sat Feb 6 01:20:00 +05 2021
make -C /lib/modules/5.10.13-arch1-1/build
M=/var/lib/dkms/ntfs3/20.0.0/build modules
make[1]: Entering directory '/usr/lib/modules/5.10.13-arch1-1/build'
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/attrib.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/attrlist.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/bitfunc.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/bitmap.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/dir.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/fsntfs.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/frecord.o
CC [M] /var/lib/dkms/ntfs3/20.0.0/build/file.o
/var/lib/dkms/ntfs3/20.0.0/build/file.c: In function ‘ntfs_getattr’:
/var/lib/dkms/ntfs3/20.0.0/build/file.c:93:19: error: passing argument
1 of ‘generic_fillattr’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
93 | generic_fillattr(mnt_userns, inode, stat);
| ^~~~~~~~~~
| |
| struct user_namespace *
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3095:30: note: expected ‘struct inode *’ but
argument is of type ‘struct user_namespace *’
3095 | extern void generic_fillattr(struct inode *, struct kstat *);
| ^~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:93:31: error: passing argument
2 of ‘generic_fillattr’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
93 | generic_fillattr(mnt_userns, inode, stat);
| ^~~~~
| |
| struct inode *
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3095:46: note: expected ‘struct kstat *’ but
argument is of type ‘struct inode *’
3095 | extern void generic_fillattr(struct inode *, struct kstat *);
| ^~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:93:2: error: too many
arguments to function ‘generic_fillattr’
93 | generic_fillattr(mnt_userns, inode, stat);
| ^~~~~~~~~~~~~~~~
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3095:13: note: declared here
3095 | extern void generic_fillattr(struct inode *, struct kstat *);
| ^~~~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c: In function ‘ntfs3_setattr’:
/var/lib/dkms/ntfs3/20.0.0/build/file.c:639:24: error: passing
argument 1 of ‘setattr_prepare’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
639 | err = setattr_prepare(mnt_userns, dentry, attr);
| ^~~~~~~~~~
| |
| struct user_namespace *
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3217:28: note: expected ‘struct dentry *’ but
argument is of type ‘struct user_namespace *’
3217 | extern int setattr_prepare(struct dentry *, struct iattr *);
| ^~~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:639:36: error: passing
argument 2 of ‘setattr_prepare’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
639 | err = setattr_prepare(mnt_userns, dentry, attr);
| ^~~~~~
| |
| struct dentry *
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3217:45: note: expected ‘struct iattr *’ but
argument is of type ‘struct dentry *’
3217 | extern int setattr_prepare(struct dentry *, struct iattr *);
| ^~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:639:8: error: too many
arguments to function ‘setattr_prepare’
639 | err = setattr_prepare(mnt_userns, dentry, attr);
| ^~~~~~~~~~~~~~~
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3217:12: note: declared here
3217 | extern int setattr_prepare(struct dentry *, struct iattr *);
| ^~~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:664:15: error: passing
argument 1 of ‘setattr_copy’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
664 | setattr_copy(mnt_userns, inode, attr);
| ^~~~~~~~~~
| |
| struct user_namespace *
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3219:40: note: expected ‘struct inode *’ but
argument is of type ‘struct user_namespace *’
3219 | extern void setattr_copy(struct inode *inode, const struct iattr *attr);
| ~~~~~~~~~~~~~~^~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:664:27: error: passing
argument 2 of ‘setattr_copy’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
664 | setattr_copy(mnt_userns, inode, attr);
| ^~~~~
| |
| struct inode *
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3219:67: note: expected ‘const struct iattr *’
but argument is of type ‘struct inode *’
3219 | extern void setattr_copy(struct inode *inode, const struct iattr *attr);
| ~~~~~~~~~~~~~~~~~~~~^~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:664:2: error: too many
arguments to function ‘setattr_copy’
664 | setattr_copy(mnt_userns, inode, attr);
| ^~~~~~~~~~~~
In file included from ./include/linux/backing-dev.h:13,
from /var/lib/dkms/ntfs3/20.0.0/build/file.c:8:
./include/linux/fs.h:3219:13: note: declared here
3219 | extern void setattr_copy(struct inode *inode, const struct iattr *attr);
| ^~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c: At top level:
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1109:13: error: initialization
of ‘int (*)(const struct path *, struct kstat *, u32, unsigned int)’
{aka ‘int (*)(const struct path *, struct kstat *, unsigned int,
unsigned int)’} from incompatible pointer type ‘int (*)(struct
user_namespace *, const struct path *, struct kstat *, u32, u32)’
{aka ‘int (*)(struct user_namespace *, const struct path *, struct
kstat *, unsigned int, unsigned int)’}
[-Werror=incompatible-pointer-types]
1109 | .getattr = ntfs_getattr,
| ^~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1109:13: note: (near
initialization for ‘ntfs_file_inode_operations.getattr’)
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1110:13: error: initialization
of ‘int (*)(struct dentry *, struct iattr *)’ from incompatible
pointer type ‘int (*)(struct user_namespace *, struct dentry *, struct
iattr *)’ [-Werror=incompatible-pointer-types]
1110 | .setattr = ntfs3_setattr,
| ^~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1110:13: note: (near
initialization for ‘ntfs_file_inode_operations.setattr’)
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1112:16: error: initialization
of ‘int (*)(struct inode *, int)’ from incompatible pointer type ‘int
(*)(struct user_namespace *, struct inode *, int)’
[-Werror=incompatible-pointer-types]
1112 | .permission = ntfs_permission,
| ^~~~~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1112:16: note: (near
initialization for ‘ntfs_file_inode_operations.permission’)
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1114:13: error: initialization
of ‘int (*)(struct inode *, struct posix_acl *, int)’ from
incompatible pointer type ‘int (*)(struct user_namespace *, struct
inode *, struct posix_acl *, int)’
[-Werror=incompatible-pointer-types]
1114 | .set_acl = ntfs_set_acl,
| ^~~~~~~~~~~~
/var/lib/dkms/ntfs3/20.0.0/build/file.c:1114:13: note: (near
initialization for ‘ntfs_file_inode_operations.set_acl’)
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:279:
/var/lib/dkms/ntfs3/20.0.0/build/file.o] Error 1
make[1]: *** [Makefile:1805: /var/lib/dkms/ntfs3/20.0.0/build] Error 2
make[1]: Leaving directory '/usr/lib/modules/5.10.13-arch1-1/build'
make: *** [Makefile:37: all] Error 2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software
2021-02-05 20:43 [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software Hanabishi Recca
@ 2021-02-06 16:44 ` Oleksandr Natalenko
2021-02-06 16:57 ` Oleksandr Natalenko
1 sibling, 0 replies; 5+ messages in thread
From: Oleksandr Natalenko @ 2021-02-06 16:44 UTC (permalink / raw)
To: Hanabishi Recca
Cc: almaz.alexandrovich, aaptel, andy.lavr, anton, dan.carpenter,
dsterba, ebiggers, hch, joe, linux-fsdevel, linux-kernel,
linux-ntfs-dev, mark, nborisov, pali, rdunlap, viro, willy
On Sat, Feb 06, 2021 at 01:43:10AM +0500, Hanabishi Recca wrote:
> Can't even build v20 due to compilation errors.
I think this submission is based against linux-next branch where
idmapped mounts are introduced, hence it is not applicable to v5.10 and
v5.11 any more.
--
Oleksandr Natalenko (post-factum)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software
2021-02-05 20:43 [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software Hanabishi Recca
2021-02-06 16:44 ` Oleksandr Natalenko
@ 2021-02-06 16:57 ` Oleksandr Natalenko
2021-02-06 17:39 ` Oleksandr Natalenko
1 sibling, 1 reply; 5+ messages in thread
From: Oleksandr Natalenko @ 2021-02-06 16:57 UTC (permalink / raw)
To: Hanabishi Recca
Cc: almaz.alexandrovich, aaptel, andy.lavr, anton, dan.carpenter,
dsterba, ebiggers, hch, joe, linux-fsdevel, linux-kernel,
linux-ntfs-dev, mark, nborisov, pali, rdunlap, viro, willy
On Sat, Feb 06, 2021 at 01:43:10AM +0500, Hanabishi Recca wrote:
> Can't even build v20 due to compilation errors.
Try this please: http://ix.io/2OwR
--
Oleksandr Natalenko (post-factum)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software
2021-02-06 16:57 ` Oleksandr Natalenko
@ 2021-02-06 17:39 ` Oleksandr Natalenko
0 siblings, 0 replies; 5+ messages in thread
From: Oleksandr Natalenko @ 2021-02-06 17:39 UTC (permalink / raw)
To: Hanabishi Recca
Cc: almaz.alexandrovich, aaptel, andy.lavr, anton, dan.carpenter,
dsterba, ebiggers, hch, joe, linux-fsdevel, linux-kernel,
linux-ntfs-dev, mark, nborisov, pali, rdunlap, viro, willy
On Sat, Feb 06, 2021 at 05:57:45PM +0100, Oleksandr Natalenko wrote:
> On Sat, Feb 06, 2021 at 01:43:10AM +0500, Hanabishi Recca wrote:
> > Can't even build v20 due to compilation errors.
>
> Try this please: http://ix.io/2OwR
Slightly reworked version: http://ix.io/2Oxa
--
Oleksandr Natalenko (post-factum)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-02-05 15:02 Konstantin Komarov
0 siblings, 0 replies; 5+ messages in thread
From: Konstantin Komarov @ 2021-02-05 15:02 UTC (permalink / raw)
To: linux-fsdevel
Cc: viro, linux-kernel, pali, dsterba, aaptel, willy, rdunlap, joe,
mark, nborisov, linux-ntfs-dev, anton, dan.carpenter, hch,
ebiggers, andy.lavr, Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3.
Having decades of expertise in commercial file systems development and huge
test coverage, we at Paragon Software GmbH want to make our contribution to
the Open Source Community by providing implementation of NTFS Read-Write
driver for the Linux Kernel.
This is fully functional NTFS Read-Write driver. Current version works with
NTFS(including v3.1) and normal/compressed/sparse files and supports journal replaying.
We plan to support this version after the codebase once merged, and add new
features and fix bugs. For example, full journaling support over JBD will be
added in later updates.
v2:
- patch splitted to chunks (file-wise)
- build issues fixed
- sparse and checkpatch.pl errors fixed
- NULL pointer dereference on mkfs.ntfs-formatted volume mount fixed
- cosmetics + code cleanup
v3:
- added acl, noatime, no_acs_rules, prealloc mount options
- added fiemap support
- fixed encodings support
- removed typedefs
- adapted Kernel-way logging mechanisms
- fixed typos and corner-case issues
v4:
- atomic_open() refactored
- code style updated
- bugfixes
v5:
- nls/nls_alt mount options added
- Unicode conversion fixes
- Improved very fragmented files operations
- logging cosmetics
v6:
- Security Descriptors processing changed
added system.ntfs_security xattr to set
SD
- atomic_open() optimized
- cosmetics
v7:
- Security Descriptors validity checks added (by Mark Harmstone)
- atomic_open() fixed for the compressed file creation with directio
case
- remount support
- temporarily removed readahead usage
- cosmetics
v8:
- Compressed files operations fixed
v9:
- Further cosmetics applied as suggested
by Joe Perches
v10:
- operations with compressed/sparse files on very fragmented volumes improved
- reduced memory consumption for above cases
v11:
- further compressed files optimizations: reads/writes are now skipping bufferization
- journal wipe to the initial state optimized (bufferization is also skipped)
- optimized run storage (re-packing cluster metainformation)
- fixes based on Matthew Wilcox feedback to the v10
- compressed/sparse/normal could be set for empty files with 'system.ntfs_attrib' xattr
v12:
- nls_alt mount option removed after discussion with Pali Rohar
- fixed ni_repack()
- fixed resident files transition to non-resident when size increasing
v13:
- nested_lock fix (lockdep)
- out-of-bounds read fix (KASAN warning)
- resident->nonresident transition fixed for compressed files
- load_nls() missed fix applied
- some sparse utility warnings fixes
v14:
- support for additional compression types (we've adapted WIMLIB's
implementation, authored by Eric Biggers, into ntfs3)
v15:
- kernel test robot warnings fixed
- lzx/xpress compression license headers updated
v16:
- lzx/xpress moved to initial ntfs-3g plugin code
- mutexes instead of a global spinlock for compresions
- FALLOC_FL_PUNCH_HOLE and FALLOC_FL_COLLAPSE_RANGE implemented
- CONFIG_NTFS3_FS_POSIX_ACL added
v17:
- FALLOC_FL_COLLAPSE_RANGE fixed
- fixes for Mattew Wilcox's and Andy Lavr's concerns
v18:
- ntfs_alloc macro splitted into two ntfs_malloc + ntfs_zalloc
- attrlist.c: always use ntfs_cmp_names instead of memcmp; compare entry names
only for entry with vcn == 0
- dir.c: remove unconditional ni_lock in ntfs_readdir
- fslog.c: corrected error case behavior
- index.c: refactored due to modification of ntfs_cmp_names; use rw_semaphore
for read/write access to alloc_run and bitmap_run while ntfs_readdir
- run.c: separated big/little endian code in functions
- upcase.c: improved ntfs_cmp_names, thanks to Kari Argillander for idea
and 'bothcase' implementation
v19:
- fixed directory bitmap for 2MB cluster size
- fixed rw_semaphore init for directories
v20:
- fixed issue with incorrect hidden/system attribute setting on
root subdirectories
- use kvmalloc instead of kmalloc for runs array
- fixed index behavior on volumes with cluster size more than 4k
- current build info is added into module info instead of printing on insmod
Konstantin Komarov (10):
fs/ntfs3: Add headers and misc files
fs/ntfs3: Add initialization of super block
fs/ntfs3: Add bitmap
fs/ntfs3: Add file operations and implementation
fs/ntfs3: Add attrib operations
fs/ntfs3: Add compression
fs/ntfs3: Add NTFS journal
fs/ntfs3: Add Kconfig, Makefile and doc
fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
fs/ntfs3: Add MAINTAINERS
Documentation/filesystems/ntfs3.rst | 107 +
MAINTAINERS | 7 +
fs/Kconfig | 1 +
fs/Makefile | 1 +
fs/ntfs3/Kconfig | 45 +
fs/ntfs3/Makefile | 31 +
fs/ntfs3/attrib.c | 2085 +++++++++++
fs/ntfs3/attrlist.c | 457 +++
fs/ntfs3/bitfunc.c | 135 +
fs/ntfs3/bitmap.c | 1495 ++++++++
fs/ntfs3/debug.h | 64 +
fs/ntfs3/dir.c | 583 +++
fs/ntfs3/file.c | 1133 ++++++
fs/ntfs3/frecord.c | 3083 ++++++++++++++++
fs/ntfs3/fslog.c | 5204 +++++++++++++++++++++++++++
fs/ntfs3/fsntfs.c | 2535 +++++++++++++
fs/ntfs3/index.c | 2637 ++++++++++++++
fs/ntfs3/inode.c | 2057 +++++++++++
fs/ntfs3/lib/decompress_common.c | 332 ++
fs/ntfs3/lib/decompress_common.h | 352 ++
fs/ntfs3/lib/lib.h | 26 +
fs/ntfs3/lib/lzx_decompress.c | 683 ++++
fs/ntfs3/lib/xpress_decompress.c | 155 +
fs/ntfs3/lznt.c | 452 +++
fs/ntfs3/namei.c | 592 +++
fs/ntfs3/ntfs.h | 1238 +++++++
fs/ntfs3/ntfs_fs.h | 1072 ++++++
fs/ntfs3/record.c | 609 ++++
fs/ntfs3/run.c | 1120 ++++++
fs/ntfs3/super.c | 1478 ++++++++
fs/ntfs3/upcase.c | 100 +
fs/ntfs3/xattr.c | 1085 ++++++
32 files changed, 30954 insertions(+)
create mode 100644 Documentation/filesystems/ntfs3.rst
create mode 100644 fs/ntfs3/Kconfig
create mode 100644 fs/ntfs3/Makefile
create mode 100644 fs/ntfs3/attrib.c
create mode 100644 fs/ntfs3/attrlist.c
create mode 100644 fs/ntfs3/bitfunc.c
create mode 100644 fs/ntfs3/bitmap.c
create mode 100644 fs/ntfs3/debug.h
create mode 100644 fs/ntfs3/dir.c
create mode 100644 fs/ntfs3/file.c
create mode 100644 fs/ntfs3/frecord.c
create mode 100644 fs/ntfs3/fslog.c
create mode 100644 fs/ntfs3/fsntfs.c
create mode 100644 fs/ntfs3/index.c
create mode 100644 fs/ntfs3/inode.c
create mode 100644 fs/ntfs3/lib/decompress_common.c
create mode 100644 fs/ntfs3/lib/decompress_common.h
create mode 100644 fs/ntfs3/lib/lib.h
create mode 100644 fs/ntfs3/lib/lzx_decompress.c
create mode 100644 fs/ntfs3/lib/xpress_decompress.c
create mode 100644 fs/ntfs3/lznt.c
create mode 100644 fs/ntfs3/namei.c
create mode 100644 fs/ntfs3/ntfs.h
create mode 100644 fs/ntfs3/ntfs_fs.h
create mode 100644 fs/ntfs3/record.c
create mode 100644 fs/ntfs3/run.c
create mode 100644 fs/ntfs3/super.c
create mode 100644 fs/ntfs3/upcase.c
create mode 100644 fs/ntfs3/xattr.c
base-commit: dd86e7fa07a3ec33c92c957ea7b642c4702516a0
--
2.25.4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-06 17:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 20:43 [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software Hanabishi Recca
2021-02-06 16:44 ` Oleksandr Natalenko
2021-02-06 16:57 ` Oleksandr Natalenko
2021-02-06 17:39 ` Oleksandr Natalenko
-- strict thread matches above, loose matches on Subject: below --
2021-02-05 15:02 Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).