[PATCH] hfsplus: report create_date to kstat.btime

[PATCH] hfsplus: report create_date to kstat.btime

[Chung-Chiang Cheng]

The create_date field of inode in hfsplus is corresponding to kstat.btime
and could be reported in statx.

Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
---
 fs/hfsplus/inode.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index 078c5c8a5156..aab3388a0fd7 100644
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -278,6 +278,11 @@ int hfsplus_getattr(struct user_namespace *mnt_userns, const struct path *path,
 	struct inode *inode = d_inode(path->dentry);
 	struct hfsplus_inode_info *hip = HFSPLUS_I(inode);
 
+	if (request_mask & STATX_BTIME) {
+		stat->result_mask |= STATX_BTIME;
+		stat->btime = hfsp_mt2ut(hip->create_date);
+	}
+
 	if (inode->i_flags & S_APPEND)
 		stat->attributes |= STATX_ATTR_APPEND;
 	if (inode->i_flags & S_IMMUTABLE)
-- 
2.25.1

Re: [PATCH] hfsplus: report create_date to kstat.btime

[Chung-Chiang Cheng]

From: Chung-Chiang Cheng <cccheng@synology.com>

There's no HFSPLUS maintainer now. Could anyone help to review this
patch or give feedback?

On Sat, Apr 17, 2021 at 1:21 AM Chung-Chiang Cheng <shepjeng@gmail.com> wrote:
>
> The create_date field of inode in hfsplus is corresponding to kstat.btime
> and could be reported in statx.
>
> Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
> ---
>  fs/hfsplus/inode.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 078c5c8a5156..aab3388a0fd7 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -278,6 +278,11 @@ int hfsplus_getattr(struct user_namespace *mnt_userns, const struct path *path,
>         struct inode *inode = d_inode(path->dentry);
>         struct hfsplus_inode_info *hip = HFSPLUS_I(inode);
>
> +       if (request_mask & STATX_BTIME) {
> +               stat->result_mask |= STATX_BTIME;
> +               stat->btime = hfsp_mt2ut(hip->create_date);
> +       }
> +
>         if (inode->i_flags & S_APPEND)
>                 stat->attributes |= STATX_ATTR_APPEND;
>         if (inode->i_flags & S_IMMUTABLE)
> --
> 2.25.1
>

Re: [PATCH] hfsplus: report create_date to kstat.btime

[Viacheslav Dubeyko]

> On Apr 16, 2021, at 10:21 AM, Chung-Chiang Cheng <shepjeng@gmail.com> wrote:
> 
> The create_date field of inode in hfsplus is corresponding to kstat.btime
> and could be reported in statx.
> 
> Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
> ---
> fs/hfsplus/inode.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 078c5c8a5156..aab3388a0fd7 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -278,6 +278,11 @@ int hfsplus_getattr(struct user_namespace *mnt_userns, const struct path *path,
> 	struct inode *inode = d_inode(path->dentry);
> 	struct hfsplus_inode_info *hip = HFSPLUS_I(inode);
> 
> +	if (request_mask & STATX_BTIME) {
> +		stat->result_mask |= STATX_BTIME;
> +		stat->btime = hfsp_mt2ut(hip->create_date);
> +	}
> +
> 	if (inode->i_flags & S_APPEND)
> 		stat->attributes |= STATX_ATTR_APPEND;
> 	if (inode->i_flags & S_IMMUTABLE)
> -- 
> 2.25.1
> 

Looks good for me.

Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>

Thanks,
Slava.