From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-fsdevel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] afs: fix tracepoint string placement with built-in AFS
Date: Mon, 14 Jun 2021 16:47:52 -0700 [thread overview]
Message-ID: <20210614164752.12438695a27203c8e7c9eaea@linux-foundation.org> (raw)
In-Reply-To: <YLAXfvZ+rObEOdc/@localhost.localdomain>
On Fri, 28 May 2021 01:04:46 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> I was adding custom tracepoint to the kernel, grabbed full F34 kernel
> .config, disabled modules and booted whole shebang as VM kernel.
>
> Then did
>
> perf record -a -e ...
>
> It crashed:
>
> general protection fault, probably for non-canonical address 0x435f5346592e4243: 0000 [#1] SMP PTI
> CPU: 1 PID: 842 Comm: cat Not tainted 5.12.6+ #26
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-1.fc33 04/01/2014
> RIP: 0010:t_show+0x22/0xd0
>
> Then reproducer was narrowed to
>
> # cat /sys/kernel/tracing/printk_formats
>
> Original F34 kernel with modules didn't crash.
>
> So I started to disable options and after disabling AFS everything
> started working again.
>
> The root cause is that AFS was placing char arrays content into a section
> full of _pointers_ to strings with predictable consequences.
>
> Non canonical address 435f5346592e4243 is "CB.YFS_" which came from
> CM_NAME macro.
>
> The fix is to create char array and pointer to it separatedly.
>
> Steps to reproduce:
>
> CONFIG_AFS=y
> CONFIG_TRACING=y
>
> # cat /sys/kernel/tracing/printk_formats
I'll add
Fixes: 8e8d7f13b6d5a9 ("afs: Add some tracepoints")
although Andi's d2abfa86ff373 gets in the way a bit.
> --- a/fs/afs/cmservice.c
> +++ b/fs/afs/cmservice.c
> @@ -30,8 +30,9 @@ static void SRXAFSCB_TellMeAboutYourself(struct work_struct *);
> static int afs_deliver_yfs_cb_callback(struct afs_call *);
>
> #define CM_NAME(name) \
> - char afs_SRXCB##name##_name[] __tracepoint_string = \
> - "CB." #name
> + const char afs_SRXCB##name##_name[] = "CB." #name; \
> + static const char *_afs_SRXCB##name##_name __tracepoint_string =\
> + afs_SRXCB##name##_name
Should/can afs_SRXCB##name##_name[] be static?
__tracepoint_string is very rarely used. I wonder if there's much
point in it existing?
kernel/rcu/tree.h does
static char rcu_name[] = RCU_NAME_RAW;
static const char *tp_rcu_varname __used __tracepoint_string = rcu_name;
which is asking the compiler to place a copy of these into each
compilation unit which includes tree.h, which probably isn't what was
intended.
next prev parent reply other threads:[~2021-06-14 23:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 22:04 [PATCH] afs: fix tracepoint string placement with built-in AFS Alexey Dobriyan
2021-06-14 16:07 ` Alexey Dobriyan
2021-06-14 23:47 ` Andrew Morton [this message]
2021-06-15 1:17 ` Steven Rostedt
2021-06-15 8:19 ` David Howells
2021-06-15 8:49 ` David Howells
2021-06-15 10:58 ` David Howells
2021-06-15 15:54 ` Steven Rostedt
2021-06-17 12:04 ` David Howells
2021-06-17 13:37 ` Steven Rostedt
2021-06-21 20:57 [PATCH] afs: Fix " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614164752.12438695a27203c8e7c9eaea@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=andi@firstfloor.org \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).