From: David Howells <dhowells@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] afs: fix tracepoint string placement with built-in AFS
Date: Tue, 15 Jun 2021 09:49:47 +0100 [thread overview]
Message-ID: <600001.1623746987@warthog.procyon.org.uk> (raw)
In-Reply-To: <558445.1623745199@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > - char afs_SRXCB##name##_name[] __tracepoint_string = \
> > - "CB." #name
>
> I seem to remember that when I did this, it couldn't be a const string for
> some reason, though I don't remember exactly why now if that was indeed the
> case.
>
> I wonder if it's better just to turn it into an enum-string table in
> linux/events/afs.h.
Hmmm... It's not necessarily quite that simple - at least if I want to use
the operation ID as the key to the table - as there are at least three
separate services involved and they can have overlapping op IDs.
Is it possible to switch the table passed to __print_symbolic()? For example,
in the afs_call tracepoint, could I do:
TP_printk("c=%08x %s u=%d o=%d sp=%pSR",
__entry->call,
__print_symbolic(__entry->op,
__entry->is_vl ? afs_vl_call_traces :
__entry->is_yfs ? afs_yfs_call_traces :
afs_fs_call_traces),
__entry->usage,
__entry->outstanding,
__entry->where)
David
next prev parent reply other threads:[~2021-06-15 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 22:04 [PATCH] afs: fix tracepoint string placement with built-in AFS Alexey Dobriyan
2021-06-14 16:07 ` Alexey Dobriyan
2021-06-14 23:47 ` Andrew Morton
2021-06-15 1:17 ` Steven Rostedt
2021-06-15 8:19 ` David Howells
2021-06-15 8:49 ` David Howells [this message]
2021-06-15 10:58 ` David Howells
2021-06-15 15:54 ` Steven Rostedt
2021-06-17 12:04 ` David Howells
2021-06-17 13:37 ` Steven Rostedt
2021-06-21 20:57 [PATCH] afs: Fix " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600001.1623746987@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).