[PATCH] fuse: Pass correct lend value to filemap_write_and_wait_range()

[PATCH] fuse: Pass correct lend value to filemap_write_and_wait_range()

[Xie Yongji]

The acceptable maximum value of lend parameter in
filemap_write_and_wait_range() is LLONG_MAX rather
than -1. And there is also some logic depending on
LLONG_MAX check in write_cache_pages(). So let's
pass LLONG_MAX to filemap_write_and_wait_range()
in fuse_writeback_range() instead.

Fixes: 59bda8ecee2f ("fuse: flush extending writes")
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 9d6c5f6361f7..df81768c81a7 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2910,7 +2910,7 @@ fuse_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
 
 static int fuse_writeback_range(struct inode *inode, loff_t start, loff_t end)
 {
-	int err = filemap_write_and_wait_range(inode->i_mapping, start, -1);
+	int err = filemap_write_and_wait_range(inode->i_mapping, start, LLONG_MAX);
 
 	if (!err)
 		fuse_sync_writes(inode);
-- 
2.11.0

Re: [PATCH] fuse: Pass correct lend value to filemap_write_and_wait_range()

[Yongji Xie]

Ping.

On Mon, Nov 22, 2021 at 5:07 PM Xie Yongji <xieyongji@bytedance.com> wrote:
>
> The acceptable maximum value of lend parameter in
> filemap_write_and_wait_range() is LLONG_MAX rather
> than -1. And there is also some logic depending on
> LLONG_MAX check in write_cache_pages(). So let's
> pass LLONG_MAX to filemap_write_and_wait_range()
> in fuse_writeback_range() instead.
>
> Fixes: 59bda8ecee2f ("fuse: flush extending writes")
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> ---
>  fs/fuse/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 9d6c5f6361f7..df81768c81a7 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -2910,7 +2910,7 @@ fuse_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
>
>  static int fuse_writeback_range(struct inode *inode, loff_t start, loff_t end)
>  {
> -       int err = filemap_write_and_wait_range(inode->i_mapping, start, -1);
> +       int err = filemap_write_and_wait_range(inode->i_mapping, start, LLONG_MAX);
>
>         if (!err)
>                 fuse_sync_writes(inode);
> --
> 2.11.0
>

Re: [PATCH] fuse: Pass correct lend value to filemap_write_and_wait_range()

[Miklos Szeredi]

On Tue, 7 Dec 2021 at 12:30, Yongji Xie <xieyongji@bytedance.com> wrote:
>
> Ping.
>
> On Mon, Nov 22, 2021 at 5:07 PM Xie Yongji <xieyongji@bytedance.com> wrote:
> >
> > The acceptable maximum value of lend parameter in
> > filemap_write_and_wait_range() is LLONG_MAX rather
> > than -1. And there is also some logic depending on
> > LLONG_MAX check in write_cache_pages(). So let's
> > pass LLONG_MAX to filemap_write_and_wait_range()
> > in fuse_writeback_range() instead.

Looks good; applied.

Thanks,
Miklos