* introduce bdev holder ops and a file system shutdown method
@ 2023-05-05 17:51 Christoph Hellwig
2023-05-05 17:51 ` [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
` (9 more replies)
0 siblings, 10 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Hi all,
this series fixes the long standing problem that we never had a good way
to communicate block device events to the user of the block device.
It fixes this by introducing a new set of holder ops registered at
blkdev_get_by_* time for the exclusive holder, and then wire that up
to a shutdown super operation to report the block device remove to the
file systems.
Diffstat:
block/bdev.c | 106 ++++++++++++++++++++----------------
block/fops.c | 2
block/genhd.c | 57 +++++++++++++------
block/ioctl.c | 3 -
drivers/block/drbd/drbd_nl.c | 3 -
drivers/block/pktcdvd.c | 5 +
drivers/block/rnbd/rnbd-srv.c | 2
drivers/block/xen-blkback/xenbus.c | 2
drivers/block/zram/zram_drv.c | 2
drivers/md/bcache/super.c | 2
drivers/md/dm.c | 2
drivers/md/md.c | 2
drivers/mtd/devices/block2mtd.c | 4 -
drivers/nvme/target/io-cmd-bdev.c | 2
drivers/s390/block/dasd_genhd.c | 2
drivers/target/target_core_iblock.c | 2
drivers/target/target_core_pscsi.c | 3 -
fs/btrfs/dev-replace.c | 2
fs/btrfs/volumes.c | 6 +-
fs/erofs/super.c | 2
fs/ext4/super.c | 3 -
fs/f2fs/super.c | 4 -
fs/jfs/jfs_logmgr.c | 2
fs/nfs/blocklayout/dev.c | 5 +
fs/nilfs2/super.c | 2
fs/ocfs2/cluster/heartbeat.c | 2
fs/reiserfs/journal.c | 5 +
fs/super.c | 21 ++++++-
fs/xfs/xfs_fsops.c | 3 +
fs/xfs/xfs_mount.h | 1
fs/xfs/xfs_super.c | 21 ++++++-
include/linux/blk_types.h | 2
include/linux/blkdev.h | 9 ++-
include/linux/fs.h | 1
kernel/power/swap.c | 4 -
mm/swapfile.c | 3 -
36 files changed, 196 insertions(+), 103 deletions(-)
^ permalink raw reply [flat|nested] 52+ messages in thread
* [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
2023-05-05 17:51 ` [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
` (8 subsequent siblings)
9 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
blk_mark_disk_dead does very similar work a a section of del_gendisk:
- set the GD_DEAD flag
- set the capacity to zero
- start a queue drain
but del_gendisk also sets QUEUE_FLAG_DYING on the queue if it is owned by
the disk, sets the capacity to zero before starting the drain, and both
with sending a uevent and kernel message for this fake capacity change.
Move the exact logic from the more heavily used del_gendisk into
blk_mark_disk_dead and then call blk_mark_disk_dead from del_gendisk.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/genhd.c | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 90c402771bb570..461999e9489937 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -583,13 +583,22 @@ EXPORT_SYMBOL(device_add_disk);
*/
void blk_mark_disk_dead(struct gendisk *disk)
{
+ /*
+ * Fail any new I/O.
+ */
set_bit(GD_DEAD, &disk->state);
- blk_queue_start_drain(disk->queue);
+ if (test_bit(GD_OWNS_QUEUE, &disk->state))
+ blk_queue_flag_set(QUEUE_FLAG_DYING, disk->queue);
/*
* Stop buffered writers from dirtying pages that can't be written out.
*/
- set_capacity_and_notify(disk, 0);
+ set_capacity(disk, 0);
+
+ /*
+ * Prevent new I/O from crossing bio_queue_enter().
+ */
+ blk_queue_start_drain(disk->queue);
}
EXPORT_SYMBOL_GPL(blk_mark_disk_dead);
@@ -632,18 +641,7 @@ void del_gendisk(struct gendisk *disk)
fsync_bdev(disk->part0);
__invalidate_device(disk->part0, true);
- /*
- * Fail any new I/O.
- */
- set_bit(GD_DEAD, &disk->state);
- if (test_bit(GD_OWNS_QUEUE, &disk->state))
- blk_queue_flag_set(QUEUE_FLAG_DYING, q);
- set_capacity(disk, 0);
-
- /*
- * Prevent new I/O from crossing bio_queue_enter().
- */
- blk_queue_start_drain(q);
+ blk_mark_disk_dead(disk);
if (!(disk->flags & GENHD_FL_HIDDEN)) {
sysfs_remove_link(&disk_to_dev(disk)->kobj, "bdi");
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
2023-05-05 17:51 ` [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-07 19:05 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
` (7 subsequent siblings)
9 siblings, 2 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Check if GD_DEAD is already set in blk_mark_disk_dead, and don't
duplicate the work already done.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/genhd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/genhd.c b/block/genhd.c
index 461999e9489937..9a35b8443f0b5f 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -586,7 +586,9 @@ void blk_mark_disk_dead(struct gendisk *disk)
/*
* Fail any new I/O.
*/
- set_bit(GD_DEAD, &disk->state);
+ if (test_and_set_bit(GD_DEAD, &disk->state))
+ return;
+
if (test_bit(GD_OWNS_QUEUE, &disk->state))
blk_queue_flag_set(QUEUE_FLAG_DYING, disk->queue);
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
2023-05-05 17:51 ` [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
2023-05-05 17:51 ` [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 4/9] block: turn bdev_lock into a mutex Christoph Hellwig
` (6 subsequent siblings)
9 siblings, 2 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Move all the logic to release an exclusive claim into a helper.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bdev.c | 63 +++++++++++++++++++++++++++-------------------------
1 file changed, 33 insertions(+), 30 deletions(-)
diff --git a/block/bdev.c b/block/bdev.c
index 850852fe4b78e1..f2c7181b0bba7d 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -578,6 +578,37 @@ void bd_abort_claiming(struct block_device *bdev, void *holder)
}
EXPORT_SYMBOL(bd_abort_claiming);
+static void bd_end_claim(struct block_device *bdev)
+{
+ struct block_device *whole = bdev_whole(bdev);
+ bool unblock = false;
+
+ /*
+ * Release a claim on the device. The holder fields are protected with
+ * bdev_lock. open_mutex is used to synchronize disk_holder unlinking.
+ */
+ spin_lock(&bdev_lock);
+ WARN_ON_ONCE(--bdev->bd_holders < 0);
+ WARN_ON_ONCE(--whole->bd_holders < 0);
+ if (!bdev->bd_holders) {
+ bdev->bd_holder = NULL;
+ if (bdev->bd_write_holder)
+ unblock = true;
+ }
+ if (!whole->bd_holders)
+ whole->bd_holder = NULL;
+ spin_unlock(&bdev_lock);
+
+ /*
+ * If this was the last claim, remove holder link and unblock evpoll if
+ * it was a write holder.
+ */
+ if (unblock) {
+ disk_unblock_events(bdev->bd_disk);
+ bdev->bd_write_holder = false;
+ }
+}
+
static void blkdev_flush_mapping(struct block_device *bdev)
{
WARN_ON_ONCE(bdev->bd_holders);
@@ -832,36 +863,8 @@ void blkdev_put(struct block_device *bdev, fmode_t mode)
sync_blockdev(bdev);
mutex_lock(&disk->open_mutex);
- if (mode & FMODE_EXCL) {
- struct block_device *whole = bdev_whole(bdev);
- bool bdev_free;
-
- /*
- * Release a claim on the device. The holder fields
- * are protected with bdev_lock. open_mutex is to
- * synchronize disk_holder unlinking.
- */
- spin_lock(&bdev_lock);
-
- WARN_ON_ONCE(--bdev->bd_holders < 0);
- WARN_ON_ONCE(--whole->bd_holders < 0);
-
- if ((bdev_free = !bdev->bd_holders))
- bdev->bd_holder = NULL;
- if (!whole->bd_holders)
- whole->bd_holder = NULL;
-
- spin_unlock(&bdev_lock);
-
- /*
- * If this was the last claim, remove holder link and
- * unblock evpoll if it was a write holder.
- */
- if (bdev_free && bdev->bd_write_holder) {
- disk_unblock_events(disk);
- bdev->bd_write_holder = false;
- }
- }
+ if (mode & FMODE_EXCL)
+ bd_end_claim(bdev);
/*
* Trigger event checking and tell drivers to flush MEDIA_CHANGE
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 4/9] block: turn bdev_lock into a mutex
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (2 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-07 19:09 ` Jan Kara
2023-05-16 16:24 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
` (5 subsequent siblings)
9 siblings, 2 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
There is no reason for this lock to spin, and being able to sleep under
it will come in handy soon.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bdev.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/block/bdev.c b/block/bdev.c
index f2c7181b0bba7d..bad75f6cf8edcd 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -308,7 +308,7 @@ EXPORT_SYMBOL(thaw_bdev);
* pseudo-fs
*/
-static __cacheline_aligned_in_smp DEFINE_SPINLOCK(bdev_lock);
+static __cacheline_aligned_in_smp DEFINE_MUTEX(bdev_lock);
static struct kmem_cache * bdev_cachep __read_mostly;
static struct inode *bdev_alloc_inode(struct super_block *sb)
@@ -457,15 +457,14 @@ long nr_blockdev_pages(void)
*
* Test whether @bdev can be claimed by @holder.
*
- * CONTEXT:
- * spin_lock(&bdev_lock).
- *
* RETURNS:
* %true if @bdev can be claimed, %false otherwise.
*/
static bool bd_may_claim(struct block_device *bdev, struct block_device *whole,
void *holder)
{
+ lockdep_assert_held(&bdev_lock);
+
if (bdev->bd_holder == holder)
return true; /* already a holder */
else if (bdev->bd_holder != NULL)
@@ -500,10 +499,10 @@ int bd_prepare_to_claim(struct block_device *bdev, void *holder)
if (WARN_ON_ONCE(!holder))
return -EINVAL;
retry:
- spin_lock(&bdev_lock);
+ mutex_lock(&bdev_lock);
/* if someone else claimed, fail */
if (!bd_may_claim(bdev, whole, holder)) {
- spin_unlock(&bdev_lock);
+ mutex_unlock(&bdev_lock);
return -EBUSY;
}
@@ -513,7 +512,7 @@ int bd_prepare_to_claim(struct block_device *bdev, void *holder)
DEFINE_WAIT(wait);
prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE);
- spin_unlock(&bdev_lock);
+ mutex_unlock(&bdev_lock);
schedule();
finish_wait(wq, &wait);
goto retry;
@@ -521,7 +520,7 @@ int bd_prepare_to_claim(struct block_device *bdev, void *holder)
/* yay, all mine */
whole->bd_claiming = holder;
- spin_unlock(&bdev_lock);
+ mutex_unlock(&bdev_lock);
return 0;
}
EXPORT_SYMBOL_GPL(bd_prepare_to_claim); /* only for the loop driver */
@@ -547,7 +546,7 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
{
struct block_device *whole = bdev_whole(bdev);
- spin_lock(&bdev_lock);
+ mutex_lock(&bdev_lock);
BUG_ON(!bd_may_claim(bdev, whole, holder));
/*
* Note that for a whole device bd_holders will be incremented twice,
@@ -558,7 +557,7 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
bdev->bd_holders++;
bdev->bd_holder = holder;
bd_clear_claiming(whole, holder);
- spin_unlock(&bdev_lock);
+ mutex_unlock(&bdev_lock);
}
/**
@@ -572,9 +571,9 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
*/
void bd_abort_claiming(struct block_device *bdev, void *holder)
{
- spin_lock(&bdev_lock);
+ mutex_lock(&bdev_lock);
bd_clear_claiming(bdev_whole(bdev), holder);
- spin_unlock(&bdev_lock);
+ mutex_unlock(&bdev_lock);
}
EXPORT_SYMBOL(bd_abort_claiming);
@@ -587,7 +586,7 @@ static void bd_end_claim(struct block_device *bdev)
* Release a claim on the device. The holder fields are protected with
* bdev_lock. open_mutex is used to synchronize disk_holder unlinking.
*/
- spin_lock(&bdev_lock);
+ mutex_lock(&bdev_lock);
WARN_ON_ONCE(--bdev->bd_holders < 0);
WARN_ON_ONCE(--whole->bd_holders < 0);
if (!bdev->bd_holders) {
@@ -597,7 +596,7 @@ static void bd_end_claim(struct block_device *bdev)
}
if (!whole->bd_holders)
whole->bd_holder = NULL;
- spin_unlock(&bdev_lock);
+ mutex_unlock(&bdev_lock);
/*
* If this was the last claim, remove holder link and unblock evpoll if
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 5/9] block: introduce holder ops
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (3 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 4/9] block: turn bdev_lock into a mutex Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-05 18:51 ` Darrick J. Wong
` (3 more replies)
2023-05-05 17:51 ` [PATCH 6/9] block: add a mark_dead holder operation Christoph Hellwig
` (4 subsequent siblings)
9 siblings, 4 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Add a new blk_holder_ops structure, which is passed to blkdev_get_by_* and
installed in the block_device for exclusive claims. It will be used to
allow the block layer to call back into the user of the block device for
thing like notification of a removed device or a device resize.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bdev.c | 20 +++++++++++++++-----
block/fops.c | 2 +-
block/genhd.c | 3 ++-
block/ioctl.c | 3 ++-
drivers/block/drbd/drbd_nl.c | 3 ++-
drivers/block/pktcdvd.c | 5 +++--
drivers/block/rnbd/rnbd-srv.c | 2 +-
drivers/block/xen-blkback/xenbus.c | 2 +-
drivers/block/zram/zram_drv.c | 2 +-
drivers/md/bcache/super.c | 2 +-
drivers/md/dm.c | 2 +-
drivers/md/md.c | 2 +-
drivers/mtd/devices/block2mtd.c | 4 ++--
drivers/nvme/target/io-cmd-bdev.c | 2 +-
drivers/s390/block/dasd_genhd.c | 2 +-
drivers/target/target_core_iblock.c | 2 +-
drivers/target/target_core_pscsi.c | 3 ++-
fs/btrfs/dev-replace.c | 2 +-
fs/btrfs/volumes.c | 6 +++---
fs/erofs/super.c | 2 +-
fs/ext4/super.c | 3 ++-
fs/f2fs/super.c | 4 ++--
fs/jfs/jfs_logmgr.c | 2 +-
fs/nfs/blocklayout/dev.c | 5 +++--
fs/nilfs2/super.c | 2 +-
fs/ocfs2/cluster/heartbeat.c | 2 +-
fs/reiserfs/journal.c | 5 +++--
fs/super.c | 4 ++--
fs/xfs/xfs_super.c | 2 +-
include/linux/blk_types.h | 2 ++
include/linux/blkdev.h | 8 ++++++--
kernel/power/swap.c | 4 ++--
mm/swapfile.c | 3 ++-
33 files changed, 71 insertions(+), 46 deletions(-)
diff --git a/block/bdev.c b/block/bdev.c
index bad75f6cf8edcd..297e26cef28c78 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -415,6 +415,7 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno)
bdev = I_BDEV(inode);
mutex_init(&bdev->bd_fsfreeze_mutex);
spin_lock_init(&bdev->bd_size_lock);
+ mutex_init(&bdev->bd_holder_lock);
bdev->bd_partno = partno;
bdev->bd_inode = inode;
bdev->bd_queue = disk->queue;
@@ -542,7 +543,8 @@ static void bd_clear_claiming(struct block_device *whole, void *holder)
* Finish exclusive open of a block device. Mark the device as exlusively
* open by the holder and wake up all waiters for exclusive open to finish.
*/
-static void bd_finish_claiming(struct block_device *bdev, void *holder)
+static void bd_finish_claiming(struct block_device *bdev, void *holder,
+ const struct blk_holder_ops *hops)
{
struct block_device *whole = bdev_whole(bdev);
@@ -555,7 +557,10 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
whole->bd_holders++;
whole->bd_holder = bd_may_claim;
bdev->bd_holders++;
+ mutex_lock(&bdev->bd_holder_lock);
bdev->bd_holder = holder;
+ bdev->bd_holder_ops = hops;
+ mutex_unlock(&bdev->bd_holder_lock);
bd_clear_claiming(whole, holder);
mutex_unlock(&bdev_lock);
}
@@ -590,7 +595,10 @@ static void bd_end_claim(struct block_device *bdev)
WARN_ON_ONCE(--bdev->bd_holders < 0);
WARN_ON_ONCE(--whole->bd_holders < 0);
if (!bdev->bd_holders) {
+ mutex_lock(&bdev->bd_holder_lock);
bdev->bd_holder = NULL;
+ bdev->bd_holder_ops = NULL;
+ mutex_unlock(&bdev->bd_holder_lock);
if (bdev->bd_write_holder)
unblock = true;
}
@@ -720,6 +728,7 @@ void blkdev_put_no_open(struct block_device *bdev)
* @dev: device number of block device to open
* @mode: FMODE_* mask
* @holder: exclusive holder identifier
+ * @hops: holder operations
*
* Open the block device described by device number @dev. If @mode includes
* %FMODE_EXCL, the block device is opened with exclusive access. Specifying
@@ -736,7 +745,8 @@ void blkdev_put_no_open(struct block_device *bdev)
* RETURNS:
* Reference to the block_device on success, ERR_PTR(-errno) on failure.
*/
-struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
+struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
+ const struct blk_holder_ops *hops)
{
bool unblock_events = true;
struct block_device *bdev;
@@ -776,7 +786,7 @@ struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
if (ret)
goto put_module;
if (mode & FMODE_EXCL) {
- bd_finish_claiming(bdev, holder);
+ bd_finish_claiming(bdev, holder, hops);
/*
* Block event polling for write claims if requested. Any write
@@ -827,7 +837,7 @@ EXPORT_SYMBOL(blkdev_get_by_dev);
* Reference to the block_device on success, ERR_PTR(-errno) on failure.
*/
struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
- void *holder)
+ void *holder, const struct blk_holder_ops *hops)
{
struct block_device *bdev;
dev_t dev;
@@ -837,7 +847,7 @@ struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
if (error)
return ERR_PTR(error);
- bdev = blkdev_get_by_dev(dev, mode, holder);
+ bdev = blkdev_get_by_dev(dev, mode, holder, hops);
if (!IS_ERR(bdev) && (mode & FMODE_WRITE) && bdev_read_only(bdev)) {
blkdev_put(bdev, mode);
return ERR_PTR(-EACCES);
diff --git a/block/fops.c b/block/fops.c
index d2e6be4e3d1c7d..2ac5ea878fa4cc 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -490,7 +490,7 @@ static int blkdev_open(struct inode *inode, struct file *filp)
if ((filp->f_flags & O_ACCMODE) == 3)
filp->f_mode |= FMODE_WRITE_IOCTL;
- bdev = blkdev_get_by_dev(inode->i_rdev, filp->f_mode, filp);
+ bdev = blkdev_get_by_dev(inode->i_rdev, filp->f_mode, filp, NULL);
if (IS_ERR(bdev))
return PTR_ERR(bdev);
diff --git a/block/genhd.c b/block/genhd.c
index 9a35b8443f0b5f..d1c673b967c254 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -381,7 +381,8 @@ int disk_scan_partitions(struct gendisk *disk, fmode_t mode)
}
set_bit(GD_NEED_PART_SCAN, &disk->state);
- bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXCL, NULL);
+ bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXCL, NULL,
+ NULL);
if (IS_ERR(bdev))
ret = PTR_ERR(bdev);
else
diff --git a/block/ioctl.c b/block/ioctl.c
index 9c5f637ff153f8..c7d7d4345edb4f 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -454,7 +454,8 @@ static int blkdev_bszset(struct block_device *bdev, fmode_t mode,
if (mode & FMODE_EXCL)
return set_blocksize(bdev, n);
- if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
+ if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
+ NULL)))
return -EBUSY;
ret = set_blocksize(bdev, n);
blkdev_put(bdev, mode | FMODE_EXCL);
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 1a5d3d72d91d27..cab59dab3410aa 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1641,7 +1641,8 @@ static struct block_device *open_backing_dev(struct drbd_device *device,
int err = 0;
bdev = blkdev_get_by_path(bdev_path,
- FMODE_READ | FMODE_WRITE | FMODE_EXCL, claim_ptr);
+ FMODE_READ | FMODE_WRITE | FMODE_EXCL,
+ claim_ptr, NULL);
if (IS_ERR(bdev)) {
drbd_err(device, "open(\"%s\") failed with %ld\n",
bdev_path, PTR_ERR(bdev));
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index d5d7884cedd477..377f8b34535294 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2125,7 +2125,8 @@ static int pkt_open_dev(struct pktcdvd_device *pd, fmode_t write)
* to read/write from/to it. It is already opened in O_NONBLOCK mode
* so open should not fail.
*/
- bdev = blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, pd);
+ bdev = blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, pd,
+ NULL);
if (IS_ERR(bdev)) {
ret = PTR_ERR(bdev);
goto out;
@@ -2530,7 +2531,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev)
}
}
- bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL);
+ bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL, NULL);
if (IS_ERR(bdev))
return PTR_ERR(bdev);
sdev = scsi_device_from_queue(bdev->bd_disk->queue);
diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index 2cfed2e58d646f..cec22bbae2f9a5 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -719,7 +719,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
goto reject;
}
- bdev = blkdev_get_by_path(full_path, open_flags, THIS_MODULE);
+ bdev = blkdev_get_by_path(full_path, open_flags, THIS_MODULE, NULL);
if (IS_ERR(bdev)) {
ret = PTR_ERR(bdev);
pr_err("Opening device '%s' on session %s failed, failed to open the block device, err: %d\n",
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 4807af1d580593..43b36da9b3544d 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -492,7 +492,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
vbd->pdevice = MKDEV(major, minor);
bdev = blkdev_get_by_dev(vbd->pdevice, vbd->readonly ?
- FMODE_READ : FMODE_WRITE, NULL);
+ FMODE_READ : FMODE_WRITE, NULL, NULL);
if (IS_ERR(bdev)) {
pr_warn("xen_vbd_create: device %08x could not be opened\n",
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index a84c4268257a99..5d21d074c7a0cd 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -508,7 +508,7 @@ static ssize_t backing_dev_store(struct device *dev,
}
bdev = blkdev_get_by_dev(inode->i_rdev,
- FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram);
+ FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram, NULL);
if (IS_ERR(bdev)) {
err = PTR_ERR(bdev);
bdev = NULL;
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index ba3909bb6beabb..c22d5aafd784b5 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -2561,7 +2561,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
err = "failed to open device";
bdev = blkdev_get_by_path(strim(path),
FMODE_READ|FMODE_WRITE|FMODE_EXCL,
- sb);
+ sb, NULL);
if (IS_ERR(bdev)) {
if (bdev == ERR_PTR(-EBUSY)) {
dev_t dev;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 3b694ba3a106e6..d759f8bdb3df2f 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -746,7 +746,7 @@ static struct table_device *open_table_device(struct mapped_device *md,
return ERR_PTR(-ENOMEM);
refcount_set(&td->count, 1);
- bdev = blkdev_get_by_dev(dev, mode | FMODE_EXCL, _dm_claim_ptr);
+ bdev = blkdev_get_by_dev(dev, mode | FMODE_EXCL, _dm_claim_ptr, NULL);
if (IS_ERR(bdev)) {
r = PTR_ERR(bdev);
goto out_free_td;
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 8e344b4b34446f..60ab5c4bee77c5 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3642,7 +3642,7 @@ static struct md_rdev *md_import_device(dev_t newdev, int super_format, int supe
rdev->bdev = blkdev_get_by_dev(newdev,
FMODE_READ | FMODE_WRITE | FMODE_EXCL,
- super_format == -2 ? &claim_rdev : rdev);
+ super_format == -2 ? &claim_rdev : rdev, NULL);
if (IS_ERR(rdev->bdev)) {
pr_warn("md: could not open device unknown-block(%u,%u).\n",
MAJOR(newdev), MINOR(newdev));
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 4cd37ec45762b6..7ac82c6fe35024 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -235,7 +235,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size,
return NULL;
/* Get a handle on the device */
- bdev = blkdev_get_by_path(devname, mode, dev);
+ bdev = blkdev_get_by_path(devname, mode, dev, NULL);
#ifndef MODULE
/*
@@ -257,7 +257,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size,
devt = name_to_dev_t(devname);
if (!devt)
continue;
- bdev = blkdev_get_by_dev(devt, mode, dev);
+ bdev = blkdev_get_by_dev(devt, mode, dev, NULL);
}
#endif
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index c2d6cea0236b0a..9b6d6d85c72544 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -85,7 +85,7 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns)
return -ENOTBLK;
ns->bdev = blkdev_get_by_path(ns->device_path,
- FMODE_READ | FMODE_WRITE, NULL);
+ FMODE_READ | FMODE_WRITE, NULL, NULL);
if (IS_ERR(ns->bdev)) {
ret = PTR_ERR(ns->bdev);
if (ret != -ENOTBLK) {
diff --git a/drivers/s390/block/dasd_genhd.c b/drivers/s390/block/dasd_genhd.c
index 998a961e170417..f21198bc483e1a 100644
--- a/drivers/s390/block/dasd_genhd.c
+++ b/drivers/s390/block/dasd_genhd.c
@@ -130,7 +130,7 @@ int dasd_scan_partitions(struct dasd_block *block)
struct block_device *bdev;
int rc;
- bdev = blkdev_get_by_dev(disk_devt(block->gdp), FMODE_READ, NULL);
+ bdev = blkdev_get_by_dev(disk_devt(block->gdp), FMODE_READ, NULL, NULL);
if (IS_ERR(bdev)) {
DBF_DEV_EVENT(DBF_ERR, block->base,
"scan partitions error, blkdev_get returned %ld",
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index cc838ffd129472..a5cbbefa78ee4e 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -114,7 +114,7 @@ static int iblock_configure_device(struct se_device *dev)
else
dev->dev_flags |= DF_READ_ONLY;
- bd = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev);
+ bd = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev, NULL);
if (IS_ERR(bd)) {
ret = PTR_ERR(bd);
goto out_free_bioset;
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index e7425549e39c73..e3494e036c6c85 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -367,7 +367,8 @@ static int pscsi_create_type_disk(struct se_device *dev, struct scsi_device *sd)
* for TYPE_DISK and TYPE_ZBC using supplied udev_path
*/
bd = blkdev_get_by_path(dev->udev_path,
- FMODE_WRITE|FMODE_READ|FMODE_EXCL, pdv);
+ FMODE_WRITE|FMODE_READ|FMODE_EXCL, pdv,
+ NULL);
if (IS_ERR(bd)) {
pr_err("pSCSI: blkdev_get_by_path() failed\n");
scsi_device_put(sd);
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 78696d331639bd..4de4984fa99ba3 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -258,7 +258,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
}
bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL,
- fs_info->bdev_holder);
+ fs_info->bdev_holder, NULL);
if (IS_ERR(bdev)) {
btrfs_err(fs_info, "target device %s is invalid!", device_path);
return PTR_ERR(bdev);
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 03f52e4a20aa9b..708350ba07e3ee 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -495,7 +495,7 @@ btrfs_get_bdev_and_sb(const char *device_path, fmode_t flags, void *holder,
{
int ret;
- *bdev = blkdev_get_by_path(device_path, flags, holder);
+ *bdev = blkdev_get_by_path(device_path, flags, holder, NULL);
if (IS_ERR(*bdev)) {
ret = PTR_ERR(*bdev);
@@ -1376,7 +1376,7 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags,
* values temporarily, as the device paths of the fsid are the only
* required information for assembling the volume.
*/
- bdev = blkdev_get_by_path(path, flags, holder);
+ bdev = blkdev_get_by_path(path, flags, holder, NULL);
if (IS_ERR(bdev))
return ERR_CAST(bdev);
@@ -2628,7 +2628,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
return -EROFS;
bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL,
- fs_info->bdev_holder);
+ fs_info->bdev_holder, NULL);
if (IS_ERR(bdev))
return PTR_ERR(bdev);
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 811ab66d805ede..6c263e9cd38b2a 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -254,7 +254,7 @@ static int erofs_init_device(struct erofs_buf *buf, struct super_block *sb,
dif->fscache = fscache;
} else if (!sbi->devs->flatdev) {
bdev = blkdev_get_by_path(dif->path, FMODE_READ | FMODE_EXCL,
- sb->s_type);
+ sb->s_type, NULL);
if (IS_ERR(bdev))
return PTR_ERR(bdev);
dif->bdev = bdev;
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index d39f386e9baf6a..99d495de2e9b08 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1101,7 +1101,8 @@ static struct block_device *ext4_blkdev_get(dev_t dev, struct super_block *sb)
{
struct block_device *bdev;
- bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb);
+ bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb,
+ NULL);
if (IS_ERR(bdev))
goto fail;
return bdev;
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 9f15b03037dba9..7c34ab082f1382 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -4025,7 +4025,7 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
/* Single zoned block device mount */
FDEV(0).bdev =
blkdev_get_by_dev(sbi->sb->s_bdev->bd_dev,
- sbi->sb->s_mode, sbi->sb->s_type);
+ sbi->sb->s_mode, sbi->sb->s_type, NULL);
} else {
/* Multi-device mount */
memcpy(FDEV(i).path, RDEV(i).path, MAX_PATH_LEN);
@@ -4044,7 +4044,7 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
sbi->log_blocks_per_seg) - 1;
}
FDEV(i).bdev = blkdev_get_by_path(FDEV(i).path,
- sbi->sb->s_mode, sbi->sb->s_type);
+ sbi->sb->s_mode, sbi->sb->s_type, NULL);
}
if (IS_ERR(FDEV(i).bdev))
return PTR_ERR(FDEV(i).bdev);
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 695415cbfe985b..8c55030c57ed52 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -1101,7 +1101,7 @@ int lmLogOpen(struct super_block *sb)
*/
bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
- log);
+ log, NULL);
if (IS_ERR(bdev)) {
rc = PTR_ERR(bdev);
goto free;
diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c
index fea5f8821da5ef..38b066ca699ed7 100644
--- a/fs/nfs/blocklayout/dev.c
+++ b/fs/nfs/blocklayout/dev.c
@@ -243,7 +243,7 @@ bl_parse_simple(struct nfs_server *server, struct pnfs_block_dev *d,
if (!dev)
return -EIO;
- bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL);
+ bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL, NULL);
if (IS_ERR(bdev)) {
printk(KERN_WARNING "pNFS: failed to open device %d:%d (%ld)\n",
MAJOR(dev), MINOR(dev), PTR_ERR(bdev));
@@ -312,7 +312,8 @@ bl_open_path(struct pnfs_block_volume *v, const char *prefix)
if (!devname)
return ERR_PTR(-ENOMEM);
- bdev = blkdev_get_by_path(devname, FMODE_READ | FMODE_WRITE, NULL);
+ bdev = blkdev_get_by_path(devname, FMODE_READ | FMODE_WRITE, NULL,
+ NULL);
if (IS_ERR(bdev)) {
pr_warn("pNFS: failed to open device %s (%ld)\n",
devname, PTR_ERR(bdev));
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
index 77f1e5778d1c84..91bfbd973d1d53 100644
--- a/fs/nilfs2/super.c
+++ b/fs/nilfs2/super.c
@@ -1285,7 +1285,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags,
if (!(flags & SB_RDONLY))
mode |= FMODE_WRITE;
- sd.bdev = blkdev_get_by_path(dev_name, mode, fs_type);
+ sd.bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
if (IS_ERR(sd.bdev))
return ERR_CAST(sd.bdev);
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
index 60b97c92e2b25e..6b13b8c3f2b8af 100644
--- a/fs/ocfs2/cluster/heartbeat.c
+++ b/fs/ocfs2/cluster/heartbeat.c
@@ -1786,7 +1786,7 @@ static ssize_t o2hb_region_dev_store(struct config_item *item,
goto out2;
reg->hr_bdev = blkdev_get_by_dev(f.file->f_mapping->host->i_rdev,
- FMODE_WRITE | FMODE_READ, NULL);
+ FMODE_WRITE | FMODE_READ, NULL, NULL);
if (IS_ERR(reg->hr_bdev)) {
ret = PTR_ERR(reg->hr_bdev);
reg->hr_bdev = NULL;
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
index 4d11d60f493c14..5e4db9a0c8e5a3 100644
--- a/fs/reiserfs/journal.c
+++ b/fs/reiserfs/journal.c
@@ -2616,7 +2616,7 @@ static int journal_init_dev(struct super_block *super,
if (jdev == super->s_dev)
blkdev_mode &= ~FMODE_EXCL;
journal->j_dev_bd = blkdev_get_by_dev(jdev, blkdev_mode,
- journal);
+ journal, NULL);
journal->j_dev_mode = blkdev_mode;
if (IS_ERR(journal->j_dev_bd)) {
result = PTR_ERR(journal->j_dev_bd);
@@ -2632,7 +2632,8 @@ static int journal_init_dev(struct super_block *super,
}
journal->j_dev_mode = blkdev_mode;
- journal->j_dev_bd = blkdev_get_by_path(jdev_name, blkdev_mode, journal);
+ journal->j_dev_bd = blkdev_get_by_path(jdev_name, blkdev_mode, journal,
+ NULL);
if (IS_ERR(journal->j_dev_bd)) {
result = PTR_ERR(journal->j_dev_bd);
journal->j_dev_bd = NULL;
diff --git a/fs/super.c b/fs/super.c
index 34afe411cf2bc3..012ce140080375 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1248,7 +1248,7 @@ int get_tree_bdev(struct fs_context *fc,
if (!fc->source)
return invalf(fc, "No source specified");
- bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type);
+ bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL);
if (IS_ERR(bdev)) {
errorf(fc, "%s: Can't open blockdev", fc->source);
return PTR_ERR(bdev);
@@ -1333,7 +1333,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
if (!(flags & SB_RDONLY))
mode |= FMODE_WRITE;
- bdev = blkdev_get_by_path(dev_name, mode, fs_type);
+ bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
if (IS_ERR(bdev))
return ERR_CAST(bdev);
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 4d2e87462ac4a1..bc17ad350aea5a 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -386,7 +386,7 @@ xfs_blkdev_get(
int error = 0;
*bdevp = blkdev_get_by_path(name, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
- mp);
+ mp, NULL);
if (IS_ERR(*bdevp)) {
error = PTR_ERR(*bdevp);
xfs_warn(mp, "Invalid device [%s], error=%d", name, error);
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 740afe80f29786..84a931caef514e 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -55,6 +55,8 @@ struct block_device {
struct super_block * bd_super;
void * bd_claiming;
void * bd_holder;
+ const struct blk_holder_ops *bd_holder_ops;
+ struct mutex bd_holder_lock;
/* The counter of freeze processes */
int bd_fsfreeze_count;
int bd_holders;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index e3242e67a8e3df..3f41f8c9b103cf 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1468,9 +1468,13 @@ void blkdev_show(struct seq_file *seqf, off_t offset);
#define BLKDEV_MAJOR_MAX 0
#endif
+struct blk_holder_ops {
+};
+
+struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
+ const struct blk_holder_ops *hops);
struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
- void *holder);
-struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder);
+ void *holder, const struct blk_holder_ops *hops);
int bd_prepare_to_claim(struct block_device *bdev, void *holder);
void bd_abort_claiming(struct block_device *bdev, void *holder);
void blkdev_put(struct block_device *bdev, fmode_t mode);
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 92e41ed292ada8..801c411530d11c 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -357,7 +357,7 @@ static int swsusp_swap_check(void)
root_swap = res;
hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device, FMODE_WRITE,
- NULL);
+ NULL, NULL);
if (IS_ERR(hib_resume_bdev))
return PTR_ERR(hib_resume_bdev);
@@ -1524,7 +1524,7 @@ int swsusp_check(void)
mode |= FMODE_EXCL;
hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device,
- mode, &holder);
+ mode, &holder, NULL);
if (!IS_ERR(hib_resume_bdev)) {
set_blocksize(hib_resume_bdev, PAGE_SIZE);
clear_page(swsusp_header);
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 274bbf79748006..cfbcf7d5705f5f 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -2770,7 +2770,8 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
if (S_ISBLK(inode->i_mode)) {
p->bdev = blkdev_get_by_dev(inode->i_rdev,
- FMODE_READ | FMODE_WRITE | FMODE_EXCL, p);
+ FMODE_READ | FMODE_WRITE | FMODE_EXCL, p,
+ NULL);
if (IS_ERR(p->bdev)) {
error = PTR_ERR(p->bdev);
p->bdev = NULL;
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 6/9] block: add a mark_dead holder operation
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (4 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-05 18:37 ` Darrick J. Wong
2023-05-07 19:19 ` Jan Kara
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
` (3 subsequent siblings)
9 siblings, 2 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Add a mark_dead method to blk_holder_ops that is called from blk_mark_disk_dead
to notify the holder that the block device it is using has been marked dead.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/genhd.c | 24 ++++++++++++++++++++++++
include/linux/blkdev.h | 1 +
2 files changed, 25 insertions(+)
diff --git a/block/genhd.c b/block/genhd.c
index d1c673b967c254..af97a4ef1e926c 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -575,6 +575,28 @@ int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
}
EXPORT_SYMBOL(device_add_disk);
+static void blk_report_disk_dead(struct gendisk *disk)
+{
+ struct block_device *bdev;
+ unsigned long idx;
+
+ rcu_read_lock();
+ xa_for_each(&disk->part_tbl, idx, bdev) {
+ if (!kobject_get_unless_zero(&bdev->bd_device.kobj))
+ continue;
+ rcu_read_unlock();
+
+ mutex_lock(&bdev->bd_holder_lock);
+ if (bdev->bd_holder_ops && bdev->bd_holder_ops->mark_dead)
+ bdev->bd_holder_ops->mark_dead(bdev);
+ mutex_unlock(&bdev->bd_holder_lock);
+
+ put_device(&bdev->bd_device);
+ rcu_read_lock();
+ }
+ rcu_read_unlock();
+}
+
/**
* blk_mark_disk_dead - mark a disk as dead
* @disk: disk to mark as dead
@@ -602,6 +624,8 @@ void blk_mark_disk_dead(struct gendisk *disk)
* Prevent new I/O from crossing bio_queue_enter().
*/
blk_queue_start_drain(disk->queue);
+
+ blk_report_disk_dead(disk);
}
EXPORT_SYMBOL_GPL(blk_mark_disk_dead);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 3f41f8c9b103cf..9706bec2be16a5 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1469,6 +1469,7 @@ void blkdev_show(struct seq_file *seqf, off_t offset);
#endif
struct blk_holder_ops {
+ void (*mark_dead)(struct block_device *bdev);
};
struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 7/9] fs: add a method to shut down the file system
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (5 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 6/9] block: add a mark_dead holder operation Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-05 18:39 ` Darrick J. Wong
` (2 more replies)
2023-05-05 17:51 ` [PATCH 8/9] xfs: wire up sops->shutdown Christoph Hellwig
` (2 subsequent siblings)
9 siblings, 3 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Add a new ->shutdown super operation that can be used to tell the file
system to shut down, and call it from newly created holder ops when the
block device under a file system shuts down.
This only covers the main block device for "simple" file systems using
get_tree_bdev / mount_bdev. File systems their own get_tree method
or opening additional devices will need to set up their own
blk_holder_ops.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/super.c | 21 +++++++++++++++++++--
include/linux/fs.h | 1 +
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 012ce140080375..f127589700ab25 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1206,6 +1206,22 @@ int get_tree_keyed(struct fs_context *fc,
EXPORT_SYMBOL(get_tree_keyed);
#ifdef CONFIG_BLOCK
+static void fs_mark_dead(struct block_device *bdev)
+{
+ struct super_block *sb;
+
+ sb = get_super(bdev);
+ if (!sb)
+ return;
+
+ if (sb->s_op->shutdown)
+ sb->s_op->shutdown(sb);
+ drop_super(sb);
+}
+
+static const struct blk_holder_ops fs_holder_ops = {
+ .mark_dead = fs_mark_dead,
+};
static int set_bdev_super(struct super_block *s, void *data)
{
@@ -1248,7 +1264,8 @@ int get_tree_bdev(struct fs_context *fc,
if (!fc->source)
return invalf(fc, "No source specified");
- bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL);
+ bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type,
+ &fs_holder_ops);
if (IS_ERR(bdev)) {
errorf(fc, "%s: Can't open blockdev", fc->source);
return PTR_ERR(bdev);
@@ -1333,7 +1350,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
if (!(flags & SB_RDONLY))
mode |= FMODE_WRITE;
- bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
+ bdev = blkdev_get_by_path(dev_name, mode, fs_type, &fs_holder_ops);
if (IS_ERR(bdev))
return ERR_CAST(bdev);
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 21a98168085641..cf3042641b9b30 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1932,6 +1932,7 @@ struct super_operations {
struct shrink_control *);
long (*free_cached_objects)(struct super_block *,
struct shrink_control *);
+ void (*shutdown)(struct super_block *sb);
};
/*
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 8/9] xfs: wire up sops->shutdown
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (6 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-05 18:23 ` Darrick J. Wong
2023-05-05 17:51 ` [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices Christoph Hellwig
2023-05-08 15:20 ` introduce bdev holder ops and a file system shutdown method Christoph Hellwig
9 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Wire up the shutdown method to shut down the file system when the
underlying block device is marked dead. Add a new message to
clearly distinguish this shutdown reason from other shutdowns.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_fsops.c | 3 +++
fs/xfs/xfs_mount.h | 1 +
fs/xfs/xfs_super.c | 8 ++++++++
3 files changed, 12 insertions(+)
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index 13851c0d640bc8..9ebb8333a30800 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -534,6 +534,9 @@ xfs_do_force_shutdown(
} else if (flags & SHUTDOWN_CORRUPT_ONDISK) {
tag = XFS_PTAG_SHUTDOWN_CORRUPT;
why = "Corruption of on-disk metadata";
+ } else if (flags & SHUTDOWN_DEVICE_REMOVED) {
+ tag = XFS_PTAG_SHUTDOWN_IOERROR;
+ why = "Block device removal";
} else {
tag = XFS_PTAG_SHUTDOWN_IOERROR;
why = "Metadata I/O Error";
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index f3269c0626f057..a3aa954477d0dc 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -454,6 +454,7 @@ void xfs_do_force_shutdown(struct xfs_mount *mp, uint32_t flags, char *fname,
#define SHUTDOWN_FORCE_UMOUNT (1u << 2) /* shutdown from a forced unmount */
#define SHUTDOWN_CORRUPT_INCORE (1u << 3) /* corrupt in-memory structures */
#define SHUTDOWN_CORRUPT_ONDISK (1u << 4) /* corrupt metadata on device */
+#define SHUTDOWN_DEVICE_REMOVED (1u << 5) /* device removed underneath us */
#define XFS_SHUTDOWN_STRINGS \
{ SHUTDOWN_META_IO_ERROR, "metadata_io" }, \
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index bc17ad350aea5a..3abe5ae96cc59b 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1156,6 +1156,13 @@ xfs_fs_free_cached_objects(
return xfs_reclaim_inodes_nr(XFS_M(sb), sc->nr_to_scan);
}
+static void
+xfs_fs_shutdown(
+ struct super_block *sb)
+{
+ xfs_force_shutdown(XFS_M(sb), SHUTDOWN_DEVICE_REMOVED);
+}
+
static const struct super_operations xfs_super_operations = {
.alloc_inode = xfs_fs_alloc_inode,
.destroy_inode = xfs_fs_destroy_inode,
@@ -1169,6 +1176,7 @@ static const struct super_operations xfs_super_operations = {
.show_options = xfs_fs_show_options,
.nr_cached_objects = xfs_fs_nr_cached_objects,
.free_cached_objects = xfs_fs_free_cached_objects,
+ .shutdown = xfs_fs_shutdown,
};
static int
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (7 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 8/9] xfs: wire up sops->shutdown Christoph Hellwig
@ 2023-05-05 17:51 ` Christoph Hellwig
2023-05-05 18:32 ` Darrick J. Wong
2023-05-08 15:20 ` introduce bdev holder ops and a file system shutdown method Christoph Hellwig
9 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-05 17:51 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
Implement a set of holder_ops that shut down the file system when the
block device used as log or RT device is removed undeneath the file
system.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_super.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 3abe5ae96cc59b..9c2401d9548d83 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -377,6 +377,17 @@ xfs_setup_dax_always(
return 0;
}
+static void
+xfs_hop_mark_dead(
+ struct block_device *bdev)
+{
+ xfs_force_shutdown(bdev->bd_holder, SHUTDOWN_DEVICE_REMOVED);
+}
+
+static const struct blk_holder_ops xfs_holder_ops = {
+ .mark_dead = xfs_hop_mark_dead,
+};
+
STATIC int
xfs_blkdev_get(
xfs_mount_t *mp,
@@ -386,7 +397,7 @@ xfs_blkdev_get(
int error = 0;
*bdevp = blkdev_get_by_path(name, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
- mp, NULL);
+ mp, &xfs_holder_ops);
if (IS_ERR(*bdevp)) {
error = PTR_ERR(*bdevp);
xfs_warn(mp, "Invalid device [%s], error=%d", name, error);
--
2.39.2
^ permalink raw reply related [flat|nested] 52+ messages in thread
* Re: [PATCH 8/9] xfs: wire up sops->shutdown
2023-05-05 17:51 ` [PATCH 8/9] xfs: wire up sops->shutdown Christoph Hellwig
@ 2023-05-05 18:23 ` Darrick J. Wong
2023-05-09 13:28 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-05 18:23 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, linux-block,
linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 01:51:31PM -0400, Christoph Hellwig wrote:
> Wire up the shutdown method to shut down the file system when the
> underlying block device is marked dead. Add a new message to
> clearly distinguish this shutdown reason from other shutdowns.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_fsops.c | 3 +++
> fs/xfs/xfs_mount.h | 1 +
> fs/xfs/xfs_super.c | 8 ++++++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
> index 13851c0d640bc8..9ebb8333a30800 100644
> --- a/fs/xfs/xfs_fsops.c
> +++ b/fs/xfs/xfs_fsops.c
> @@ -534,6 +534,9 @@ xfs_do_force_shutdown(
> } else if (flags & SHUTDOWN_CORRUPT_ONDISK) {
> tag = XFS_PTAG_SHUTDOWN_CORRUPT;
> why = "Corruption of on-disk metadata";
> + } else if (flags & SHUTDOWN_DEVICE_REMOVED) {
> + tag = XFS_PTAG_SHUTDOWN_IOERROR;
> + why = "Block device removal";
> } else {
> tag = XFS_PTAG_SHUTDOWN_IOERROR;
> why = "Metadata I/O Error";
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index f3269c0626f057..a3aa954477d0dc 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -454,6 +454,7 @@ void xfs_do_force_shutdown(struct xfs_mount *mp, uint32_t flags, char *fname,
> #define SHUTDOWN_FORCE_UMOUNT (1u << 2) /* shutdown from a forced unmount */
> #define SHUTDOWN_CORRUPT_INCORE (1u << 3) /* corrupt in-memory structures */
> #define SHUTDOWN_CORRUPT_ONDISK (1u << 4) /* corrupt metadata on device */
> +#define SHUTDOWN_DEVICE_REMOVED (1u << 5) /* device removed underneath us */
>
> #define XFS_SHUTDOWN_STRINGS \
Could you add SHUTDOWN_DEVICE_REMOVED to XFS_SHUTDOWN_STRINGS so the
tracepoint data will decode that flag?
(Everything else in here looks fine to me)
--D
> { SHUTDOWN_META_IO_ERROR, "metadata_io" }, \
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index bc17ad350aea5a..3abe5ae96cc59b 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1156,6 +1156,13 @@ xfs_fs_free_cached_objects(
> return xfs_reclaim_inodes_nr(XFS_M(sb), sc->nr_to_scan);
> }
>
> +static void
> +xfs_fs_shutdown(
> + struct super_block *sb)
> +{
> + xfs_force_shutdown(XFS_M(sb), SHUTDOWN_DEVICE_REMOVED);
> +}
> +
> static const struct super_operations xfs_super_operations = {
> .alloc_inode = xfs_fs_alloc_inode,
> .destroy_inode = xfs_fs_destroy_inode,
> @@ -1169,6 +1176,7 @@ static const struct super_operations xfs_super_operations = {
> .show_options = xfs_fs_show_options,
> .nr_cached_objects = xfs_fs_nr_cached_objects,
> .free_cached_objects = xfs_fs_free_cached_objects,
> + .shutdown = xfs_fs_shutdown,
> };
>
> static int
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices
2023-05-05 17:51 ` [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices Christoph Hellwig
@ 2023-05-05 18:32 ` Darrick J. Wong
0 siblings, 0 replies; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-05 18:32 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, linux-block,
linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 01:51:32PM -0400, Christoph Hellwig wrote:
> Implement a set of holder_ops that shut down the file system when the
> block device used as log or RT device is removed undeneath the file
> system.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_super.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 3abe5ae96cc59b..9c2401d9548d83 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -377,6 +377,17 @@ xfs_setup_dax_always(
> return 0;
> }
>
> +static void
> +xfs_hop_mark_dead(
> + struct block_device *bdev)
> +{
> + xfs_force_shutdown(bdev->bd_holder, SHUTDOWN_DEVICE_REMOVED);
/me wonders if this should be xfs_bdev_mark_dead, but eh that's mostly
stylistic.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> +}
> +
> +static const struct blk_holder_ops xfs_holder_ops = {
> + .mark_dead = xfs_hop_mark_dead,
> +};
> +
> STATIC int
> xfs_blkdev_get(
> xfs_mount_t *mp,
> @@ -386,7 +397,7 @@ xfs_blkdev_get(
> int error = 0;
>
> *bdevp = blkdev_get_by_path(name, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - mp, NULL);
> + mp, &xfs_holder_ops);
> if (IS_ERR(*bdevp)) {
> error = PTR_ERR(*bdevp);
> xfs_warn(mp, "Invalid device [%s], error=%d", name, error);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 6/9] block: add a mark_dead holder operation
2023-05-05 17:51 ` [PATCH 6/9] block: add a mark_dead holder operation Christoph Hellwig
@ 2023-05-05 18:37 ` Darrick J. Wong
2023-05-09 13:30 ` Christoph Hellwig
2023-05-07 19:19 ` Jan Kara
1 sibling, 1 reply; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-05 18:37 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, linux-block,
linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 01:51:29PM -0400, Christoph Hellwig wrote:
> Add a mark_dead method to blk_holder_ops that is called from blk_mark_disk_dead
> to notify the holder that the block device it is using has been marked dead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/genhd.c | 24 ++++++++++++++++++++++++
> include/linux/blkdev.h | 1 +
> 2 files changed, 25 insertions(+)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index d1c673b967c254..af97a4ef1e926c 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -575,6 +575,28 @@ int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
> }
> EXPORT_SYMBOL(device_add_disk);
>
> +static void blk_report_disk_dead(struct gendisk *disk)
> +{
> + struct block_device *bdev;
> + unsigned long idx;
> +
> + rcu_read_lock();
> + xa_for_each(&disk->part_tbl, idx, bdev) {
> + if (!kobject_get_unless_zero(&bdev->bd_device.kobj))
> + continue;
> + rcu_read_unlock();
> +
> + mutex_lock(&bdev->bd_holder_lock);
> + if (bdev->bd_holder_ops && bdev->bd_holder_ops->mark_dead)
> + bdev->bd_holder_ops->mark_dead(bdev);
> + mutex_unlock(&bdev->bd_holder_lock);
> +
> + put_device(&bdev->bd_device);
> + rcu_read_lock();
> + }
> + rcu_read_unlock();
> +}
> +
> /**
> * blk_mark_disk_dead - mark a disk as dead
> * @disk: disk to mark as dead
> @@ -602,6 +624,8 @@ void blk_mark_disk_dead(struct gendisk *disk)
> * Prevent new I/O from crossing bio_queue_enter().
> */
> blk_queue_start_drain(disk->queue);
> +
> + blk_report_disk_dead(disk);
> }
> EXPORT_SYMBOL_GPL(blk_mark_disk_dead);
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 3f41f8c9b103cf..9706bec2be16a5 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1469,6 +1469,7 @@ void blkdev_show(struct seq_file *seqf, off_t offset);
> #endif
>
> struct blk_holder_ops {
> + void (*mark_dead)(struct block_device *bdev);
Now that we have blockdev callbacks, can we add a pair for freeze_bdev
and thaw_bdev so that LVM snapshotting an xfs log device can actually
quiesce the filesystem?
This patch itself looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> };
>
> struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 7/9] fs: add a method to shut down the file system
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
@ 2023-05-05 18:39 ` Darrick J. Wong
2023-05-07 19:20 ` Jan Kara
2023-05-16 16:20 ` Christian Brauner
2 siblings, 0 replies; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-05 18:39 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, linux-block,
linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 01:51:30PM -0400, Christoph Hellwig wrote:
> Add a new ->shutdown super operation that can be used to tell the file
> system to shut down, and call it from newly created holder ops when the
> block device under a file system shuts down.
>
> This only covers the main block device for "simple" file systems using
> get_tree_bdev / mount_bdev. File systems their own get_tree method
> or opening additional devices will need to set up their own
> blk_holder_ops.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/super.c | 21 +++++++++++++++++++--
> include/linux/fs.h | 1 +
> 2 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 012ce140080375..f127589700ab25 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1206,6 +1206,22 @@ int get_tree_keyed(struct fs_context *fc,
> EXPORT_SYMBOL(get_tree_keyed);
>
> #ifdef CONFIG_BLOCK
> +static void fs_mark_dead(struct block_device *bdev)
> +{
> + struct super_block *sb;
> +
> + sb = get_super(bdev);
> + if (!sb)
> + return;
> +
> + if (sb->s_op->shutdown)
> + sb->s_op->shutdown(sb);
> + drop_super(sb);
> +}
> +
> +static const struct blk_holder_ops fs_holder_ops = {
> + .mark_dead = fs_mark_dead,
> +};
>
> static int set_bdev_super(struct super_block *s, void *data)
> {
> @@ -1248,7 +1264,8 @@ int get_tree_bdev(struct fs_context *fc,
> if (!fc->source)
> return invalf(fc, "No source specified");
>
> - bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL);
> + bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type,
> + &fs_holder_ops);
> if (IS_ERR(bdev)) {
> errorf(fc, "%s: Can't open blockdev", fc->source);
> return PTR_ERR(bdev);
> @@ -1333,7 +1350,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
> if (!(flags & SB_RDONLY))
> mode |= FMODE_WRITE;
>
> - bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
> + bdev = blkdev_get_by_path(dev_name, mode, fs_type, &fs_holder_ops);
> if (IS_ERR(bdev))
> return ERR_CAST(bdev);
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 21a98168085641..cf3042641b9b30 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1932,6 +1932,7 @@ struct super_operations {
struct shrink_control *);
> long (*free_cached_objects)(struct super_block *,
> struct shrink_control *);
> + void (*shutdown)(struct super_block *sb);
> };
>
> /*
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
@ 2023-05-05 18:51 ` Darrick J. Wong
2023-05-09 13:35 ` Christoph Hellwig
2023-05-07 19:12 ` Jan Kara
` (2 subsequent siblings)
3 siblings, 1 reply; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-05 18:51 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, linux-block,
linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 01:51:28PM -0400, Christoph Hellwig wrote:
> Add a new blk_holder_ops structure, which is passed to blkdev_get_by_* and
> installed in the block_device for exclusive claims. It will be used to
> allow the block layer to call back into the user of the block device for
> thing like notification of a removed device or a device resize.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/bdev.c | 20 +++++++++++++++-----
> block/fops.c | 2 +-
> block/genhd.c | 3 ++-
> block/ioctl.c | 3 ++-
> drivers/block/drbd/drbd_nl.c | 3 ++-
> drivers/block/pktcdvd.c | 5 +++--
> drivers/block/rnbd/rnbd-srv.c | 2 +-
> drivers/block/xen-blkback/xenbus.c | 2 +-
> drivers/block/zram/zram_drv.c | 2 +-
> drivers/md/bcache/super.c | 2 +-
> drivers/md/dm.c | 2 +-
> drivers/md/md.c | 2 +-
> drivers/mtd/devices/block2mtd.c | 4 ++--
> drivers/nvme/target/io-cmd-bdev.c | 2 +-
> drivers/s390/block/dasd_genhd.c | 2 +-
> drivers/target/target_core_iblock.c | 2 +-
> drivers/target/target_core_pscsi.c | 3 ++-
> fs/btrfs/dev-replace.c | 2 +-
> fs/btrfs/volumes.c | 6 +++---
> fs/erofs/super.c | 2 +-
> fs/ext4/super.c | 3 ++-
> fs/f2fs/super.c | 4 ++--
> fs/jfs/jfs_logmgr.c | 2 +-
> fs/nfs/blocklayout/dev.c | 5 +++--
> fs/nilfs2/super.c | 2 +-
> fs/ocfs2/cluster/heartbeat.c | 2 +-
> fs/reiserfs/journal.c | 5 +++--
> fs/super.c | 4 ++--
> fs/xfs/xfs_super.c | 2 +-
> include/linux/blk_types.h | 2 ++
> include/linux/blkdev.h | 8 ++++++--
> kernel/power/swap.c | 4 ++--
> mm/swapfile.c | 3 ++-
Fun question: What happens when the swap disk falls off the bus?
> 33 files changed, 71 insertions(+), 46 deletions(-)
>
> diff --git a/block/bdev.c b/block/bdev.c
> index bad75f6cf8edcd..297e26cef28c78 100644
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -415,6 +415,7 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno)
> bdev = I_BDEV(inode);
> mutex_init(&bdev->bd_fsfreeze_mutex);
> spin_lock_init(&bdev->bd_size_lock);
> + mutex_init(&bdev->bd_holder_lock);
> bdev->bd_partno = partno;
> bdev->bd_inode = inode;
> bdev->bd_queue = disk->queue;
> @@ -542,7 +543,8 @@ static void bd_clear_claiming(struct block_device *whole, void *holder)
> * Finish exclusive open of a block device. Mark the device as exlusively
> * open by the holder and wake up all waiters for exclusive open to finish.
> */
> -static void bd_finish_claiming(struct block_device *bdev, void *holder)
> +static void bd_finish_claiming(struct block_device *bdev, void *holder,
> + const struct blk_holder_ops *hops)
> {
> struct block_device *whole = bdev_whole(bdev);
>
> @@ -555,7 +557,10 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> whole->bd_holders++;
> whole->bd_holder = bd_may_claim;
> bdev->bd_holders++;
> + mutex_lock(&bdev->bd_holder_lock);
> bdev->bd_holder = holder;
> + bdev->bd_holder_ops = hops;
> + mutex_unlock(&bdev->bd_holder_lock);
> bd_clear_claiming(whole, holder);
> mutex_unlock(&bdev_lock);
> }
> @@ -590,7 +595,10 @@ static void bd_end_claim(struct block_device *bdev)
> WARN_ON_ONCE(--bdev->bd_holders < 0);
> WARN_ON_ONCE(--whole->bd_holders < 0);
> if (!bdev->bd_holders) {
> + mutex_lock(&bdev->bd_holder_lock);
> bdev->bd_holder = NULL;
> + bdev->bd_holder_ops = NULL;
> + mutex_unlock(&bdev->bd_holder_lock);
> if (bdev->bd_write_holder)
> unblock = true;
> }
> @@ -720,6 +728,7 @@ void blkdev_put_no_open(struct block_device *bdev)
> * @dev: device number of block device to open
> * @mode: FMODE_* mask
> * @holder: exclusive holder identifier
> + * @hops: holder operations
> *
> * Open the block device described by device number @dev. If @mode includes
> * %FMODE_EXCL, the block device is opened with exclusive access. Specifying
> @@ -736,7 +745,8 @@ void blkdev_put_no_open(struct block_device *bdev)
> * RETURNS:
> * Reference to the block_device on success, ERR_PTR(-errno) on failure.
> */
> -struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
> +struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
> + const struct blk_holder_ops *hops)
> {
> bool unblock_events = true;
> struct block_device *bdev;
> @@ -776,7 +786,7 @@ struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
> if (ret)
> goto put_module;
> if (mode & FMODE_EXCL) {
> - bd_finish_claiming(bdev, holder);
> + bd_finish_claiming(bdev, holder, hops);
>
> /*
> * Block event polling for write claims if requested. Any write
> @@ -827,7 +837,7 @@ EXPORT_SYMBOL(blkdev_get_by_dev);
> * Reference to the block_device on success, ERR_PTR(-errno) on failure.
> */
> struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
> - void *holder)
> + void *holder, const struct blk_holder_ops *hops)
> {
> struct block_device *bdev;
> dev_t dev;
> @@ -837,7 +847,7 @@ struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
> if (error)
> return ERR_PTR(error);
>
> - bdev = blkdev_get_by_dev(dev, mode, holder);
> + bdev = blkdev_get_by_dev(dev, mode, holder, hops);
> if (!IS_ERR(bdev) && (mode & FMODE_WRITE) && bdev_read_only(bdev)) {
> blkdev_put(bdev, mode);
> return ERR_PTR(-EACCES);
> diff --git a/block/fops.c b/block/fops.c
> index d2e6be4e3d1c7d..2ac5ea878fa4cc 100644
> --- a/block/fops.c
> +++ b/block/fops.c
> @@ -490,7 +490,7 @@ static int blkdev_open(struct inode *inode, struct file *filp)
> if ((filp->f_flags & O_ACCMODE) == 3)
> filp->f_mode |= FMODE_WRITE_IOCTL;
>
> - bdev = blkdev_get_by_dev(inode->i_rdev, filp->f_mode, filp);
> + bdev = blkdev_get_by_dev(inode->i_rdev, filp->f_mode, filp, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 9a35b8443f0b5f..d1c673b967c254 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -381,7 +381,8 @@ int disk_scan_partitions(struct gendisk *disk, fmode_t mode)
> }
>
> set_bit(GD_NEED_PART_SCAN, &disk->state);
> - bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXCL, NULL);
> + bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXCL, NULL,
> + NULL);
> if (IS_ERR(bdev))
> ret = PTR_ERR(bdev);
> else
> diff --git a/block/ioctl.c b/block/ioctl.c
> index 9c5f637ff153f8..c7d7d4345edb4f 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -454,7 +454,8 @@ static int blkdev_bszset(struct block_device *bdev, fmode_t mode,
> if (mode & FMODE_EXCL)
> return set_blocksize(bdev, n);
>
> - if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
> + if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
> + NULL)))
> return -EBUSY;
> ret = set_blocksize(bdev, n);
> blkdev_put(bdev, mode | FMODE_EXCL);
Somewhat related question: Should we allow userspace to initiate a fs
shutdown through the block device? Let's say you're preparing to yank
/dev/sda and want to kill anything attached to it or its partitions?
Without having to walk through however many mount namespaces there are
to find the mountpoints?
<skip down to the xfs changes>
> diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
> index 1a5d3d72d91d27..cab59dab3410aa 100644
> --- a/drivers/block/drbd/drbd_nl.c
> +++ b/drivers/block/drbd/drbd_nl.c
> @@ -1641,7 +1641,8 @@ static struct block_device *open_backing_dev(struct drbd_device *device,
> int err = 0;
>
> bdev = blkdev_get_by_path(bdev_path,
> - FMODE_READ | FMODE_WRITE | FMODE_EXCL, claim_ptr);
> + FMODE_READ | FMODE_WRITE | FMODE_EXCL,
> + claim_ptr, NULL);
> if (IS_ERR(bdev)) {
> drbd_err(device, "open(\"%s\") failed with %ld\n",
> bdev_path, PTR_ERR(bdev));
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index d5d7884cedd477..377f8b34535294 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -2125,7 +2125,8 @@ static int pkt_open_dev(struct pktcdvd_device *pd, fmode_t write)
> * to read/write from/to it. It is already opened in O_NONBLOCK mode
> * so open should not fail.
> */
> - bdev = blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, pd);
> + bdev = blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, pd,
> + NULL);
> if (IS_ERR(bdev)) {
> ret = PTR_ERR(bdev);
> goto out;
> @@ -2530,7 +2531,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev)
> }
> }
>
> - bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL);
> + bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
> sdev = scsi_device_from_queue(bdev->bd_disk->queue);
> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
> index 2cfed2e58d646f..cec22bbae2f9a5 100644
> --- a/drivers/block/rnbd/rnbd-srv.c
> +++ b/drivers/block/rnbd/rnbd-srv.c
> @@ -719,7 +719,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> goto reject;
> }
>
> - bdev = blkdev_get_by_path(full_path, open_flags, THIS_MODULE);
> + bdev = blkdev_get_by_path(full_path, open_flags, THIS_MODULE, NULL);
> if (IS_ERR(bdev)) {
> ret = PTR_ERR(bdev);
> pr_err("Opening device '%s' on session %s failed, failed to open the block device, err: %d\n",
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 4807af1d580593..43b36da9b3544d 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -492,7 +492,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
> vbd->pdevice = MKDEV(major, minor);
>
> bdev = blkdev_get_by_dev(vbd->pdevice, vbd->readonly ?
> - FMODE_READ : FMODE_WRITE, NULL);
> + FMODE_READ : FMODE_WRITE, NULL, NULL);
>
> if (IS_ERR(bdev)) {
> pr_warn("xen_vbd_create: device %08x could not be opened\n",
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index a84c4268257a99..5d21d074c7a0cd 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -508,7 +508,7 @@ static ssize_t backing_dev_store(struct device *dev,
> }
>
> bdev = blkdev_get_by_dev(inode->i_rdev,
> - FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram);
> + FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram, NULL);
> if (IS_ERR(bdev)) {
> err = PTR_ERR(bdev);
> bdev = NULL;
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index ba3909bb6beabb..c22d5aafd784b5 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2561,7 +2561,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
> err = "failed to open device";
> bdev = blkdev_get_by_path(strim(path),
> FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - sb);
> + sb, NULL);
> if (IS_ERR(bdev)) {
> if (bdev == ERR_PTR(-EBUSY)) {
> dev_t dev;
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 3b694ba3a106e6..d759f8bdb3df2f 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -746,7 +746,7 @@ static struct table_device *open_table_device(struct mapped_device *md,
> return ERR_PTR(-ENOMEM);
> refcount_set(&td->count, 1);
>
> - bdev = blkdev_get_by_dev(dev, mode | FMODE_EXCL, _dm_claim_ptr);
> + bdev = blkdev_get_by_dev(dev, mode | FMODE_EXCL, _dm_claim_ptr, NULL);
> if (IS_ERR(bdev)) {
> r = PTR_ERR(bdev);
> goto out_free_td;
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8e344b4b34446f..60ab5c4bee77c5 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3642,7 +3642,7 @@ static struct md_rdev *md_import_device(dev_t newdev, int super_format, int supe
>
> rdev->bdev = blkdev_get_by_dev(newdev,
> FMODE_READ | FMODE_WRITE | FMODE_EXCL,
> - super_format == -2 ? &claim_rdev : rdev);
> + super_format == -2 ? &claim_rdev : rdev, NULL);
> if (IS_ERR(rdev->bdev)) {
> pr_warn("md: could not open device unknown-block(%u,%u).\n",
> MAJOR(newdev), MINOR(newdev));
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index 4cd37ec45762b6..7ac82c6fe35024 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -235,7 +235,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size,
> return NULL;
>
> /* Get a handle on the device */
> - bdev = blkdev_get_by_path(devname, mode, dev);
> + bdev = blkdev_get_by_path(devname, mode, dev, NULL);
>
> #ifndef MODULE
> /*
> @@ -257,7 +257,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size,
> devt = name_to_dev_t(devname);
> if (!devt)
> continue;
> - bdev = blkdev_get_by_dev(devt, mode, dev);
> + bdev = blkdev_get_by_dev(devt, mode, dev, NULL);
> }
> #endif
>
> diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
> index c2d6cea0236b0a..9b6d6d85c72544 100644
> --- a/drivers/nvme/target/io-cmd-bdev.c
> +++ b/drivers/nvme/target/io-cmd-bdev.c
> @@ -85,7 +85,7 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns)
> return -ENOTBLK;
>
> ns->bdev = blkdev_get_by_path(ns->device_path,
> - FMODE_READ | FMODE_WRITE, NULL);
> + FMODE_READ | FMODE_WRITE, NULL, NULL);
> if (IS_ERR(ns->bdev)) {
> ret = PTR_ERR(ns->bdev);
> if (ret != -ENOTBLK) {
> diff --git a/drivers/s390/block/dasd_genhd.c b/drivers/s390/block/dasd_genhd.c
> index 998a961e170417..f21198bc483e1a 100644
> --- a/drivers/s390/block/dasd_genhd.c
> +++ b/drivers/s390/block/dasd_genhd.c
> @@ -130,7 +130,7 @@ int dasd_scan_partitions(struct dasd_block *block)
> struct block_device *bdev;
> int rc;
>
> - bdev = blkdev_get_by_dev(disk_devt(block->gdp), FMODE_READ, NULL);
> + bdev = blkdev_get_by_dev(disk_devt(block->gdp), FMODE_READ, NULL, NULL);
> if (IS_ERR(bdev)) {
> DBF_DEV_EVENT(DBF_ERR, block->base,
> "scan partitions error, blkdev_get returned %ld",
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index cc838ffd129472..a5cbbefa78ee4e 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -114,7 +114,7 @@ static int iblock_configure_device(struct se_device *dev)
> else
> dev->dev_flags |= DF_READ_ONLY;
>
> - bd = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev);
> + bd = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev, NULL);
> if (IS_ERR(bd)) {
> ret = PTR_ERR(bd);
> goto out_free_bioset;
> diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
> index e7425549e39c73..e3494e036c6c85 100644
> --- a/drivers/target/target_core_pscsi.c
> +++ b/drivers/target/target_core_pscsi.c
> @@ -367,7 +367,8 @@ static int pscsi_create_type_disk(struct se_device *dev, struct scsi_device *sd)
> * for TYPE_DISK and TYPE_ZBC using supplied udev_path
> */
> bd = blkdev_get_by_path(dev->udev_path,
> - FMODE_WRITE|FMODE_READ|FMODE_EXCL, pdv);
> + FMODE_WRITE|FMODE_READ|FMODE_EXCL, pdv,
> + NULL);
> if (IS_ERR(bd)) {
> pr_err("pSCSI: blkdev_get_by_path() failed\n");
> scsi_device_put(sd);
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 78696d331639bd..4de4984fa99ba3 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -258,7 +258,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
> }
>
> bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL,
> - fs_info->bdev_holder);
> + fs_info->bdev_holder, NULL);
> if (IS_ERR(bdev)) {
> btrfs_err(fs_info, "target device %s is invalid!", device_path);
> return PTR_ERR(bdev);
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 03f52e4a20aa9b..708350ba07e3ee 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -495,7 +495,7 @@ btrfs_get_bdev_and_sb(const char *device_path, fmode_t flags, void *holder,
> {
> int ret;
>
> - *bdev = blkdev_get_by_path(device_path, flags, holder);
> + *bdev = blkdev_get_by_path(device_path, flags, holder, NULL);
>
> if (IS_ERR(*bdev)) {
> ret = PTR_ERR(*bdev);
> @@ -1376,7 +1376,7 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags,
> * values temporarily, as the device paths of the fsid are the only
> * required information for assembling the volume.
> */
> - bdev = blkdev_get_by_path(path, flags, holder);
> + bdev = blkdev_get_by_path(path, flags, holder, NULL);
> if (IS_ERR(bdev))
> return ERR_CAST(bdev);
>
> @@ -2628,7 +2628,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> return -EROFS;
>
> bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL,
> - fs_info->bdev_holder);
> + fs_info->bdev_holder, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 811ab66d805ede..6c263e9cd38b2a 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -254,7 +254,7 @@ static int erofs_init_device(struct erofs_buf *buf, struct super_block *sb,
> dif->fscache = fscache;
> } else if (!sbi->devs->flatdev) {
> bdev = blkdev_get_by_path(dif->path, FMODE_READ | FMODE_EXCL,
> - sb->s_type);
> + sb->s_type, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
> dif->bdev = bdev;
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index d39f386e9baf6a..99d495de2e9b08 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1101,7 +1101,8 @@ static struct block_device *ext4_blkdev_get(dev_t dev, struct super_block *sb)
> {
> struct block_device *bdev;
>
> - bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb);
> + bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb,
> + NULL);
> if (IS_ERR(bdev))
> goto fail;
> return bdev;
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 9f15b03037dba9..7c34ab082f1382 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4025,7 +4025,7 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
> /* Single zoned block device mount */
> FDEV(0).bdev =
> blkdev_get_by_dev(sbi->sb->s_bdev->bd_dev,
> - sbi->sb->s_mode, sbi->sb->s_type);
> + sbi->sb->s_mode, sbi->sb->s_type, NULL);
> } else {
> /* Multi-device mount */
> memcpy(FDEV(i).path, RDEV(i).path, MAX_PATH_LEN);
> @@ -4044,7 +4044,7 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
> sbi->log_blocks_per_seg) - 1;
> }
> FDEV(i).bdev = blkdev_get_by_path(FDEV(i).path,
> - sbi->sb->s_mode, sbi->sb->s_type);
> + sbi->sb->s_mode, sbi->sb->s_type, NULL);
> }
> if (IS_ERR(FDEV(i).bdev))
> return PTR_ERR(FDEV(i).bdev);
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 695415cbfe985b..8c55030c57ed52 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1101,7 +1101,7 @@ int lmLogOpen(struct super_block *sb)
> */
>
> bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - log);
> + log, NULL);
> if (IS_ERR(bdev)) {
> rc = PTR_ERR(bdev);
> goto free;
> diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c
> index fea5f8821da5ef..38b066ca699ed7 100644
> --- a/fs/nfs/blocklayout/dev.c
> +++ b/fs/nfs/blocklayout/dev.c
> @@ -243,7 +243,7 @@ bl_parse_simple(struct nfs_server *server, struct pnfs_block_dev *d,
> if (!dev)
> return -EIO;
>
> - bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL);
> + bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL, NULL);
> if (IS_ERR(bdev)) {
> printk(KERN_WARNING "pNFS: failed to open device %d:%d (%ld)\n",
> MAJOR(dev), MINOR(dev), PTR_ERR(bdev));
> @@ -312,7 +312,8 @@ bl_open_path(struct pnfs_block_volume *v, const char *prefix)
> if (!devname)
> return ERR_PTR(-ENOMEM);
>
> - bdev = blkdev_get_by_path(devname, FMODE_READ | FMODE_WRITE, NULL);
> + bdev = blkdev_get_by_path(devname, FMODE_READ | FMODE_WRITE, NULL,
> + NULL);
> if (IS_ERR(bdev)) {
> pr_warn("pNFS: failed to open device %s (%ld)\n",
> devname, PTR_ERR(bdev));
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index 77f1e5778d1c84..91bfbd973d1d53 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -1285,7 +1285,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags,
> if (!(flags & SB_RDONLY))
> mode |= FMODE_WRITE;
>
> - sd.bdev = blkdev_get_by_path(dev_name, mode, fs_type);
> + sd.bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
> if (IS_ERR(sd.bdev))
> return ERR_CAST(sd.bdev);
>
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index 60b97c92e2b25e..6b13b8c3f2b8af 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -1786,7 +1786,7 @@ static ssize_t o2hb_region_dev_store(struct config_item *item,
> goto out2;
>
> reg->hr_bdev = blkdev_get_by_dev(f.file->f_mapping->host->i_rdev,
> - FMODE_WRITE | FMODE_READ, NULL);
> + FMODE_WRITE | FMODE_READ, NULL, NULL);
> if (IS_ERR(reg->hr_bdev)) {
> ret = PTR_ERR(reg->hr_bdev);
> reg->hr_bdev = NULL;
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 4d11d60f493c14..5e4db9a0c8e5a3 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2616,7 +2616,7 @@ static int journal_init_dev(struct super_block *super,
> if (jdev == super->s_dev)
> blkdev_mode &= ~FMODE_EXCL;
> journal->j_dev_bd = blkdev_get_by_dev(jdev, blkdev_mode,
> - journal);
> + journal, NULL);
> journal->j_dev_mode = blkdev_mode;
> if (IS_ERR(journal->j_dev_bd)) {
> result = PTR_ERR(journal->j_dev_bd);
> @@ -2632,7 +2632,8 @@ static int journal_init_dev(struct super_block *super,
> }
>
> journal->j_dev_mode = blkdev_mode;
> - journal->j_dev_bd = blkdev_get_by_path(jdev_name, blkdev_mode, journal);
> + journal->j_dev_bd = blkdev_get_by_path(jdev_name, blkdev_mode, journal,
> + NULL);
> if (IS_ERR(journal->j_dev_bd)) {
> result = PTR_ERR(journal->j_dev_bd);
> journal->j_dev_bd = NULL;
> diff --git a/fs/super.c b/fs/super.c
> index 34afe411cf2bc3..012ce140080375 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1248,7 +1248,7 @@ int get_tree_bdev(struct fs_context *fc,
> if (!fc->source)
> return invalf(fc, "No source specified");
>
> - bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type);
> + bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL);
> if (IS_ERR(bdev)) {
> errorf(fc, "%s: Can't open blockdev", fc->source);
> return PTR_ERR(bdev);
> @@ -1333,7 +1333,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
> if (!(flags & SB_RDONLY))
> mode |= FMODE_WRITE;
>
> - bdev = blkdev_get_by_path(dev_name, mode, fs_type);
> + bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
> if (IS_ERR(bdev))
> return ERR_CAST(bdev);
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 4d2e87462ac4a1..bc17ad350aea5a 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -386,7 +386,7 @@ xfs_blkdev_get(
> int error = 0;
>
> *bdevp = blkdev_get_by_path(name, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - mp);
> + mp, NULL);
> if (IS_ERR(*bdevp)) {
> error = PTR_ERR(*bdevp);
> xfs_warn(mp, "Invalid device [%s], error=%d", name, error);
I only looked at fs/xfs/, fs/*.c, and the block layer changes.
For those parts,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
(I didn't see anything obviously wrong in the rest of the patch, but I'm
no pktcdvd expert...)
--D
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 740afe80f29786..84a931caef514e 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -55,6 +55,8 @@ struct block_device {
> struct super_block * bd_super;
> void * bd_claiming;
> void * bd_holder;
> + const struct blk_holder_ops *bd_holder_ops;
> + struct mutex bd_holder_lock;
> /* The counter of freeze processes */
> int bd_fsfreeze_count;
> int bd_holders;
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index e3242e67a8e3df..3f41f8c9b103cf 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1468,9 +1468,13 @@ void blkdev_show(struct seq_file *seqf, off_t offset);
> #define BLKDEV_MAJOR_MAX 0
> #endif
>
> +struct blk_holder_ops {
> +};
> +
> +struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
> + const struct blk_holder_ops *hops);
> struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
> - void *holder);
> -struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder);
> + void *holder, const struct blk_holder_ops *hops);
> int bd_prepare_to_claim(struct block_device *bdev, void *holder);
> void bd_abort_claiming(struct block_device *bdev, void *holder);
> void blkdev_put(struct block_device *bdev, fmode_t mode);
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 92e41ed292ada8..801c411530d11c 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -357,7 +357,7 @@ static int swsusp_swap_check(void)
> root_swap = res;
>
> hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device, FMODE_WRITE,
> - NULL);
> + NULL, NULL);
> if (IS_ERR(hib_resume_bdev))
> return PTR_ERR(hib_resume_bdev);
>
> @@ -1524,7 +1524,7 @@ int swsusp_check(void)
> mode |= FMODE_EXCL;
>
> hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device,
> - mode, &holder);
> + mode, &holder, NULL);
> if (!IS_ERR(hib_resume_bdev)) {
> set_blocksize(hib_resume_bdev, PAGE_SIZE);
> clear_page(swsusp_header);
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 274bbf79748006..cfbcf7d5705f5f 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -2770,7 +2770,8 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
>
> if (S_ISBLK(inode->i_mode)) {
> p->bdev = blkdev_get_by_dev(inode->i_rdev,
> - FMODE_READ | FMODE_WRITE | FMODE_EXCL, p);
> + FMODE_READ | FMODE_WRITE | FMODE_EXCL, p,
> + NULL);
> if (IS_ERR(p->bdev)) {
> error = PTR_ERR(p->bdev);
> p->bdev = NULL;
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead
2023-05-05 17:51 ` [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
@ 2023-05-07 19:05 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:05 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:25, Christoph Hellwig wrote:
> Check if GD_DEAD is already set in blk_mark_disk_dead, and don't
> duplicate the work already done.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/genhd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 461999e9489937..9a35b8443f0b5f 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -586,7 +586,9 @@ void blk_mark_disk_dead(struct gendisk *disk)
> /*
> * Fail any new I/O.
> */
> - set_bit(GD_DEAD, &disk->state);
> + if (test_and_set_bit(GD_DEAD, &disk->state))
> + return;
> +
> if (test_bit(GD_OWNS_QUEUE, &disk->state))
> blk_queue_flag_set(QUEUE_FLAG_DYING, disk->queue);
>
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk
2023-05-05 17:51 ` [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
@ 2023-05-07 19:08 ` Jan Kara
2023-05-09 13:35 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:08 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:24, Christoph Hellwig wrote:
> blk_mark_disk_dead does very similar work a a section of del_gendisk:
>
> - set the GD_DEAD flag
> - set the capacity to zero
> - start a queue drain
>
> but del_gendisk also sets QUEUE_FLAG_DYING on the queue if it is owned by
> the disk, sets the capacity to zero before starting the drain, and both
> with sending a uevent and kernel message for this fake capacity change.
>
> Move the exact logic from the more heavily used del_gendisk into
> blk_mark_disk_dead and then call blk_mark_disk_dead from del_gendisk.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I'm somewhat wondering about the lost notification from
blk_mark_disk_dead(). E.g. DM uses blk_mark_disk_dead() so if some udev
script depends on the event when DM device gets destroyed, we would break
it?
Honza
> ---
> block/genhd.c | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 90c402771bb570..461999e9489937 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -583,13 +583,22 @@ EXPORT_SYMBOL(device_add_disk);
> */
> void blk_mark_disk_dead(struct gendisk *disk)
> {
> + /*
> + * Fail any new I/O.
> + */
> set_bit(GD_DEAD, &disk->state);
> - blk_queue_start_drain(disk->queue);
> + if (test_bit(GD_OWNS_QUEUE, &disk->state))
> + blk_queue_flag_set(QUEUE_FLAG_DYING, disk->queue);
>
> /*
> * Stop buffered writers from dirtying pages that can't be written out.
> */
> - set_capacity_and_notify(disk, 0);
> + set_capacity(disk, 0);
> +
> + /*
> + * Prevent new I/O from crossing bio_queue_enter().
> + */
> + blk_queue_start_drain(disk->queue);
> }
> EXPORT_SYMBOL_GPL(blk_mark_disk_dead);
>
> @@ -632,18 +641,7 @@ void del_gendisk(struct gendisk *disk)
> fsync_bdev(disk->part0);
> __invalidate_device(disk->part0, true);
>
> - /*
> - * Fail any new I/O.
> - */
> - set_bit(GD_DEAD, &disk->state);
> - if (test_bit(GD_OWNS_QUEUE, &disk->state))
> - blk_queue_flag_set(QUEUE_FLAG_DYING, q);
> - set_capacity(disk, 0);
> -
> - /*
> - * Prevent new I/O from crossing bio_queue_enter().
> - */
> - blk_queue_start_drain(q);
> + blk_mark_disk_dead(disk);
>
> if (!(disk->flags & GENHD_FL_HIDDEN)) {
> sysfs_remove_link(&disk_to_dev(disk)->kobj, "bdi");
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put
2023-05-05 17:51 ` [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
@ 2023-05-07 19:08 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:08 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:26, Christoph Hellwig wrote:
> Move all the logic to release an exclusive claim into a helper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Nice. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bdev.c | 63 +++++++++++++++++++++++++++-------------------------
> 1 file changed, 33 insertions(+), 30 deletions(-)
>
> diff --git a/block/bdev.c b/block/bdev.c
> index 850852fe4b78e1..f2c7181b0bba7d 100644
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -578,6 +578,37 @@ void bd_abort_claiming(struct block_device *bdev, void *holder)
> }
> EXPORT_SYMBOL(bd_abort_claiming);
>
> +static void bd_end_claim(struct block_device *bdev)
> +{
> + struct block_device *whole = bdev_whole(bdev);
> + bool unblock = false;
> +
> + /*
> + * Release a claim on the device. The holder fields are protected with
> + * bdev_lock. open_mutex is used to synchronize disk_holder unlinking.
> + */
> + spin_lock(&bdev_lock);
> + WARN_ON_ONCE(--bdev->bd_holders < 0);
> + WARN_ON_ONCE(--whole->bd_holders < 0);
> + if (!bdev->bd_holders) {
> + bdev->bd_holder = NULL;
> + if (bdev->bd_write_holder)
> + unblock = true;
> + }
> + if (!whole->bd_holders)
> + whole->bd_holder = NULL;
> + spin_unlock(&bdev_lock);
> +
> + /*
> + * If this was the last claim, remove holder link and unblock evpoll if
> + * it was a write holder.
> + */
> + if (unblock) {
> + disk_unblock_events(bdev->bd_disk);
> + bdev->bd_write_holder = false;
> + }
> +}
> +
> static void blkdev_flush_mapping(struct block_device *bdev)
> {
> WARN_ON_ONCE(bdev->bd_holders);
> @@ -832,36 +863,8 @@ void blkdev_put(struct block_device *bdev, fmode_t mode)
> sync_blockdev(bdev);
>
> mutex_lock(&disk->open_mutex);
> - if (mode & FMODE_EXCL) {
> - struct block_device *whole = bdev_whole(bdev);
> - bool bdev_free;
> -
> - /*
> - * Release a claim on the device. The holder fields
> - * are protected with bdev_lock. open_mutex is to
> - * synchronize disk_holder unlinking.
> - */
> - spin_lock(&bdev_lock);
> -
> - WARN_ON_ONCE(--bdev->bd_holders < 0);
> - WARN_ON_ONCE(--whole->bd_holders < 0);
> -
> - if ((bdev_free = !bdev->bd_holders))
> - bdev->bd_holder = NULL;
> - if (!whole->bd_holders)
> - whole->bd_holder = NULL;
> -
> - spin_unlock(&bdev_lock);
> -
> - /*
> - * If this was the last claim, remove holder link and
> - * unblock evpoll if it was a write holder.
> - */
> - if (bdev_free && bdev->bd_write_holder) {
> - disk_unblock_events(disk);
> - bdev->bd_write_holder = false;
> - }
> - }
> + if (mode & FMODE_EXCL)
> + bd_end_claim(bdev);
>
> /*
> * Trigger event checking and tell drivers to flush MEDIA_CHANGE
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 4/9] block: turn bdev_lock into a mutex
2023-05-05 17:51 ` [PATCH 4/9] block: turn bdev_lock into a mutex Christoph Hellwig
@ 2023-05-07 19:09 ` Jan Kara
2023-05-16 16:24 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:09 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:27, Christoph Hellwig wrote:
> There is no reason for this lock to spin, and being able to sleep under
> it will come in handy soon.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Makes sense. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bdev.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/block/bdev.c b/block/bdev.c
> index f2c7181b0bba7d..bad75f6cf8edcd 100644
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -308,7 +308,7 @@ EXPORT_SYMBOL(thaw_bdev);
> * pseudo-fs
> */
>
> -static __cacheline_aligned_in_smp DEFINE_SPINLOCK(bdev_lock);
> +static __cacheline_aligned_in_smp DEFINE_MUTEX(bdev_lock);
> static struct kmem_cache * bdev_cachep __read_mostly;
>
> static struct inode *bdev_alloc_inode(struct super_block *sb)
> @@ -457,15 +457,14 @@ long nr_blockdev_pages(void)
> *
> * Test whether @bdev can be claimed by @holder.
> *
> - * CONTEXT:
> - * spin_lock(&bdev_lock).
> - *
> * RETURNS:
> * %true if @bdev can be claimed, %false otherwise.
> */
> static bool bd_may_claim(struct block_device *bdev, struct block_device *whole,
> void *holder)
> {
> + lockdep_assert_held(&bdev_lock);
> +
> if (bdev->bd_holder == holder)
> return true; /* already a holder */
> else if (bdev->bd_holder != NULL)
> @@ -500,10 +499,10 @@ int bd_prepare_to_claim(struct block_device *bdev, void *holder)
> if (WARN_ON_ONCE(!holder))
> return -EINVAL;
> retry:
> - spin_lock(&bdev_lock);
> + mutex_lock(&bdev_lock);
> /* if someone else claimed, fail */
> if (!bd_may_claim(bdev, whole, holder)) {
> - spin_unlock(&bdev_lock);
> + mutex_unlock(&bdev_lock);
> return -EBUSY;
> }
>
> @@ -513,7 +512,7 @@ int bd_prepare_to_claim(struct block_device *bdev, void *holder)
> DEFINE_WAIT(wait);
>
> prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE);
> - spin_unlock(&bdev_lock);
> + mutex_unlock(&bdev_lock);
> schedule();
> finish_wait(wq, &wait);
> goto retry;
> @@ -521,7 +520,7 @@ int bd_prepare_to_claim(struct block_device *bdev, void *holder)
>
> /* yay, all mine */
> whole->bd_claiming = holder;
> - spin_unlock(&bdev_lock);
> + mutex_unlock(&bdev_lock);
> return 0;
> }
> EXPORT_SYMBOL_GPL(bd_prepare_to_claim); /* only for the loop driver */
> @@ -547,7 +546,7 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> {
> struct block_device *whole = bdev_whole(bdev);
>
> - spin_lock(&bdev_lock);
> + mutex_lock(&bdev_lock);
> BUG_ON(!bd_may_claim(bdev, whole, holder));
> /*
> * Note that for a whole device bd_holders will be incremented twice,
> @@ -558,7 +557,7 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> bdev->bd_holders++;
> bdev->bd_holder = holder;
> bd_clear_claiming(whole, holder);
> - spin_unlock(&bdev_lock);
> + mutex_unlock(&bdev_lock);
> }
>
> /**
> @@ -572,9 +571,9 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> */
> void bd_abort_claiming(struct block_device *bdev, void *holder)
> {
> - spin_lock(&bdev_lock);
> + mutex_lock(&bdev_lock);
> bd_clear_claiming(bdev_whole(bdev), holder);
> - spin_unlock(&bdev_lock);
> + mutex_unlock(&bdev_lock);
> }
> EXPORT_SYMBOL(bd_abort_claiming);
>
> @@ -587,7 +586,7 @@ static void bd_end_claim(struct block_device *bdev)
> * Release a claim on the device. The holder fields are protected with
> * bdev_lock. open_mutex is used to synchronize disk_holder unlinking.
> */
> - spin_lock(&bdev_lock);
> + mutex_lock(&bdev_lock);
> WARN_ON_ONCE(--bdev->bd_holders < 0);
> WARN_ON_ONCE(--whole->bd_holders < 0);
> if (!bdev->bd_holders) {
> @@ -597,7 +596,7 @@ static void bd_end_claim(struct block_device *bdev)
> }
> if (!whole->bd_holders)
> whole->bd_holder = NULL;
> - spin_unlock(&bdev_lock);
> + mutex_unlock(&bdev_lock);
>
> /*
> * If this was the last claim, remove holder link and unblock evpoll if
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
2023-05-05 18:51 ` Darrick J. Wong
@ 2023-05-07 19:12 ` Jan Kara
2023-05-16 11:02 ` Ming Lei
2023-05-16 16:00 ` Christian Brauner
3 siblings, 0 replies; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:12 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:28, Christoph Hellwig wrote:
> Add a new blk_holder_ops structure, which is passed to blkdev_get_by_* and
> installed in the block_device for exclusive claims. It will be used to
> allow the block layer to call back into the user of the block device for
> thing like notification of a removed device or a device resize.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bdev.c | 20 +++++++++++++++-----
> block/fops.c | 2 +-
> block/genhd.c | 3 ++-
> block/ioctl.c | 3 ++-
> drivers/block/drbd/drbd_nl.c | 3 ++-
> drivers/block/pktcdvd.c | 5 +++--
> drivers/block/rnbd/rnbd-srv.c | 2 +-
> drivers/block/xen-blkback/xenbus.c | 2 +-
> drivers/block/zram/zram_drv.c | 2 +-
> drivers/md/bcache/super.c | 2 +-
> drivers/md/dm.c | 2 +-
> drivers/md/md.c | 2 +-
> drivers/mtd/devices/block2mtd.c | 4 ++--
> drivers/nvme/target/io-cmd-bdev.c | 2 +-
> drivers/s390/block/dasd_genhd.c | 2 +-
> drivers/target/target_core_iblock.c | 2 +-
> drivers/target/target_core_pscsi.c | 3 ++-
> fs/btrfs/dev-replace.c | 2 +-
> fs/btrfs/volumes.c | 6 +++---
> fs/erofs/super.c | 2 +-
> fs/ext4/super.c | 3 ++-
> fs/f2fs/super.c | 4 ++--
> fs/jfs/jfs_logmgr.c | 2 +-
> fs/nfs/blocklayout/dev.c | 5 +++--
> fs/nilfs2/super.c | 2 +-
> fs/ocfs2/cluster/heartbeat.c | 2 +-
> fs/reiserfs/journal.c | 5 +++--
> fs/super.c | 4 ++--
> fs/xfs/xfs_super.c | 2 +-
> include/linux/blk_types.h | 2 ++
> include/linux/blkdev.h | 8 ++++++--
> kernel/power/swap.c | 4 ++--
> mm/swapfile.c | 3 ++-
> 33 files changed, 71 insertions(+), 46 deletions(-)
>
> diff --git a/block/bdev.c b/block/bdev.c
> index bad75f6cf8edcd..297e26cef28c78 100644
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -415,6 +415,7 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno)
> bdev = I_BDEV(inode);
> mutex_init(&bdev->bd_fsfreeze_mutex);
> spin_lock_init(&bdev->bd_size_lock);
> + mutex_init(&bdev->bd_holder_lock);
> bdev->bd_partno = partno;
> bdev->bd_inode = inode;
> bdev->bd_queue = disk->queue;
> @@ -542,7 +543,8 @@ static void bd_clear_claiming(struct block_device *whole, void *holder)
> * Finish exclusive open of a block device. Mark the device as exlusively
> * open by the holder and wake up all waiters for exclusive open to finish.
> */
> -static void bd_finish_claiming(struct block_device *bdev, void *holder)
> +static void bd_finish_claiming(struct block_device *bdev, void *holder,
> + const struct blk_holder_ops *hops)
> {
> struct block_device *whole = bdev_whole(bdev);
>
> @@ -555,7 +557,10 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> whole->bd_holders++;
> whole->bd_holder = bd_may_claim;
> bdev->bd_holders++;
> + mutex_lock(&bdev->bd_holder_lock);
> bdev->bd_holder = holder;
> + bdev->bd_holder_ops = hops;
> + mutex_unlock(&bdev->bd_holder_lock);
> bd_clear_claiming(whole, holder);
> mutex_unlock(&bdev_lock);
> }
> @@ -590,7 +595,10 @@ static void bd_end_claim(struct block_device *bdev)
> WARN_ON_ONCE(--bdev->bd_holders < 0);
> WARN_ON_ONCE(--whole->bd_holders < 0);
> if (!bdev->bd_holders) {
> + mutex_lock(&bdev->bd_holder_lock);
> bdev->bd_holder = NULL;
> + bdev->bd_holder_ops = NULL;
> + mutex_unlock(&bdev->bd_holder_lock);
> if (bdev->bd_write_holder)
> unblock = true;
> }
> @@ -720,6 +728,7 @@ void blkdev_put_no_open(struct block_device *bdev)
> * @dev: device number of block device to open
> * @mode: FMODE_* mask
> * @holder: exclusive holder identifier
> + * @hops: holder operations
> *
> * Open the block device described by device number @dev. If @mode includes
> * %FMODE_EXCL, the block device is opened with exclusive access. Specifying
> @@ -736,7 +745,8 @@ void blkdev_put_no_open(struct block_device *bdev)
> * RETURNS:
> * Reference to the block_device on success, ERR_PTR(-errno) on failure.
> */
> -struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
> +struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
> + const struct blk_holder_ops *hops)
> {
> bool unblock_events = true;
> struct block_device *bdev;
> @@ -776,7 +786,7 @@ struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
> if (ret)
> goto put_module;
> if (mode & FMODE_EXCL) {
> - bd_finish_claiming(bdev, holder);
> + bd_finish_claiming(bdev, holder, hops);
>
> /*
> * Block event polling for write claims if requested. Any write
> @@ -827,7 +837,7 @@ EXPORT_SYMBOL(blkdev_get_by_dev);
> * Reference to the block_device on success, ERR_PTR(-errno) on failure.
> */
> struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
> - void *holder)
> + void *holder, const struct blk_holder_ops *hops)
> {
> struct block_device *bdev;
> dev_t dev;
> @@ -837,7 +847,7 @@ struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
> if (error)
> return ERR_PTR(error);
>
> - bdev = blkdev_get_by_dev(dev, mode, holder);
> + bdev = blkdev_get_by_dev(dev, mode, holder, hops);
> if (!IS_ERR(bdev) && (mode & FMODE_WRITE) && bdev_read_only(bdev)) {
> blkdev_put(bdev, mode);
> return ERR_PTR(-EACCES);
> diff --git a/block/fops.c b/block/fops.c
> index d2e6be4e3d1c7d..2ac5ea878fa4cc 100644
> --- a/block/fops.c
> +++ b/block/fops.c
> @@ -490,7 +490,7 @@ static int blkdev_open(struct inode *inode, struct file *filp)
> if ((filp->f_flags & O_ACCMODE) == 3)
> filp->f_mode |= FMODE_WRITE_IOCTL;
>
> - bdev = blkdev_get_by_dev(inode->i_rdev, filp->f_mode, filp);
> + bdev = blkdev_get_by_dev(inode->i_rdev, filp->f_mode, filp, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 9a35b8443f0b5f..d1c673b967c254 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -381,7 +381,8 @@ int disk_scan_partitions(struct gendisk *disk, fmode_t mode)
> }
>
> set_bit(GD_NEED_PART_SCAN, &disk->state);
> - bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXCL, NULL);
> + bdev = blkdev_get_by_dev(disk_devt(disk), mode & ~FMODE_EXCL, NULL,
> + NULL);
> if (IS_ERR(bdev))
> ret = PTR_ERR(bdev);
> else
> diff --git a/block/ioctl.c b/block/ioctl.c
> index 9c5f637ff153f8..c7d7d4345edb4f 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -454,7 +454,8 @@ static int blkdev_bszset(struct block_device *bdev, fmode_t mode,
> if (mode & FMODE_EXCL)
> return set_blocksize(bdev, n);
>
> - if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
> + if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
> + NULL)))
> return -EBUSY;
> ret = set_blocksize(bdev, n);
> blkdev_put(bdev, mode | FMODE_EXCL);
> diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
> index 1a5d3d72d91d27..cab59dab3410aa 100644
> --- a/drivers/block/drbd/drbd_nl.c
> +++ b/drivers/block/drbd/drbd_nl.c
> @@ -1641,7 +1641,8 @@ static struct block_device *open_backing_dev(struct drbd_device *device,
> int err = 0;
>
> bdev = blkdev_get_by_path(bdev_path,
> - FMODE_READ | FMODE_WRITE | FMODE_EXCL, claim_ptr);
> + FMODE_READ | FMODE_WRITE | FMODE_EXCL,
> + claim_ptr, NULL);
> if (IS_ERR(bdev)) {
> drbd_err(device, "open(\"%s\") failed with %ld\n",
> bdev_path, PTR_ERR(bdev));
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index d5d7884cedd477..377f8b34535294 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -2125,7 +2125,8 @@ static int pkt_open_dev(struct pktcdvd_device *pd, fmode_t write)
> * to read/write from/to it. It is already opened in O_NONBLOCK mode
> * so open should not fail.
> */
> - bdev = blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, pd);
> + bdev = blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, pd,
> + NULL);
> if (IS_ERR(bdev)) {
> ret = PTR_ERR(bdev);
> goto out;
> @@ -2530,7 +2531,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev)
> }
> }
>
> - bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL);
> + bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
> sdev = scsi_device_from_queue(bdev->bd_disk->queue);
> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
> index 2cfed2e58d646f..cec22bbae2f9a5 100644
> --- a/drivers/block/rnbd/rnbd-srv.c
> +++ b/drivers/block/rnbd/rnbd-srv.c
> @@ -719,7 +719,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> goto reject;
> }
>
> - bdev = blkdev_get_by_path(full_path, open_flags, THIS_MODULE);
> + bdev = blkdev_get_by_path(full_path, open_flags, THIS_MODULE, NULL);
> if (IS_ERR(bdev)) {
> ret = PTR_ERR(bdev);
> pr_err("Opening device '%s' on session %s failed, failed to open the block device, err: %d\n",
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 4807af1d580593..43b36da9b3544d 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -492,7 +492,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
> vbd->pdevice = MKDEV(major, minor);
>
> bdev = blkdev_get_by_dev(vbd->pdevice, vbd->readonly ?
> - FMODE_READ : FMODE_WRITE, NULL);
> + FMODE_READ : FMODE_WRITE, NULL, NULL);
>
> if (IS_ERR(bdev)) {
> pr_warn("xen_vbd_create: device %08x could not be opened\n",
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index a84c4268257a99..5d21d074c7a0cd 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -508,7 +508,7 @@ static ssize_t backing_dev_store(struct device *dev,
> }
>
> bdev = blkdev_get_by_dev(inode->i_rdev,
> - FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram);
> + FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram, NULL);
> if (IS_ERR(bdev)) {
> err = PTR_ERR(bdev);
> bdev = NULL;
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index ba3909bb6beabb..c22d5aafd784b5 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2561,7 +2561,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
> err = "failed to open device";
> bdev = blkdev_get_by_path(strim(path),
> FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - sb);
> + sb, NULL);
> if (IS_ERR(bdev)) {
> if (bdev == ERR_PTR(-EBUSY)) {
> dev_t dev;
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 3b694ba3a106e6..d759f8bdb3df2f 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -746,7 +746,7 @@ static struct table_device *open_table_device(struct mapped_device *md,
> return ERR_PTR(-ENOMEM);
> refcount_set(&td->count, 1);
>
> - bdev = blkdev_get_by_dev(dev, mode | FMODE_EXCL, _dm_claim_ptr);
> + bdev = blkdev_get_by_dev(dev, mode | FMODE_EXCL, _dm_claim_ptr, NULL);
> if (IS_ERR(bdev)) {
> r = PTR_ERR(bdev);
> goto out_free_td;
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8e344b4b34446f..60ab5c4bee77c5 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3642,7 +3642,7 @@ static struct md_rdev *md_import_device(dev_t newdev, int super_format, int supe
>
> rdev->bdev = blkdev_get_by_dev(newdev,
> FMODE_READ | FMODE_WRITE | FMODE_EXCL,
> - super_format == -2 ? &claim_rdev : rdev);
> + super_format == -2 ? &claim_rdev : rdev, NULL);
> if (IS_ERR(rdev->bdev)) {
> pr_warn("md: could not open device unknown-block(%u,%u).\n",
> MAJOR(newdev), MINOR(newdev));
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index 4cd37ec45762b6..7ac82c6fe35024 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -235,7 +235,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size,
> return NULL;
>
> /* Get a handle on the device */
> - bdev = blkdev_get_by_path(devname, mode, dev);
> + bdev = blkdev_get_by_path(devname, mode, dev, NULL);
>
> #ifndef MODULE
> /*
> @@ -257,7 +257,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size,
> devt = name_to_dev_t(devname);
> if (!devt)
> continue;
> - bdev = blkdev_get_by_dev(devt, mode, dev);
> + bdev = blkdev_get_by_dev(devt, mode, dev, NULL);
> }
> #endif
>
> diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
> index c2d6cea0236b0a..9b6d6d85c72544 100644
> --- a/drivers/nvme/target/io-cmd-bdev.c
> +++ b/drivers/nvme/target/io-cmd-bdev.c
> @@ -85,7 +85,7 @@ int nvmet_bdev_ns_enable(struct nvmet_ns *ns)
> return -ENOTBLK;
>
> ns->bdev = blkdev_get_by_path(ns->device_path,
> - FMODE_READ | FMODE_WRITE, NULL);
> + FMODE_READ | FMODE_WRITE, NULL, NULL);
> if (IS_ERR(ns->bdev)) {
> ret = PTR_ERR(ns->bdev);
> if (ret != -ENOTBLK) {
> diff --git a/drivers/s390/block/dasd_genhd.c b/drivers/s390/block/dasd_genhd.c
> index 998a961e170417..f21198bc483e1a 100644
> --- a/drivers/s390/block/dasd_genhd.c
> +++ b/drivers/s390/block/dasd_genhd.c
> @@ -130,7 +130,7 @@ int dasd_scan_partitions(struct dasd_block *block)
> struct block_device *bdev;
> int rc;
>
> - bdev = blkdev_get_by_dev(disk_devt(block->gdp), FMODE_READ, NULL);
> + bdev = blkdev_get_by_dev(disk_devt(block->gdp), FMODE_READ, NULL, NULL);
> if (IS_ERR(bdev)) {
> DBF_DEV_EVENT(DBF_ERR, block->base,
> "scan partitions error, blkdev_get returned %ld",
> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
> index cc838ffd129472..a5cbbefa78ee4e 100644
> --- a/drivers/target/target_core_iblock.c
> +++ b/drivers/target/target_core_iblock.c
> @@ -114,7 +114,7 @@ static int iblock_configure_device(struct se_device *dev)
> else
> dev->dev_flags |= DF_READ_ONLY;
>
> - bd = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev);
> + bd = blkdev_get_by_path(ib_dev->ibd_udev_path, mode, ib_dev, NULL);
> if (IS_ERR(bd)) {
> ret = PTR_ERR(bd);
> goto out_free_bioset;
> diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
> index e7425549e39c73..e3494e036c6c85 100644
> --- a/drivers/target/target_core_pscsi.c
> +++ b/drivers/target/target_core_pscsi.c
> @@ -367,7 +367,8 @@ static int pscsi_create_type_disk(struct se_device *dev, struct scsi_device *sd)
> * for TYPE_DISK and TYPE_ZBC using supplied udev_path
> */
> bd = blkdev_get_by_path(dev->udev_path,
> - FMODE_WRITE|FMODE_READ|FMODE_EXCL, pdv);
> + FMODE_WRITE|FMODE_READ|FMODE_EXCL, pdv,
> + NULL);
> if (IS_ERR(bd)) {
> pr_err("pSCSI: blkdev_get_by_path() failed\n");
> scsi_device_put(sd);
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 78696d331639bd..4de4984fa99ba3 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -258,7 +258,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
> }
>
> bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL,
> - fs_info->bdev_holder);
> + fs_info->bdev_holder, NULL);
> if (IS_ERR(bdev)) {
> btrfs_err(fs_info, "target device %s is invalid!", device_path);
> return PTR_ERR(bdev);
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 03f52e4a20aa9b..708350ba07e3ee 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -495,7 +495,7 @@ btrfs_get_bdev_and_sb(const char *device_path, fmode_t flags, void *holder,
> {
> int ret;
>
> - *bdev = blkdev_get_by_path(device_path, flags, holder);
> + *bdev = blkdev_get_by_path(device_path, flags, holder, NULL);
>
> if (IS_ERR(*bdev)) {
> ret = PTR_ERR(*bdev);
> @@ -1376,7 +1376,7 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags,
> * values temporarily, as the device paths of the fsid are the only
> * required information for assembling the volume.
> */
> - bdev = blkdev_get_by_path(path, flags, holder);
> + bdev = blkdev_get_by_path(path, flags, holder, NULL);
> if (IS_ERR(bdev))
> return ERR_CAST(bdev);
>
> @@ -2628,7 +2628,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> return -EROFS;
>
> bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL,
> - fs_info->bdev_holder);
> + fs_info->bdev_holder, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 811ab66d805ede..6c263e9cd38b2a 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -254,7 +254,7 @@ static int erofs_init_device(struct erofs_buf *buf, struct super_block *sb,
> dif->fscache = fscache;
> } else if (!sbi->devs->flatdev) {
> bdev = blkdev_get_by_path(dif->path, FMODE_READ | FMODE_EXCL,
> - sb->s_type);
> + sb->s_type, NULL);
> if (IS_ERR(bdev))
> return PTR_ERR(bdev);
> dif->bdev = bdev;
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index d39f386e9baf6a..99d495de2e9b08 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1101,7 +1101,8 @@ static struct block_device *ext4_blkdev_get(dev_t dev, struct super_block *sb)
> {
> struct block_device *bdev;
>
> - bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb);
> + bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb,
> + NULL);
> if (IS_ERR(bdev))
> goto fail;
> return bdev;
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 9f15b03037dba9..7c34ab082f1382 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4025,7 +4025,7 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
> /* Single zoned block device mount */
> FDEV(0).bdev =
> blkdev_get_by_dev(sbi->sb->s_bdev->bd_dev,
> - sbi->sb->s_mode, sbi->sb->s_type);
> + sbi->sb->s_mode, sbi->sb->s_type, NULL);
> } else {
> /* Multi-device mount */
> memcpy(FDEV(i).path, RDEV(i).path, MAX_PATH_LEN);
> @@ -4044,7 +4044,7 @@ static int f2fs_scan_devices(struct f2fs_sb_info *sbi)
> sbi->log_blocks_per_seg) - 1;
> }
> FDEV(i).bdev = blkdev_get_by_path(FDEV(i).path,
> - sbi->sb->s_mode, sbi->sb->s_type);
> + sbi->sb->s_mode, sbi->sb->s_type, NULL);
> }
> if (IS_ERR(FDEV(i).bdev))
> return PTR_ERR(FDEV(i).bdev);
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 695415cbfe985b..8c55030c57ed52 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1101,7 +1101,7 @@ int lmLogOpen(struct super_block *sb)
> */
>
> bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - log);
> + log, NULL);
> if (IS_ERR(bdev)) {
> rc = PTR_ERR(bdev);
> goto free;
> diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c
> index fea5f8821da5ef..38b066ca699ed7 100644
> --- a/fs/nfs/blocklayout/dev.c
> +++ b/fs/nfs/blocklayout/dev.c
> @@ -243,7 +243,7 @@ bl_parse_simple(struct nfs_server *server, struct pnfs_block_dev *d,
> if (!dev)
> return -EIO;
>
> - bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL);
> + bdev = blkdev_get_by_dev(dev, FMODE_READ | FMODE_WRITE, NULL, NULL);
> if (IS_ERR(bdev)) {
> printk(KERN_WARNING "pNFS: failed to open device %d:%d (%ld)\n",
> MAJOR(dev), MINOR(dev), PTR_ERR(bdev));
> @@ -312,7 +312,8 @@ bl_open_path(struct pnfs_block_volume *v, const char *prefix)
> if (!devname)
> return ERR_PTR(-ENOMEM);
>
> - bdev = blkdev_get_by_path(devname, FMODE_READ | FMODE_WRITE, NULL);
> + bdev = blkdev_get_by_path(devname, FMODE_READ | FMODE_WRITE, NULL,
> + NULL);
> if (IS_ERR(bdev)) {
> pr_warn("pNFS: failed to open device %s (%ld)\n",
> devname, PTR_ERR(bdev));
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index 77f1e5778d1c84..91bfbd973d1d53 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -1285,7 +1285,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags,
> if (!(flags & SB_RDONLY))
> mode |= FMODE_WRITE;
>
> - sd.bdev = blkdev_get_by_path(dev_name, mode, fs_type);
> + sd.bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
> if (IS_ERR(sd.bdev))
> return ERR_CAST(sd.bdev);
>
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index 60b97c92e2b25e..6b13b8c3f2b8af 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -1786,7 +1786,7 @@ static ssize_t o2hb_region_dev_store(struct config_item *item,
> goto out2;
>
> reg->hr_bdev = blkdev_get_by_dev(f.file->f_mapping->host->i_rdev,
> - FMODE_WRITE | FMODE_READ, NULL);
> + FMODE_WRITE | FMODE_READ, NULL, NULL);
> if (IS_ERR(reg->hr_bdev)) {
> ret = PTR_ERR(reg->hr_bdev);
> reg->hr_bdev = NULL;
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 4d11d60f493c14..5e4db9a0c8e5a3 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2616,7 +2616,7 @@ static int journal_init_dev(struct super_block *super,
> if (jdev == super->s_dev)
> blkdev_mode &= ~FMODE_EXCL;
> journal->j_dev_bd = blkdev_get_by_dev(jdev, blkdev_mode,
> - journal);
> + journal, NULL);
> journal->j_dev_mode = blkdev_mode;
> if (IS_ERR(journal->j_dev_bd)) {
> result = PTR_ERR(journal->j_dev_bd);
> @@ -2632,7 +2632,8 @@ static int journal_init_dev(struct super_block *super,
> }
>
> journal->j_dev_mode = blkdev_mode;
> - journal->j_dev_bd = blkdev_get_by_path(jdev_name, blkdev_mode, journal);
> + journal->j_dev_bd = blkdev_get_by_path(jdev_name, blkdev_mode, journal,
> + NULL);
> if (IS_ERR(journal->j_dev_bd)) {
> result = PTR_ERR(journal->j_dev_bd);
> journal->j_dev_bd = NULL;
> diff --git a/fs/super.c b/fs/super.c
> index 34afe411cf2bc3..012ce140080375 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1248,7 +1248,7 @@ int get_tree_bdev(struct fs_context *fc,
> if (!fc->source)
> return invalf(fc, "No source specified");
>
> - bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type);
> + bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL);
> if (IS_ERR(bdev)) {
> errorf(fc, "%s: Can't open blockdev", fc->source);
> return PTR_ERR(bdev);
> @@ -1333,7 +1333,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
> if (!(flags & SB_RDONLY))
> mode |= FMODE_WRITE;
>
> - bdev = blkdev_get_by_path(dev_name, mode, fs_type);
> + bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
> if (IS_ERR(bdev))
> return ERR_CAST(bdev);
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 4d2e87462ac4a1..bc17ad350aea5a 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -386,7 +386,7 @@ xfs_blkdev_get(
> int error = 0;
>
> *bdevp = blkdev_get_by_path(name, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
> - mp);
> + mp, NULL);
> if (IS_ERR(*bdevp)) {
> error = PTR_ERR(*bdevp);
> xfs_warn(mp, "Invalid device [%s], error=%d", name, error);
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 740afe80f29786..84a931caef514e 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -55,6 +55,8 @@ struct block_device {
> struct super_block * bd_super;
> void * bd_claiming;
> void * bd_holder;
> + const struct blk_holder_ops *bd_holder_ops;
> + struct mutex bd_holder_lock;
> /* The counter of freeze processes */
> int bd_fsfreeze_count;
> int bd_holders;
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index e3242e67a8e3df..3f41f8c9b103cf 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1468,9 +1468,13 @@ void blkdev_show(struct seq_file *seqf, off_t offset);
> #define BLKDEV_MAJOR_MAX 0
> #endif
>
> +struct blk_holder_ops {
> +};
> +
> +struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder,
> + const struct blk_holder_ops *hops);
> struct block_device *blkdev_get_by_path(const char *path, fmode_t mode,
> - void *holder);
> -struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder);
> + void *holder, const struct blk_holder_ops *hops);
> int bd_prepare_to_claim(struct block_device *bdev, void *holder);
> void bd_abort_claiming(struct block_device *bdev, void *holder);
> void blkdev_put(struct block_device *bdev, fmode_t mode);
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 92e41ed292ada8..801c411530d11c 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -357,7 +357,7 @@ static int swsusp_swap_check(void)
> root_swap = res;
>
> hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device, FMODE_WRITE,
> - NULL);
> + NULL, NULL);
> if (IS_ERR(hib_resume_bdev))
> return PTR_ERR(hib_resume_bdev);
>
> @@ -1524,7 +1524,7 @@ int swsusp_check(void)
> mode |= FMODE_EXCL;
>
> hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device,
> - mode, &holder);
> + mode, &holder, NULL);
> if (!IS_ERR(hib_resume_bdev)) {
> set_blocksize(hib_resume_bdev, PAGE_SIZE);
> clear_page(swsusp_header);
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 274bbf79748006..cfbcf7d5705f5f 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -2770,7 +2770,8 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
>
> if (S_ISBLK(inode->i_mode)) {
> p->bdev = blkdev_get_by_dev(inode->i_rdev,
> - FMODE_READ | FMODE_WRITE | FMODE_EXCL, p);
> + FMODE_READ | FMODE_WRITE | FMODE_EXCL, p,
> + NULL);
> if (IS_ERR(p->bdev)) {
> error = PTR_ERR(p->bdev);
> p->bdev = NULL;
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 6/9] block: add a mark_dead holder operation
2023-05-05 17:51 ` [PATCH 6/9] block: add a mark_dead holder operation Christoph Hellwig
2023-05-05 18:37 ` Darrick J. Wong
@ 2023-05-07 19:19 ` Jan Kara
2023-05-09 13:32 ` Christoph Hellwig
1 sibling, 1 reply; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:19 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:29, Christoph Hellwig wrote:
> Add a mark_dead method to blk_holder_ops that is called from blk_mark_disk_dead
> to notify the holder that the block device it is using has been marked dead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
One question below:
> ---
> block/genhd.c | 24 ++++++++++++++++++++++++
> include/linux/blkdev.h | 1 +
> 2 files changed, 25 insertions(+)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index d1c673b967c254..af97a4ef1e926c 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -575,6 +575,28 @@ int __must_check device_add_disk(struct device *parent, struct gendisk *disk,
> }
> EXPORT_SYMBOL(device_add_disk);
>
> +static void blk_report_disk_dead(struct gendisk *disk)
> +{
> + struct block_device *bdev;
> + unsigned long idx;
> +
> + rcu_read_lock();
> + xa_for_each(&disk->part_tbl, idx, bdev) {
> + if (!kobject_get_unless_zero(&bdev->bd_device.kobj))
> + continue;
> + rcu_read_unlock();
> +
> + mutex_lock(&bdev->bd_holder_lock);
> + if (bdev->bd_holder_ops && bdev->bd_holder_ops->mark_dead)
> + bdev->bd_holder_ops->mark_dead(bdev);
> + mutex_unlock(&bdev->bd_holder_lock);
> +
> + put_device(&bdev->bd_device);
> + rcu_read_lock();
> + }
> + rcu_read_unlock();
> +}
> +
> /**
> * blk_mark_disk_dead - mark a disk as dead
> * @disk: disk to mark as dead
> @@ -602,6 +624,8 @@ void blk_mark_disk_dead(struct gendisk *disk)
> * Prevent new I/O from crossing bio_queue_enter().
> */
> blk_queue_start_drain(disk->queue);
> +
> + blk_report_disk_dead(disk);
Hum, but this gets called from del_gendisk() after blk_drop_partitions()
happens. So how is this going to be able to iterate anything?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 7/9] fs: add a method to shut down the file system
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
2023-05-05 18:39 ` Darrick J. Wong
@ 2023-05-07 19:20 ` Jan Kara
2023-05-16 16:20 ` Christian Brauner
2 siblings, 0 replies; 52+ messages in thread
From: Jan Kara @ 2023-05-07 19:20 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Fri 05-05-23 13:51:30, Christoph Hellwig wrote:
> Add a new ->shutdown super operation that can be used to tell the file
> system to shut down, and call it from newly created holder ops when the
> block device under a file system shuts down.
>
> This only covers the main block device for "simple" file systems using
> get_tree_bdev / mount_bdev. File systems their own get_tree method
> or opening additional devices will need to set up their own
> blk_holder_ops.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/super.c | 21 +++++++++++++++++++--
> include/linux/fs.h | 1 +
> 2 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 012ce140080375..f127589700ab25 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1206,6 +1206,22 @@ int get_tree_keyed(struct fs_context *fc,
> EXPORT_SYMBOL(get_tree_keyed);
>
> #ifdef CONFIG_BLOCK
> +static void fs_mark_dead(struct block_device *bdev)
> +{
> + struct super_block *sb;
> +
> + sb = get_super(bdev);
> + if (!sb)
> + return;
> +
> + if (sb->s_op->shutdown)
> + sb->s_op->shutdown(sb);
> + drop_super(sb);
> +}
> +
> +static const struct blk_holder_ops fs_holder_ops = {
> + .mark_dead = fs_mark_dead,
> +};
>
> static int set_bdev_super(struct super_block *s, void *data)
> {
> @@ -1248,7 +1264,8 @@ int get_tree_bdev(struct fs_context *fc,
> if (!fc->source)
> return invalf(fc, "No source specified");
>
> - bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL);
> + bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type,
> + &fs_holder_ops);
> if (IS_ERR(bdev)) {
> errorf(fc, "%s: Can't open blockdev", fc->source);
> return PTR_ERR(bdev);
> @@ -1333,7 +1350,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
> if (!(flags & SB_RDONLY))
> mode |= FMODE_WRITE;
>
> - bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL);
> + bdev = blkdev_get_by_path(dev_name, mode, fs_type, &fs_holder_ops);
> if (IS_ERR(bdev))
> return ERR_CAST(bdev);
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 21a98168085641..cf3042641b9b30 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1932,6 +1932,7 @@ struct super_operations {
> struct shrink_control *);
> long (*free_cached_objects)(struct super_block *,
> struct shrink_control *);
> + void (*shutdown)(struct super_block *sb);
> };
>
> /*
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: introduce bdev holder ops and a file system shutdown method
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
` (8 preceding siblings ...)
2023-05-05 17:51 ` [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices Christoph Hellwig
@ 2023-05-08 15:20 ` Christoph Hellwig
9 siblings, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-08 15:20 UTC (permalink / raw)
To: Jens Axboe
Cc: Al Viro, Christian Brauner, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
As I got asked last night what tree this actually applies to, and
the answer is "whatever was in Linus' tree three days ago",
I have just pushed out the branch here:
git://git.infradead.org/users/hch/block.git blk_holder_ops
Gitweb:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/blk_holder_ops
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 8/9] xfs: wire up sops->shutdown
2023-05-05 18:23 ` Darrick J. Wong
@ 2023-05-09 13:28 ` Christoph Hellwig
0 siblings, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-09 13:28 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
linux-block, linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 11:23:05AM -0700, Darrick J. Wong wrote:
> Could you add SHUTDOWN_DEVICE_REMOVED to XFS_SHUTDOWN_STRINGS so the
> tracepoint data will decode that flag?
Sure.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 6/9] block: add a mark_dead holder operation
2023-05-05 18:37 ` Darrick J. Wong
@ 2023-05-09 13:30 ` Christoph Hellwig
0 siblings, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-09 13:30 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
linux-block, linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 11:37:49AM -0700, Darrick J. Wong wrote:
> Now that we have blockdev callbacks, can we add a pair for freeze_bdev
> and thaw_bdev so that LVM snapshotting an xfs log device can actually
> quiesce the filesystem?
Probably. Assuming we're not creating any really weird locking dependency
that way.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 6/9] block: add a mark_dead holder operation
2023-05-07 19:19 ` Jan Kara
@ 2023-05-09 13:32 ` Christoph Hellwig
2023-05-16 16:17 ` Christian Brauner
0 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-09 13:32 UTC (permalink / raw)
To: Jan Kara
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
Darrick J. Wong, linux-block, linux-fsdevel, linux-xfs
On Sun, May 07, 2023 at 09:19:46PM +0200, Jan Kara wrote:
> > @@ -602,6 +624,8 @@ void blk_mark_disk_dead(struct gendisk *disk)
> > * Prevent new I/O from crossing bio_queue_enter().
> > */
> > blk_queue_start_drain(disk->queue);
> > +
> > + blk_report_disk_dead(disk);
>
> Hum, but this gets called from del_gendisk() after blk_drop_partitions()
> happens. So how is this going to be able to iterate anything?
It isn't, and doesn't work for partitions right now. I guess del_gendisk
needs a bit of refacoring that we do two pases over the inode and/or
move the ->mark_deal call for partitions into blk_drop_partitions.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-05 18:51 ` Darrick J. Wong
@ 2023-05-09 13:35 ` Christoph Hellwig
2023-05-09 22:19 ` Dave Chinner
0 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-09 13:35 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
linux-block, linux-fsdevel, linux-xfs
On Fri, May 05, 2023 at 11:51:19AM -0700, Darrick J. Wong wrote:
> Fun question: What happens when the swap disk falls off the bus?
Your system is toast.
> > - if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
> > + if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
> > + NULL)))
> > return -EBUSY;
> > ret = set_blocksize(bdev, n);
> > blkdev_put(bdev, mode | FMODE_EXCL);
>
> Somewhat related question: Should we allow userspace to initiate a fs
> shutdown through the block device? Let's say you're preparing to yank
> /dev/sda and want to kill anything attached to it or its partitions?
> Without having to walk through however many mount namespaces there are
> to find the mountpoints?
That's kinda what we're doing here. Or do you mean even more advanced
notice by having another callout before stopping I/O so that we could
write out all log buffers? It's probably doable, but I'm not convinced
that this use case is worth maintaining and testing the kernel code for
it.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk
2023-05-07 19:08 ` Jan Kara
@ 2023-05-09 13:35 ` Christoph Hellwig
0 siblings, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-09 13:35 UTC (permalink / raw)
To: Jan Kara
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
Darrick J. Wong, linux-block, linux-fsdevel, linux-xfs
On Sun, May 07, 2023 at 09:08:11PM +0200, Jan Kara wrote:
> I'm somewhat wondering about the lost notification from
> blk_mark_disk_dead(). E.g. DM uses blk_mark_disk_dead() so if some udev
> script depends on the event when DM device gets destroyed, we would break
> it?
Maybe. We'll probably find out..
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-09 13:35 ` Christoph Hellwig
@ 2023-05-09 22:19 ` Dave Chinner
2023-05-10 1:38 ` Darrick J. Wong
2023-05-10 15:13 ` Christoph Hellwig
0 siblings, 2 replies; 52+ messages in thread
From: Dave Chinner @ 2023-05-09 22:19 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Darrick J. Wong, Jens Axboe, Al Viro, Christian Brauner,
linux-block, linux-fsdevel, linux-xfs
On Tue, May 09, 2023 at 03:35:01PM +0200, Christoph Hellwig wrote:
> On Fri, May 05, 2023 at 11:51:19AM -0700, Darrick J. Wong wrote:
> > Fun question: What happens when the swap disk falls off the bus?
>
> Your system is toast.
>
> > > - if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
> > > + if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
> > > + NULL)))
> > > return -EBUSY;
> > > ret = set_blocksize(bdev, n);
> > > blkdev_put(bdev, mode | FMODE_EXCL);
> >
> > Somewhat related question: Should we allow userspace to initiate a fs
> > shutdown through the block device? Let's say you're preparing to yank
> > /dev/sda and want to kill anything attached to it or its partitions?
> > Without having to walk through however many mount namespaces there are
> > to find the mountpoints?
>
> That's kinda what we're doing here. Or do you mean even more advanced
> notice by having another callout before stopping I/O so that we could
> write out all log buffers? It's probably doable, but I'm not convinced
> that this use case is worth maintaining and testing the kernel code for
> it.
The userspace shutdown code already does this by default - it
actually calls freeze_bdev() to cause the filesystem to be made
consistent on the block device before it executes the shutdown.
So, in effect, we already have the "shutdown before turning off
block device" paths in the filesystems and extremely well tested.
Indeed, if the device is being removed, why not call freeze_bdev()
before doing anything else? It guarantees that applications will be
quiesced and the filesystem will stabilise and not try to change
anything until the shutdown occurs when the device is pulled...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-09 22:19 ` Dave Chinner
@ 2023-05-10 1:38 ` Darrick J. Wong
2023-05-10 15:13 ` Christoph Hellwig
1 sibling, 0 replies; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-10 1:38 UTC (permalink / raw)
To: Dave Chinner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
linux-block, linux-fsdevel, linux-xfs
On Wed, May 10, 2023 at 08:19:58AM +1000, Dave Chinner wrote:
> On Tue, May 09, 2023 at 03:35:01PM +0200, Christoph Hellwig wrote:
> > On Fri, May 05, 2023 at 11:51:19AM -0700, Darrick J. Wong wrote:
> > > Fun question: What happens when the swap disk falls off the bus?
> >
> > Your system is toast.
> >
> > > > - if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
> > > > + if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
> > > > + NULL)))
> > > > return -EBUSY;
> > > > ret = set_blocksize(bdev, n);
> > > > blkdev_put(bdev, mode | FMODE_EXCL);
> > >
> > > Somewhat related question: Should we allow userspace to initiate a fs
> > > shutdown through the block device? Let's say you're preparing to yank
> > > /dev/sda and want to kill anything attached to it or its partitions?
> > > Without having to walk through however many mount namespaces there are
> > > to find the mountpoints?
> >
> > That's kinda what we're doing here. Or do you mean even more advanced
> > notice by having another callout before stopping I/O so that we could
> > write out all log buffers? It's probably doable, but I'm not convinced
> > that this use case is worth maintaining and testing the kernel code for
> > it.
>
> The userspace shutdown code already does this by default - it
> actually calls freeze_bdev() to cause the filesystem to be made
> consistent on the block device before it executes the shutdown.
> So, in effect, we already have the "shutdown before turning off
> block device" paths in the filesystems and extremely well tested.
>
> Indeed, if the device is being removed, why not call freeze_bdev()
> before doing anything else? It guarantees that applications will be
> quiesced and the filesystem will stabilise and not try to change
> anything until the shutdown occurs when the device is pulled...
I think I want everything -- I want freeze_bdev on a device /before/ we
pull it out so that we can try to flush dirty everything to the disk; I
want that to work for the log/rt devices; and I want a final shutdown
notification when the kernel drops the bdev so that we can offline the
fs and shortcut/start returning EIO.
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-09 22:19 ` Dave Chinner
2023-05-10 1:38 ` Darrick J. Wong
@ 2023-05-10 15:13 ` Christoph Hellwig
1 sibling, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-10 15:13 UTC (permalink / raw)
To: Dave Chinner
Cc: Christoph Hellwig, Darrick J. Wong, Jens Axboe, Al Viro,
Christian Brauner, linux-block, linux-fsdevel, linux-xfs
On Wed, May 10, 2023 at 08:19:58AM +1000, Dave Chinner wrote:
> The userspace shutdown code already does this by default - it
> actually calls freeze_bdev() to cause the filesystem to be made
> consistent on the block device before it executes the shutdown.
> So, in effect, we already have the "shutdown before turning off
> block device" paths in the filesystems and extremely well tested.
Yes.
> Indeed, if the device is being removed, why not call freeze_bdev()
> before doing anything else? It guarantees that applications will be
> quiesced and the filesystem will stabilise and not try to change
> anything until the shutdown occurs when the device is pulled...
Because the primary use case of using sysfs to yank a block device
out under a live fs is testing the shutdown path. Changing behavior
here will not improve any actual user live, because no user actually
intentially does this, but at the same time we add new odd code
we need to test, while breaking existing tests.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
2023-05-05 18:51 ` Darrick J. Wong
2023-05-07 19:12 ` Jan Kara
@ 2023-05-16 11:02 ` Ming Lei
2023-05-16 14:36 ` Darrick J. Wong
2023-05-16 16:00 ` Christian Brauner
3 siblings, 1 reply; 52+ messages in thread
From: Ming Lei @ 2023-05-16 11:02 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Christian Brauner, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs, ming.lei
On Fri, May 05, 2023 at 01:51:28PM -0400, Christoph Hellwig wrote:
> Add a new blk_holder_ops structure, which is passed to blkdev_get_by_* and
> installed in the block_device for exclusive claims. It will be used to
> allow the block layer to call back into the user of the block device for
> thing like notification of a removed device or a device resize.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
...
> @@ -542,7 +543,8 @@ static void bd_clear_claiming(struct block_device *whole, void *holder)
> * Finish exclusive open of a block device. Mark the device as exlusively
> * open by the holder and wake up all waiters for exclusive open to finish.
> */
> -static void bd_finish_claiming(struct block_device *bdev, void *holder)
> +static void bd_finish_claiming(struct block_device *bdev, void *holder,
> + const struct blk_holder_ops *hops)
> {
> struct block_device *whole = bdev_whole(bdev);
>
> @@ -555,7 +557,10 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> whole->bd_holders++;
> whole->bd_holder = bd_may_claim;
> bdev->bd_holders++;
> + mutex_lock(&bdev->bd_holder_lock);
> bdev->bd_holder = holder;
> + bdev->bd_holder_ops = hops;
> + mutex_unlock(&bdev->bd_holder_lock);
> bd_clear_claiming(whole, holder);
> mutex_unlock(&bdev_lock);
> }
I guess the holder ops may be override in case of multiple claim, can
this be one problem from the holder ops user viewpoint? Or
warn_on_once(bdev->bd_holder_ops && bdev->bd_holder_ops != hops) is needed here?
Thanks,
Ming
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-16 11:02 ` Ming Lei
@ 2023-05-16 14:36 ` Darrick J. Wong
2023-05-17 7:29 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Darrick J. Wong @ 2023-05-16 14:36 UTC (permalink / raw)
To: Ming Lei
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Christian Brauner,
linux-block, linux-fsdevel, linux-xfs
On Tue, May 16, 2023 at 07:02:31PM +0800, Ming Lei wrote:
> On Fri, May 05, 2023 at 01:51:28PM -0400, Christoph Hellwig wrote:
> > Add a new blk_holder_ops structure, which is passed to blkdev_get_by_* and
> > installed in the block_device for exclusive claims. It will be used to
> > allow the block layer to call back into the user of the block device for
> > thing like notification of a removed device or a device resize.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> ...
>
> > @@ -542,7 +543,8 @@ static void bd_clear_claiming(struct block_device *whole, void *holder)
> > * Finish exclusive open of a block device. Mark the device as exlusively
> > * open by the holder and wake up all waiters for exclusive open to finish.
> > */
> > -static void bd_finish_claiming(struct block_device *bdev, void *holder)
> > +static void bd_finish_claiming(struct block_device *bdev, void *holder,
> > + const struct blk_holder_ops *hops)
> > {
> > struct block_device *whole = bdev_whole(bdev);
> >
> > @@ -555,7 +557,10 @@ static void bd_finish_claiming(struct block_device *bdev, void *holder)
> > whole->bd_holders++;
> > whole->bd_holder = bd_may_claim;
> > bdev->bd_holders++;
> > + mutex_lock(&bdev->bd_holder_lock);
> > bdev->bd_holder = holder;
> > + bdev->bd_holder_ops = hops;
> > + mutex_unlock(&bdev->bd_holder_lock);
> > bd_clear_claiming(whole, holder);
> > mutex_unlock(&bdev_lock);
> > }
>
> I guess the holder ops may be override in case of multiple claim, can
> this be one problem from the holder ops user viewpoint? Or
> warn_on_once(bdev->bd_holder_ops && bdev->bd_holder_ops != hops) is needed here?
<shrug> I'd have thought bd_may_claim would suffice for detecting
multiple claims based on its "bd_holder != NULL" test?
Though I suppose an explicit test for bd_holder_ops != NULL would
prevent multiple claims if all the claims had NULL holders.
--D
>
> Thanks,
> Ming
>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
` (2 preceding siblings ...)
2023-05-16 11:02 ` Ming Lei
@ 2023-05-16 16:00 ` Christian Brauner
2023-05-17 7:30 ` Christoph Hellwig
3 siblings, 1 reply; 52+ messages in thread
From: Christian Brauner @ 2023-05-16 16:00 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Fri, May 05, 2023 at 01:51:28PM -0400, Christoph Hellwig wrote:
> Add a new blk_holder_ops structure, which is passed to blkdev_get_by_* and
> installed in the block_device for exclusive claims. It will be used to
> allow the block layer to call back into the user of the block device for
> thing like notification of a removed device or a device resize.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
Looking at this code reminds me that we'll need a block dev lookup
function that takes a diskseq argument so we can lookup a block device
and check it against the diskseq number we provided so we can detect
"media" changes (images on a loop device etc). Idea being to pass
diskseq numbers via fsconfig().
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 6/9] block: add a mark_dead holder operation
2023-05-09 13:32 ` Christoph Hellwig
@ 2023-05-16 16:17 ` Christian Brauner
0 siblings, 0 replies; 52+ messages in thread
From: Christian Brauner @ 2023-05-16 16:17 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jan Kara, Jens Axboe, Al Viro, Darrick J. Wong, linux-block,
linux-fsdevel, linux-xfs
On Tue, May 09, 2023 at 03:32:09PM +0200, Christoph Hellwig wrote:
> On Sun, May 07, 2023 at 09:19:46PM +0200, Jan Kara wrote:
> > > @@ -602,6 +624,8 @@ void blk_mark_disk_dead(struct gendisk *disk)
> > > * Prevent new I/O from crossing bio_queue_enter().
> > > */
> > > blk_queue_start_drain(disk->queue);
> > > +
> > > + blk_report_disk_dead(disk);
> >
> > Hum, but this gets called from del_gendisk() after blk_drop_partitions()
> > happens. So how is this going to be able to iterate anything?
>
> It isn't, and doesn't work for partitions right now. I guess del_gendisk
> needs a bit of refacoring that we do two pases over the inode and/or
> move the ->mark_deal call for partitions into blk_drop_partitions.
Might be worth a comment. Otherwise looks good to me,
Acked-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 7/9] fs: add a method to shut down the file system
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
2023-05-05 18:39 ` Darrick J. Wong
2023-05-07 19:20 ` Jan Kara
@ 2023-05-16 16:20 ` Christian Brauner
2023-05-17 7:27 ` Christoph Hellwig
2 siblings, 1 reply; 52+ messages in thread
From: Christian Brauner @ 2023-05-16 16:20 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Fri, May 05, 2023 at 01:51:30PM -0400, Christoph Hellwig wrote:
> Add a new ->shutdown super operation that can be used to tell the file
> system to shut down, and call it from newly created holder ops when the
> block device under a file system shuts down.
>
> This only covers the main block device for "simple" file systems using
> get_tree_bdev / mount_bdev. File systems their own get_tree method
> or opening additional devices will need to set up their own
> blk_holder_ops.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Do you want the fs infra and block infra merged together or separately?
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 4/9] block: turn bdev_lock into a mutex
2023-05-05 17:51 ` [PATCH 4/9] block: turn bdev_lock into a mutex Christoph Hellwig
2023-05-07 19:09 ` Jan Kara
@ 2023-05-16 16:24 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Christian Brauner @ 2023-05-16 16:24 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Fri, May 05, 2023 at 01:51:27PM -0400, Christoph Hellwig wrote:
> There is no reason for this lock to spin, and being able to sleep under
> it will come in handy soon.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Acked-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put
2023-05-05 17:51 ` [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
@ 2023-05-16 16:29 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Christian Brauner @ 2023-05-16 16:29 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Fri, May 05, 2023 at 01:51:26PM -0400, Christoph Hellwig wrote:
> Move all the logic to release an exclusive claim into a helper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Acked-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead
2023-05-05 17:51 ` [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
2023-05-07 19:05 ` Jan Kara
@ 2023-05-16 16:29 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Christian Brauner @ 2023-05-16 16:29 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Fri, May 05, 2023 at 01:51:25PM -0400, Christoph Hellwig wrote:
> Check if GD_DEAD is already set in blk_mark_disk_dead, and don't
> duplicate the work already done.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Acked-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 7/9] fs: add a method to shut down the file system
2023-05-16 16:20 ` Christian Brauner
@ 2023-05-17 7:27 ` Christoph Hellwig
0 siblings, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-17 7:27 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Tue, May 16, 2023 at 06:20:19PM +0200, Christian Brauner wrote:
> Do you want the fs infra and block infra merged together or separately?
Yes, splitting this up doesn't really make a lot of sense.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-16 14:36 ` Darrick J. Wong
@ 2023-05-17 7:29 ` Christoph Hellwig
0 siblings, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-17 7:29 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Ming Lei, Christoph Hellwig, Jens Axboe, Al Viro,
Christian Brauner, linux-block, linux-fsdevel, linux-xfs
On Tue, May 16, 2023 at 07:36:26AM -0700, Darrick J. Wong wrote:
> > > + mutex_lock(&bdev->bd_holder_lock);
> > > bdev->bd_holder = holder;
> > > + bdev->bd_holder_ops = hops;
> > > + mutex_unlock(&bdev->bd_holder_lock);
> > > bd_clear_claiming(whole, holder);
> > > mutex_unlock(&bdev_lock);
> > > }
> >
> > I guess the holder ops may be override in case of multiple claim, can
> > this be one problem from the holder ops user viewpoint? Or
> > warn_on_once(bdev->bd_holder_ops && bdev->bd_holder_ops != hops) is needed here?
>
> <shrug> I'd have thought bd_may_claim would suffice for detecting
> multiple claims based on its "bd_holder != NULL" test?
>
> Though I suppose an explicit test for bd_holder_ops != NULL would
> prevent multiple claims if all the claims had NULL holders.
bd_may_claim allows re-claims as long as the same holder is set.
I think we'll want to add an extra check that the holder_ops don't
change for this case. They aren't with the current holders, but this
is a place where a belt and suspenders might be a good idea..
>
> --D
>
> >
> > Thanks,
> > Ming
> >
---end quoted text---
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-16 16:00 ` Christian Brauner
@ 2023-05-17 7:30 ` Christoph Hellwig
2023-05-17 7:57 ` Christian Brauner
0 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-17 7:30 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Tue, May 16, 2023 at 06:00:05PM +0200, Christian Brauner wrote:
> Looking at this code reminds me that we'll need a block dev lookup
> function that takes a diskseq argument so we can lookup a block device
> and check it against the diskseq number we provided so we can detect
> "media" changes (images on a loop device etc). Idea being to pass
> diskseq numbers via fsconfig().
You can already do this by checking right after opening but before
using it. In theory we could pass the seq down, and handle it further
down, but I'm not sure this really solves anything.
The main work here really is in the mount code.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 7:30 ` Christoph Hellwig
@ 2023-05-17 7:57 ` Christian Brauner
2023-05-17 8:06 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Christian Brauner @ 2023-05-17 7:57 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Wed, May 17, 2023 at 09:30:31AM +0200, Christoph Hellwig wrote:
> On Tue, May 16, 2023 at 06:00:05PM +0200, Christian Brauner wrote:
> > Looking at this code reminds me that we'll need a block dev lookup
> > function that takes a diskseq argument so we can lookup a block device
> > and check it against the diskseq number we provided so we can detect
> > "media" changes (images on a loop device etc). Idea being to pass
> > diskseq numbers via fsconfig().
>
> You can already do this by checking right after opening but before
> using it. In theory we could pass the seq down, and handle it further
> down, but I'm not sure this really solves anything.
BTW, why is there no code to lookup a bdev by O_PATH fd? It seems weird
that a lot of ioctls pass the device path to the kernel (btrfs comes to
mind). I can see certain things that would make this potentially a bit
tricky e.g., you'd not have access to the path/name of the device if you
want to show it somewhere such as in mountinfo but nothing that makes it
impossible afaict.
>
> The main work here really is in the mount code.
Yeah, I'll get to this soon. Josef has mentioned that he'll convert
btrfs to the new mount api this cycle and we have that recorded on
video. And I think that otherwise all block device based filesystems
might have already been converted.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 7:57 ` Christian Brauner
@ 2023-05-17 8:06 ` Christoph Hellwig
2023-05-17 8:42 ` Christian Brauner
0 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-17 8:06 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Wed, May 17, 2023 at 09:57:55AM +0200, Christian Brauner wrote:
> BTW, why is there no code to lookup a bdev by O_PATH fd? It seems weird
> that a lot of ioctls pass the device path to the kernel (btrfs comes to
> mind). I can see certain things that would make this potentially a bit
> tricky e.g., you'd not have access to the path/name of the device if you
> want to show it somewhere such as in mountinfo but nothing that makes it
> impossible afaict.
As far as I can tell you should be able to hold a reference to a block
device file descriptor with an O_PATH fd. Or did I miss something
that specifically prohibits that?
> Yeah, I'll get to this soon. Josef has mentioned that he'll convert
> btrfs to the new mount api this cycle and we have that recorded on
> video. And I think that otherwise all block device based filesystems
> might have already been converted.
Btrfs is the last "big" file system, but there plenty more. A quick
grep for mount_bdev fills more than a page on my terminal..
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 8:06 ` Christoph Hellwig
@ 2023-05-17 8:42 ` Christian Brauner
2023-05-17 12:02 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Christian Brauner @ 2023-05-17 8:42 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Wed, May 17, 2023 at 10:06:13AM +0200, Christoph Hellwig wrote:
> On Wed, May 17, 2023 at 09:57:55AM +0200, Christian Brauner wrote:
> > BTW, why is there no code to lookup a bdev by O_PATH fd? It seems weird
> > that a lot of ioctls pass the device path to the kernel (btrfs comes to
> > mind). I can see certain things that would make this potentially a bit
> > tricky e.g., you'd not have access to the path/name of the device if you
> > want to show it somewhere such as in mountinfo but nothing that makes it
> > impossible afaict.
>
> As far as I can tell you should be able to hold a reference to a block
> device file descriptor with an O_PATH fd. Or did I miss something
> that specifically prohibits that?
So with an O_PATH fd the device wouldn't really be opened at all we'd
just hold a reference to a struct file with f->f_op set to empty_fops.
(See the FMODE_PATH code in fs/open.c:do_dentry_open().)
So blkdev_open() is never called for O_PATH fds. Consequently an O_PATH
fd to a block device would only be useful if the intention is to later
lookup the block device based on inode->i_rdev.
So my earlier question should have been why there's no method to lookup
a block device purely by non-O_PATH fd since that way you do actually
pin the block device which is probably what you almost always want to do.
I'm asking because it would be nice if we could allow callers to specify
the source of a filesystem mount as an fd and not just as a string as
the mount api currently does. That's probably not super straightforward
but might be really worth it.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 8:42 ` Christian Brauner
@ 2023-05-17 12:02 ` Christoph Hellwig
2023-05-17 13:14 ` Christian Brauner
0 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-17 12:02 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Wed, May 17, 2023 at 10:42:01AM +0200, Christian Brauner wrote:
> So with an O_PATH fd the device wouldn't really be opened at all we'd
> just hold a reference to a struct file with f->f_op set to empty_fops.
> (See the FMODE_PATH code in fs/open.c:do_dentry_open().)
>
> So blkdev_open() is never called for O_PATH fds. Consequently an O_PATH
> fd to a block device would only be useful if the intention is to later
> lookup the block device based on inode->i_rdev.
Yes. That's pretty much the definition of O_PATH..
> So my earlier question should have been why there's no method to lookup
> a block device purely by non-O_PATH fd since that way you do actually
> pin the block device which is probably what you almost always want to do.
Why would we want to pin it? That just means the device is open and
you're have a non-O_PATH mount.
> I'm asking because it would be nice if we could allow callers to specify
> the source of a filesystem mount as an fd and not just as a string as
> the mount api currently does. That's probably not super straightforward
> but might be really worth it.
What you seem to want is a way to convert an O_PATH fs into a non-O_PATH
one. Which seems generally useful, but isn't really anything block
device specific.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 12:02 ` Christoph Hellwig
@ 2023-05-17 13:14 ` Christian Brauner
2023-05-17 14:26 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Christian Brauner @ 2023-05-17 13:14 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Wed, May 17, 2023 at 02:02:59PM +0200, Christoph Hellwig wrote:
> On Wed, May 17, 2023 at 10:42:01AM +0200, Christian Brauner wrote:
> > So with an O_PATH fd the device wouldn't really be opened at all we'd
> > just hold a reference to a struct file with f->f_op set to empty_fops.
> > (See the FMODE_PATH code in fs/open.c:do_dentry_open().)
> >
> > So blkdev_open() is never called for O_PATH fds. Consequently an O_PATH
> > fd to a block device would only be useful if the intention is to later
> > lookup the block device based on inode->i_rdev.
>
> Yes. That's pretty much the definition of O_PATH..
>
> > So my earlier question should have been why there's no method to lookup
> > a block device purely by non-O_PATH fd since that way you do actually
> > pin the block device which is probably what you almost always want to do.
>
> Why would we want to pin it? That just means the device is open and
> you're have a non-O_PATH mount.
I think we're talking past each other. Both an O_PATH fd and a regular
fd would work. But its often desirable to pass a regular fd. If
userspace uses an O_PATH fd then the block device could be looked up
later during mounting via blkdev_open().
But when you use a regular fd blkdev_open() will be called and the
device resolved right at open time and we'll hold a reference to it.
So that way userspace can immediately know whether the device can be
opened/found. That's usually preferable. That's all I meant to say.
>
> > I'm asking because it would be nice if we could allow callers to specify
> > the source of a filesystem mount as an fd and not just as a string as
> > the mount api currently does. That's probably not super straightforward
> > but might be really worth it.
>
> What you seem to want is a way to convert an O_PATH fs into a non-O_PATH
> one. Which seems generally useful, but isn't really anything block
> device specific.
That already exists, indirectly. You can reopen an O_PATH fd via
/proc/$pid/$nr. And Aleksa is working on O_EMPTYPATH to make this a
first class API including restrictions for how an O_PATH fd can be
reopened. We discussed that during LSFMM.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 13:14 ` Christian Brauner
@ 2023-05-17 14:26 ` Christoph Hellwig
2023-05-18 8:13 ` Christian Brauner
0 siblings, 1 reply; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-17 14:26 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Wed, May 17, 2023 at 03:14:40PM +0200, Christian Brauner wrote:
> > Why would we want to pin it? That just means the device is open and
> > you're have a non-O_PATH mount.
>
> I think we're talking past each other. Both an O_PATH fd and a regular
> fd would work. But its often desirable to pass a regular fd. If
> userspace uses an O_PATH fd then the block device could be looked up
> later during mounting via blkdev_open().
>
> But when you use a regular fd blkdev_open() will be called and the
> device resolved right at open time and we'll hold a reference to it.
>
> So that way userspace can immediately know whether the device can be
> opened/found. That's usually preferable. That's all I meant to say.
I know what you mean. But based on the concept of how O_PATH and
block devices work it really doesn't make any sense to have a block
device handle for an O_PATH fd, except for the actual fd itself.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-17 14:26 ` Christoph Hellwig
@ 2023-05-18 8:13 ` Christian Brauner
2023-05-18 13:12 ` Christoph Hellwig
0 siblings, 1 reply; 52+ messages in thread
From: Christian Brauner @ 2023-05-18 8:13 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Wed, May 17, 2023 at 04:26:09PM +0200, Christoph Hellwig wrote:
> On Wed, May 17, 2023 at 03:14:40PM +0200, Christian Brauner wrote:
> > > Why would we want to pin it? That just means the device is open and
> > > you're have a non-O_PATH mount.
> >
> > I think we're talking past each other. Both an O_PATH fd and a regular
> > fd would work. But its often desirable to pass a regular fd. If
> > userspace uses an O_PATH fd then the block device could be looked up
> > later during mounting via blkdev_open().
> >
> > But when you use a regular fd blkdev_open() will be called and the
> > device resolved right at open time and we'll hold a reference to it.
> >
> > So that way userspace can immediately know whether the device can be
> > opened/found. That's usually preferable. That's all I meant to say.
>
> I know what you mean. But based on the concept of how O_PATH and
> block devices work it really doesn't make any sense to have a block
> device handle for an O_PATH fd, except for the actual fd itself.
Fwiw, I didn't mean to have a special device handler for an O_PATH fd.
I really just tried to figure out whether it would make sense to have an
fd-based block device lookup function because right now we only have
blkdev_get_by_path() and we'd be passing blkdev fds through the mount
api. But I understand now how I'd likely do it. So now just finding time
to actually implement it.
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-18 8:13 ` Christian Brauner
@ 2023-05-18 13:12 ` Christoph Hellwig
2023-05-18 13:13 ` Christoph Hellwig
2023-05-18 13:56 ` Christian Brauner
0 siblings, 2 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-18 13:12 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Thu, May 18, 2023 at 10:13:04AM +0200, Christian Brauner wrote:
> Fwiw, I didn't mean to have a special device handler for an O_PATH fd.
> I really just tried to figure out whether it would make sense to have an
> fd-based block device lookup function because right now we only have
> blkdev_get_by_path() and we'd be passing blkdev fds through the mount
> api. But I understand now how I'd likely do it. So now just finding time
> to actually implement it.
What's wrong with blkdev_get_by_dev(file_inode(file)->i_rdev) after
the sanity checks from lookup_bdev (S_ISBLK and may_open_dev)?
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-18 13:12 ` Christoph Hellwig
@ 2023-05-18 13:13 ` Christoph Hellwig
2023-05-18 13:56 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Christoph Hellwig @ 2023-05-18 13:13 UTC (permalink / raw)
To: Christian Brauner
Cc: Christoph Hellwig, Jens Axboe, Al Viro, Darrick J. Wong,
linux-block, linux-fsdevel, linux-xfs
On Thu, May 18, 2023 at 03:12:16PM +0200, Christoph Hellwig wrote:
> On Thu, May 18, 2023 at 10:13:04AM +0200, Christian Brauner wrote:
> > Fwiw, I didn't mean to have a special device handler for an O_PATH fd.
> > I really just tried to figure out whether it would make sense to have an
> > fd-based block device lookup function because right now we only have
> > blkdev_get_by_path() and we'd be passing blkdev fds through the mount
> > api. But I understand now how I'd likely do it. So now just finding time
> > to actually implement it.
>
> What's wrong with blkdev_get_by_dev(file_inode(file)->i_rdev) after
> the sanity checks from lookup_bdev (S_ISBLK and may_open_dev)?
s/i_rdev/i_dev/
^ permalink raw reply [flat|nested] 52+ messages in thread
* Re: [PATCH 5/9] block: introduce holder ops
2023-05-18 13:12 ` Christoph Hellwig
2023-05-18 13:13 ` Christoph Hellwig
@ 2023-05-18 13:56 ` Christian Brauner
1 sibling, 0 replies; 52+ messages in thread
From: Christian Brauner @ 2023-05-18 13:56 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Al Viro, Darrick J. Wong, linux-block, linux-fsdevel,
linux-xfs
On Thu, May 18, 2023 at 03:12:16PM +0200, Christoph Hellwig wrote:
> On Thu, May 18, 2023 at 10:13:04AM +0200, Christian Brauner wrote:
> > Fwiw, I didn't mean to have a special device handler for an O_PATH fd.
> > I really just tried to figure out whether it would make sense to have an
> > fd-based block device lookup function because right now we only have
> > blkdev_get_by_path() and we'd be passing blkdev fds through the mount
> > api. But I understand now how I'd likely do it. So now just finding time
> > to actually implement it.
>
> What's wrong with blkdev_get_by_dev(file_inode(file)->i_rdev) after
> the sanity checks from lookup_bdev (S_ISBLK and may_open_dev)?
Yeah, that's what I realized could work fine. I just need to check all
fses how they currently do this and how to do this cleanly.
^ permalink raw reply [flat|nested] 52+ messages in thread
end of thread, other threads:[~2023-05-18 13:56 UTC | newest]
Thread overview: 52+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
2023-05-05 17:51 ` [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
2023-05-09 13:35 ` Christoph Hellwig
2023-05-05 17:51 ` [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
2023-05-07 19:05 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 4/9] block: turn bdev_lock into a mutex Christoph Hellwig
2023-05-07 19:09 ` Jan Kara
2023-05-16 16:24 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
2023-05-05 18:51 ` Darrick J. Wong
2023-05-09 13:35 ` Christoph Hellwig
2023-05-09 22:19 ` Dave Chinner
2023-05-10 1:38 ` Darrick J. Wong
2023-05-10 15:13 ` Christoph Hellwig
2023-05-07 19:12 ` Jan Kara
2023-05-16 11:02 ` Ming Lei
2023-05-16 14:36 ` Darrick J. Wong
2023-05-17 7:29 ` Christoph Hellwig
2023-05-16 16:00 ` Christian Brauner
2023-05-17 7:30 ` Christoph Hellwig
2023-05-17 7:57 ` Christian Brauner
2023-05-17 8:06 ` Christoph Hellwig
2023-05-17 8:42 ` Christian Brauner
2023-05-17 12:02 ` Christoph Hellwig
2023-05-17 13:14 ` Christian Brauner
2023-05-17 14:26 ` Christoph Hellwig
2023-05-18 8:13 ` Christian Brauner
2023-05-18 13:12 ` Christoph Hellwig
2023-05-18 13:13 ` Christoph Hellwig
2023-05-18 13:56 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 6/9] block: add a mark_dead holder operation Christoph Hellwig
2023-05-05 18:37 ` Darrick J. Wong
2023-05-09 13:30 ` Christoph Hellwig
2023-05-07 19:19 ` Jan Kara
2023-05-09 13:32 ` Christoph Hellwig
2023-05-16 16:17 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
2023-05-05 18:39 ` Darrick J. Wong
2023-05-07 19:20 ` Jan Kara
2023-05-16 16:20 ` Christian Brauner
2023-05-17 7:27 ` Christoph Hellwig
2023-05-05 17:51 ` [PATCH 8/9] xfs: wire up sops->shutdown Christoph Hellwig
2023-05-05 18:23 ` Darrick J. Wong
2023-05-09 13:28 ` Christoph Hellwig
2023-05-05 17:51 ` [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices Christoph Hellwig
2023-05-05 18:32 ` Darrick J. Wong
2023-05-08 15:20 ` introduce bdev holder ops and a file system shutdown method Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).