archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-07-28 16:23 Mohammad Rasim
  0 siblings, 0 replies; 8+ messages in thread
From: Mohammad Rasim @ 2021-07-28 16:23 UTC (permalink / raw)
  To: yanp.bugz
  Cc: aaptel, almaz.alexandrovich, andy.lavr, anton, dan.carpenter,
	dsterba, ebiggers, hch, joe, kari.argillander, linux-fsdevel,
	linux-kernel, linux-ntfs-dev, mark, nborisov, oleksandr, pali,
	rdunlap, viro, willy


I've been using your ntfs driver for sometime now and it's great to 
finally have a good driver for this FS, however i have problem where if 
the power cuts off from my system while writing to the volume the 
partition gets corrupted, this is expected of course but the problem is 
that `ntfsfix` tool can't fix the partition and no matter how many times 
i run it the system will always spits this in the kernel log when trying 
to mount the partition:

     ntfs3: sdb1: volume is dirty and "force" flag is not set!

if i boot to a windows 10 OS then the system is able to mount the volume 
with no problem(even before running chkdsk on it), windows `chkdsk` 
utility can find the errors and fix them, and i can reboot to linux to 
use my partition again with no problem.

it would be nice to have your filesystem utilites published on github so 
we can use them with the current out of the tree driver


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-06-07  9:55 Marius Cirsta
  0 siblings, 0 replies; 8+ messages in thread
From: Marius Cirsta @ 2021-06-07  9:55 UTC (permalink / raw)
  To: almaz.alexandrovich
  Cc: aaptel, andy.lavr, anton, dan.carpenter, dsterba, ebiggers, hch,
	joe, kari.argillander, linux-fsdevel, linux-kernel,
	linux-ntfs-dev, mark, nborisov, oleksandr, pali, rdunlap, viro,

I am just a user of the kernel but for me the ntfs support is really
important as I have shared drives that are in NTFS format and ntfs-3g
is not really the best as it has a high CPU usage.

What happened to this review ? I am not sure what the process is but
is no one really interested ?

I saw there were some comments initially but if those were solved then
is it ready for integration ? Is more testing required? I could help
with that if needed.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-04-02 15:53 Konstantin Komarov
  2021-05-19  3:47 ` Neal Gompa
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Konstantin Komarov @ 2021-04-02 15:53 UTC (permalink / raw)
  To: linux-fsdevel
  Cc: viro, linux-kernel, pali, dsterba, aaptel, willy, rdunlap, joe,
	mark, nborisov, linux-ntfs-dev, anton, dan.carpenter, hch,
	ebiggers, andy.lavr, kari.argillander, oleksandr,
	Konstantin Komarov

This patch adds NTFS Read-Write driver to fs/ntfs3.

Having decades of expertise in commercial file systems development and huge
test coverage, we at Paragon Software GmbH want to make our contribution to
the Open Source Community by providing implementation of NTFS Read-Write
driver for the Linux Kernel.

This is fully functional NTFS Read-Write driver. Current version works with
NTFS(including v3.1) and normal/compressed/sparse files and supports journal replaying.

We plan to support this version after the codebase once merged, and add new
features and fix bugs. For example, full journaling support over JBD will be
added in later updates.

 - patch splitted to chunks (file-wise)
 - build issues fixed
 - sparse and errors fixed
 - NULL pointer dereference on mkfs.ntfs-formatted volume mount fixed
 - cosmetics + code cleanup

 - added acl, noatime, no_acs_rules, prealloc mount options
 - added fiemap support
 - fixed encodings support
 - removed typedefs
 - adapted Kernel-way logging mechanisms
 - fixed typos and corner-case issues

 - atomic_open() refactored
 - code style updated
 - bugfixes

- nls/nls_alt mount options added
- Unicode conversion fixes
- Improved very fragmented files operations
- logging cosmetics

- Security Descriptors processing changed
  added system.ntfs_security xattr to set
- atomic_open() optimized
- cosmetics

- Security Descriptors validity checks added (by Mark Harmstone)
- atomic_open() fixed for the compressed file creation with directio
- remount support
- temporarily removed readahead usage
- cosmetics

- Compressed files operations fixed

- Further cosmetics applied as suggested
by Joe Perches

- operations with compressed/sparse files on very fragmented volumes improved
- reduced memory consumption for above cases

- further compressed files optimizations: reads/writes are now skipping bufferization
- journal wipe to the initial state optimized (bufferization is also skipped)
- optimized run storage (re-packing cluster metainformation)
- fixes based on Matthew Wilcox feedback to the v10
- compressed/sparse/normal could be set for empty files with 'system.ntfs_attrib' xattr

- nls_alt mount option removed after discussion with Pali Rohar
- fixed ni_repack()
- fixed resident files transition to non-resident when size increasing

- nested_lock fix (lockdep)
- out-of-bounds read fix (KASAN warning)
- resident->nonresident transition fixed for compressed files
- load_nls() missed fix applied
- some sparse utility warnings fixes

- support for additional compression types (we've adapted WIMLIB's
  implementation, authored by Eric Biggers, into ntfs3)

- kernel test robot warnings fixed
- lzx/xpress compression license headers updated

- lzx/xpress moved to initial ntfs-3g plugin code
- mutexes instead of a global spinlock for compresions

- fixes for Mattew Wilcox's and Andy Lavr's concerns

- ntfs_alloc macro splitted into two ntfs_malloc + ntfs_zalloc
- attrlist.c: always use ntfs_cmp_names instead of memcmp; compare entry names
  only for entry with vcn == 0
- dir.c: remove unconditional ni_lock in ntfs_readdir
- fslog.c: corrected error case behavior
- index.c: refactored due to modification of ntfs_cmp_names; use rw_semaphore
  for read/write access to alloc_run and bitmap_run while ntfs_readdir
- run.c: separated big/little endian code in functions
- upcase.c: improved ntfs_cmp_names, thanks to Kari Argillander for idea
  and 'bothcase' implementation

- fixed directory bitmap for 2MB cluster size
- fixed rw_semaphore init for directories

- fixed issue with incorrect hidden/system attribute setting on
  root subdirectories
- use kvmalloc instead of kmalloc for runs array
- fixed index behavior on volumes with cluster size more than 4k
- current build info is added into module info instead of printing on insmod

- fixes for clang CFI checks
- fixed sb->s_maxbytes for 32bit clusters
- user.DOSATTRIB is no more intercepted by ntfs3
- corrected xattr limits;  is used
- corrected CONFIG_NTFS3_64BIT_CLUSTER usage
- info about current build is added into module info and printing
on insmod (by Andy Lavr's request)
note: v21 is applicable for 'linux-next' not older than 2021.01.28

- ntfs_cmp_names() fixed
- raise warning if 'nls->uni2char' fails
- hot fix free clusters code optimized
- use clang-format 11.0 instead of 10.0 to format code

- corrections for Kernel Test Robot warnings
- kmem_cache_create() utilized to allocate memory in bitmap.c
- cosmetics and comments thru the code

- BIO_MAX_PAGES -> BIO_MAX_VECS (fix for build issue of v23 vs linux-next)
- minor optimization for LogFile: do not fill it with -1, if it's already there
- index.c: removed 'inline' in definition of hdr_find_split() and hdr_insert_head()

- restore fs/Makefile in patch
- refactor ntfs_create_inode() to use error-valued pointer
- use mi_get_ref to fill MFT_REF
- minimize warnings: replace LogFile with \x24LogFile when printing

- fixed coccinelle warnings
- fslog.c: fix memory leak and memory overwrite

Konstantin Komarov (10):
  fs/ntfs3: Add headers and misc files
  fs/ntfs3: Add initialization of super block
  fs/ntfs3: Add bitmap
  fs/ntfs3: Add file operations and implementation
  fs/ntfs3: Add attrib operations
  fs/ntfs3: Add compression
  fs/ntfs3: Add NTFS journal
  fs/ntfs3: Add Kconfig, Makefile and doc
  fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
  fs/ntfs3: Add MAINTAINERS

 Documentation/filesystems/ntfs3.rst |  107 +
 MAINTAINERS                         |    7 +
 fs/Kconfig                          |    1 +
 fs/Makefile                         |    1 +
 fs/ntfs3/Kconfig                    |   46 +
 fs/ntfs3/Makefile                   |   34 +
 fs/ntfs3/attrib.c                   | 2082 +++++++++++
 fs/ntfs3/attrlist.c                 |  456 +++
 fs/ntfs3/bitfunc.c                  |  135 +
 fs/ntfs3/bitmap.c                   | 1519 ++++++++
 fs/ntfs3/debug.h                    |   64 +
 fs/ntfs3/dir.c                      |  594 +++
 fs/ntfs3/file.c                     | 1130 ++++++
 fs/ntfs3/frecord.c                  | 3071 ++++++++++++++++
 fs/ntfs3/fslog.c                    | 5181 +++++++++++++++++++++++++++
 fs/ntfs3/fsntfs.c                   | 2542 +++++++++++++
 fs/ntfs3/index.c                    | 2641 ++++++++++++++
 fs/ntfs3/inode.c                    | 2033 +++++++++++
 fs/ntfs3/lib/decompress_common.c    |  332 ++
 fs/ntfs3/lib/decompress_common.h    |  352 ++
 fs/ntfs3/lib/lib.h                  |   26 +
 fs/ntfs3/lib/lzx_decompress.c       |  683 ++++
 fs/ntfs3/lib/xpress_decompress.c    |  155 +
 fs/ntfs3/lznt.c                     |  452 +++
 fs/ntfs3/namei.c                    |  578 +++
 fs/ntfs3/ntfs.h                     | 1238 +++++++
 fs/ntfs3/ntfs_fs.h                  | 1085 ++++++
 fs/ntfs3/record.c                   |  609 ++++
 fs/ntfs3/run.c                      | 1111 ++++++
 fs/ntfs3/super.c                    | 1500 ++++++++
 fs/ntfs3/upcase.c                   |  105 +
 fs/ntfs3/xattr.c                    | 1046 ++++++
 32 files changed, 30916 insertions(+)
 create mode 100644 Documentation/filesystems/ntfs3.rst
 create mode 100644 fs/ntfs3/Kconfig
 create mode 100644 fs/ntfs3/Makefile
 create mode 100644 fs/ntfs3/attrib.c
 create mode 100644 fs/ntfs3/attrlist.c
 create mode 100644 fs/ntfs3/bitfunc.c
 create mode 100644 fs/ntfs3/bitmap.c
 create mode 100644 fs/ntfs3/debug.h
 create mode 100644 fs/ntfs3/dir.c
 create mode 100644 fs/ntfs3/file.c
 create mode 100644 fs/ntfs3/frecord.c
 create mode 100644 fs/ntfs3/fslog.c
 create mode 100644 fs/ntfs3/fsntfs.c
 create mode 100644 fs/ntfs3/index.c
 create mode 100644 fs/ntfs3/inode.c
 create mode 100644 fs/ntfs3/lib/decompress_common.c
 create mode 100644 fs/ntfs3/lib/decompress_common.h
 create mode 100644 fs/ntfs3/lib/lib.h
 create mode 100644 fs/ntfs3/lib/lzx_decompress.c
 create mode 100644 fs/ntfs3/lib/xpress_decompress.c
 create mode 100644 fs/ntfs3/lznt.c
 create mode 100644 fs/ntfs3/namei.c
 create mode 100644 fs/ntfs3/ntfs.h
 create mode 100644 fs/ntfs3/ntfs_fs.h
 create mode 100644 fs/ntfs3/record.c
 create mode 100644 fs/ntfs3/run.c
 create mode 100644 fs/ntfs3/super.c
 create mode 100644 fs/ntfs3/upcase.c
 create mode 100644 fs/ntfs3/xattr.c

base-commit: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-28 16:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 16:23 [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software Mohammad Rasim
  -- strict thread matches above, loose matches on Subject: below --
2021-06-07  9:55 Marius Cirsta
2021-04-02 15:53 Konstantin Komarov
2021-05-19  3:47 ` Neal Gompa
2021-05-19  3:51   ` Neal Gompa
2021-05-20 16:13 ` Darrick J. Wong
2021-07-17 16:36 ` Pali Rohár
2021-07-25 17:02 ` Yan Pas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).