linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: jack@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org
Cc: adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
	darrick.wong@oracle.com, hch@infradead.org, cmaiolino@redhat.com,
	Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCHv3 2/6] ext4: Optimize ext4_ext_precache for 0 depth
Date: Wed, 26 Feb 2020 15:27:04 +0530	[thread overview]
Message-ID: <30a143eafd931603d54bef8026411d89c71ffdda.1582702694.git.riteshh@linux.ibm.com> (raw)
In-Reply-To: <cover.1582702693.git.riteshh@linux.ibm.com>

This patch avoids the memory alloc & free path when depth is 0, 
since anyway there is no extra caching done in that case.
So on checking depth 0, simply return early.

Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
 fs/ext4/extents.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ee83fe7c98aa..0de548bb3c90 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -594,6 +594,12 @@ int ext4_ext_precache(struct inode *inode)
 	down_read(&ei->i_data_sem);
 	depth = ext_depth(inode);
 
+	/* Don't cache anything if there are no external extent blocks */
+	if (!depth) {
+		up_read(&ei->i_data_sem);
+		return ret;
+	}
+
 	path = kcalloc(depth + 1, sizeof(struct ext4_ext_path),
 		       GFP_NOFS);
 	if (path == NULL) {
@@ -601,9 +607,6 @@ int ext4_ext_precache(struct inode *inode)
 		return -ENOMEM;
 	}
 
-	/* Don't cache anything if there are no external extent blocks */
-	if (depth == 0)
-		goto out;
 	path[0].p_hdr = ext_inode_hdr(inode);
 	ret = ext4_ext_check(inode, path[0].p_hdr, depth, 0);
 	if (ret)
-- 
2.21.0


  parent reply	other threads:[~2020-02-26  9:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1582702693.git.riteshh@linux.ibm.com>
2020-02-26  9:57 ` [PATCHv3 1/6] ext4: Add IOMAP_F_MERGED for non-extent based mapping Ritesh Harjani
2020-02-26 12:26   ` Jan Kara
2020-02-26 12:33     ` Ritesh Harjani
2020-02-26  9:57 ` Ritesh Harjani [this message]
2020-02-26 12:28   ` [PATCHv3 2/6] ext4: Optimize ext4_ext_precache for 0 depth Jan Kara
2020-02-26  9:57 ` [PATCHv3 3/6] ext4: Move ext4 bmap to use iomap infrastructure Ritesh Harjani
2020-02-26 12:29   ` Jan Kara
2020-02-26  9:57 ` [PATCHv3 4/6] ext4: Make ext4_ind_map_blocks work with fiemap Ritesh Harjani
2020-02-26 12:39   ` Jan Kara
2020-02-26 12:47     ` Ritesh Harjani
2020-02-26 16:11   ` Darrick J. Wong
2020-02-27  5:27     ` Ritesh Harjani
2020-02-26  9:57 ` [PATCHv3 5/6] ext4: Move ext4_fiemap to use iomap framework Ritesh Harjani
2020-02-26 13:27   ` Jan Kara
2020-02-27  5:38     ` Ritesh Harjani
2020-02-26  9:57 ` [PATCHv3 6/6] Documentation: Correct the description of FIEMAP_EXTENT_LAST Ritesh Harjani
2020-02-26 13:05   ` Matthew Wilcox
2020-02-26 16:17     ` Darrick J. Wong
2020-02-26 17:26       ` Jan Kara
2020-02-27  3:24         ` Dave Chinner
2020-02-27  5:17       ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30a143eafd931603d54bef8026411d89c71ffdda.1582702694.git.riteshh@linux.ibm.com \
    --to=riteshh@linux.ibm.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=cmaiolino@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).