* [PATCH] fuse: clean up redundant assignment
@ 2020-11-26 4:03 Shiyang Ruan
2020-12-14 5:43 ` Ruan Shiyang
0 siblings, 1 reply; 2+ messages in thread
From: Shiyang Ruan @ 2020-11-26 4:03 UTC (permalink / raw)
To: miklos, linux-fsdevel; +Cc: linux-kernel
The 'err' was assigned to -ENOMEM in just few lines above, no need to be
assigned again.
Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
---
fs/fuse/dir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index ff7dbeb16f88..f28eb54517ff 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
if (!forget)
goto out_err;
- err = -ENOMEM;
ff = fuse_file_alloc(fm);
if (!ff)
goto out_put_forget_req;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fuse: clean up redundant assignment
2020-11-26 4:03 [PATCH] fuse: clean up redundant assignment Shiyang Ruan
@ 2020-12-14 5:43 ` Ruan Shiyang
0 siblings, 0 replies; 2+ messages in thread
From: Ruan Shiyang @ 2020-12-14 5:43 UTC (permalink / raw)
To: miklos, linux-fsdevel; +Cc: linux-kernel
Hi guys,
any ideas?
--
Thanks,
Ruan Shiyang.
On 2020/11/26 下午12:03, Shiyang Ruan wrote:
> The 'err' was assigned to -ENOMEM in just few lines above, no need to be
> assigned again.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> ---
> fs/fuse/dir.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index ff7dbeb16f88..f28eb54517ff 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
> if (!forget)
> goto out_err;
>
> - err = -ENOMEM;
> ff = fuse_file_alloc(fm);
> if (!ff)
> goto out_put_forget_req;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-14 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 4:03 [PATCH] fuse: clean up redundant assignment Shiyang Ruan
2020-12-14 5:43 ` Ruan Shiyang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).