From: Guenter Roeck <linux@roeck-us.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, mhocko@suse.cz,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process'
Date: Mon, 26 Jan 2015 06:17:55 -0800 [thread overview]
Message-ID: <54C64C93.6040504@roeck-us.net> (raw)
In-Reply-To: <54C6494D.80802@roeck-us.net>
On 01/26/2015 06:03 AM, Guenter Roeck wrote:
> On 01/26/2015 04:29 AM, Kirill A. Shutemov wrote:
>> On Fri, Jan 23, 2015 at 09:52:07PM -0800, Guenter Roeck wrote:
>>> On Fri, Jan 23, 2015 at 01:55:19PM -0800, Andrew Morton wrote:
>>>> On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
>>>>
>>>>>>>
>>>>>>> qemu:microblaze generates warnings to the console.
>>>>>>>
>>>>>>> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4()
>>>>>>>
>>>>>>> with various call stacks. See
>>>>>>> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio
>>>>>>> for details.
>>>>>>
>>>>>> Could you try patch below? Completely untested.
>>>>>>
>>>>>> >From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001
>>>>>> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
>>>>>> Date: Fri, 23 Jan 2015 13:08:26 +0200
>>>>>> Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED
>>>>>>
>>>>>> Microblaze uses custom implementation of PMD folding, but doesn't define
>>>>>> __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it.
>>>>>>
>>>>>> Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc().
>>>>>> It also fixes problems with recently-introduced pmd accounting.
>>>>>>
>>>>>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>>>>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>>>>>
>>>>> Tested working.
>>>>>
>>>>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>>>>
>>>>> Any idea how to fix the sh problem ?
>>>>
>>>> Can you tell us more about it? All I'm seeing is "qemu:sh fails to
>>>> shut down", which isn't very clear.
>>>
>>> Turns out that the include file defining __PAGETABLE_PMD_FOLDED
>>> was not always included where used, resulting in a messed up mm_struct.
>>
>> What means "messed up" here? It should only affect size of mm_struct.
>>
> Plus the offset of all variables after the #ifndef.
>
>>> The patch below fixes the problem for the sh architecture.
>>> No idea if the patch is correct/acceptable for other architectures.
>>
>> That's pain. Some archs includes <linux/mm_types.h> from <asm/pgtable.h>.
>> I don't see obvious way to fix this. Urghh.
>>
> Does it matter ? Circular includes are normally ok and happen all over the place.
Ah yes, it does, because mm_struct will not see the define in that case
since it comes later. Hmm, that is really tricky. You could of course
just drop the conditional from mm_struct. That would result in an unused
variable for some architectures, but at least it would work.
Guenter
next prev parent reply other threads:[~2015-01-26 14:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 23:05 mmotm 2015-01-22-15-04 uploaded akpm
2015-01-23 5:04 ` mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' Guenter Roeck
2015-01-23 11:13 ` Kirill A. Shutemov
2015-01-23 15:07 ` Guenter Roeck
2015-01-23 21:55 ` Andrew Morton
2015-01-24 2:44 ` Guenter Roeck
2015-01-24 3:05 ` Guenter Roeck
2015-01-24 5:52 ` Guenter Roeck
2015-01-26 12:29 ` Kirill A. Shutemov
2015-01-26 14:03 ` Guenter Roeck
2015-01-26 14:17 ` Guenter Roeck [this message]
2015-01-27 16:16 ` Kirill A. Shutemov
2015-01-27 16:24 ` Guenter Roeck
2015-01-27 21:24 ` Andrew Morton
2015-01-28 6:16 ` Guenter Roeck
2015-01-23 5:08 ` mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test' Guenter Roeck
2015-01-23 14:18 ` Johannes Weiner
2015-01-23 15:17 ` Christoph Lameter
2015-01-23 16:02 ` Johannes Weiner
2015-01-23 16:59 ` Guenter Roeck
2015-01-23 17:36 ` Johannes Weiner
2015-01-23 17:38 ` Johannes Weiner
2015-01-24 2:02 ` Guenter Roeck
2015-01-27 17:24 ` Michal Hocko
2015-01-28 15:03 ` Christoph Lameter
2015-01-23 15:46 ` Guenter Roeck
2015-01-23 16:03 ` Johannes Weiner
2015-01-23 20:20 ` Christoph Lameter
2015-01-23 20:33 ` Guenter Roeck
2015-01-23 21:09 ` Christoph Lameter
2015-01-24 7:16 ` Johannes Weiner
2015-01-25 21:36 ` Valdis.Kletnieks
2015-01-26 13:37 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C64C93.6040504@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).