From: Christoph Lameter <cl@linux.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, mhocko@suse.cz
Subject: Re: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test'
Date: Fri, 23 Jan 2015 14:20:03 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.11.1501231419420.11767@gentwo.org> (raw)
In-Reply-To: <20150123141817.GA22926@phnom.home.cmpxchg.org>
On Fri, 23 Jan 2015, Johannes Weiner wrote:
> struct mem_cgroup_tree_per_node *rtpn;
> struct mem_cgroup_tree_per_zone *rtpz;
> - int tmp, node, zone;
> + int node, zone;
>
> for_each_node(node) {
Do for_each_online_node(node) {
instead?
> - tmp = node;
> - if (!node_state(node, N_NORMAL_MEMORY))
> - tmp = -1;
> - rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, tmp);
> + rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node);
> BUG_ON(!rtpn);
>
> soft_limit_tree.rb_tree_per_node[node] = rtpn;
>
> --
>
> Is the assumption of this patch wrong? Does the specified node have
> to be online for the fallback to work?
>
> Thanks
>
next prev parent reply other threads:[~2015-01-23 20:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 23:05 mmotm 2015-01-22-15-04 uploaded akpm
2015-01-23 5:04 ` mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' Guenter Roeck
2015-01-23 11:13 ` Kirill A. Shutemov
2015-01-23 15:07 ` Guenter Roeck
2015-01-23 21:55 ` Andrew Morton
2015-01-24 2:44 ` Guenter Roeck
2015-01-24 3:05 ` Guenter Roeck
2015-01-24 5:52 ` Guenter Roeck
2015-01-26 12:29 ` Kirill A. Shutemov
2015-01-26 14:03 ` Guenter Roeck
2015-01-26 14:17 ` Guenter Roeck
2015-01-27 16:16 ` Kirill A. Shutemov
2015-01-27 16:24 ` Guenter Roeck
2015-01-27 21:24 ` Andrew Morton
2015-01-28 6:16 ` Guenter Roeck
2015-01-23 5:08 ` mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test' Guenter Roeck
2015-01-23 14:18 ` Johannes Weiner
2015-01-23 15:17 ` Christoph Lameter
2015-01-23 16:02 ` Johannes Weiner
2015-01-23 16:59 ` Guenter Roeck
2015-01-23 17:36 ` Johannes Weiner
2015-01-23 17:38 ` Johannes Weiner
2015-01-24 2:02 ` Guenter Roeck
2015-01-27 17:24 ` Michal Hocko
2015-01-28 15:03 ` Christoph Lameter
2015-01-23 15:46 ` Guenter Roeck
2015-01-23 16:03 ` Johannes Weiner
2015-01-23 20:20 ` Christoph Lameter [this message]
2015-01-23 20:33 ` Guenter Roeck
2015-01-23 21:09 ` Christoph Lameter
2015-01-24 7:16 ` Johannes Weiner
2015-01-25 21:36 ` Valdis.Kletnieks
2015-01-26 13:37 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1501231419420.11767@gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).