From: Waiman Long <waiman.long@hpe.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jan Kara <jack@suse.com>, Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <andi@firstfloor.org>,
Dave Chinner <dchinner@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Scott J Norton <scott.norton@hpe.com>,
Douglas Hatch <doug.hatch@hpe.com>
Subject: Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists
Date: Tue, 19 Jul 2016 15:01:30 -0400 [thread overview]
Message-ID: <578E790A.6090403@hpe.com> (raw)
In-Reply-To: <20160719050032.GE2356@ZenIV.linux.org.uk>
On 07/19/2016 01:00 AM, Al Viro wrote:
> On Fri, Jul 15, 2016 at 01:39:40PM -0400, Waiman Long wrote:
>
>> +struct dlock_list_head_percpu {
>> + struct list_head list;
>> + spinlock_t lock;
>> +};
>> +#define DLOCK_LIST_HEAD_PERCPU_INIT(name) \
>> + { \
>> + .list.prev =&name.list, \
>> + .list.next =&name.list, \
>> + .list.lock = __SPIN_LOCK_UNLOCKED(name), \
> What's .list.lock and how does that even compile?
Yes, it is a typo. This macro is not used. That is why there is no
compilation error. I will remove it from the patch.
>> +extern bool dlock_list_next(struct dlock_list_head *dlist,
>> + struct dlock_list_iter *iter);
> Ugh... Why not dlist_for_each_entry(), seeing that all users end up with
> the same boilerplate?
Right, I could make a dlock_list_for_each_entry() that encapsulate the
boilerplate. I will work on that.
Thanks,
Longman
next prev parent reply other threads:[~2016-07-19 19:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 17:39 [PATCH v3 0/4] vfs: Use dlock list for SB's s_inodes list Waiman Long
2016-07-15 17:39 ` [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists Waiman Long
2016-07-18 23:38 ` Tejun Heo
2016-07-19 18:42 ` Waiman Long
2016-07-19 19:23 ` Tejun Heo
2016-07-20 19:53 ` Waiman Long
2016-07-20 22:02 ` Waiman Long
2016-07-20 22:15 ` Waiman Long
2016-07-21 0:48 ` Christoph Lameter
2016-07-21 1:36 ` Waiman Long
2016-07-21 1:49 ` Dave Chinner
2016-07-22 20:43 ` Waiman Long
2016-07-19 5:00 ` Al Viro
2016-07-19 19:01 ` Waiman Long [this message]
2016-07-15 17:39 ` [PATCH v3 2/4] fsnotify: Simplify inode iteration on umount Waiman Long
2016-07-15 17:39 ` [PATCH v3 3/4] vfs: Remove unnecessary list_for_each_entry_safe() variants Waiman Long
2016-07-15 17:39 ` [PATCH v3 4/4] vfs: Use dlock list for superblock's inode list Waiman Long
2016-07-19 5:23 ` Al Viro
2016-07-19 18:35 ` Tejun Heo
2016-07-19 19:07 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578E790A.6090403@hpe.com \
--to=waiman.long@hpe.com \
--cc=andi@firstfloor.org \
--cc=bfields@fieldses.org \
--cc=boqun.feng@gmail.com \
--cc=cl@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=doug.hatch@hpe.com \
--cc=jack@suse.com \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=scott.norton@hpe.com \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).