From: Waiman Long <waiman.long@hpe.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.com>, Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <andi@firstfloor.org>,
Dave Chinner <dchinner@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Scott J Norton <scott.norton@hpe.com>,
Douglas Hatch <doug.hatch@hpe.com>
Subject: Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists
Date: Wed, 20 Jul 2016 18:15:47 -0400 [thread overview]
Message-ID: <578FF813.3040901@hpe.com> (raw)
In-Reply-To: <578E7497.30602@hpe.com>
On 07/19/2016 02:42 PM, Waiman Long wrote:
> On 07/18/2016 07:38 PM, Tejun Heo wrote:
>
>>> +/*
>>> + * include/linux/dlock-list.h
>>> + *
>>> + * A distributed (per-cpu) set of lists each of which is protected
>>> by its
>>> + * own spinlock, but acts like a single consolidated list to the
>>> callers.
>>> + *
>>> + * The dlock_list_head_percpu structure contains the spinlock, the
>>> other
>>> + * dlock_list_node structures only contains a pointer to the
>>> spinlock in
>>> + * dlock_list_head_percpu.
>>> + */
>> The more I think about it, the more bothered I'm about the dlock_list
>> name. For the most part, this isn't different from other percpu data
>> structures in the kernel. Sure, it might benefit from doing Nth cpu,
>> but so are other percpu data structures and it's not just "distributed
>> lock" list either. The list itself is percpu, not just locking. Can
>> we please go back to percpu_list? Christoph, what do you think?
>>
>
> As I said before, I don't mind reverting the name back to percpu_list.
> I am just waiting for a final agreement.
>
Christoph, are you OK with Tejun's request to revert the name back to
percpu_list? Or do you still think the current name is better?
I am almost done with my next version of the patch. This is the only
thing that is still outstanding.
Thanks,
Longman
Thanks,
Longman
next prev parent reply other threads:[~2016-07-20 22:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 17:39 [PATCH v3 0/4] vfs: Use dlock list for SB's s_inodes list Waiman Long
2016-07-15 17:39 ` [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists Waiman Long
2016-07-18 23:38 ` Tejun Heo
2016-07-19 18:42 ` Waiman Long
2016-07-19 19:23 ` Tejun Heo
2016-07-20 19:53 ` Waiman Long
2016-07-20 22:02 ` Waiman Long
2016-07-20 22:15 ` Waiman Long [this message]
2016-07-21 0:48 ` Christoph Lameter
2016-07-21 1:36 ` Waiman Long
2016-07-21 1:49 ` Dave Chinner
2016-07-22 20:43 ` Waiman Long
2016-07-19 5:00 ` Al Viro
2016-07-19 19:01 ` Waiman Long
2016-07-15 17:39 ` [PATCH v3 2/4] fsnotify: Simplify inode iteration on umount Waiman Long
2016-07-15 17:39 ` [PATCH v3 3/4] vfs: Remove unnecessary list_for_each_entry_safe() variants Waiman Long
2016-07-15 17:39 ` [PATCH v3 4/4] vfs: Use dlock list for superblock's inode list Waiman Long
2016-07-19 5:23 ` Al Viro
2016-07-19 18:35 ` Tejun Heo
2016-07-19 19:07 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578FF813.3040901@hpe.com \
--to=waiman.long@hpe.com \
--cc=andi@firstfloor.org \
--cc=bfields@fieldses.org \
--cc=boqun.feng@gmail.com \
--cc=cl@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=doug.hatch@hpe.com \
--cc=jack@suse.com \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=scott.norton@hpe.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).