linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* mmotm 2019-08-27-20-39 uploaded
@ 2019-08-28  3:40 akpm
       [not found] ` <8b09d93a-bc42-bd8e-29ee-cd37765f4899@infradead.org>
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: akpm @ 2019-08-28  3:40 UTC (permalink / raw)
  To: broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next,
	mhocko, mm-commits, sfr

The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to

   http://www.ozlabs.org/~akpm/mmotm/

mmotm-readme.txt says

README for mm-of-the-moment:

http://www.ozlabs.org/~akpm/mmotm/

This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
more than once a week.

You will need quilt to apply these patches to the latest Linus release (5.x
or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
http://ozlabs.org/~akpm/mmotm/series

The file broken-out.tar.gz contains two datestamp files: .DATE and
.DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
followed by the base kernel version against which this patch series is to
be applied.

This tree is partially included in linux-next.  To see which patches are
included in linux-next, consult the `series' file.  Only the patches
within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in
linux-next.


A full copy of the full kernel tree with the linux-next and mmotm patches
already applied is available through git within an hour of the mmotm
release.  Individual mmotm releases are tagged.  The master branch always
points to the latest release, so it's constantly rebasing.

http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/



The directory http://www.ozlabs.org/~akpm/mmots/ (mm-of-the-second)
contains daily snapshots of the -mm tree.  It is updated more frequently
than mmotm, and is untested.

A git copy of this tree is available at

	http://git.cmpxchg.org/cgit.cgi/linux-mmots.git/

and use of this tree is similar to
http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/, described above.


This mmotm tree contains the following patches against 5.3-rc6:
(patches marked "*" will be included in linux-next)

  origin.patch
* mm-memcontrol-flush-percpu-slab-vmstats-on-kmem-offlining.patch
* mm-zsmallocc-fix-build-when-config_compaction=n.patch
* proc-kpageflags-prevent-an-integer-overflow-in-stable_page_flags.patch
* proc-kpageflags-do-not-use-uninitialized-struct-pages.patch
* partially-revert-mm-memcontrolc-keep-local-vm-counters-in-sync-with-the-hierarchical-ones.patch
* mm-z3foldc-fix-lock-unlock-imbalance-in-z3fold_page_isolate.patch
* mailmap-add-aliases-for-dmitry-safonov.patch
* kbuild-clean-compressed-initramfs-image.patch
* ocfs2-use-jbd2_inode-dirty-range-scoping.patch
* jbd2-remove-jbd2_journal_inode_add_.patch
* ocfs-further-debugfs-cleanups.patch
* ocfs-further-debugfs-cleanups-fix.patch
* ocfs2-the-function-ocfs2_calc_tree_trunc_credits-is-not-used-anymore-so-as-to-be-removed.patch
* ocfs2-the-function-ocfs2_orphan_scan_exit-is-declared-but-not-implemented-and-called-so-as-to-be-removed.patch
* fs-ocfs2-nameic-remove-set-but-not-used-variables.patch
* fs-ocfs2-filec-remove-set-but-not-used-variables.patch
* fs-ocfs2-dirc-remove-set-but-not-used-variables.patch
* ocfs2-clear-zero-in-unaligned-direct-io.patch
* ocfs2-clear-zero-in-unaligned-direct-io-checkpatch-fixes.patch
* ocfs2-wait-for-recovering-done-after-direct-unlock-request.patch
* ocfs2-checkpoint-appending-truncate-log-transaction-before-flushing.patch
* fs-ocfs2-fix-possible-null-pointer-dereferences-in-ocfs2_xa_prepare_entry.patch
* fs-ocfs2-fix-possible-null-pointer-dereferences-in-ocfs2_xa_prepare_entry-fix.patch
* fs-ocfs2-fix-a-possible-null-pointer-dereference-in-ocfs2_write_end_nolock.patch
* fs-ocfs2-fix-a-possible-null-pointer-dereference-in-ocfs2_info_scan_inode_alloc.patch
* ramfs-support-o_tmpfile.patch
  mm.patch
* mm-slab-extend-slab-shrink-to-shrink-all-memcg-caches.patch
* mm-slb-improve-memory-accounting.patch
* mm-slb-guarantee-natural-alignment-for-kmallocpower-of-two.patch
* mm-slab-move-memcg_cache_params-structure-to-mm-slabh.patch
* kmemleak-increase-debug_kmemleak_early_log_size-default-to-16k.patch
* mm-kmemleak-make-the-tool-tolerant-to-struct-scan_area-allocation-failures.patch
* mm-kmemleak-simple-memory-allocation-pool-for-kmemleak-objects.patch
* mm-kmemleak-use-the-memory-pool-for-early-allocations.patch
* mm-kmemleak-use-the-memory-pool-for-early-allocations-checkpatch-fixes.patch
* mm-kmemleak-use-the-memory-pool-for-early-allocations-checkpatch-fixes-fix.patch
* mm-kmemleak-record-the-current-memory-pool-size.patch
* mm-kmemleak-increase-the-max-mem-pool-to-1m.patch
* kasan-add-memory-corruption-identification-for-software-tag-based-mode.patch
* lib-test_kasan-add-roundtrip-tests.patch
* lib-test_kasan-add-roundtrip-tests-checkpatch-fixes.patch
* mm-page_poison-fix-a-typo-in-a-comment.patch
* mm-rmapc-remove-set-but-not-used-variable-cstart.patch
* mm-introduce-page_size.patch
* mm-introduce-page_shift.patch
* mm-introduce-page_shift-fix.patch
* mm-introduce-compound_nr.patch
* mm-replace-list_move_tail-with-add_page_to_lru_list_tail.patch
* mm-page_owner-record-page-owner-for-each-subpage.patch
* mm-page_owner-keep-owner-info-when-freeing-the-page.patch
* mm-page_owner-debug_pagealloc-save-and-dump-freeing-stack-trace.patch
* mm-filemap-dont-initiate-writeback-if-mapping-has-no-dirty-pages.patch
* mm-filemap-rewrite-mapping_needs_writeback-in-less-fancy-manner.patch
* mm-page-cache-store-only-head-pages-in-i_pages.patch
* mm-page-cache-store-only-head-pages-in-i_pages-fix.patch
* mm-throttle-allocators-when-failing-reclaim-over-memoryhigh.patch
* mm-throttle-allocators-when-failing-reclaim-over-memoryhigh-fix.patch
* mm-throttle-allocators-when-failing-reclaim-over-memoryhigh-fix-fix.patch
* mm-throttle-allocators-when-failing-reclaim-over-memoryhigh-fix-fix-fix.patch
* mm-throttle-allocators-when-failing-reclaim-over-memoryhigh-fix-fix-fix-fix.patch
* mm-vmscan-expose-cgroup_ino-for-memcg-reclaim-tracepoints.patch
* mm-memcontrol-switch-to-rcu-protection-in-drain_all_stock.patch
* mm-vmscan-do-not-share-cgroup-iteration-between-reclaimers.patch
* mm-gup-add-make_dirty-arg-to-put_user_pages_dirty_lock.patch
* mm-gup-add-make_dirty-arg-to-put_user_pages_dirty_lock-fix.patch
* drivers-gpu-drm-via-convert-put_page-to-put_user_page.patch
* net-xdp-convert-put_page-to-put_user_page.patch
* mm-remove-redundant-assignment-of-entry.patch
* mm-mmap-fix-the-adjusted-length-error.patch
* mm-release-the-spinlock-on-zap_pte_range.patch
* mm-remove-quicklist-page-table-caches.patch
* ia64-switch-to-generic-version-of-pte-allocation.patch
* sh-switch-to-generic-version-of-pte-allocation.patch
* microblaze-switch-to-generic-version-of-pte-allocation.patch
* mm-consolidate-pgtable_cache_init-and-pgd_cache_init.patch
* mm-memory_hotplug-remove-move_pfn_range.patch
* mm-memory_hotplug-remove-move_pfn_range-fix.patch
* drivers-base-nodec-simplify-unregister_memory_block_under_nodes.patch
* drivers-base-memoryc-fixup-documentation-of-removable-phys_index-block_size_bytes.patch
* driver-base-memoryc-validate-memory-block-size-early.patch
* drivers-base-memoryc-dont-store-end_section_nr-in-memory-blocks.patch
* mm-hotplug-prevent-memory-leak-when-reuse-pgdat.patch
* resource-use-pfn_up-pfn_down-in-walk_system_ram_range.patch
* mm-memory_hotplug-drop-pagereserved-check-in-online_pages_range.patch
* mm-memory_hotplug-simplify-online_pages_range.patch
* mm-memory_hotplug-make-sure-the-pfn-is-aligned-to-the-order-when-onlining.patch
* mm-memory_hotplug-make-sure-the-pfn-is-aligned-to-the-order-when-onlining-fix.patch
* mm-memory_hotplug-online_pages-cannot-be-0-in-online_pages.patch
* mm-sparse-fix-memory-leak-of-sparsemap_buf-in-aliged-memory.patch
* mm-sparse-fix-memory-leak-of-sparsemap_buf-in-aliged-memory-fix.patch
* mm-sparse-fix-align-without-power-of-2-in-sparse_buffer_alloc.patch
* mm-sparse-use-__nr_to_sectionsection_nr-to-get-mem_section.patch
* mm-vmalloc-do-not-keep-unpurged-areas-in-the-busy-tree.patch
* mm-vmalloc-modify-struct-vmap_area-to-reduce-its-size.patch
* mm-use-cpu_bits_none-to-initialize-init_mmcpu_bitmask.patch
* mm-silence-woverride-init-initializer-overrides.patch
* mm-compaction-clear-total_migratefree_scanned-before-scanning-a-new-zone.patch
* mm-compaction-clear-total_migratefree_scanned-before-scanning-a-new-zone-fix.patch
* mm-compaction-clear-total_migratefree_scanned-before-scanning-a-new-zone-fix-fix.patch
* mm-compaction-clear-total_migratefree_scanned-before-scanning-a-new-zone-fix-2.patch
* mm-compaction-clear-total_migratefree_scanned-before-scanning-a-new-zone-fix-2-fix.patch
* mm-compaction-remove-unnecessary-zone-parameter-in-isolate_migratepages.patch
* mm-mempolicyc-remove-unnecessary-nodemask-check-in-kernel_migrate_pages.patch
* mm-oom-avoid-printk-iteration-under-rcu.patch
* mm-oom-avoid-printk-iteration-under-rcu-fix.patch
* mm-oom_killer-add-task-uid-to-info-message-on-an-oom-kill.patch
* mm-oom_killer-add-task-uid-to-info-message-on-an-oom-kill-fix.patch
* memcg-oom-dont-require-__gfp_fs-when-invoking-memcg-oom-killer.patch
* mm-oom-add-oom_score_adj-and-pgtables-to-killed-process-message.patch
* mm-reclaim-make-should_continue_reclaim-perform-dryrun-detection.patch
* mm-reclaim-cleanup-should_continue_reclaim.patch
* mm-compaction-raise-compaction-priority-after-it-withdrawns.patch
* hugetlbfs-dont-retry-when-pool-page-allocations-start-to-fail.patch
* mm-migrate-clean-up-useless-code-in-migrate_vma_collect_pmd.patch
* thp-update-split_huge_page_pmd-commnet.patch
* filemap-check-compound_headpage-mapping-in-filemap_fault.patch
* filemap-check-compound_headpage-mapping-in-pagecache_get_page.patch
* filemap-update-offset-check-in-filemap_fault.patch
* mmthp-stats-for-file-backed-thp.patch
* khugepaged-rename-collapse_shmem-and-khugepaged_scan_shmem.patch
* mmthp-add-read-only-thp-support-for-non-shmem-fs.patch
* mmthp-add-read-only-thp-support-for-non-shmem-fs-fix.patch
* mmthp-add-read-only-thp-support-for-non-shmem-fs-fix-2.patch
* mmthp-avoid-writes-to-file-with-thp-in-pagecache.patch
* mm-thp-extract-split_queue_-into-a-struct.patch
* mm-move-mem_cgroup_uncharge-out-of-__page_cache_release.patch
* mm-shrinker-make-shrinker-not-depend-on-memcg-kmem.patch
* mm-shrinker-make-shrinker-not-depend-on-memcg-kmem-v6.patch
* mm-thp-make-deferred-split-shrinker-memcg-aware.patch
* mm-thp-make-deferred-split-shrinker-memcg-aware-v6.patch
* mm-move-memcmp_pages-and-pages_identical.patch
* uprobe-use-original-page-when-all-uprobes-are-removed.patch
* mm-thp-introduce-foll_split_pmd.patch
* uprobe-use-foll_split_pmd-instead-of-foll_split.patch
* khugepaged-enable-collapse-pmd-for-pte-mapped-thp.patch
* khugepaged-enable-collapse-pmd-for-pte-mapped-thp-fix.patch
* uprobe-collapse-thp-pmd-after-removing-all-uprobes.patch
* mm-account-deferred-split-thps-into-memavailable.patch
* psi-annotate-refault-stalls-from-io-submission-fix.patch
* psi-annotate-refault-stalls-from-io-submission-fix-2.patch
* mm-fs-move-randomize_stack_top-from-fs-to-mm.patch
* arm64-make-use-of-is_compat_task-instead-of-hardcoding-this-test.patch
* arm64-consider-stack-randomization-for-mmap-base-only-when-necessary.patch
* arm64-mm-move-generic-mmap-layout-functions-to-mm.patch
* arm64-mm-make-randomization-selected-by-generic-topdown-mmap-layout.patch
* arm-properly-account-for-stack-randomization-and-stack-guard-gap.patch
* arm-use-stack_top-when-computing-mmap-base-address.patch
* arm-use-generic-mmap-top-down-layout-and-brk-randomization.patch
* mips-properly-account-for-stack-randomization-and-stack-guard-gap.patch
* mips-use-stack_top-when-computing-mmap-base-address.patch
* mips-adjust-brk-randomization-offset-to-fit-generic-version.patch
* mips-replace-arch-specific-way-to-determine-32bit-task-with-generic-version.patch
* mips-use-generic-mmap-top-down-layout-and-brk-randomization.patch
* riscv-make-mmap-allocation-top-down-by-default.patch
* riscv-make-mmap-allocation-top-down-by-default-v6.patch
* mm-mmapc-refine-find_vma_prev-with-rb_last.patch
* mm-mmapc-refine-find_vma_prev-with-rb_last-fix.patch
* mm-mmap-increase-sockets-maximum-memory-size-pgoff-for-32bits.patch
* mm-introduce-madv_cold.patch
* mm-change-pageref_reclaim_clean-with-page_refreclaim.patch
* mm-introduce-madv_pageout.patch
* mm-introduce-madv_pageout-fix.patch
* mm-factor-out-common-parts-between-madv_cold-and-madv_pageout.patch
* mm-madvise-reduce-code-duplication-in-error-handling-paths.patch
* shmem-fix-obsolete-comment-in-shmem_getpage_gfp.patch
* zpool-add-malloc_support_movable-to-zpool_driver.patch
* zswap-use-movable-memory-if-zpool-support-allocate-movable-memory.patch
* mm-proportional-memorylowmin-reclaim.patch
* mm-make-memoryemin-the-baseline-for-utilisation-determination.patch
* mm-make-memoryemin-the-baseline-for-utilisation-determination-fix.patch
* mm-vmscan-remove-unused-lru_pages-argument.patch
* mm-dont-expose-page-to-fast-gup-before-its-ready.patch
* info-task-hung-in-generic_file_write_iter.patch
* info-task-hung-in-generic_file_write-fix.patch
* kernel-hung_taskc-monitor-killed-tasks.patch
* linux-coffh-add-include-guard.patch
* include-proper-prototypes-for-kernel-elfcorec.patch
* hung_task-allow-printing-warnings-every-check-interval.patch
* rbtree-sync-up-the-tools-copy-of-the-code-with-the-main-one.patch
* augmented-rbtree-add-comments-for-rb_declare_callbacks-macro.patch
* augmented-rbtree-add-new-rb_declare_callbacks_max-macro.patch
* augmented-rbtree-add-new-rb_declare_callbacks_max-macro-fix.patch
* augmented-rbtree-add-new-rb_declare_callbacks_max-macro-fix-3.patch
* augmented-rbtree-rework-the-rb_declare_callbacks-macro-definition.patch
* lib-genallocc-export-symbol-addr_in_gen_pool.patch
* lib-genallocc-rename-addr_in_gen_pool-to-gen_pool_has_addr.patch
* lib-genallocc-rename-addr_in_gen_pool-to-gen_pool_has_addr-fix.patch
* string-add-stracpy-and-stracpy_pad-mechanisms.patch
* documentation-checkpatch-prefer-stracpy-strscpy-over-strcpy-strlcpy-strncpy.patch
* kernel-doc-core-api-include-stringh-into-core-api.patch
* kernel-doc-core-api-include-stringh-into-core-api-v2.patch
* writeback-fix-wstringop-truncation-warnings.patch
* strscpy-reject-buffer-sizes-larger-than-int_max.patch
* lib-generic-radix-treec-make-2-functions-static-inline.patch
* lib-extablec-add-missing-prototypes.patch
* lib-hexdump-make-print_hex_dump_bytes-a-nop-on-debug-builds.patch
* lib-fix-possible-incorrect-result-from-rational-fractions-helper.patch
* checkpatch-dont-interpret-stack-dumps-as-commit-ids.patch
* checkpatch-improve-spdx-license-checking.patch
* checkpatchpl-warn-on-invalid-commit-id.patch
* checkpatch-exclude-sizeof-sub-expressions-from-macro_arg_reuse.patch
* checkpatch-prefer-__section-over-__attribute__section.patch
* checkpatch-allow-consecutive-close-braces.patch
* fs-reiserfs-remove-unnecessary-check-of-bh-in-remove_from_transaction.patch
* fs-reiserfs-journalc-remove-set-but-not-used-variables.patch
* fs-reiserfs-streec-remove-set-but-not-used-variables.patch
* fs-reiserfs-lbalancec-remove-set-but-not-used-variables.patch
* fs-reiserfs-objectidc-remove-set-but-not-used-variables.patch
* fs-reiserfs-printsc-remove-set-but-not-used-variables.patch
* fs-reiserfs-fix_nodec-remove-set-but-not-used-variables.patch
* fs-reiserfs-do_balanc-remove-set-but-not-used-variables.patch
* reiserfs-remove-set-but-not-used-variable-in-journalc.patch
* reiserfs-remove-set-but-not-used-variable-in-do_balanc.patch
* fat-add-nobarrier-to-workaround-the-strange-behavior-of-device.patch
* fork-improve-error-message-for-corrupted-page-tables.patch
* cpumask-nicer-for_each_cpumask_and-signature.patch
* kexec-bail-out-upon-sigkill-when-allocating-memory.patch
* kexec-restore-arch_kexec_kernel_image_probe-declaration.patch
* aio-simplify-read_events.patch
* kgdb-dont-use-a-notifier-to-enter-kgdb-at-panic-call-directly.patch
* scripts-gdb-handle-split-debug.patch
* bug-refactor-away-warn_slowpath_fmt_taint.patch
* bug-rename-__warn_printf_taint-to-__warn_printf.patch
* bug-consolidate-warn_slowpath_fmt-usage.patch
* bug-lift-cut-here-out-of-__warn.patch
* bug-clean-up-helper-macros-to-remove-__warn_taint.patch
* bug-consolidate-__warn_flags-usage.patch
* bug-move-warn_on-cut-here-into-exception-handler.patch
* ipc-mqueuec-delete-an-unnecessary-check-before-the-macro-call-dev_kfree_skb.patch
* ipc-mqueue-improve-exception-handling-in-do_mq_notify.patch
* ipc-consolidate-all-xxxctl_down-functions.patch
  linux-next.patch
  linux-next-rejects.patch
  linux-next-git-rejects.patch
  diff-sucks.patch
  tmpfs-fixups-to-use-of-the-new-mount-api.patch
* pinctrl-fix-pxa2xxc-build-warnings.patch
* lib-untag-user-pointers-in-strn_user.patch
* mm-untag-user-pointers-passed-to-memory-syscalls.patch
* mm-untag-user-pointers-in-mm-gupc.patch
* mm-untag-user-pointers-in-get_vaddr_frames.patch
* fs-namespace-untag-user-pointers-in-copy_mount_options.patch
* userfaultfd-untag-user-pointers.patch
* drm-amdgpu-untag-user-pointers.patch
* drm-radeon-untag-user-pointers-in-radeon_gem_userptr_ioctl.patch
* media-v4l2-core-untag-user-pointers-in-videobuf_dma_contig_user_get.patch
* tee-shm-untag-user-pointers-in-tee_shm_register.patch
* vfio-type1-untag-user-pointers-in-vaddr_get_pfn.patch
* mm-untag-user-pointers-in-mmap-munmap-mremap-brk.patch
* hexagon-drop-empty-and-unused-free_initrd_mem.patch
* mm-treewide-clarify-pgtable_page_ctordtor-naming.patch
* drivers-tty-serial-sh-scic-suppress-warning.patch
* fix-read-buffer-overflow-in-delta-ipc.patch
  make-sure-nobodys-leaking-resources.patch
  releasing-resources-with-children.patch
  mutex-subsystem-synchro-test-module.patch
  kernel-forkc-export-kernel_thread-to-modules.patch
  workaround-for-a-pci-restoring-bug.patch

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen)
       [not found] ` <8b09d93a-bc42-bd8e-29ee-cd37765f4899@infradead.org>
@ 2019-08-28 17:19   ` Josh Poimboeuf
  2019-08-28 17:56     ` Randy Dunlap
  0 siblings, 1 reply; 16+ messages in thread
From: Josh Poimboeuf @ 2019-08-28 17:19 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next,
	mhocko, mm-commits, sfr, Peter Zijlstra

On Wed, Aug 28, 2019 at 09:58:37AM -0700, Randy Dunlap wrote:
> On 8/27/19 8:40 PM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to
> > 
> >    http://www.ozlabs.org/~akpm/mmotm/
> > 
> > mmotm-readme.txt says
> > 
> > README for mm-of-the-moment:
> > 
> > http://www.ozlabs.org/~akpm/mmotm/
> > 
> > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > more than once a week.
> > 
> > You will need quilt to apply these patches to the latest Linus release (5.x
> > or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> > http://ozlabs.org/~akpm/mmotm/series
> > 
> > The file broken-out.tar.gz contains two datestamp files: .DATE and
> > .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
> > followed by the base kernel version against which this patch series is to
> > be applied.
> 
> 
> 
> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled

Easy one :-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0c8e17f946cd..6a935ab93149 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = {
 	"ubsan_type_mismatch_common",
 	"__ubsan_handle_type_mismatch",
 	"__ubsan_handle_type_mismatch_v1",
+	"__ubsan_handle_out_of_bounds",
 	/* misc */
 	"csum_partial_copy_generic",
 	"__memcpy_mcsafe",

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen)
  2019-08-28 17:19   ` mmotm 2019-08-27-20-39 uploaded (objtool: xen) Josh Poimboeuf
@ 2019-08-28 17:56     ` Randy Dunlap
  2019-08-28 20:01       ` Josh Poimboeuf
  0 siblings, 1 reply; 16+ messages in thread
From: Randy Dunlap @ 2019-08-28 17:56 UTC (permalink / raw)
  To: Josh Poimboeuf
  Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next,
	mhocko, mm-commits, sfr, Peter Zijlstra

On 8/28/19 10:19 AM, Josh Poimboeuf wrote:
> On Wed, Aug 28, 2019 at 09:58:37AM -0700, Randy Dunlap wrote:
>> On 8/27/19 8:40 PM, akpm@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to
>>>
>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release (5.x
>>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>>> http://ozlabs.org/~akpm/mmotm/series
>>>
>>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>>> followed by the base kernel version against which this patch series is to
>>> be applied.
>>
>>
>>
>> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled
> 
> Easy one :-)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 0c8e17f946cd..6a935ab93149 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = {
>  	"ubsan_type_mismatch_common",
>  	"__ubsan_handle_type_mismatch",
>  	"__ubsan_handle_type_mismatch_v1",
> +	"__ubsan_handle_out_of_bounds",
>  	/* misc */
>  	"csum_partial_copy_generic",
>  	"__memcpy_mcsafe",
> 


then I get this one:

lib/ubsan.o: warning: objtool: __ubsan_handle_out_of_bounds()+0x5d: call to ubsan_prologue() with UACCESS enabled


-- 
~Randy

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
  2019-08-28  3:40 mmotm 2019-08-27-20-39 uploaded akpm
       [not found] ` <8b09d93a-bc42-bd8e-29ee-cd37765f4899@infradead.org>
@ 2019-08-28 18:30 ` Randy Dunlap
  2019-08-28 19:28   ` Pierre-Louis Bossart
       [not found] ` <3e4eba58-7d24-f811-baa1-b6e88334e5a2@infradead.org>
  2 siblings, 1 reply; 16+ messages in thread
From: Randy Dunlap @ 2019-08-28 18:30 UTC (permalink / raw)
  To: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next,
	mhocko, mm-commits, sfr, moderated for non-subscribers,
	Pierre-Louis Bossart

On 8/27/19 8:40 PM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to
> 
>    http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.
> 
> You will need quilt to apply these patches to the latest Linus release (5.x
> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> http://ozlabs.org/~akpm/mmotm/series
> 
> The file broken-out.tar.gz contains two datestamp files: .DATE and
> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
> followed by the base kernel version against which this patch series is to
> be applied.

(from linux-next tree, but problem found/seen in mmotm)

Sorry, I don't know who is responsible for this driver.

~~~~~~~~~~~~~~~~~~~~~~
on i386:

  CC      sound/hda/intel-nhlt.o
../sound/hda/intel-nhlt.c:14:25: error: redefinition of ‘intel_nhlt_init’
 struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
                         ^~~~~~~~~~~~~~~
In file included from ../sound/hda/intel-nhlt.c:5:0:
../include/sound/intel-nhlt.h:134:39: note: previous definition of ‘intel_nhlt_init’ was here
 static inline struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
                                       ^~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c: In function ‘intel_nhlt_init’:
../sound/hda/intel-nhlt.c:39:14: error: dereferencing pointer to incomplete type ‘struct nhlt_resource_desc’
  if (nhlt_ptr->length)
              ^~
../sound/hda/intel-nhlt.c:41:4: error: implicit declaration of function ‘memremap’; did you mean ‘ioremap’? [-Werror=implicit-function-declaration]
    memremap(nhlt_ptr->min_addr, nhlt_ptr->length,
    ^~~~~~~~
    ioremap
../sound/hda/intel-nhlt.c:42:6: error: ‘MEMREMAP_WB’ undeclared (first use in this function)
      MEMREMAP_WB);
      ^~~~~~~~~~~
../sound/hda/intel-nhlt.c:42:6: note: each undeclared identifier is reported only once for each function it appears in
../sound/hda/intel-nhlt.c:45:25: error: dereferencing pointer to incomplete type ‘struct nhlt_acpi_table’
      (strncmp(nhlt_table->header.signature,
                         ^~
../sound/hda/intel-nhlt.c:48:3: error: implicit declaration of function ‘memunmap’; did you mean ‘vunmap’? [-Werror=implicit-function-declaration]
   memunmap(nhlt_table);
   ^~~~~~~~
   vunmap
../sound/hda/intel-nhlt.c: At top level:
../sound/hda/intel-nhlt.c:56:6: error: redefinition of ‘intel_nhlt_free’
 void intel_nhlt_free(struct nhlt_acpi_table *nhlt)
      ^~~~~~~~~~~~~~~
In file included from ../sound/hda/intel-nhlt.c:5:0:
../include/sound/intel-nhlt.h:139:20: note: previous definition of ‘intel_nhlt_free’ was here
 static inline void intel_nhlt_free(struct nhlt_acpi_table *addr)
                    ^~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c:62:5: error: redefinition of ‘intel_nhlt_get_dmic_geo’
 int intel_nhlt_get_dmic_geo(struct device *dev, struct nhlt_acpi_table *nhlt)
     ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ../sound/hda/intel-nhlt.c:5:0:
../include/sound/intel-nhlt.h:143:19: note: previous definition of ‘intel_nhlt_get_dmic_geo’ was here
 static inline int intel_nhlt_get_dmic_geo(struct device *dev,
                   ^~~~~~~~~~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c: In function ‘intel_nhlt_get_dmic_geo’:
../sound/hda/intel-nhlt.c:76:11: error: dereferencing pointer to incomplete type ‘struct nhlt_endpoint’
   if (epnt->linktype == NHLT_LINK_DMIC) {
           ^~
../sound/hda/intel-nhlt.c:76:25: error: ‘NHLT_LINK_DMIC’ undeclared (first use in this function)
   if (epnt->linktype == NHLT_LINK_DMIC) {
                         ^~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c:79:15: error: dereferencing pointer to incomplete type ‘struct nhlt_dmic_array_config’
    switch (cfg->array_type) {
               ^~
../sound/hda/intel-nhlt.c:80:9: error: ‘NHLT_MIC_ARRAY_2CH_SMALL’ undeclared (first use in this function)
    case NHLT_MIC_ARRAY_2CH_SMALL:
         ^~~~~~~~~~~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c:81:9: error: ‘NHLT_MIC_ARRAY_2CH_BIG’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_SMALL’?
    case NHLT_MIC_ARRAY_2CH_BIG:
         ^~~~~~~~~~~~~~~~~~~~~~
         NHLT_MIC_ARRAY_2CH_SMALL
../sound/hda/intel-nhlt.c:82:16: error: ‘MIC_ARRAY_2CH’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_BIG’?
     dmic_geo = MIC_ARRAY_2CH;
                ^~~~~~~~~~~~~
                NHLT_MIC_ARRAY_2CH_BIG
../sound/hda/intel-nhlt.c:85:9: error: ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_BIG’?
    case NHLT_MIC_ARRAY_4CH_1ST_GEOM:
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         NHLT_MIC_ARRAY_2CH_BIG
../sound/hda/intel-nhlt.c:86:9: error: ‘NHLT_MIC_ARRAY_4CH_L_SHAPED’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’?
    case NHLT_MIC_ARRAY_4CH_L_SHAPED:
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         NHLT_MIC_ARRAY_4CH_1ST_GEOM
  AR      sound/i2c/other/built-in.a
../sound/hda/intel-nhlt.c:87:9: error: ‘NHLT_MIC_ARRAY_4CH_2ND_GEOM’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’?
    case NHLT_MIC_ARRAY_4CH_2ND_GEOM:
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         NHLT_MIC_ARRAY_4CH_1ST_GEOM
../sound/hda/intel-nhlt.c:88:16: error: ‘MIC_ARRAY_4CH’ undeclared (first use in this function); did you mean ‘MIC_ARRAY_2CH’?
     dmic_geo = MIC_ARRAY_4CH;
                ^~~~~~~~~~~~~
                MIC_ARRAY_2CH
  AR      sound/i2c/built-in.a
  CC      drivers/bluetooth/btmtksdio.o
../sound/hda/intel-nhlt.c:90:9: error: ‘NHLT_MIC_ARRAY_VENDOR_DEFINED’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_L_SHAPED’?
    case NHLT_MIC_ARRAY_VENDOR_DEFINED:
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         NHLT_MIC_ARRAY_4CH_L_SHAPED
../sound/hda/intel-nhlt.c:92:26: error: dereferencing pointer to incomplete type ‘struct nhlt_vendor_dmic_array_config’
     dmic_geo = cfg_vendor->nb_mics;
                          ^~
../sound/hda/intel-nhlt.c: At top level:
../sound/hda/intel-nhlt.c:106:16: error: expected declaration specifiers or ‘...’ before string constant
 MODULE_LICENSE("GPL v2");
                ^~~~~~~~
../sound/hda/intel-nhlt.c:107:20: error: expected declaration specifiers or ‘...’ before string constant
 MODULE_DESCRIPTION("Intel NHLT driver");
                    ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [../scripts/Makefile.build:266: sound/hda/intel-nhlt.o] Error 1



-- 
~Randy

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (gpu/drm/amd/display/)
       [not found] ` <3e4eba58-7d24-f811-baa1-b6e88334e5a2@infradead.org>
@ 2019-08-28 18:53   ` Alex Deucher
  0 siblings, 0 replies; 16+ messages in thread
From: Alex Deucher @ 2019-08-28 18:53 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Andrew Morton, Mark Brown, linux-fsdevel, LKML, linux-mm,
	Linux-Next Mailing List, Michal Hocko, mm-commits,
	Stephen Rothwell, amd-gfx list, dri-devel, Harry Wentland,
	Leo Li

On Wed, Aug 28, 2019 at 2:51 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 8/27/19 8:40 PM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to
> >
> >    http://www.ozlabs.org/~akpm/mmotm/
> >
> > mmotm-readme.txt says
> >
> > README for mm-of-the-moment:
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > more than once a week.
> >
> > You will need quilt to apply these patches to the latest Linus release (5.x
> > or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> > http://ozlabs.org/~akpm/mmotm/series
> >
> > The file broken-out.tar.gz contains two datestamp files: .DATE and
> > .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
> > followed by the base kernel version against which this patch series is to
> > be applied.
> >
> > This tree is partially included in linux-next.  To see which patches are
> > included in linux-next, consult the `series' file.  Only the patches
> > within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in
> > linux-next.
>
> on i386:
>
> ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function ‘dcn20_hw_sequencer_construct’:
> ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:2127:28: error: ‘dcn20_dsc_pg_control’ undeclared (first use in this function); did you mean ‘dcn20_dpp_pg_control’?
>   dc->hwss.dsc_pg_control = dcn20_dsc_pg_control;
>                             ^~~~~~~~~~~~~~~~~~~~
>                             dcn20_dpp_pg_control
>
>
> Full randconfig file is attached.

Fixed here:
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next&id=da26ded3b2fff646d28559004195abe353bce49b

Alex

>
> --
> ~Randy
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
  2019-08-28 18:30 ` mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c) Randy Dunlap
@ 2019-08-28 19:28   ` Pierre-Louis Bossart
       [not found]     ` <98ada795-4700-7fcc-6d14-fcc1ab25d509@infradead.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-28 19:28 UTC (permalink / raw)
  To: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers



On 8/28/19 1:30 PM, Randy Dunlap wrote:
> On 8/27/19 8:40 PM, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to
>>
>>     http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> http://ozlabs.org/~akpm/mmotm/series
>>
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
> 
> (from linux-next tree, but problem found/seen in mmotm)
> 
> Sorry, I don't know who is responsible for this driver.

That would be me.

I just checked with Mark Brown's for-next tree 
8aceffa09b4b9867153bfe0ff6f40517240cee12
and things are fine in i386 mode, see below.

next-20190828 also works fine for me in i386 mode.

if you can point me to a tree and configuration that don't work I'll 
look into this, I'd need more info to progress.

make ARCH=i386
   Using /data/pbossart/ktest/broonie-next as source for kernel
   GEN     Makefile
   CALL    /data/pbossart/ktest/broonie-next/scripts/checksyscalls.sh
   CALL    /data/pbossart/ktest/broonie-next/scripts/atomic/check-atomics.sh
   CHK     include/generated/compile.h
   CC [M]  sound/hda/ext/hdac_ext_bus.o
   CC [M]  sound/hda/ext/hdac_ext_controller.o
   CC [M]  sound/hda/ext/hdac_ext_stream.o
   LD [M]  sound/hda/ext/snd-hda-ext-core.o
   CC [M]  sound/hda/hda_bus_type.o
   CC [M]  sound/hda/hdac_bus.o
   CC [M]  sound/hda/hdac_device.o
   CC [M]  sound/hda/hdac_sysfs.o
   CC [M]  sound/hda/hdac_regmap.o
   CC [M]  sound/hda/hdac_controller.o
   CC [M]  sound/hda/hdac_stream.o
   CC [M]  sound/hda/array.o
   CC [M]  sound/hda/hdmi_chmap.o
   CC [M]  sound/hda/trace.o
   CC [M]  sound/hda/hdac_component.o
   CC [M]  sound/hda/hdac_i915.o
   LD [M]  sound/hda/snd-hda-core.o
   CC [M]  sound/hda/intel-nhlt.o
   LD [M]  sound/hda/snd-intel-nhlt.o
Kernel: arch/x86/boot/bzImage is ready  (#18)
   Building modules, stage 2.
   MODPOST 156 modules
   CC      sound/hda/ext/snd-hda-ext-core.mod.o
   LD [M]  sound/hda/ext/snd-hda-ext-core.ko
   CC      sound/hda/snd-hda-core.mod.o
   LD [M]  sound/hda/snd-hda-core.ko
   CC      sound/hda/snd-intel-nhlt.mod.o
   LD [M]  sound/hda/snd-intel-nhlt.ko


> 
> ~~~~~~~~~~~~~~~~~~~~~~
> on i386:
> 
>    CC      sound/hda/intel-nhlt.o
> ../sound/hda/intel-nhlt.c:14:25: error: redefinition of ‘intel_nhlt_init’
>   struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
>                           ^~~~~~~~~~~~~~~
> In file included from ../sound/hda/intel-nhlt.c:5:0:
> ../include/sound/intel-nhlt.h:134:39: note: previous definition of ‘intel_nhlt_init’ was here
>   static inline struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
>                                         ^~~~~~~~~~~~~~~
> ../sound/hda/intel-nhlt.c: In function ‘intel_nhlt_init’:
> ../sound/hda/intel-nhlt.c:39:14: error: dereferencing pointer to incomplete type ‘struct nhlt_resource_desc’
>    if (nhlt_ptr->length)
>                ^~
> ../sound/hda/intel-nhlt.c:41:4: error: implicit declaration of function ‘memremap’; did you mean ‘ioremap’? [-Werror=implicit-function-declaration]
>      memremap(nhlt_ptr->min_addr, nhlt_ptr->length,
>      ^~~~~~~~
>      ioremap
> ../sound/hda/intel-nhlt.c:42:6: error: ‘MEMREMAP_WB’ undeclared (first use in this function)
>        MEMREMAP_WB);
>        ^~~~~~~~~~~
> ../sound/hda/intel-nhlt.c:42:6: note: each undeclared identifier is reported only once for each function it appears in
> ../sound/hda/intel-nhlt.c:45:25: error: dereferencing pointer to incomplete type ‘struct nhlt_acpi_table’
>        (strncmp(nhlt_table->header.signature,
>                           ^~
> ../sound/hda/intel-nhlt.c:48:3: error: implicit declaration of function ‘memunmap’; did you mean ‘vunmap’? [-Werror=implicit-function-declaration]
>     memunmap(nhlt_table);
>     ^~~~~~~~
>     vunmap
> ../sound/hda/intel-nhlt.c: At top level:
> ../sound/hda/intel-nhlt.c:56:6: error: redefinition of ‘intel_nhlt_free’
>   void intel_nhlt_free(struct nhlt_acpi_table *nhlt)
>        ^~~~~~~~~~~~~~~
> In file included from ../sound/hda/intel-nhlt.c:5:0:
> ../include/sound/intel-nhlt.h:139:20: note: previous definition of ‘intel_nhlt_free’ was here
>   static inline void intel_nhlt_free(struct nhlt_acpi_table *addr)
>                      ^~~~~~~~~~~~~~~
> ../sound/hda/intel-nhlt.c:62:5: error: redefinition of ‘intel_nhlt_get_dmic_geo’
>   int intel_nhlt_get_dmic_geo(struct device *dev, struct nhlt_acpi_table *nhlt)
>       ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from ../sound/hda/intel-nhlt.c:5:0:
> ../include/sound/intel-nhlt.h:143:19: note: previous definition of ‘intel_nhlt_get_dmic_geo’ was here
>   static inline int intel_nhlt_get_dmic_geo(struct device *dev,
>                     ^~~~~~~~~~~~~~~~~~~~~~~
> ../sound/hda/intel-nhlt.c: In function ‘intel_nhlt_get_dmic_geo’:
> ../sound/hda/intel-nhlt.c:76:11: error: dereferencing pointer to incomplete type ‘struct nhlt_endpoint’
>     if (epnt->linktype == NHLT_LINK_DMIC) {
>             ^~
> ../sound/hda/intel-nhlt.c:76:25: error: ‘NHLT_LINK_DMIC’ undeclared (first use in this function)
>     if (epnt->linktype == NHLT_LINK_DMIC) {
>                           ^~~~~~~~~~~~~~
> ../sound/hda/intel-nhlt.c:79:15: error: dereferencing pointer to incomplete type ‘struct nhlt_dmic_array_config’
>      switch (cfg->array_type) {
>                 ^~
> ../sound/hda/intel-nhlt.c:80:9: error: ‘NHLT_MIC_ARRAY_2CH_SMALL’ undeclared (first use in this function)
>      case NHLT_MIC_ARRAY_2CH_SMALL:
>           ^~~~~~~~~~~~~~~~~~~~~~~~
> ../sound/hda/intel-nhlt.c:81:9: error: ‘NHLT_MIC_ARRAY_2CH_BIG’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_SMALL’?
>      case NHLT_MIC_ARRAY_2CH_BIG:
>           ^~~~~~~~~~~~~~~~~~~~~~
>           NHLT_MIC_ARRAY_2CH_SMALL
> ../sound/hda/intel-nhlt.c:82:16: error: ‘MIC_ARRAY_2CH’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_BIG’?
>       dmic_geo = MIC_ARRAY_2CH;
>                  ^~~~~~~~~~~~~
>                  NHLT_MIC_ARRAY_2CH_BIG
> ../sound/hda/intel-nhlt.c:85:9: error: ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_BIG’?
>      case NHLT_MIC_ARRAY_4CH_1ST_GEOM:
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>           NHLT_MIC_ARRAY_2CH_BIG
> ../sound/hda/intel-nhlt.c:86:9: error: ‘NHLT_MIC_ARRAY_4CH_L_SHAPED’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’?
>      case NHLT_MIC_ARRAY_4CH_L_SHAPED:
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>           NHLT_MIC_ARRAY_4CH_1ST_GEOM
>    AR      sound/i2c/other/built-in.a
> ../sound/hda/intel-nhlt.c:87:9: error: ‘NHLT_MIC_ARRAY_4CH_2ND_GEOM’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’?
>      case NHLT_MIC_ARRAY_4CH_2ND_GEOM:
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>           NHLT_MIC_ARRAY_4CH_1ST_GEOM
> ../sound/hda/intel-nhlt.c:88:16: error: ‘MIC_ARRAY_4CH’ undeclared (first use in this function); did you mean ‘MIC_ARRAY_2CH’?
>       dmic_geo = MIC_ARRAY_4CH;
>                  ^~~~~~~~~~~~~
>                  MIC_ARRAY_2CH
>    AR      sound/i2c/built-in.a
>    CC      drivers/bluetooth/btmtksdio.o
> ../sound/hda/intel-nhlt.c:90:9: error: ‘NHLT_MIC_ARRAY_VENDOR_DEFINED’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_L_SHAPED’?
>      case NHLT_MIC_ARRAY_VENDOR_DEFINED:
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>           NHLT_MIC_ARRAY_4CH_L_SHAPED
> ../sound/hda/intel-nhlt.c:92:26: error: dereferencing pointer to incomplete type ‘struct nhlt_vendor_dmic_array_config’
>       dmic_geo = cfg_vendor->nb_mics;
>                            ^~
> ../sound/hda/intel-nhlt.c: At top level:
> ../sound/hda/intel-nhlt.c:106:16: error: expected declaration specifiers or ‘...’ before string constant
>   MODULE_LICENSE("GPL v2");
>                  ^~~~~~~~
> ../sound/hda/intel-nhlt.c:107:20: error: expected declaration specifiers or ‘...’ before string constant
>   MODULE_DESCRIPTION("Intel NHLT driver");
>                      ^~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [../scripts/Makefile.build:266: sound/hda/intel-nhlt.o] Error 1
> 
> 
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen)
  2019-08-28 17:56     ` Randy Dunlap
@ 2019-08-28 20:01       ` Josh Poimboeuf
  2019-08-29  8:24         ` Peter Zijlstra
  0 siblings, 1 reply; 16+ messages in thread
From: Josh Poimboeuf @ 2019-08-28 20:01 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: akpm, broonie, linux-fsdevel, linux-kernel, linux-mm, linux-next,
	mhocko, mm-commits, sfr, Peter Zijlstra

On Wed, Aug 28, 2019 at 10:56:25AM -0700, Randy Dunlap wrote:
> >> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled
> > 
> > Easy one :-)
> > 
> > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > index 0c8e17f946cd..6a935ab93149 100644
> > --- a/tools/objtool/check.c
> > +++ b/tools/objtool/check.c
> > @@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = {
> >  	"ubsan_type_mismatch_common",
> >  	"__ubsan_handle_type_mismatch",
> >  	"__ubsan_handle_type_mismatch_v1",
> > +	"__ubsan_handle_out_of_bounds",
> >  	/* misc */
> >  	"csum_partial_copy_generic",
> >  	"__memcpy_mcsafe",
> > 
> 
> 
> then I get this one:
> 
> lib/ubsan.o: warning: objtool: __ubsan_handle_out_of_bounds()+0x5d: call to ubsan_prologue() with UACCESS enabled

And of course I jinxed it by calling it easy.

Peter, how do you want to handle this?

Should we just disable UACCESS checking in lib/ubsan.c?

-- 
Josh

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
       [not found]     ` <98ada795-4700-7fcc-6d14-fcc1ab25d509@infradead.org>
@ 2019-08-28 22:20       ` Pierre-Louis Bossart
  2019-08-28 22:45         ` Pierre-Louis Bossart
  0 siblings, 1 reply; 16+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-28 22:20 UTC (permalink / raw)
  To: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers



On 8/28/19 4:06 PM, Randy Dunlap wrote:
> On 8/28/19 12:28 PM, Pierre-Louis Bossart wrote:
>>
>>
>> On 8/28/19 1:30 PM, Randy Dunlap wrote:
> 
>>>
>>> (from linux-next tree, but problem found/seen in mmotm)
>>>
>>> Sorry, I don't know who is responsible for this driver.
>>
>> That would be me.
>>
>> I just checked with Mark Brown's for-next tree 8aceffa09b4b9867153bfe0ff6f40517240cee12
>> and things are fine in i386 mode, see below.
>>
>> next-20190828 also works fine for me in i386 mode.
>>
>> if you can point me to a tree and configuration that don't work I'll look into this, I'd need more info to progress.
> 
> Please try the attached randconfig file.
> 
> Thanks for looking.

Ack, I see some errors as well with this config. Likely a missing 
dependency somewhere, working on this now.

> 
>> make ARCH=i386
>>    Using /data/pbossart/ktest/broonie-next as source for kernel
>>    GEN     Makefile
>>    CALL    /data/pbossart/ktest/broonie-next/scripts/checksyscalls.sh
>>    CALL    /data/pbossart/ktest/broonie-next/scripts/atomic/check-atomics.sh
>>    CHK     include/generated/compile.h
>>    CC [M]  sound/hda/ext/hdac_ext_bus.o
>>    CC [M]  sound/hda/ext/hdac_ext_controller.o
>>    CC [M]  sound/hda/ext/hdac_ext_stream.o
>>    LD [M]  sound/hda/ext/snd-hda-ext-core.o
>>    CC [M]  sound/hda/hda_bus_type.o
>>    CC [M]  sound/hda/hdac_bus.o
>>    CC [M]  sound/hda/hdac_device.o
>>    CC [M]  sound/hda/hdac_sysfs.o
>>    CC [M]  sound/hda/hdac_regmap.o
>>    CC [M]  sound/hda/hdac_controller.o
>>    CC [M]  sound/hda/hdac_stream.o
>>    CC [M]  sound/hda/array.o
>>    CC [M]  sound/hda/hdmi_chmap.o
>>    CC [M]  sound/hda/trace.o
>>    CC [M]  sound/hda/hdac_component.o
>>    CC [M]  sound/hda/hdac_i915.o
>>    LD [M]  sound/hda/snd-hda-core.o
>>    CC [M]  sound/hda/intel-nhlt.o
>>    LD [M]  sound/hda/snd-intel-nhlt.o
>> Kernel: arch/x86/boot/bzImage is ready  (#18)
>>    Building modules, stage 2.
>>    MODPOST 156 modules
>>    CC      sound/hda/ext/snd-hda-ext-core.mod.o
>>    LD [M]  sound/hda/ext/snd-hda-ext-core.ko
>>    CC      sound/hda/snd-hda-core.mod.o
>>    LD [M]  sound/hda/snd-hda-core.ko
>>    CC      sound/hda/snd-intel-nhlt.mod.o
>>    LD [M]  sound/hda/snd-intel-nhlt.ko
>>
>>
>>>
>>> ~~~~~~~~~~~~~~~~~~~~~~
>>> on i386:
>>>
>>>     CC      sound/hda/intel-nhlt.o
>>> ../sound/hda/intel-nhlt.c:14:25: error: redefinition of ‘intel_nhlt_init’
>>>    struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
>>>                            ^~~~~~~~~~~~~~~
>>> In file included from ../sound/hda/intel-nhlt.c:5:0:
>>> ../include/sound/intel-nhlt.h:134:39: note: previous definition of ‘intel_nhlt_init’ was here
>>>    static inline struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
>>>                                          ^~~~~~~~~~~~~~~
>>> ../sound/hda/intel-nhlt.c: In function ‘intel_nhlt_init’:
>>> ../sound/hda/intel-nhlt.c:39:14: error: dereferencing pointer to incomplete type ‘struct nhlt_resource_desc’
>>>     if (nhlt_ptr->length)
>>>                 ^~
>>> ../sound/hda/intel-nhlt.c:41:4: error: implicit declaration of function ‘memremap’; did you mean ‘ioremap’? [-Werror=implicit-function-declaration]
>>>       memremap(nhlt_ptr->min_addr, nhlt_ptr->length,
>>>       ^~~~~~~~
>>>       ioremap
>>> ../sound/hda/intel-nhlt.c:42:6: error: ‘MEMREMAP_WB’ undeclared (first use in this function)
>>>         MEMREMAP_WB);
>>>         ^~~~~~~~~~~
>>> ../sound/hda/intel-nhlt.c:42:6: note: each undeclared identifier is reported only once for each function it appears in
>>> ../sound/hda/intel-nhlt.c:45:25: error: dereferencing pointer to incomplete type ‘struct nhlt_acpi_table’
>>>         (strncmp(nhlt_table->header.signature,
>>>                            ^~
>>> ../sound/hda/intel-nhlt.c:48:3: error: implicit declaration of function ‘memunmap’; did you mean ‘vunmap’? [-Werror=implicit-function-declaration]
>>>      memunmap(nhlt_table);
>>>      ^~~~~~~~
>>>      vunmap
>>> ../sound/hda/intel-nhlt.c: At top level:
>>> ../sound/hda/intel-nhlt.c:56:6: error: redefinition of ‘intel_nhlt_free’
>>>    void intel_nhlt_free(struct nhlt_acpi_table *nhlt)
>>>         ^~~~~~~~~~~~~~~
>>> In file included from ../sound/hda/intel-nhlt.c:5:0:
>>> ../include/sound/intel-nhlt.h:139:20: note: previous definition of ‘intel_nhlt_free’ was here
>>>    static inline void intel_nhlt_free(struct nhlt_acpi_table *addr)
>>>                       ^~~~~~~~~~~~~~~
>>> ../sound/hda/intel-nhlt.c:62:5: error: redefinition of ‘intel_nhlt_get_dmic_geo’
>>>    int intel_nhlt_get_dmic_geo(struct device *dev, struct nhlt_acpi_table *nhlt)
>>>        ^~~~~~~~~~~~~~~~~~~~~~~
>>> In file included from ../sound/hda/intel-nhlt.c:5:0:
>>> ../include/sound/intel-nhlt.h:143:19: note: previous definition of ‘intel_nhlt_get_dmic_geo’ was here
>>>    static inline int intel_nhlt_get_dmic_geo(struct device *dev,
>>>                      ^~~~~~~~~~~~~~~~~~~~~~~
>>> ../sound/hda/intel-nhlt.c: In function ‘intel_nhlt_get_dmic_geo’:
>>> ../sound/hda/intel-nhlt.c:76:11: error: dereferencing pointer to incomplete type ‘struct nhlt_endpoint’
>>>      if (epnt->linktype == NHLT_LINK_DMIC) {
>>>              ^~
>>> ../sound/hda/intel-nhlt.c:76:25: error: ‘NHLT_LINK_DMIC’ undeclared (first use in this function)
>>>      if (epnt->linktype == NHLT_LINK_DMIC) {
>>>                            ^~~~~~~~~~~~~~
>>> ../sound/hda/intel-nhlt.c:79:15: error: dereferencing pointer to incomplete type ‘struct nhlt_dmic_array_config’
>>>       switch (cfg->array_type) {
>>>                  ^~
>>> ../sound/hda/intel-nhlt.c:80:9: error: ‘NHLT_MIC_ARRAY_2CH_SMALL’ undeclared (first use in this function)
>>>       case NHLT_MIC_ARRAY_2CH_SMALL:
>>>            ^~~~~~~~~~~~~~~~~~~~~~~~
>>> ../sound/hda/intel-nhlt.c:81:9: error: ‘NHLT_MIC_ARRAY_2CH_BIG’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_SMALL’?
>>>       case NHLT_MIC_ARRAY_2CH_BIG:
>>>            ^~~~~~~~~~~~~~~~~~~~~~
>>>            NHLT_MIC_ARRAY_2CH_SMALL
>>> ../sound/hda/intel-nhlt.c:82:16: error: ‘MIC_ARRAY_2CH’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_BIG’?
>>>        dmic_geo = MIC_ARRAY_2CH;
>>>                   ^~~~~~~~~~~~~
>>>                   NHLT_MIC_ARRAY_2CH_BIG
>>> ../sound/hda/intel-nhlt.c:85:9: error: ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_2CH_BIG’?
>>>       case NHLT_MIC_ARRAY_4CH_1ST_GEOM:
>>>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>            NHLT_MIC_ARRAY_2CH_BIG
>>> ../sound/hda/intel-nhlt.c:86:9: error: ‘NHLT_MIC_ARRAY_4CH_L_SHAPED’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’?
>>>       case NHLT_MIC_ARRAY_4CH_L_SHAPED:
>>>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>            NHLT_MIC_ARRAY_4CH_1ST_GEOM
>>>     AR      sound/i2c/other/built-in.a
>>> ../sound/hda/intel-nhlt.c:87:9: error: ‘NHLT_MIC_ARRAY_4CH_2ND_GEOM’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_1ST_GEOM’?
>>>       case NHLT_MIC_ARRAY_4CH_2ND_GEOM:
>>>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>            NHLT_MIC_ARRAY_4CH_1ST_GEOM
>>> ../sound/hda/intel-nhlt.c:88:16: error: ‘MIC_ARRAY_4CH’ undeclared (first use in this function); did you mean ‘MIC_ARRAY_2CH’?
>>>        dmic_geo = MIC_ARRAY_4CH;
>>>                   ^~~~~~~~~~~~~
>>>                   MIC_ARRAY_2CH
>>>     AR      sound/i2c/built-in.a
>>>     CC      drivers/bluetooth/btmtksdio.o
>>> ../sound/hda/intel-nhlt.c:90:9: error: ‘NHLT_MIC_ARRAY_VENDOR_DEFINED’ undeclared (first use in this function); did you mean ‘NHLT_MIC_ARRAY_4CH_L_SHAPED’?
>>>       case NHLT_MIC_ARRAY_VENDOR_DEFINED:
>>>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>            NHLT_MIC_ARRAY_4CH_L_SHAPED
>>> ../sound/hda/intel-nhlt.c:92:26: error: dereferencing pointer to incomplete type ‘struct nhlt_vendor_dmic_array_config’
>>>        dmic_geo = cfg_vendor->nb_mics;
>>>                             ^~
>>> ../sound/hda/intel-nhlt.c: At top level:
>>> ../sound/hda/intel-nhlt.c:106:16: error: expected declaration specifiers or ‘...’ before string constant
>>>    MODULE_LICENSE("GPL v2");
>>>                   ^~~~~~~~
>>> ../sound/hda/intel-nhlt.c:107:20: error: expected declaration specifiers or ‘...’ before string constant
>>>    MODULE_DESCRIPTION("Intel NHLT driver");
>>>                       ^~~~~~~~~~~~~~~~~~~
>>> cc1: some warnings being treated as errors
>>> make[3]: *** [../scripts/Makefile.build:266: sound/hda/intel-nhlt.o] Error 1
>>>
>>>
>>>
> 
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
  2019-08-28 22:20       ` Pierre-Louis Bossart
@ 2019-08-28 22:45         ` Pierre-Louis Bossart
  2019-08-28 22:59           ` Randy Dunlap
  2019-08-29 15:08           ` [alsa-devel] " Takashi Iwai
  0 siblings, 2 replies; 16+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-28 22:45 UTC (permalink / raw)
  To: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers


>>> I just checked with Mark Brown's for-next tree 
>>> 8aceffa09b4b9867153bfe0ff6f40517240cee12
>>> and things are fine in i386 mode, see below.
>>>
>>> next-20190828 also works fine for me in i386 mode.
>>>
>>> if you can point me to a tree and configuration that don't work I'll 
>>> look into this, I'd need more info to progress.
>>
>> Please try the attached randconfig file.
>>
>> Thanks for looking.
> 
> Ack, I see some errors as well with this config. Likely a missing 
> dependency somewhere, working on this now.

My bad, I added a fallback with static inline functions in the .h file 
when ACPI is not defined, but the .c file was still compiled.

The diff below makes next-20190828 compile with Randy's config.

It looks like the alsa-devel server is down btw?

diff --git a/sound/hda/Makefile b/sound/hda/Makefile
index 8560f6ef1b19..b3af071ce06b 100644
--- a/sound/hda/Makefile
+++ b/sound/hda/Makefile
@@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
  #extended hda
  obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/

+ifdef CONFIG_ACPI
  snd-intel-nhlt-objs := intel-nhlt.o
  obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
+endif


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
  2019-08-28 22:45         ` Pierre-Louis Bossart
@ 2019-08-28 22:59           ` Randy Dunlap
  2019-08-29  2:26             ` Randy Dunlap
  2019-08-29 15:08           ` [alsa-devel] " Takashi Iwai
  1 sibling, 1 reply; 16+ messages in thread
From: Randy Dunlap @ 2019-08-28 22:59 UTC (permalink / raw)
  To: Pierre-Louis Bossart, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers

On 8/28/19 3:45 PM, Pierre-Louis Bossart wrote:
> 
>>>> I just checked with Mark Brown's for-next tree 8aceffa09b4b9867153bfe0ff6f40517240cee12
>>>> and things are fine in i386 mode, see below.
>>>>
>>>> next-20190828 also works fine for me in i386 mode.
>>>>
>>>> if you can point me to a tree and configuration that don't work I'll look into this, I'd need more info to progress.
>>>
>>> Please try the attached randconfig file.
>>>
>>> Thanks for looking.
>>
>> Ack, I see some errors as well with this config. Likely a missing dependency somewhere, working on this now.
> 
> My bad, I added a fallback with static inline functions in the .h file when ACPI is not defined, but the .c file was still compiled.
> 
> The diff below makes next-20190828 compile with Randy's config.
> 
> It looks like the alsa-devel server is down btw?
> 
> diff --git a/sound/hda/Makefile b/sound/hda/Makefile
> index 8560f6ef1b19..b3af071ce06b 100644
> --- a/sound/hda/Makefile
> +++ b/sound/hda/Makefile
> @@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
>  #extended hda
>  obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
> 
> +ifdef CONFIG_ACPI
>  snd-intel-nhlt-objs := intel-nhlt.o
>  obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
> +endif
> 

works for me.  Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

-- 
~Randy

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
  2019-08-28 22:59           ` Randy Dunlap
@ 2019-08-29  2:26             ` Randy Dunlap
  0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2019-08-29  2:26 UTC (permalink / raw)
  To: Pierre-Louis Bossart, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers

On 8/28/19 3:59 PM, Randy Dunlap wrote:
> On 8/28/19 3:45 PM, Pierre-Louis Bossart wrote:
>>
>>>>> I just checked with Mark Brown's for-next tree 8aceffa09b4b9867153bfe0ff6f40517240cee12
>>>>> and things are fine in i386 mode, see below.
>>>>>
>>>>> next-20190828 also works fine for me in i386 mode.
>>>>>
>>>>> if you can point me to a tree and configuration that don't work I'll look into this, I'd need more info to progress.
>>>>
>>>> Please try the attached randconfig file.
>>>>
>>>> Thanks for looking.
>>>
>>> Ack, I see some errors as well with this config. Likely a missing dependency somewhere, working on this now.
>>
>> My bad, I added a fallback with static inline functions in the .h file when ACPI is not defined, but the .c file was still compiled.
>>
>> The diff below makes next-20190828 compile with Randy's config.
>>
>> It looks like the alsa-devel server is down btw?
>>
>> diff --git a/sound/hda/Makefile b/sound/hda/Makefile
>> index 8560f6ef1b19..b3af071ce06b 100644
>> --- a/sound/hda/Makefile
>> +++ b/sound/hda/Makefile
>> @@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
>>  #extended hda
>>  obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
>>
>> +ifdef CONFIG_ACPI
>>  snd-intel-nhlt-objs := intel-nhlt.o
>>  obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
>> +endif
>>
> 
> works for me.  Thanks.
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> 

although this Makefile change should not be needed
and the dependencies should be handled correctly in Kconfig files.

-- 
~Randy

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen)
  2019-08-28 20:01       ` Josh Poimboeuf
@ 2019-08-29  8:24         ` Peter Zijlstra
  2019-08-29 23:37           ` Josh Poimboeuf
  0 siblings, 1 reply; 16+ messages in thread
From: Peter Zijlstra @ 2019-08-29  8:24 UTC (permalink / raw)
  To: Josh Poimboeuf
  Cc: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr

On Wed, Aug 28, 2019 at 03:01:34PM -0500, Josh Poimboeuf wrote:
> On Wed, Aug 28, 2019 at 10:56:25AM -0700, Randy Dunlap wrote:
> > >> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled
> > > 
> > > Easy one :-)
> > > 
> > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > > index 0c8e17f946cd..6a935ab93149 100644
> > > --- a/tools/objtool/check.c
> > > +++ b/tools/objtool/check.c
> > > @@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = {
> > >  	"ubsan_type_mismatch_common",
> > >  	"__ubsan_handle_type_mismatch",
> > >  	"__ubsan_handle_type_mismatch_v1",
> > > +	"__ubsan_handle_out_of_bounds",
> > >  	/* misc */
> > >  	"csum_partial_copy_generic",
> > >  	"__memcpy_mcsafe",
> > > 
> > 
> > 
> > then I get this one:
> > 
> > lib/ubsan.o: warning: objtool: __ubsan_handle_out_of_bounds()+0x5d: call to ubsan_prologue() with UACCESS enabled
> 
> And of course I jinxed it by calling it easy.
> 
> Peter, how do you want to handle this?
> 
> Should we just disable UACCESS checking in lib/ubsan.c?

No, that is actually unsafe and could break things (as would you patch
above).

I'm thinking the below patch ought to cure things:

---
Subject: x86/uaccess: Don't leak the AC flags into __get_user() argument evalidation

Identical to __put_user(); the __get_user() argument evalution will too
leak UBSAN crud into the __uaccess_begin() / __uaccess_end() region.
While uncommon this was observed to happen for:

  drivers/xen/gntdev.c: if (__get_user(old_status, batch->status[i]))

where UBSAN added array bound checking.

This complements commit:

  6ae865615fc4 ("x86/uaccess: Dont leak the AC flag into __put_user() argument evaluation")

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: luto@kernel.org
---
 arch/x86/include/asm/uaccess.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
index 9c4435307ff8..35c225ede0e4 100644
--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -444,8 +444,10 @@ __pu_label:							\
 ({									\
 	int __gu_err;							\
 	__inttype(*(ptr)) __gu_val;					\
+	__typeof__(ptr) __gu_ptr = (ptr);				\
+	__typeof__(size) __gu_size = (size);				\
 	__uaccess_begin_nospec();					\
-	__get_user_size(__gu_val, (ptr), (size), __gu_err, -EFAULT);	\
+	__get_user_size(__gu_val, __gu_ptr, __gu_size, __gu_err, -EFAULT);	\
 	__uaccess_end();						\
 	(x) = (__force __typeof__(*(ptr)))__gu_val;			\
 	__builtin_expect(__gu_err, 0);					\

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [alsa-devel] mmotm 2019-08-27-20-39 uploaded       (sound/hda/intel-nhlt.c)
  2019-08-28 22:45         ` Pierre-Louis Bossart
  2019-08-28 22:59           ` Randy Dunlap
@ 2019-08-29 15:08           ` Takashi Iwai
  2019-08-29 16:22             ` Pierre-Louis Bossart
  1 sibling, 1 reply; 16+ messages in thread
From: Takashi Iwai @ 2019-08-29 15:08 UTC (permalink / raw)
  To: Pierre-Louis Bossart
  Cc: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers

On Thu, 29 Aug 2019 00:45:05 +0200,
Pierre-Louis Bossart wrote:
> 
> 
> >>> I just checked with Mark Brown's for-next tree
> >>> 8aceffa09b4b9867153bfe0ff6f40517240cee12
> >>> and things are fine in i386 mode, see below.
> >>>
> >>> next-20190828 also works fine for me in i386 mode.
> >>>
> >>> if you can point me to a tree and configuration that don't work
> >>> I'll look into this, I'd need more info to progress.
> >>
> >> Please try the attached randconfig file.
> >>
> >> Thanks for looking.
> >
> > Ack, I see some errors as well with this config. Likely a missing
> > dependency somewhere, working on this now.
> 
> My bad, I added a fallback with static inline functions in the .h file
> when ACPI is not defined, but the .c file was still compiled.
> 
> The diff below makes next-20190828 compile with Randy's config.

IMO, we need to fix the site that enables this config.  i.e.
the "select SND_INTEL_NHLT" must be always conditional, e.g.
	select SND_INTEL_NHLT if ACPI

> It looks like the alsa-devel server is down btw?

Now it seems starting again.


thanks,

Takashi

> diff --git a/sound/hda/Makefile b/sound/hda/Makefile
> index 8560f6ef1b19..b3af071ce06b 100644
> --- a/sound/hda/Makefile
> +++ b/sound/hda/Makefile
> @@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
>  #extended hda
>  obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
> 
> +ifdef CONFIG_ACPI
>  snd-intel-nhlt-objs := intel-nhlt.o
>  obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
> +endif
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [alsa-devel] mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
  2019-08-29 15:08           ` [alsa-devel] " Takashi Iwai
@ 2019-08-29 16:22             ` Pierre-Louis Bossart
  0 siblings, 0 replies; 16+ messages in thread
From: Pierre-Louis Bossart @ 2019-08-29 16:22 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr,
	moderated for non-subscribers



On 8/29/19 10:08 AM, Takashi Iwai wrote:
> On Thu, 29 Aug 2019 00:45:05 +0200,
> Pierre-Louis Bossart wrote:
>>
>>
>>>>> I just checked with Mark Brown's for-next tree
>>>>> 8aceffa09b4b9867153bfe0ff6f40517240cee12
>>>>> and things are fine in i386 mode, see below.
>>>>>
>>>>> next-20190828 also works fine for me in i386 mode.
>>>>>
>>>>> if you can point me to a tree and configuration that don't work
>>>>> I'll look into this, I'd need more info to progress.
>>>>
>>>> Please try the attached randconfig file.
>>>>
>>>> Thanks for looking.
>>>
>>> Ack, I see some errors as well with this config. Likely a missing
>>> dependency somewhere, working on this now.
>>
>> My bad, I added a fallback with static inline functions in the .h file
>> when ACPI is not defined, but the .c file was still compiled.
>>
>> The diff below makes next-20190828 compile with Randy's config.
> 
> IMO, we need to fix the site that enables this config.  i.e.
> the "select SND_INTEL_NHLT" must be always conditional, e.g.
> 	select SND_INTEL_NHLT if ACPI

that would be nicer indeed, currently we don't have a consistent solution:
sound/pci/hda/Kconfig:  select SND_INTEL_NHLT if ACPI
sound/soc/intel/Kconfig:        select SND_INTEL_NHLT
sound/soc/sof/intel/Kconfig:    select SND_INTEL_NHLT

I can't recall why things are different, will send a patch to align.


> 
>> It looks like the alsa-devel server is down btw?
> 
> Now it seems starting again.
> 
> 
> thanks,
> 
> Takashi
> 
>> diff --git a/sound/hda/Makefile b/sound/hda/Makefile
>> index 8560f6ef1b19..b3af071ce06b 100644
>> --- a/sound/hda/Makefile
>> +++ b/sound/hda/Makefile
>> @@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
>>   #extended hda
>>   obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
>>
>> +ifdef CONFIG_ACPI
>>   snd-intel-nhlt-objs := intel-nhlt.o
>>   obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
>> +endif
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen)
  2019-08-29  8:24         ` Peter Zijlstra
@ 2019-08-29 23:37           ` Josh Poimboeuf
  2019-08-30  4:10             ` Sedat Dilek
  0 siblings, 1 reply; 16+ messages in thread
From: Josh Poimboeuf @ 2019-08-29 23:37 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Randy Dunlap, akpm, broonie, linux-fsdevel, linux-kernel,
	linux-mm, linux-next, mhocko, mm-commits, sfr

On Thu, Aug 29, 2019 at 10:24:45AM +0200, Peter Zijlstra wrote:
> On Wed, Aug 28, 2019 at 03:01:34PM -0500, Josh Poimboeuf wrote:
> > On Wed, Aug 28, 2019 at 10:56:25AM -0700, Randy Dunlap wrote:
> > > >> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled
> > > > 
> > > > Easy one :-)
> > > > 
> > > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > > > index 0c8e17f946cd..6a935ab93149 100644
> > > > --- a/tools/objtool/check.c
> > > > +++ b/tools/objtool/check.c
> > > > @@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = {
> > > >  	"ubsan_type_mismatch_common",
> > > >  	"__ubsan_handle_type_mismatch",
> > > >  	"__ubsan_handle_type_mismatch_v1",
> > > > +	"__ubsan_handle_out_of_bounds",
> > > >  	/* misc */
> > > >  	"csum_partial_copy_generic",
> > > >  	"__memcpy_mcsafe",
> > > > 
> > > 
> > > 
> > > then I get this one:
> > > 
> > > lib/ubsan.o: warning: objtool: __ubsan_handle_out_of_bounds()+0x5d: call to ubsan_prologue() with UACCESS enabled
> > 
> > And of course I jinxed it by calling it easy.
> > 
> > Peter, how do you want to handle this?
> > 
> > Should we just disable UACCESS checking in lib/ubsan.c?
> 
> No, that is actually unsafe and could break things (as would you patch
> above).

Oops.  -EFIXINGTOOMANYOBJTOOLISSUESATONCE

> I'm thinking the below patch ought to cure things:
> 
> ---
> Subject: x86/uaccess: Don't leak the AC flags into __get_user() argument evalidation

s/evalidation/evaluation

> Identical to __put_user(); the __get_user() argument evalution will too
> leak UBSAN crud into the __uaccess_begin() / __uaccess_end() region.
> While uncommon this was observed to happen for:
> 
>   drivers/xen/gntdev.c: if (__get_user(old_status, batch->status[i]))
> 
> where UBSAN added array bound checking.
> 
> This complements commit:
> 
>   6ae865615fc4 ("x86/uaccess: Dont leak the AC flag into __put_user() argument evaluation")
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: luto@kernel.org
> ---
>  arch/x86/include/asm/uaccess.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
> index 9c4435307ff8..35c225ede0e4 100644
> --- a/arch/x86/include/asm/uaccess.h
> +++ b/arch/x86/include/asm/uaccess.h
> @@ -444,8 +444,10 @@ __pu_label:							\
>  ({									\
>  	int __gu_err;							\
>  	__inttype(*(ptr)) __gu_val;					\
> +	__typeof__(ptr) __gu_ptr = (ptr);				\
> +	__typeof__(size) __gu_size = (size);				\
>  	__uaccess_begin_nospec();					\
> -	__get_user_size(__gu_val, (ptr), (size), __gu_err, -EFAULT);	\
> +	__get_user_size(__gu_val, __gu_ptr, __gu_size, __gu_err, -EFAULT);	\
>  	__uaccess_end();						\
>  	(x) = (__force __typeof__(*(ptr)))__gu_val;			\
>  	__builtin_expect(__gu_err, 0);					\

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen)
  2019-08-29 23:37           ` Josh Poimboeuf
@ 2019-08-30  4:10             ` Sedat Dilek
  0 siblings, 0 replies; 16+ messages in thread
From: Sedat Dilek @ 2019-08-30  4:10 UTC (permalink / raw)
  To: Josh Poimboeuf
  Cc: Peter Zijlstra, Randy Dunlap, akpm, broonie, linux-fsdevel,
	linux-kernel, linux-mm, linux-next, mhocko, mm-commits, sfr

On Fri, Aug 30, 2019 at 1:38 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> On Thu, Aug 29, 2019 at 10:24:45AM +0200, Peter Zijlstra wrote:
> > On Wed, Aug 28, 2019 at 03:01:34PM -0500, Josh Poimboeuf wrote:
> > > On Wed, Aug 28, 2019 at 10:56:25AM -0700, Randy Dunlap wrote:
> > > > >> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled
> > > > >
> > > > > Easy one :-)
> > > > >
> > > > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > > > > index 0c8e17f946cd..6a935ab93149 100644
> > > > > --- a/tools/objtool/check.c
> > > > > +++ b/tools/objtool/check.c
> > > > > @@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = {
> > > > >         "ubsan_type_mismatch_common",
> > > > >         "__ubsan_handle_type_mismatch",
> > > > >         "__ubsan_handle_type_mismatch_v1",
> > > > > +       "__ubsan_handle_out_of_bounds",
> > > > >         /* misc */
> > > > >         "csum_partial_copy_generic",
> > > > >         "__memcpy_mcsafe",
> > > > >
> > > >
> > > >
> > > > then I get this one:
> > > >
> > > > lib/ubsan.o: warning: objtool: __ubsan_handle_out_of_bounds()+0x5d: call to ubsan_prologue() with UACCESS enabled
> > >
> > > And of course I jinxed it by calling it easy.
> > >
> > > Peter, how do you want to handle this?
> > >
> > > Should we just disable UACCESS checking in lib/ubsan.c?
> >
> > No, that is actually unsafe and could break things (as would you patch
> > above).
>
> Oops.  -EFIXINGTOOMANYOBJTOOLISSUESATONCE
>
> > I'm thinking the below patch ought to cure things:
> >
> > ---
> > Subject: x86/uaccess: Don't leak the AC flags into __get_user() argument evalidation
>
> s/evalidation/evaluation
>
> > Identical to __put_user(); the __get_user() argument evalution will too
> > leak UBSAN crud into the __uaccess_begin() / __uaccess_end() region.
> > While uncommon this was observed to happen for:
> >
> >   drivers/xen/gntdev.c: if (__get_user(old_status, batch->status[i]))
> >
> > where UBSAN added array bound checking.
> >
> > This complements commit:
> >
> >   6ae865615fc4 ("x86/uaccess: Dont leak the AC flag into __put_user() argument evaluation")
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Cc: luto@kernel.org
> > ---
> >  arch/x86/include/asm/uaccess.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
> > index 9c4435307ff8..35c225ede0e4 100644
> > --- a/arch/x86/include/asm/uaccess.h
> > +++ b/arch/x86/include/asm/uaccess.h
> > @@ -444,8 +444,10 @@ __pu_label:                                                      \
> >  ({                                                                   \
> >       int __gu_err;                                                   \
> >       __inttype(*(ptr)) __gu_val;                                     \
> > +     __typeof__(ptr) __gu_ptr = (ptr);                               \
> > +     __typeof__(size) __gu_size = (size);                            \
> >       __uaccess_begin_nospec();                                       \
> > -     __get_user_size(__gu_val, (ptr), (size), __gu_err, -EFAULT);    \
> > +     __get_user_size(__gu_val, __gu_ptr, __gu_size, __gu_err, -EFAULT);      \
> >       __uaccess_end();                                                \
> >       (x) = (__force __typeof__(*(ptr)))__gu_val;                     \
> >       __builtin_expect(__gu_err, 0);                                  \
>
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
>

Tested-by Sedat Dilek <sedat.dilek@gmail.com>

- Sedat -

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2019-08-30  4:11 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-28  3:40 mmotm 2019-08-27-20-39 uploaded akpm
     [not found] ` <8b09d93a-bc42-bd8e-29ee-cd37765f4899@infradead.org>
2019-08-28 17:19   ` mmotm 2019-08-27-20-39 uploaded (objtool: xen) Josh Poimboeuf
2019-08-28 17:56     ` Randy Dunlap
2019-08-28 20:01       ` Josh Poimboeuf
2019-08-29  8:24         ` Peter Zijlstra
2019-08-29 23:37           ` Josh Poimboeuf
2019-08-30  4:10             ` Sedat Dilek
2019-08-28 18:30 ` mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c) Randy Dunlap
2019-08-28 19:28   ` Pierre-Louis Bossart
     [not found]     ` <98ada795-4700-7fcc-6d14-fcc1ab25d509@infradead.org>
2019-08-28 22:20       ` Pierre-Louis Bossart
2019-08-28 22:45         ` Pierre-Louis Bossart
2019-08-28 22:59           ` Randy Dunlap
2019-08-29  2:26             ` Randy Dunlap
2019-08-29 15:08           ` [alsa-devel] " Takashi Iwai
2019-08-29 16:22             ` Pierre-Louis Bossart
     [not found] ` <3e4eba58-7d24-f811-baa1-b6e88334e5a2@infradead.org>
2019-08-28 18:53   ` mmotm 2019-08-27-20-39 uploaded (gpu/drm/amd/display/) Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).