From: Yang Shi <yang.shi@linux.alibaba.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>,
mgorman@techsingularity.net, adilger.kernel@dilger.ca,
darrick.wong@oracle.com, dchinner@redhat.com,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim
Date: Tue, 3 Jul 2018 10:05:04 -0700 [thread overview]
Message-ID: <6c305241-d502-b8ea-a187-54c33e4ca692@linux.alibaba.com> (raw)
In-Reply-To: <20180703103948.GB27426@thunk.org>
On 7/3/18 3:39 AM, Theodore Y. Ts'o wrote:
> On Tue, Jul 03, 2018 at 12:11:18PM +0800, Yang Shi wrote:
>> direct reclaim doesn't write out filesystem page, only kswapd could do
>> it. So, if the call comes from direct reclaim, it is definitely a bug.
>>
>> And, Mel Gormane also mentioned "Ultimately, this will be a BUG_ON." In
>> commit 94054fa3fca1fd78db02cb3d68d5627120f0a1d4 ("xfs: warn if direct
>> reclaim tries to writeback pages").
>>
>> Although it is for xfs, ext4 has the similar behavior, so elevate
>> WARN_ON to BUG_ON.
>>
>> And, correct the comment accordingly.
>>
>> Cc: Mel Gorman <mgorman@techsingularity.net>
>> Cc: "Theodore Ts'o" <tytso@mit.edu>
>> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
>> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> What's the upside of crashing the kernel if the file sytsem can handle it?
I'm not sure if it is a good choice to let filesystem handle such vital
VM regression. IMHO, writing out filesystem page from direct reclaim
context is a vital VM bug. It means something is definitely wrong in VM.
It should never happen.
It sounds ok to have filesystem throw out warning and handle it, but I'm
not sure if someone will just ignore the warning, but it should *never*
be ignored.
Yang
>
> - Ted
next prev parent reply other threads:[~2018-07-03 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 4:11 [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim Yang Shi
2018-07-03 4:11 ` [PATCH 2/2] fs: xfs: " Yang Shi
2018-07-03 4:37 ` Dave Chinner
2018-07-03 17:19 ` Darrick J. Wong
2018-07-03 10:39 ` [PATCH 1/2] fs: ext4: " Theodore Y. Ts'o
2018-07-03 17:05 ` Yang Shi [this message]
2018-07-03 23:10 ` Yang Shi
2018-07-03 23:43 ` Theodore Y. Ts'o
2018-07-04 14:03 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c305241-d502-b8ea-a187-54c33e4ca692@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).