* [PATCH v3 1/3] fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint name
2019-09-20 15:58 [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Eugene Syromiatnikov
@ 2019-09-20 15:58 ` Eugene Syromiatnikov
2019-09-20 15:58 ` [PATCH v3 2/3] drivers/md/raid5.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET Eugene Syromiatnikov
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Eugene Syromiatnikov @ 2019-09-20 15:58 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Viro, Jeff Layton, J. Bruce Fields,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
Shaohua Li, Jens Axboe, linux-raid, Song Liu, linux-fsdevel
According to commit message in the original commit c75b1d9421f8 ("fs:
add fcntl() interface for setting/getting write life time hints"),
as well as userspace library[1] and man page update[2], R/W hint constants
are intended to have RWH_* prefix. However, RWF_WRITE_LIFE_NOT_SET retained
"RWF_*" prefix used in the early versions of the proposed patch set[3].
Rename it and provide the old name as a synonym for the new one
for backward compatibility.
[1] https://github.com/axboe/fio/commit/bd553af6c849
[2] https://github.com/mkerrisk/man-pages/commit/580082a186fd
[3] https://www.mail-archive.com/linux-block@vger.kernel.org/msg09638.html
Fixes: c75b1d9421f8 ("fs: add fcntl() interface for setting/getting write life time hints")
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
---
fs/fcntl.c | 2 +-
include/uapi/linux/fcntl.h | 9 ++++++++-
tools/include/uapi/linux/fcntl.h | 9 ++++++++-
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 3d40771..41b6438 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -261,7 +261,7 @@ static int f_getowner_uids(struct file *filp, unsigned long arg)
static bool rw_hint_valid(enum rw_hint hint)
{
switch (hint) {
- case RWF_WRITE_LIFE_NOT_SET:
+ case RWH_WRITE_LIFE_NOT_SET:
case RWH_WRITE_LIFE_NONE:
case RWH_WRITE_LIFE_SHORT:
case RWH_WRITE_LIFE_MEDIUM:
diff --git a/include/uapi/linux/fcntl.h b/include/uapi/linux/fcntl.h
index 1d33835..1f97b33 100644
--- a/include/uapi/linux/fcntl.h
+++ b/include/uapi/linux/fcntl.h
@@ -58,7 +58,7 @@
* Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be
* used to clear any hints previously set.
*/
-#define RWF_WRITE_LIFE_NOT_SET 0
+#define RWH_WRITE_LIFE_NOT_SET 0
#define RWH_WRITE_LIFE_NONE 1
#define RWH_WRITE_LIFE_SHORT 2
#define RWH_WRITE_LIFE_MEDIUM 3
@@ -66,6 +66,13 @@
#define RWH_WRITE_LIFE_EXTREME 5
/*
+ * The originally introduced spelling is remained from the first
+ * versions of the patch set that introduced the feature, see commit
+ * v4.13-rc1~212^2~51.
+ */
+#define RWF_WRITE_LIFE_NOT_SET RWH_WRITE_LIFE_NOT_SET
+
+/*
* Types of directory notifications that may be requested.
*/
#define DN_ACCESS 0x00000001 /* File accessed */
diff --git a/tools/include/uapi/linux/fcntl.h b/tools/include/uapi/linux/fcntl.h
index 1d33835..1f97b33 100644
--- a/tools/include/uapi/linux/fcntl.h
+++ b/tools/include/uapi/linux/fcntl.h
@@ -58,7 +58,7 @@
* Valid hint values for F_{GET,SET}_RW_HINT. 0 is "not set", or can be
* used to clear any hints previously set.
*/
-#define RWF_WRITE_LIFE_NOT_SET 0
+#define RWH_WRITE_LIFE_NOT_SET 0
#define RWH_WRITE_LIFE_NONE 1
#define RWH_WRITE_LIFE_SHORT 2
#define RWH_WRITE_LIFE_MEDIUM 3
@@ -66,6 +66,13 @@
#define RWH_WRITE_LIFE_EXTREME 5
/*
+ * The originally introduced spelling is remained from the first
+ * versions of the patch set that introduced the feature, see commit
+ * v4.13-rc1~212^2~51.
+ */
+#define RWF_WRITE_LIFE_NOT_SET RWH_WRITE_LIFE_NOT_SET
+
+/*
* Types of directory notifications that may be requested.
*/
#define DN_ACCESS 0x00000001 /* File accessed */
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 2/3] drivers/md/raid5.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET
2019-09-20 15:58 [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Eugene Syromiatnikov
2019-09-20 15:58 ` [PATCH v3 1/3] fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint name Eugene Syromiatnikov
@ 2019-09-20 15:58 ` Eugene Syromiatnikov
2019-09-20 15:58 ` [PATCH v3 3/3] drivers/md/raid5-ppl.c: " Eugene Syromiatnikov
2019-10-01 23:12 ` [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Song Liu
3 siblings, 0 replies; 9+ messages in thread
From: Eugene Syromiatnikov @ 2019-09-20 15:58 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Viro, Jeff Layton, J. Bruce Fields,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
Shaohua Li, Jens Axboe, linux-raid, Song Liu, linux-fsdevel
As it is consistent with prefixes of other write life time hints.
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
---
drivers/md/raid5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 223e97a..2f71f6f 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -1134,7 +1134,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
bi->bi_iter.bi_size = STRIPE_SIZE;
bi->bi_write_hint = sh->dev[i].write_hint;
if (!rrdev)
- sh->dev[i].write_hint = RWF_WRITE_LIFE_NOT_SET;
+ sh->dev[i].write_hint = RWH_WRITE_LIFE_NOT_SET;
/*
* If this is discard request, set bi_vcnt 0. We don't
* want to confuse SCSI because SCSI will replace payload
@@ -1187,7 +1187,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
rbi->bi_io_vec[0].bv_offset = 0;
rbi->bi_iter.bi_size = STRIPE_SIZE;
rbi->bi_write_hint = sh->dev[i].write_hint;
- sh->dev[i].write_hint = RWF_WRITE_LIFE_NOT_SET;
+ sh->dev[i].write_hint = RWH_WRITE_LIFE_NOT_SET;
/*
* If this is discard request, set bi_vcnt 0. We don't
* want to confuse SCSI because SCSI will replace payload
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 3/3] drivers/md/raid5-ppl.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET
2019-09-20 15:58 [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Eugene Syromiatnikov
2019-09-20 15:58 ` [PATCH v3 1/3] fcntl: fix typo in RWH_WRITE_LIFE_NOT_SET r/w hint name Eugene Syromiatnikov
2019-09-20 15:58 ` [PATCH v3 2/3] drivers/md/raid5.c: use the new spelling of RWH_WRITE_LIFE_NOT_SET Eugene Syromiatnikov
@ 2019-09-20 15:58 ` Eugene Syromiatnikov
2019-10-01 23:12 ` [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Song Liu
3 siblings, 0 replies; 9+ messages in thread
From: Eugene Syromiatnikov @ 2019-09-20 15:58 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Viro, Jeff Layton, J. Bruce Fields,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
Shaohua Li, Jens Axboe, linux-raid, Song Liu, linux-fsdevel
As it is consistent with prefixes of other write life time hints.
Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
---
drivers/md/raid5-ppl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index 18a4064..cab5b13 100644
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -1404,7 +1404,7 @@ int ppl_init_log(struct r5conf *conf)
atomic64_set(&ppl_conf->seq, 0);
INIT_LIST_HEAD(&ppl_conf->no_mem_stripes);
spin_lock_init(&ppl_conf->no_mem_stripes_lock);
- ppl_conf->write_hint = RWF_WRITE_LIFE_NOT_SET;
+ ppl_conf->write_hint = RWH_WRITE_LIFE_NOT_SET;
if (!mddev->external) {
ppl_conf->signature = ~crc32c_le(~0, mddev->uuid, sizeof(mddev->uuid));
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name
2019-09-20 15:58 [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Eugene Syromiatnikov
` (2 preceding siblings ...)
2019-09-20 15:58 ` [PATCH v3 3/3] drivers/md/raid5-ppl.c: " Eugene Syromiatnikov
@ 2019-10-01 23:12 ` Song Liu
2019-10-02 0:55 ` Jens Axboe
3 siblings, 1 reply; 9+ messages in thread
From: Song Liu @ 2019-10-01 23:12 UTC (permalink / raw)
To: Eugene Syromiatnikov
Cc: open list, Alexander Viro, Jeff Layton, J. Bruce Fields,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
Shaohua Li, Jens Axboe, linux-raid, Linux-Fsdevel
On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> Hello.
>
> This is a small fix of a typo (or, more specifically, some remnant of
> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
> with "H" is used in man page and everywhere else, it's probably worth
> to make the name used in the fcntl.h UAPI header in line with it.
> The two follow-up patches update usage sites of this constant in kernel
> to use the new spelling.
>
> The old name is retained as it is part of UAPI now.
>
> Changes since v2[1]:
> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
> in drivers/md/raid5-ppl.c:ppl_init_log().
>
> Changes since v1[2]:
> * Changed format of the commit ID in the commit message of the first patch.
> * Removed bogus Signed-off-by that snuck into the resend of the series.
Applied to md-next.
Thanks,
Song
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name
2019-10-01 23:12 ` [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name Song Liu
@ 2019-10-02 0:55 ` Jens Axboe
2019-10-02 16:55 ` Song Liu
0 siblings, 1 reply; 9+ messages in thread
From: Jens Axboe @ 2019-10-02 0:55 UTC (permalink / raw)
To: Song Liu, Eugene Syromiatnikov
Cc: open list, Alexander Viro, Jeff Layton, J. Bruce Fields,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
Shaohua Li, linux-raid, Linux-Fsdevel
On 10/1/19 5:12 PM, Song Liu wrote:
> On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>>
>> Hello.
>>
>> This is a small fix of a typo (or, more specifically, some remnant of
>> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
>> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
>> with "H" is used in man page and everywhere else, it's probably worth
>> to make the name used in the fcntl.h UAPI header in line with it.
>> The two follow-up patches update usage sites of this constant in kernel
>> to use the new spelling.
>>
>> The old name is retained as it is part of UAPI now.
>>
>> Changes since v2[1]:
>> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
>> in drivers/md/raid5-ppl.c:ppl_init_log().
>>
>> Changes since v1[2]:
>> * Changed format of the commit ID in the commit message of the first patch.
>> * Removed bogus Signed-off-by that snuck into the resend of the series.
>
> Applied to md-next.
I think the core fs change should core in through a core tree, then
the md bits can go in at will after that.
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name
2019-10-02 0:55 ` Jens Axboe
@ 2019-10-02 16:55 ` Song Liu
2019-10-16 17:00 ` Song Liu
0 siblings, 1 reply; 9+ messages in thread
From: Song Liu @ 2019-10-02 16:55 UTC (permalink / raw)
To: Jens Axboe
Cc: Eugene Syromiatnikov, open list, Alexander Viro, Jeff Layton,
J. Bruce Fields, Arnaldo Carvalho de Melo, Greg Kroah-Hartman,
Ingo Molnar, Shaohua Li, linux-raid, Linux-Fsdevel
On Tue, Oct 1, 2019 at 5:55 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 10/1/19 5:12 PM, Song Liu wrote:
> > On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <esyr@redhat.com> wrote:
> >>
> >> Hello.
> >>
> >> This is a small fix of a typo (or, more specifically, some remnant of
> >> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> >> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
> >> with "H" is used in man page and everywhere else, it's probably worth
> >> to make the name used in the fcntl.h UAPI header in line with it.
> >> The two follow-up patches update usage sites of this constant in kernel
> >> to use the new spelling.
> >>
> >> The old name is retained as it is part of UAPI now.
> >>
> >> Changes since v2[1]:
> >> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
> >> in drivers/md/raid5-ppl.c:ppl_init_log().
> >>
> >> Changes since v1[2]:
> >> * Changed format of the commit ID in the commit message of the first patch.
> >> * Removed bogus Signed-off-by that snuck into the resend of the series.
> >
> > Applied to md-next.
>
> I think the core fs change should core in through a core tree, then
> the md bits can go in at will after that.
Good point. I guess I will wait until it shows up in for-5.5/block?
Song
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name
2019-10-02 16:55 ` Song Liu
@ 2019-10-16 17:00 ` Song Liu
2019-10-25 20:21 ` Jens Axboe
0 siblings, 1 reply; 9+ messages in thread
From: Song Liu @ 2019-10-16 17:00 UTC (permalink / raw)
To: Jens Axboe, Jeff Layton, J. Bruce Fields
Cc: Eugene Syromiatnikov, open list, Alexander Viro,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
linux-raid, Linux-Fsdevel
Hi Jeff and J. Bruce,
On Wed, Oct 2, 2019 at 9:55 AM Song Liu <liu.song.a23@gmail.com> wrote:
>
> On Tue, Oct 1, 2019 at 5:55 PM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > On 10/1/19 5:12 PM, Song Liu wrote:
> > > On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <esyr@redhat.com> wrote:
> > >>
> > >> Hello.
> > >>
> > >> This is a small fix of a typo (or, more specifically, some remnant of
> > >> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
> > >> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
> > >> with "H" is used in man page and everywhere else, it's probably worth
> > >> to make the name used in the fcntl.h UAPI header in line with it.
> > >> The two follow-up patches update usage sites of this constant in kernel
> > >> to use the new spelling.
> > >>
> > >> The old name is retained as it is part of UAPI now.
> > >>
> > >> Changes since v2[1]:
> > >> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
> > >> in drivers/md/raid5-ppl.c:ppl_init_log().
> > >>
> > >> Changes since v1[2]:
> > >> * Changed format of the commit ID in the commit message of the first patch.
> > >> * Removed bogus Signed-off-by that snuck into the resend of the series.
> > >
> > > Applied to md-next.
> >
> > I think the core fs change should core in through a core tree, then
> > the md bits can go in at will after that.
As Jens suggested, we should route core fs patches through core tree. Could
you please apply these patches? Since the change is small, probably you can
also apply md patches?
Thanks,
Song
PS: for the series:
Acked-by: Song Liu <songliubraving@fb.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/3] Fix typo in RWH_WRITE_LIFE_NOT_SET constant name
2019-10-16 17:00 ` Song Liu
@ 2019-10-25 20:21 ` Jens Axboe
0 siblings, 0 replies; 9+ messages in thread
From: Jens Axboe @ 2019-10-25 20:21 UTC (permalink / raw)
To: Song Liu, Jeff Layton, J. Bruce Fields
Cc: Eugene Syromiatnikov, open list, Alexander Viro,
Arnaldo Carvalho de Melo, Greg Kroah-Hartman, Ingo Molnar,
linux-raid, Linux-Fsdevel
On 10/16/19 11:00 AM, Song Liu wrote:
> Hi Jeff and J. Bruce,
>
> On Wed, Oct 2, 2019 at 9:55 AM Song Liu <liu.song.a23@gmail.com> wrote:
>>
>> On Tue, Oct 1, 2019 at 5:55 PM Jens Axboe <axboe@kernel.dk> wrote:
>>>
>>> On 10/1/19 5:12 PM, Song Liu wrote:
>>>> On Fri, Sep 20, 2019 at 8:58 AM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>>>>>
>>>>> Hello.
>>>>>
>>>>> This is a small fix of a typo (or, more specifically, some remnant of
>>>>> the old patch version spelling) in RWH_WRITE_LIFE_NOT_SET constant,
>>>>> which is named as RWF_WRITE_LIFE_NOT_SET currently. Since the name
>>>>> with "H" is used in man page and everywhere else, it's probably worth
>>>>> to make the name used in the fcntl.h UAPI header in line with it.
>>>>> The two follow-up patches update usage sites of this constant in kernel
>>>>> to use the new spelling.
>>>>>
>>>>> The old name is retained as it is part of UAPI now.
>>>>>
>>>>> Changes since v2[1]:
>>>>> * Updated RWF_WRITE_LIFE_NOT_SET constant usage
>>>>> in drivers/md/raid5-ppl.c:ppl_init_log().
>>>>>
>>>>> Changes since v1[2]:
>>>>> * Changed format of the commit ID in the commit message of the first patch.
>>>>> * Removed bogus Signed-off-by that snuck into the resend of the series.
>>>>
>>>> Applied to md-next.
>>>
>>> I think the core fs change should core in through a core tree, then
>>> the md bits can go in at will after that.
>
> As Jens suggested, we should route core fs patches through core tree. Could
> you please apply these patches? Since the change is small, probably you can
> also apply md patches?
>
> Thanks,
> Song
>
> PS: for the series:
>
> Acked-by: Song Liu <songliubraving@fb.com>
I applied 1/3 to the for-5.5/block core branch.
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread