From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Frank Sorenson <sorenson@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH V2 2/4] fat: add functions to update and truncate timestamps appropriately
Date: Fri, 28 Sep 2018 19:31:21 +0900 [thread overview]
Message-ID: <87wor5eww6.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20180926224335.5919-3-sorenson@redhat.com> (Frank Sorenson's message of "Wed, 26 Sep 2018 17:43:33 -0500")
Frank Sorenson <sorenson@redhat.com> writes:
> + if (inode->i_ino == MSDOS_ROOT_INO)
> + return 0;
> + if (flags & S_MTIME)
> + inode->i_mtime = (struct timespec64){ now->tv_sec & ~1, 0 };
> + inode->i_mtime = fat_timespec64_trunc_2secs(*now);
Looks like the patch is broken. Sent wrong patch?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2018-09-28 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 22:43 [PATCH V4 0/4] fat: timestamp updates Frank Sorenson
2018-09-26 22:43 ` [PATCH V4 1/4] fat: create a function to calculate the timezone offest Frank Sorenson
2018-09-26 22:43 ` [PATCH V2 2/4] fat: add functions to update and truncate timestamps appropriately Frank Sorenson
2018-09-28 10:31 ` OGAWA Hirofumi [this message]
2018-09-26 22:43 ` [PATCH V4 3/4] fat: change timestamp updates to use fat_truncate_time Frank Sorenson
2018-09-26 22:43 ` [PATCH V4 4/4] fat: truncate inode timestamp updates in setattr Frank Sorenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wor5eww6.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sorenson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).