From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Dave Chinner <david@fromorbit.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
James Morris <james.l.morris@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
"Theodore Ts'o" <tytso@mit.edu>, stable <stable@vger.kernel.org>,
Paul Moore <paul@paul-moore.com>,
LKML <linux-kernel@vger.kernel.org>,
Matthew Wilcox <matthew@wil.cx>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission()
Date: Fri, 10 Jan 2014 08:18:18 +0800 [thread overview]
Message-ID: <CA+55aFwVNAKAqyR8gA+pewz2qSjDCq2w+NwN-vmChoMKSz-idg@mail.gmail.com> (raw)
In-Reply-To: <20140110000642.GN10323@ZenIV.linux.org.uk>
On Fri, Jan 10, 2014 at 8:06 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Sure, we can separate the simple "just do call_rcu(...->free_inode)" case
> and hit it whenever full ->free_inode is there and ->destroy_inode isn't.
> Not too pretty, but removal of tons of boilerplate might be worth doing
> that anyway.
Yeah.
> But ->destroy_inode() is still needed for cases where fs
> has its own idea of inode lifetime rules. Again, check what XFS is doing
> in that area...
Ok, so we can't change destroy_inode, and we'd need to add a new op
for just freeing it.
Painful mainly because there are so many filesystems, but it shouldn't
be *complicated*.
> There's an extra source of headache, BTW - what about the "LSM stacking"
> crowd and their plans?
LSM stacking is a pipedream right now anyway, isn't it? It's been
talked about for years and years, I've never seen a patch-set that is
even remotely something we'd seriously consider.
Linus
next prev parent reply other threads:[~2014-01-10 0:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:27 [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission() Steven Rostedt
2014-01-09 21:42 ` Matthew Wilcox
2014-01-09 21:50 ` Steven Rostedt
2014-01-09 22:31 ` Al Viro
[not found] ` <CA+55aFzCTPYEQCPnLBi1CwmMTocVqCFiCuJ391HkVx1CMw61ug@mail.gmail.com>
2014-01-09 23:10 ` Paul E. McKenney
2014-01-09 23:25 ` Steven Rostedt
2014-01-09 23:27 ` Steven Rostedt
2014-01-09 23:37 ` Eric Paris
2014-01-09 23:45 ` Steven Rostedt
2014-01-09 23:53 ` Linus Torvalds
2014-01-10 0:06 ` Al Viro
2014-01-10 0:09 ` Al Viro
2014-01-10 0:18 ` Linus Torvalds [this message]
2014-01-10 2:36 ` James Morris
2014-01-10 9:31 ` Christoph Hellwig
2014-01-10 18:14 ` Ben Myers
2014-01-11 10:32 ` Christoph Hellwig
2014-01-09 23:45 ` Paul E. McKenney
2014-01-09 23:59 ` Steven Rostedt
2014-01-10 0:44 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFwVNAKAqyR8gA+pewz2qSjDCq2w+NwN-vmChoMKSz-idg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=james.l.morris@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paul@paul-moore.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=sds@tycho.nsa.gov \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).