From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC][PATCH] rmdir(),rename(): do shrink_dcache_parent() only on success
Date: Sun, 27 May 2018 16:04:37 -0700 [thread overview]
Message-ID: <CA+55aFwW5VtwanEVdUQH5MrE9iqP2LqvK6fPmHW1pRS+_T=RXA@mail.gmail.com> (raw)
In-Reply-To: <20180527222029.GR30522@ZenIV.linux.org.uk>
On Sun, May 27, 2018 at 3:20 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> We should've done that call right *after* successful ->rmdir(). That
> reduces contention caused by tree-walking in shrink_dcache_parent()
> and, especially, contention caused by evictions in two nested subtrees
> going on in parallel. The same goes for directory-overwriting rename() -
> the story there had been parallel to that of rmdir().
Looks eminently sane to me.
Linus
next prev parent reply other threads:[~2018-05-27 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-27 22:20 [RFC][PATCH] rmdir(),rename(): do shrink_dcache_parent() only on success Al Viro
2018-05-27 23:04 ` Linus Torvalds [this message]
2018-05-28 2:14 ` Andreas Dilger
2018-05-28 2:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwW5VtwanEVdUQH5MrE9iqP2LqvK6fPmHW1pRS+_T=RXA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).