From: Marc Dionne <marc.dionne@auristor.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] afs: Fix setting of writeback_index
Date: Wed, 21 Jul 2021 09:52:45 -0300 [thread overview]
Message-ID: <CAB9dFduhRHzZCRBenqLsPPYe+ba19TnX6ftooSVgjSULCnLH9w@mail.gmail.com> (raw)
In-Reply-To: <162610728339.3408253.4604750166391496546.stgit@warthog.procyon.org.uk>
On Mon, Jul 12, 2021 at 1:28 PM David Howells <dhowells@redhat.com> wrote:
>
> Fix afs_writepages() to always set mapping->writeback_index to a page index
> and not a byte position[1].
>
> Fixes: 31143d5d515e ("AFS: implement basic file write support")
> Reported-by: Marc Dionne <marc.dionne@auristor.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com/ [1]
> cc: linux-afs@lists.infradead.org
> ---
>
> fs/afs/write.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/afs/write.c b/fs/afs/write.c
> index 1ed62e0ccfe5..c0534697268e 100644
> --- a/fs/afs/write.c
> +++ b/fs/afs/write.c
> @@ -784,7 +784,7 @@ int afs_writepages(struct address_space *mapping,
> } else if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX) {
> ret = afs_writepages_region(mapping, wbc, 0, LLONG_MAX, &next);
> if (wbc->nr_to_write > 0 && ret == 0)
> - mapping->writeback_index = next;
> + mapping->writeback_index = next / PAGE_SIZE;
> } else {
> ret = afs_writepages_region(mapping, wbc,
> wbc->range_start, wbc->range_end, &next);
>
>
>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Marc
next prev parent reply other threads:[~2021-07-21 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 16:27 [PATCH v2 0/4] afs: Miscellaneous fixes David Howells
2021-07-12 16:27 ` [PATCH v2 1/4] afs: Fix tracepoint string placement with built-in AFS David Howells
2021-07-12 19:27 ` Marc Dionne
2021-07-12 16:27 ` [PATCH v2 2/4] afs: check function return David Howells
2021-07-21 12:59 ` Marc Dionne
2021-07-12 16:28 ` [PATCH v2 3/4] afs: Fix setting of writeback_index David Howells
2021-07-21 12:52 ` Marc Dionne [this message]
2021-07-12 16:28 ` [PATCH v2 4/4] afs: Remove redundant assignment to ret David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB9dFduhRHzZCRBenqLsPPYe+ba19TnX6ftooSVgjSULCnLH9w@mail.gmail.com \
--to=marc.dionne@auristor.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).