From: Marc Dionne <marc.c.dionne@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, Tom Rix <trix@redhat.com>,
linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] afs: check function return
Date: Mon, 12 Jul 2021 11:20:47 -0300 [thread overview]
Message-ID: <CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com> (raw)
In-Reply-To: <162609464716.3133237.10354897554363093252.stgit@warthog.procyon.org.uk>
On Mon, Jul 12, 2021 at 9:57 AM David Howells <dhowells@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> Static analysis reports this problem
>
> write.c:773:29: warning: Assigned value is garbage or undefined
> mapping->writeback_index = next;
> ^ ~~~~
> The call to afs_writepages_region() can return without setting
> next. So check the function return before using next.
>
> Fixes: e87b03f5830e ("afs: Prepare for use of THPs")
> Signed-off-by: Tom Rix <trix@redhat.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Link: https://lore.kernel.org/r/20210430155031.3287870-1-trix@redhat.com
> ---
>
> fs/afs/write.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/afs/write.c b/fs/afs/write.c
> index 3104b62c2082..2794147f82ff 100644
> --- a/fs/afs/write.c
> +++ b/fs/afs/write.c
> @@ -777,7 +777,7 @@ int afs_writepages(struct address_space *mapping,
> mapping->writeback_index = next / PAGE_SIZE;
Isn't there the same issue with the use of next here.
> } else if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX) {
> ret = afs_writepages_region(mapping, wbc, 0, LLONG_MAX, &next);
> - if (wbc->nr_to_write > 0)
> + if (wbc->nr_to_write > 0 && ret == 0)
> mapping->writeback_index = next;
Unrelated to this patch, but since next is a byte offset, should this
also divide by PAGE_SIZE as above.
> } else {
> ret = afs_writepages_region(mapping, wbc,
>
>
Marc
next prev parent reply other threads:[~2021-07-12 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 12:57 [PATCH 0/3] afs: Miscellaneous fixes David Howells
2021-07-12 12:57 ` [PATCH 1/3] afs: Fix tracepoint string placement with built-in AFS David Howells
2021-07-12 12:57 ` [PATCH 2/3] afs: check function return David Howells
2021-07-12 14:20 ` Marc Dionne [this message]
2021-07-12 15:21 ` David Howells
2021-07-12 12:57 ` [PATCH 3/3] afs: Remove redundant assignment to ret David Howells
2021-07-12 14:04 ` Marc Dionne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com \
--to=marc.c.dionne@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.