From: Paul Moore <paul@paul-moore.com>
To: Richard Guy Briggs <rgb@redhat.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-Audit Mailing List <linux-audit@redhat.com>
Subject: Re: [PATCH ghak100 V2 2/2] audit: ignore fcaps on umount
Date: Wed, 30 Jan 2019 21:20:42 -0500 [thread overview]
Message-ID: <CAHC9VhS1JLd-vuhh8jba4wgiH2GZUiF4ayLqh=61w1Z1aYvMqA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhSGmTKOAXA74_zcBWn=wL1LAxnx91Wv7v9d49Y-QskWBg@mail.gmail.com>
On Mon, Jan 28, 2019 at 6:25 PM Paul Moore <paul@paul-moore.com> wrote:
> On Fri, Jan 25, 2019 at 5:27 PM Richard Guy Briggs <rgb@redhat.com> wrote:
> > On 2019-01-25 16:45, Paul Moore wrote:
> > > On Wed, Jan 23, 2019 at 1:35 PM Richard Guy Briggs <rgb@redhat.com> wrote:
> > > > Don't fetch fcaps when umount2 is called to avoid a process hang while
> > > > it waits for the missing resource to (possibly never) re-appear.
> > > >
> > > > Note the comment above user_path_mountpoint_at():
> > > > * A umount is a special case for path walking. We're not actually interested
> > > > * in the inode in this situation, and ESTALE errors can be a problem. We
> > > > * simply want track down the dentry and vfsmount attached at the mountpoint
> > > > * and avoid revalidating the last component.
> > > >
> > > > This can happen on ceph, cifs, 9p, lustre, fuse (gluster) or NFS.
> > > >
> > > > Please see the github issue tracker
> > > > https://github.com/linux-audit/audit-kernel/issues/100
> > > >
> > > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > > > ---
> > > > fs/namei.c | 2 +-
> > > > fs/namespace.c | 2 ++
> > > > include/linux/audit.h | 15 ++++++++++-----
> > > > include/linux/namei.h | 3 +++
> > > > kernel/audit.c | 10 +++++++++-
> > > > kernel/audit.h | 2 +-
> > > > kernel/auditsc.c | 6 +++---
> > > > 7 files changed, 29 insertions(+), 11 deletions(-)
...
> You posted this patch on the 23rd (last Wednesday), let's give the FS
> folks another day or two to comment since it does touch their code.
> If we don't see any objections by later this week I'll merge it into
> audit/next.
I'm not seeing any objections from the fs folks, so I'm merging this
into audit/next.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2019-01-31 2:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 18:34 [PATCH ghak100 V2 0/2] audit: avoid umount hangs on missing mount Richard Guy Briggs
2019-01-23 18:34 ` [PATCH ghak100 V2 1/2] audit: more filter PATH records keyed on filesystem magic Richard Guy Briggs
2019-01-25 21:36 ` Paul Moore
2019-01-23 18:35 ` [PATCH ghak100 V2 2/2] audit: ignore fcaps on umount Richard Guy Briggs
2019-01-25 21:45 ` Paul Moore
2019-01-25 22:27 ` Richard Guy Briggs
2019-01-28 23:25 ` Paul Moore
2019-01-31 2:20 ` Paul Moore [this message]
2019-02-01 20:42 ` Nathan Chancellor
2019-02-01 21:05 ` Paul Moore
2019-02-01 21:57 ` Richard Guy Briggs
2019-02-01 22:27 ` Paul Moore
2019-02-01 22:49 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhS1JLd-vuhh8jba4wgiH2GZUiF4ayLqh=61w1Z1aYvMqA@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).