Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
From: Namjae Jeon <linkinjeon@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Namjae Jeon <namjae.jeon@samsung.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
	sj1557.seo@samsung.com, arnd@arndb.de
Subject: Re: [PATCH v10 05/14] exfat: add file operations
Date: Fri, 17 Jan 2020 20:12:26 +0800
Message-ID: <CAKYAXd9mcsZYp_EuPx_5KACW7oPvtTmWmxHgCsy1PgOZskJjyg@mail.gmail.com> (raw)
In-Reply-To: <20200117091813.wiksrz5khmtoocbj@pali>

2020-01-17 17:18 GMT+08:00, Pali Rohár <pali.rohar@gmail.com>:
> On Wednesday 15 January 2020 17:24:38 Namjae Jeon wrote:
>> This adds the implementation of file operations for exfat.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
>> ---
>>  fs/exfat/file.c | 355 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 355 insertions(+)
>>  create mode 100644 fs/exfat/file.c
>>
>> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
>> new file mode 100644
>> index 000000000000..b4b8af0cae0a
>> --- /dev/null
>> +++ b/fs/exfat/file.c
>
> ...
>
>> +/* resize the file length */
>> +int __exfat_truncate(struct inode *inode, loff_t new_size)
>> +{
>
> ...
>
>> +
>> +		ktime_get_real_ts64(&ts);
>> +		exfat_set_entry_time(sbi, &ts,
>> +				&ep->dentry.file.modify_time,
>> +				&ep->dentry.file.modify_date,
>> +				&ep->dentry.file.modify_tz);
>
> Hello! Now I spotted that you forgot to update "modify_time_ms" entry.
Good catch:)
>
> To prevent this problem, maybe function modify_time_ms() could take
> another (optional) parameter for specifying time_ms?
Okay, I will change exfat_set/get_entry_time to take a time_ms argument.
Thanks for your review!

  reply index

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200115082818epcas1p4892a99345626188afd111ee263132458@epcas1p4.samsung.com>
2020-01-15  8:24 ` [PATCH v10 00/14] add the latest exfat driver Namjae Jeon
     [not found]   ` <CGME20200115082819epcas1p3303009557f8bf670b47991530f380ef7@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 01/14] exfat: add in-memory and on-disk structures and headers Namjae Jeon
     [not found]   ` <CGME20200115082819epcas1p3825d5bed592a8378ad26254d07d59b18@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 02/14] exfat: add super block operations Namjae Jeon
     [not found]   ` <CGME20200115082820epcas1p34ebebebaf610fd61c4e9882fca8ddbd5@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 03/14] exfat: add inode operations Namjae Jeon
2020-01-15 10:25       ` Arnd Bergmann
2020-01-15 13:39         ` Namjae Jeon
2020-01-17  9:25       ` Pali Rohár
2020-01-17 11:17       ` Pali Rohár
     [not found]   ` <CGME20200115082821epcas1p3db1f70cf53185c40934c3a754c65e648@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 04/14] exfat: add directory operations Namjae Jeon
2020-01-17 11:13       ` Pali Rohár
     [not found]   ` <CGME20200115082821epcas1p4d76d8668dfac70ae3e3889d4ccb6c3ee@epcas1p4.samsung.com>
2020-01-15  8:24     ` [PATCH v10 05/14] exfat: add file operations Namjae Jeon
2020-01-15  9:56       ` Arnd Bergmann
2020-01-15 13:07         ` Namjae Jeon
2020-01-17  9:18       ` Pali Rohár
2020-01-17 12:12         ` Namjae Jeon [this message]
     [not found]   ` <CGME20200115082822epcas1p37aca37dad0aa9159d7eddde01edfeec2@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 06/14] exfat: add fat entry operations Namjae Jeon
     [not found]   ` <CGME20200115082822epcas1p384d080724d8bb0a8cd4c3e3015a0895c@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 07/14] exfat: add bitmap operations Namjae Jeon
     [not found]   ` <CGME20200115082823epcas1p27ec5ff6d384f148d826529f573173b04@epcas1p2.samsung.com>
2020-01-15  8:24     ` [PATCH v10 08/14] exfat: add exfat cache Namjae Jeon
     [not found]   ` <CGME20200115082824epcas1p4eb45d088c2f88149acb94563c4a9b276@epcas1p4.samsung.com>
2020-01-15  8:24     ` [PATCH v10 09/14] exfat: add misc operations Namjae Jeon
2020-01-15 10:10       ` Arnd Bergmann
2020-01-15 13:30         ` Namjae Jeon
2020-01-15 13:38           ` Pali Rohár
2020-01-15 13:50             ` Arnd Bergmann
2020-01-15 14:24               ` Pali Rohár
2020-01-15 15:03                 ` Arnd Bergmann
2020-01-15 15:39                   ` Pali Rohár
2020-01-15 15:52                     ` Arnd Bergmann
2020-01-16 10:19                       ` Pali Rohár
2020-01-16 10:23                         ` Christoph Hellwig
2020-01-16 16:00                           ` Pali Rohár
2020-01-17  2:59                       ` Namjae Jeon
2020-01-17 10:13                         ` Arnd Bergmann
2020-01-17 12:13                           ` Namjae Jeon
     [not found]   ` <CGME20200115082824epcas1p23a0fa255a5833c6dcd2479b384f37740@epcas1p2.samsung.com>
2020-01-15  8:24     ` [PATCH v10 10/14] exfat: add nls operations Namjae Jeon
     [not found]   ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>
2020-01-15  8:24     ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon
2020-01-15  9:39       ` Pali Rohár
2020-01-17  4:22         ` Namjae Jeon
2020-01-17  9:12           ` Pali Rohár
2020-01-17 11:59             ` Namjae Jeon
     [not found]   ` <CGME20200115082825epcas1p4a0d63d53d8737a84fe8867bc1e63811e@epcas1p4.samsung.com>
2020-01-15  8:24     ` [PATCH v10 12/14] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
     [not found]   ` <CGME20200115082826epcas1p117191a39ecccaef5a9b5cbe77b05c5a5@epcas1p1.samsung.com>
2020-01-15  8:24     ` [PATCH v10 13/14] MAINTAINERS: add exfat filesystem Namjae Jeon
     [not found]   ` <CGME20200115082826epcas1p3475ce2b4d03234dc96ced428be582eb3@epcas1p3.samsung.com>
2020-01-15  8:24     ` [PATCH v10 14/14] staging: exfat: make staging/exfat and fs/exfat mutually exclusive Namjae Jeon
2020-01-15  8:56       ` Greg KH
2020-01-15 13:06         ` Namjae Jeon
2020-01-15  9:47   ` [PATCH v10 00/14] add the latest exfat driver Pali Rohár
2020-01-15 13:05     ` Namjae Jeon
2020-01-16 10:51     ` Christoph Hellwig
2020-01-16 11:32       ` Pali Rohár
2020-01-16 13:01       ` Greg KH

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKYAXd9mcsZYp_EuPx_5KACW7oPvtTmWmxHgCsy1PgOZskJjyg@mail.gmail.com \
    --to=linkinjeon@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=pali.rohar@gmail.com \
    --cc=sj1557.seo@samsung.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git