archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <>
To: shankarapailoor <>,
	linux-fsdevel <>
Cc: David Miller <>,
	LKML <>,
	syzkaller <>,
	Linux Kernel Network Developers <>
Subject: Re: general protection fault in sockfs_setattr
Date: Wed, 6 Jun 2018 11:21:07 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Jun 5, 2018 at 7:19 PM, shankarapailoor
<> wrote:
> Hi Cong,
> I added that check and it seems to stop the crash. Like you said, I
> don't see where the reference count for the file is increased. The
> inode lock also seems to be held during this call.

I know inode lock is held for ->setattr(), but not for ->release(), this
is why I suspect sock_close() could still race with sockfs_setattr()
after my patch.

I am not sure if it is crazy to just hold fd refcnt for fchmodat() too..

      parent reply	other threads:[~2018-06-06 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
     [not found]   ` <>
     [not found]     ` <>
2018-06-06 13:30       ` shankarapailoor
2018-06-06 18:21     ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \
    --subject='Re: general protection fault in sockfs_setattr' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).