linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Matthew Bobrowski <mbobrowski@mbobrowski.org>
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH] fanotify: introduce event flags FAN_EXEC and FAN_EXEC_PERM
Date: Tue, 17 Jul 2018 15:21:45 +0300	[thread overview]
Message-ID: <CAOQ4uxgdgZyHA7TN7=G-1yiD+ocWgOK8xD-YkV=RD8cQKcyGeA@mail.gmail.com> (raw)
In-Reply-To: <1531731011.19075.11.camel@mbobrowski.org>

On Mon, Jul 16, 2018 at 11:50 AM, Matthew Bobrowski
<mbobrowski@mbobrowski.org> wrote:
> Currently, the fanotify API does not provide a means for user space
> programs to register and receive events specifically when a file has been
> opened with the intent to be executed. Two new event flags FAN_EXEC and
> FAN_EXEC_PERM have been introduced to the fanotify API along with updates
> to the generic filesystem notification hooks fsnotify_open and
> fsnotify_perm in order to support this capability.
>
> Signed-off-by: Matthew Bobrowski <mbobrowski@mbobrowski.org>
>
> ---
>
[...]
> @@ -69,13 +71,15 @@
>  #define FAN_ALL_EVENTS (FAN_ACCESS |\
>                         FAN_MODIFY |\
>                         FAN_CLOSE |\
> -                       FAN_OPEN)
> +                       FAN_OPEN |\
> +                       FAN_EXEC)
>
>  /*
>   * All events which require a permission response from userspace
>   */
>  #define FAN_ALL_PERM_EVENTS (FAN_OPEN_PERM |\
> -                            FAN_ACCESS_PERM)
> +                            FAN_ACCESS_PERM |\
> +                            FAN_EXEC_PERM)
>

If we change these masks that are exposed to user and
there is a user program setting a mark with FAN_ALL_EVENTS,
recompiling that program with new headers will make the binary
incompatible with old kernels.

Jan,

Do you think that is a problem?

Thanks,
Amir.

  parent reply	other threads:[~2018-07-17 12:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16  8:50 [PATCH] fanotify: introduce event flags FAN_EXEC and FAN_EXEC_PERM Matthew Bobrowski
2018-07-16  9:53 ` Marko Rauhamaa
2018-07-16 15:26 ` Jan Kara
2018-07-16 20:29   ` Steve Grubb
2018-07-17 12:44     ` Jan Kara
2018-07-17 13:36       ` Steve Grubb
2018-07-19  9:33         ` Jan Kara
2018-07-19 12:39           ` Steve Grubb
2018-07-19 13:06           ` Steve Grubb
2018-07-18 11:17       ` Matthew Bobrowski
2018-07-19 10:17         ` Jan Kara
2018-07-19 14:18           ` Marko Rauhamaa
2018-07-19 14:59           ` Steve Grubb
2018-07-17 12:21 ` Amir Goldstein [this message]
2018-07-17 12:48   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxgdgZyHA7TN7=G-1yiD+ocWgOK8xD-YkV=RD8cQKcyGeA@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mbobrowski@mbobrowski.org \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).