linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Miklos Szeredi <mszeredi@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	"Jens Axboe :" <axboe@kernel.dk>
Subject: Re: [PATCH] vfs: explicitly include fileattr.h dependency
Date: Wed, 23 Jun 2021 08:16:09 +0300	[thread overview]
Message-ID: <CAOQ4uxiCUd3SjThiX31L8JFgRAvemcMgtzfZJY1aXGwANNJ6Mg@mail.gmail.com> (raw)
In-Reply-To: <20210622194300.2617430-1-kbusch@kernel.org>

On Tue, Jun 22, 2021 at 10:47 PM Keith Busch <kbusch@kernel.org> wrote:
>
> linux/fileattr.h has an implicit requirement that linux/fs.h be included
> first. Make that dependency explicit.
>
> Cc: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Jens Axboe: <axboe@kernel.dk>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>  include/linux/fileattr.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h
> index 9e37e063ac69..34e153172a85 100644
> --- a/include/linux/fileattr.h
> +++ b/include/linux/fileattr.h
> @@ -3,6 +3,8 @@
>  #ifndef _LINUX_FILEATTR_H
>  #define _LINUX_FILEATTR_H
>
> +#include <linux/fs.h>
> +
>  /* Flags shared betwen flags/xflags */
>  #define FS_COMMON_FL \
>         (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
> --

Thinking out loud:
Would it be better to split out the flag definitions to uapi/linux/fileattr.h
and include it from here and from uapi/linux/fs.h?

Will that cause UAPI pain??

Thanks,
Amir.

      parent reply	other threads:[~2021-06-23  5:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 19:43 [PATCH] vfs: explicitly include fileattr.h dependency Keith Busch
2021-06-22 19:55 ` Matthew Wilcox
2021-06-22 21:44 ` Jens Axboe
2021-06-23  5:16 ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxiCUd3SjThiX31L8JFgRAvemcMgtzfZJY1aXGwANNJ6Mg@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).