linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Nigel_Banks@waters.com
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Mark Salyzyn <salyzyn@android.com>
Subject: Re: Deadlock in fsnotify for
Date: Mon, 1 Oct 2018 17:09:04 +0300	[thread overview]
Message-ID: <CAOQ4uxib=NF-pQ5VFuhou_gUfHq5BBLGi8xztEQZHwhU0-+_9A@mail.gmail.com> (raw)
In-Reply-To: <OFD621F3D0.4B122C7F-ON80258319.00395CDF-80258319.00399966@waters.com>

On Mon, Oct 1, 2018 at 1:29 PM Nigel Banks <Nigel_Banks@waters.com> wrote:
>
> Thank you Amir,
>
> I will try the patch you've recommend. It some times takes several days for this issue to arise, so you may not hear back from me for a week or so. On a side note if I were to use AUFS instead of Overlay2 would that potentially avoid this issue?
>

I don't know the answer to that question, but there is an easy way to find out.
The fix patch has a simple reproducer in commit message.
Run the same reproducer with AUFS instead of overlayfs and tell me.

I can only say that AFAIK all past versions of overlayfs has had this problem
with inotify.
I can also say that if you have a hardlink in lower layer and you are not using
the new overlayfs index feature (docker is not using this feature) then said
inotify issue will still happen on that lower hardlink.

Thanks,
Amir.

  parent reply	other threads:[~2018-10-01 20:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <OFAA2B5164.CC89CD80-ON80258315.0053848D-80258315.005681B2@waters.com>
2018-09-27 16:24 ` Deadlock in fsnotify for Jan Kara
     [not found]   ` <OFC1587FEF.00F5AC8A-ON80258316.004A23A8-80258316.004AAC30@waters.com>
2018-09-28 14:27     ` Amir Goldstein
     [not found]       ` <OFD621F3D0.4B122C7F-ON80258319.00395CDF-80258319.00399966@waters.com>
2018-10-01 14:09         ` Amir Goldstein [this message]
2018-10-01 10:25     ` Jan Kara
     [not found]   ` <OFC1587FEF.00F5AC8A-ON80258316.004A23A8-80258316.004A4100@LocalDomain>
     [not found]     ` <OFBCEABA83.BA7DAF1C-ON80258319.003B1DB4-80258319.003B4841@LocalDomain>
     [not found]       ` <OF184949B9.0B312CF1-ON80258319.003B7FFA-80258319.003BA9B9@LocalDomain>
2018-10-01 11:09         ` Nigel Banks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxib=NF-pQ5VFuhou_gUfHq5BBLGi8xztEQZHwhU0-+_9A@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=Nigel_Banks@waters.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=salyzyn@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).