* [GIT PULL] orangefs: an adjustment and a fix...
@ 2021-07-06 13:36 Mike Marshall
2021-07-06 19:24 ` pr-tracker-bot
0 siblings, 1 reply; 5+ messages in thread
From: Mike Marshall @ 2021-07-06 13:36 UTC (permalink / raw)
To: Linus Torvalds, linux-fsdevel, Mike Marshall
The following changes since commit 13311e74253fe64329390df80bed3f07314ddd61:
Linux 5.13-rc7 (2021-06-20 15:03:15 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux.git
tags/for-linus-5.14-ofs1
for you to fetch changes up to 0fdec1b3c9fbb5e856a40db5993c9eaf91c74a83:
orangefs: fix orangefs df output. (2021-06-28 08:40:08 -0400)
----------------------------------------------------------------
Orangefs: and adjustment and a fix
The readahead adjustment was suggested by Matthew Wilcox and looks like
how I should have written it in the first place... the "df fix" was
suggested by Walt Ligon, some Orangefs users have been complaining
about whacky df output...
----------------------------------------------------------------
Mike Marshall (2):
orangefs: readahead adjustment
orangefs: fix orangefs df output.
fs/orangefs/inode.c | 7 +++----
fs/orangefs/super.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread* [GIT PULL] orangefs: an adjustment and a fix...
@ 2021-06-26 14:14 Mike Marshall
2021-06-26 17:02 ` Linus Torvalds
0 siblings, 1 reply; 5+ messages in thread
From: Mike Marshall @ 2021-06-26 14:14 UTC (permalink / raw)
To: Linus Torvalds, Mike Marshall, linux-fsdevel
The following changes since commit 13311e74253fe64329390df80bed3f07314ddd61:
Linux 5.13-rc7 (2021-06-20 15:03:15 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux.git
tags/for-linus-5.13-ofs2
for you to fetch changes up to 1815bba0a5c935d60f0fa180873d9152feb29d09:
orangefs: fix orangefs df output. (2021-06-25 12:00:04 -0400)
----------------------------------------------------------------
Orangefs: and adjustment and a fix
If it is not too late for these... the readahead adjustment
was suggested by Matthew Wilcox and looks like how I should
have written it in the first place... the "df fix" was
suggested by Walt Ligon, some Orangefs users have been complaining
about whacky df output...
----------------------------------------------------------------
Mike Marshall (2):
orangefs: readahead adjustment
orangefs: fix orangefs df output.
fs/orangefs/inode.c | 6 +++---
fs/orangefs/super.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [GIT PULL] orangefs: an adjustment and a fix...
2021-06-26 14:14 Mike Marshall
@ 2021-06-26 17:02 ` Linus Torvalds
2021-06-27 14:50 ` Mike Marshall
0 siblings, 1 reply; 5+ messages in thread
From: Linus Torvalds @ 2021-06-26 17:02 UTC (permalink / raw)
To: Mike Marshall; +Cc: linux-fsdevel
On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall <hubcap@omnibond.com> wrote:
>
> If it is not too late for these... the readahead adjustment
> was suggested by Matthew Wilcox and looks like how I should
> have written it in the first place...
It wasn't too late - I pulled these.
And then I un-pulled them. You removed all the uses of "file", but
left the variable, so it all warns about
fs/orangefs/inode.c: In function ‘orangefs_readahead’:
fs/orangefs/inode.c:252:22: warning: unused variable ‘file’
[-Wunused-variable]
252 | struct file *file = rac->file;
| ^~~~
so clearly this has gotten absolutely zero testing.
Linus
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [GIT PULL] orangefs: an adjustment and a fix...
2021-06-26 17:02 ` Linus Torvalds
@ 2021-06-27 14:50 ` Mike Marshall
0 siblings, 0 replies; 5+ messages in thread
From: Mike Marshall @ 2021-06-27 14:50 UTC (permalink / raw)
To: Linus Torvalds, linux-fsdevel, Mike Marshall
Fair enough... I promise it is my generally my habit to do
this and pay attention to the output before I send stuff
to you:
1011 rm fs/orangefs/*.o
1012 make
>>so clearly this has gotten absolutely zero testing.
I wouldn't do you that way :-) ... I ran this through xfstests
and left it on linux-next for a cycle.
-Mike
On Sat, Jun 26, 2021 at 1:02 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Sat, Jun 26, 2021 at 7:14 AM Mike Marshall <hubcap@omnibond.com> wrote:
> >
> > If it is not too late for these... the readahead adjustment
> > was suggested by Matthew Wilcox and looks like how I should
> > have written it in the first place...
>
> It wasn't too late - I pulled these.
>
> And then I un-pulled them. You removed all the uses of "file", but
> left the variable, so it all warns about
>
> fs/orangefs/inode.c: In function ‘orangefs_readahead’:
> fs/orangefs/inode.c:252:22: warning: unused variable ‘file’
> [-Wunused-variable]
> 252 | struct file *file = rac->file;
> | ^~~~
>
> so clearly this has gotten absolutely zero testing.
>
> Linus
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-06 19:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 13:36 [GIT PULL] orangefs: an adjustment and a fix Mike Marshall
2021-07-06 19:24 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2021-06-26 14:14 Mike Marshall
2021-06-26 17:02 ` Linus Torvalds
2021-06-27 14:50 ` Mike Marshall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).