[PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

[PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

[Alan Somers]

From: Alan Somers <asomers@FreeBSD.org>
Date: Wed, 13 Mar 2019 10:24:21 -0600
Subject: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a
magic number.  No new values have been added to fsync_flags since.

Signed-off-by: Alan Somers <asomers@FreeBSD.org>
---
 fs/fuse/file.c            | 2 +-
 include/uapi/linux/fuse.h | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 06096b60f1df..db083359b56f 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -462,7 +462,7 @@ int fuse_fsync_common(struct file *file, loff_t
start, loff_t end,

     memset(&inarg, 0, sizeof(inarg));
     inarg.fh = ff->fh;
-    inarg.fsync_flags = datasync ? 1 : 0;
+    inarg.fsync_flags = datasync ? FUSE_FSYNC_FDATASYNC: 0;
     args.in.h.opcode = opcode;
     args.in.h.nodeid = get_node_id(inode);
     args.in.numargs = 1;
diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h
index 2ac598614a8f..e4ceeb406eb3 100644
--- a/include/uapi/linux/fuse.h
+++ b/include/uapi/linux/fuse.h
@@ -353,6 +353,13 @@ struct fuse_file_lock {
  */
 #define FUSE_POLL_SCHEDULE_NOTIFY (1 << 0)

+/**
+ * Fsync flags
+ *
+ * FUSE_FSYNC_FDATASYNC: Sync data only, not metadata
+ */
+#define FUSE_FSYNC_FDATASYNC    (1 << 0)
+
 enum fuse_opcode {
     FUSE_LOOKUP        = 1,
     FUSE_FORGET        = 2,  /* no reply */
-- 
2.20.1

Re: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

[Miklos Szeredi]

On Wed, Mar 13, 2019 at 6:14 PM Alan Somers <asomers@freebsd.org> wrote:
>
> From: Alan Somers <asomers@FreeBSD.org>
> Date: Wed, 13 Mar 2019 10:24:21 -0600
> Subject: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags
>
> The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a
> magic number.  No new values have been added to fsync_flags since.

Patches are whitespace damaged (gmail does that unfortunately).  The
standard solution is git-send-email, but if you just attach the
patches, that's fine by me as well.

Thanks,
Miklos

Re: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

[Alan Somers]

On Tue, Apr 23, 2019 at 6:44 AM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Wed, Mar 13, 2019 at 6:14 PM Alan Somers <asomers@freebsd.org> wrote:
> >
> > From: Alan Somers <asomers@FreeBSD.org>
> > Date: Wed, 13 Mar 2019 10:24:21 -0600
> > Subject: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags
> >
> > The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a
> > magic number.  No new values have been added to fsync_flags since.
>
> Patches are whitespace damaged (gmail does that unfortunately).  The
> standard solution is git-send-email, but if you just attach the
> patches, that's fine by me as well.
>
> Thanks,
> Miklos

As a matter of fact, I resent the (rebased) patch with git-send-email
4 days ago.  See https://patchwork.kernel.org/patch/10909823/ .
-Alan

Re: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

[Miklos Szeredi]

On Tue, Apr 23, 2019 at 4:44 PM Alan Somers <asomers@freebsd.org> wrote:
>
> On Tue, Apr 23, 2019 at 6:44 AM Miklos Szeredi <miklos@szeredi.hu> wrote:
> >
> > On Wed, Mar 13, 2019 at 6:14 PM Alan Somers <asomers@freebsd.org> wrote:
> > >
> > > From: Alan Somers <asomers@FreeBSD.org>
> > > Date: Wed, 13 Mar 2019 10:24:21 -0600
> > > Subject: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags
> > >
> > > The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a
> > > magic number.  No new values have been added to fsync_flags since.
> >
> > Patches are whitespace damaged (gmail does that unfortunately).  The
> > standard solution is git-send-email, but if you just attach the
> > patches, that's fine by me as well.
> >
> > Thanks,
> > Miklos
>
> As a matter of fact, I resent the (rebased) patch with git-send-email
> 4 days ago.  See https://patchwork.kernel.org/patch/10909823/ .

Okay, applied.

Thanks,
Miklos

Re: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags

[Alan Somers]

On Tue, Apr 23, 2019 at 12:53 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Tue, Apr 23, 2019 at 4:44 PM Alan Somers <asomers@freebsd.org> wrote:
> >
> > On Tue, Apr 23, 2019 at 6:44 AM Miklos Szeredi <miklos@szeredi.hu> wrote:
> > >
> > > On Wed, Mar 13, 2019 at 6:14 PM Alan Somers <asomers@freebsd.org> wrote:
> > > >
> > > > From: Alan Somers <asomers@FreeBSD.org>
> > > > Date: Wed, 13 Mar 2019 10:24:21 -0600
> > > > Subject: [PATCH 1/2] fuse: document fuse_fsync_in.fsync_flags
> > > >
> > > > The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a
> > > > magic number.  No new values have been added to fsync_flags since.
> > >
> > > Patches are whitespace damaged (gmail does that unfortunately).  The
> > > standard solution is git-send-email, but if you just attach the
> > > patches, that's fine by me as well.
> > >
> > > Thanks,
> > > Miklos
> >
> > As a matter of fact, I resent the (rebased) patch with git-send-email
> > 4 days ago.  See https://patchwork.kernel.org/patch/10909823/ .
>
> Okay, applied.
>
> Thanks,
> Miklos

Thanks!  Is there anything else you need from me?