From: Dan Williams <dan.j.williams@intel.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Toshi Kani <toshi.kani@hpe.com>,
device-mapper development <dm-devel@redhat.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Tue, 26 Jun 2018 12:07:40 -0700 [thread overview]
Message-ID: <CAPcyv4h6HO6fs6k7QMD77jkz2djCeWCtWomCdNb0-1Q4VKanqw@mail.gmail.com> (raw)
In-Reply-To: <20180626185830.GA7171@redhat.com>
On Tue, Jun 26, 2018 at 11:58 AM, Mike Snitzer <snitzer@redhat.com> wrote:
> On Tue, Jun 26 2018 at 2:52pm -0400,
> Dan Williams <dan.j.williams@intel.com> wrote:
>
>> On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler
>> <ross.zwisler@linux.intel.com> wrote:
>> > QUEUE_FLAG_DAX is an indication that a given block device supports
>> > filesystem DAX and should not be set for PMEM namespaces which are in "raw"
>> > or "sector" modes. These namespaces lack struct page and are prevented
>> > from participating in filesystem DAX.
>> >
>> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>> > Suggested-by: Mike Snitzer <snitzer@redhat.com>
>> > Cc: stable@vger.kernel.org
>>
>> Why is this cc: stable? What is the user visible impact of this change
>> especially given the requirement to validate QUEUE_FLAG_DAX with
>> bdev_dax_supported()? Patch looks good, but it's just a cosmetic fixup
>> afaics.
>
> This isn't cosmetic when you consider that stacking up a DM device is
> looking at this flag to determine whether a table does or does _not_
> support DAX.
>
> So this patch, in conjunction with the other changes in the series, is
> certainly something I'd consider appropriate for stable.
I think this classifies as something that never worked correctly and
is not a regression. It does not identify which commit it is repairing
or the user visible failure mode.
next prev parent reply other threads:[~2018-06-26 19:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 17:59 [PATCH v3 0/3] Fix DM DAX handling Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Ross Zwisler
2018-06-26 18:52 ` Dan Williams
2018-06-26 18:58 ` Mike Snitzer
2018-06-26 19:07 ` Dan Williams [this message]
2018-06-26 19:12 ` Ross Zwisler
2018-06-26 19:13 ` Mike Snitzer
2018-06-26 19:19 ` Dan Williams
2018-06-26 20:54 ` Kani, Toshi
2018-06-26 21:02 ` Dan Williams
2018-06-26 21:23 ` Kani, Toshi
2018-06-26 21:28 ` Dan Williams
2018-06-26 21:31 ` Kani, Toshi
2018-06-26 21:51 ` Dan Williams
2018-06-26 22:04 ` Ross Zwisler
2018-06-28 17:42 ` Kani, Toshi
2018-06-28 17:48 ` Mike Snitzer
2018-06-28 17:59 ` Dan Williams
2018-06-28 18:01 ` Kani, Toshi
2018-06-28 19:04 ` Ross Zwisler
2018-06-28 19:40 ` Kani, Toshi
2018-06-26 19:11 ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 3/3] dm: prevent DAX mounts if not supported Ross Zwisler
2018-06-26 18:17 ` Mike Snitzer
2018-06-26 19:01 ` [PATCH v4 " Ross Zwisler
2018-06-26 18:48 ` [PATCH v3 0/3] Fix DM DAX handling Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4h6HO6fs6k7QMD77jkz2djCeWCtWomCdNb0-1Q4VKanqw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).