* Re: [PATCH v4 2/2] f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE
[not found] ` <20221004171351.3678194-2-daeho43@gmail.com>
@ 2022-10-06 8:33 ` Christoph Hellwig
2022-10-06 16:32 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2022-10-06 8:33 UTC (permalink / raw)
To: Daeho Jeong, Darrick J. Wong
Cc: linux-kernel, linux-f2fs-devel, kernel-team, Daeho Jeong, linux-fsdevel
On Tue, Oct 04, 2022 at 10:13:51AM -0700, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> introduce a new ioctl to replace the whole content of a file atomically,
> which means it induces truncate and content update at the same time.
> We can start it with F2FS_IOC_START_ATOMIC_REPLACE and complete it with
> F2FS_IOC_COMMIT_ATOMIC_WRITE. Or abort it with
> F2FS_IOC_ABORT_ATOMIC_WRITE.
It would be great to Cc Darrick and linux-fsdevel as there have been
attempts to do this properly at the VFS level instead of a completely
undocumented ioctl.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 2/2] f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE
2022-10-06 8:33 ` [PATCH v4 2/2] f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE Christoph Hellwig
@ 2022-10-06 16:32 ` Darrick J. Wong
2022-10-17 17:03 ` Daeho Jeong
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2022-10-06 16:32 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Daeho Jeong, linux-kernel, linux-f2fs-devel, kernel-team,
Daeho Jeong, linux-fsdevel
On Thu, Oct 06, 2022 at 01:33:34AM -0700, Christoph Hellwig wrote:
> On Tue, Oct 04, 2022 at 10:13:51AM -0700, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > introduce a new ioctl to replace the whole content of a file atomically,
> > which means it induces truncate and content update at the same time.
> > We can start it with F2FS_IOC_START_ATOMIC_REPLACE and complete it with
> > F2FS_IOC_COMMIT_ATOMIC_WRITE. Or abort it with
> > F2FS_IOC_ABORT_ATOMIC_WRITE.
>
> It would be great to Cc Darrick and linux-fsdevel as there have been
> attempts to do this properly at the VFS level instead of a completely
> undocumented ioctl.
It's been a while since I sent the last RFC, but yes, it's still in my
queue as part of the xfs online fsck patchserieses.
https://lore.kernel.org/linux-fsdevel/161723932606.3149451.12366114306150243052.stgit@magnolia/
More recent git branch:
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=atomic-file-updates
--D
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 2/2] f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE
2022-10-06 16:32 ` Darrick J. Wong
@ 2022-10-17 17:03 ` Daeho Jeong
0 siblings, 0 replies; 3+ messages in thread
From: Daeho Jeong @ 2022-10-17 17:03 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Christoph Hellwig, linux-kernel, linux-f2fs-devel, kernel-team,
Daeho Jeong, linux-fsdevel
On Thu, Oct 6, 2022 at 9:32 AM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Thu, Oct 06, 2022 at 01:33:34AM -0700, Christoph Hellwig wrote:
> > On Tue, Oct 04, 2022 at 10:13:51AM -0700, Daeho Jeong wrote:
> > > From: Daeho Jeong <daehojeong@google.com>
> > >
> > > introduce a new ioctl to replace the whole content of a file atomically,
> > > which means it induces truncate and content update at the same time.
> > > We can start it with F2FS_IOC_START_ATOMIC_REPLACE and complete it with
> > > F2FS_IOC_COMMIT_ATOMIC_WRITE. Or abort it with
> > > F2FS_IOC_ABORT_ATOMIC_WRITE.
> >
> > It would be great to Cc Darrick and linux-fsdevel as there have been
> > attempts to do this properly at the VFS level instead of a completely
> > undocumented ioctl.
>
> It's been a while since I sent the last RFC, but yes, it's still in my
> queue as part of the xfs online fsck patchserieses.
>
> https://lore.kernel.org/linux-fsdevel/161723932606.3149451.12366114306150243052.stgit@magnolia/
>
> More recent git branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=atomic-file-updates
Hi,
It's a very interesting suggestion and we might use this in F2FS someday.
However, I think it's not exactly matched for what
F2FS_IOC_START_ATOMIC_REPLACE is doing now.
Thanks for bringing my attention to this.
>
> --D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 17:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221004171351.3678194-1-daeho43@gmail.com>
[not found] ` <20221004171351.3678194-2-daeho43@gmail.com>
2022-10-06 8:33 ` [PATCH v4 2/2] f2fs: introduce F2FS_IOC_START_ATOMIC_REPLACE Christoph Hellwig
2022-10-06 16:32 ` Darrick J. Wong
2022-10-17 17:03 ` Daeho Jeong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).