From: Pavel Begunkov <asml.silence@gmail.com>
To: Bernd Schubert <bschubert@ddn.com>, Miklos Szeredi <miklos@szeredi.hu>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Dharmendra Singh <dsingh@ddn.com>,
Amir Goldstein <amir73il@gmail.com>,
"fuse-devel@lists.sourceforge.net"
<fuse-devel@lists.sourceforge.net>,
Ming Lei <ming.lei@redhat.com>,
Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 06/13] fuse: Add an interval ring stop worker/monitor
Date: Mon, 27 Mar 2023 14:22:11 +0100 [thread overview]
Message-ID: <a2fbe689-40e6-c01f-3616-4f42ae14347b@gmail.com> (raw)
In-Reply-To: <a1b51f8c-06b9-8f89-f60e-ee2051069a51@ddn.com>
On 3/23/23 20:51, Bernd Schubert wrote:
> On 3/23/23 14:18, Bernd Schubert wrote:
>> On 3/23/23 13:35, Miklos Szeredi wrote:
>>> On Thu, 23 Mar 2023 at 12:04, Bernd Schubert <bschubert@ddn.com> wrote:
[...]
> Found the reason why I complete SQEs when the daemon stops - on daemon
> side I have
>
> ret = io_uring_wait_cqe(&queue->ring, &cqe);
>
> and that hangs when you stop user side with SIGTERM/SIGINT. Maybe that
> could be solved with io_uring_wait_cqe_timeout() /
> io_uring_wait_cqe_timeout(), but would that really be a good solution?
It can be some sort of an eventfd triggered from the signal handler
and waited upon by an io_uring poll/read request. Or maybe signalfd.
> We would now have CPU activity in intervals on the daemon side for now
> good reason - the more often the faster SIGTERM/SIGINT works.
> So at best, it should be uring side that stops to wait on a receiving a
> signal.
FWIW, io_uring (i.e. kernel side) will stop waiting if there are pending
signals, and we'd need to check liburing to honour it, e.g. not to retry
waiting.
--
Pavel Begunkov
next prev parent reply other threads:[~2023-03-27 13:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 1:10 [RFC PATCH 00/13] fuse uring communication Bernd Schubert
2023-03-21 1:10 ` [PATCH 01/13] fuse: Add uring data structures and documentation Bernd Schubert
2023-03-21 1:10 ` [PATCH 02/13] fuse: rename to fuse_dev_end_requests and make non-static Bernd Schubert
2023-03-21 1:10 ` [PATCH 03/13] fuse: Move fuse_get_dev to header file Bernd Schubert
2023-03-21 1:10 ` [PATCH 04/13] Add a vmalloc_node_user function Bernd Schubert
2023-03-21 21:21 ` Andrew Morton
2023-03-21 1:10 ` [PATCH 05/13] fuse: Add a uring config ioctl and ring destruction Bernd Schubert
2023-03-21 1:10 ` [PATCH 06/13] fuse: Add an interval ring stop worker/monitor Bernd Schubert
2023-03-23 10:27 ` Miklos Szeredi
2023-03-23 11:04 ` Bernd Schubert
2023-03-23 12:35 ` Miklos Szeredi
2023-03-23 13:18 ` Bernd Schubert
2023-03-23 20:51 ` Bernd Schubert
2023-03-27 13:22 ` Pavel Begunkov [this message]
2023-03-27 14:02 ` Bernd Schubert
2023-03-23 13:26 ` Ming Lei
2023-03-21 1:10 ` [PATCH 07/13] fuse: Add uring mmap method Bernd Schubert
2023-03-21 1:10 ` [PATCH 08/13] fuse: Move request bits Bernd Schubert
2023-03-21 1:10 ` [PATCH 09/13] fuse: Add wait stop ioctl support to the ring Bernd Schubert
2023-03-21 1:10 ` [PATCH 10/13] fuse: Handle SQEs - register commands Bernd Schubert
2023-03-21 1:10 ` [PATCH 11/13] fuse: Add support to copy from/to the ring buffer Bernd Schubert
2023-03-21 1:10 ` [PATCH 12/13] fuse: Add uring sqe commit and fetch support Bernd Schubert
2023-03-21 1:10 ` [PATCH 13/13] fuse: Allow to queue to the ring Bernd Schubert
2023-03-21 1:26 ` [RFC PATCH 00/13] fuse uring communication Bernd Schubert
2023-03-21 9:35 ` Amir Goldstein
2023-03-23 11:18 ` Bernd Schubert
2023-03-23 11:55 ` Amir Goldstein
2023-06-07 14:20 ` Miklos Szeredi
2023-06-08 21:31 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2fbe689-40e6-c01f-3616-4f42ae14347b@gmail.com \
--to=asml.silence@gmail.com \
--cc=aleksandr.mikhalitsyn@canonical.com \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=bschubert@ddn.com \
--cc=dsingh@ddn.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).