From: Hyeongseok Kim <hyeongseok@gmail.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"namjae.jeon@samsung.com" <namjae.jeon@samsung.com>,
"sj1557.seo@samsung.com" <sj1557.seo@samsung.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] exfat: add initial ioctl function
Date: Wed, 17 Feb 2021 09:13:35 +0900 [thread overview]
Message-ID: <c186df93-a6b8-2cd5-8710-077382574b83@gmail.com> (raw)
In-Reply-To: <BYAPR04MB4965E7E1A47A3EF603A3E34C86879@BYAPR04MB4965.namprd04.prod.outlook.com>
On 2/17/21 8:51 AM, Chaitanya Kulkarni wrote:
> On 2/16/21 14:36, Hyeongseok Kim wrote:
>> Initialize empty ioctl function
>>
>> Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
> This patch doesn't do much, but this commit log could be better.
Sorry, I don't understand exactly.
You're saying that these 2 patch should be merged to a single patch?
Would it be better?
>
> Also from my experience there is not point in introducing an empty
> function.
>
next prev parent reply other threads:[~2021-02-17 0:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 22:33 [PATCH v2 0/2] Add FITRIM ioctl support for exFAT filesystem Hyeongseok Kim
2021-02-16 22:33 ` [PATCH v2 1/2] exfat: add initial ioctl function Hyeongseok Kim
2021-02-16 23:51 ` Chaitanya Kulkarni
2021-02-17 0:13 ` Hyeongseok Kim [this message]
2021-02-17 0:17 ` Chaitanya Kulkarni
2021-02-17 0:33 ` Hyeongseok Kim
2021-02-17 5:39 ` Namjae Jeon
2021-02-17 6:05 ` Hyeongseok Kim
2021-02-16 22:33 ` [PATCH v2 2/2] exfat: add support FITRIM ioctl Hyeongseok Kim
2021-02-16 23:56 ` Chaitanya Kulkarni
2021-02-17 0:14 ` Hyeongseok Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c186df93-a6b8-2cd5-8710-077382574b83@gmail.com \
--to=hyeongseok@gmail.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).