From: Namjae Jeon <linkinjeon@kernel.org>
To: Hyeongseok Kim <hyeongseok@gmail.com>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"namjae.jeon@samsung.com" <namjae.jeon@samsung.com>,
"sj1557.seo@samsung.com" <sj1557.seo@samsung.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] exfat: add initial ioctl function
Date: Wed, 17 Feb 2021 14:39:17 +0900 [thread overview]
Message-ID: <CAKYAXd9=NwCpFJ7NczFBF1diFV3mLpL2Sz7UQP-Pg78zaFtBnA@mail.gmail.com> (raw)
In-Reply-To: <78a7f3ec-f5c2-071a-506c-b19b21b9b04c@gmail.com>
2021-02-17 9:33 GMT+09:00, Hyeongseok Kim <hyeongseok@gmail.com>:
> On 2/17/21 9:17 AM, Chaitanya Kulkarni wrote:
>> On 2/16/21 16:13, Hyeongseok Kim wrote:
>>> Sorry, I don't understand exactly.
>>> You're saying that these 2 patch should be merged to a single patch?
>>> Would it be better?
>> I think so unless there is a specific reason for this to keep it
>> isolated.
>>
> The reason was just that I think it seems better to seperate ioctl
> initializing and adding specific ioctl functionality.
> Anyway, I got it.
>
> Namjae,
Hi Hyeongseok,
> Do you have any other opinion about this?
I also think this patch should be combined with the 2/2 patch.
> If you agree, I'll merge these as one.
Yep, Agreed. Please do that:)
Thanks!
>
>
next prev parent reply other threads:[~2021-02-17 5:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 22:33 [PATCH v2 0/2] Add FITRIM ioctl support for exFAT filesystem Hyeongseok Kim
2021-02-16 22:33 ` [PATCH v2 1/2] exfat: add initial ioctl function Hyeongseok Kim
2021-02-16 23:51 ` Chaitanya Kulkarni
2021-02-17 0:13 ` Hyeongseok Kim
2021-02-17 0:17 ` Chaitanya Kulkarni
2021-02-17 0:33 ` Hyeongseok Kim
2021-02-17 5:39 ` Namjae Jeon [this message]
2021-02-17 6:05 ` Hyeongseok Kim
2021-02-16 22:33 ` [PATCH v2 2/2] exfat: add support FITRIM ioctl Hyeongseok Kim
2021-02-16 23:56 ` Chaitanya Kulkarni
2021-02-17 0:14 ` Hyeongseok Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd9=NwCpFJ7NczFBF1diFV3mLpL2Sz7UQP-Pg78zaFtBnA@mail.gmail.com' \
--to=linkinjeon@kernel.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hyeongseok@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).