linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	David Howells <dhowells@redhat.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: Merging virtualbox shared-folder VFS driver through drivers/staging?
Date: Thu, 29 Aug 2019 17:05:49 +0200	[thread overview]
Message-ID: <c8495f31-5975-d4b1-1dd4-28d01b594a9a@redhat.com> (raw)
In-Reply-To: <20190811074348.GA13485@infradead.org>

Hi all,

On 11-08-19 09:43, Christoph Hellwig wrote:
> On Sun, Aug 11, 2019 at 09:40:05AM +0200, Greg Kroah-Hartman wrote:
>>> Since I do not see the lack of reviewing capacity problem get solved
>>> anytime soon, I was wondering if you are ok with putting the code
>>> in drivers/staging/vboxsf for now, until someone can review it and ack it
>>> for moving over to sf/vboxsf ?
>>
>> I have no objection to that if the vfs developers do not mind.
> 
> We had really bad experiences with fs code in staging.  I think it is
> a bad idea that should not be repeated.

So after resolving the problem with the patch not making it through
to the list because of the patch-size, v12 got reviewed (thank you
for that Christoph) and I did a v13.

Then there was some discussion about read cache-coherency vs writes
done on the host side underneath us (the guest) and in the end
Christoph agreed that what was done in v13 was as good as it would
get given the limitations of the shared folder API offered by
the VirtualBox hypervisor, but Christoph did request to add a big
comment explaining these issues in more detail.

So I posted a v14, adding the big comment and addressing 2 very minor
other issue spotted by Christoph, that was 10 days ago and things
have gotten quiet again since. I realiz that 10 days is not very
long but for previous revisions I have been waiting upto 60 days
sometimes and the exfat in staging discussion reminded me of this.

So what is the plan going forward for vboxsf now?

Regards,

Hans


  parent reply	other threads:[~2019-08-29 15:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-10 22:25 Merging virtualbox shared-folder VFS driver through drivers/staging? Hans de Goede
2019-08-11  0:50 ` Matthew Wilcox
2019-08-11 13:36   ` Hans de Goede
2019-08-11  7:40 ` Greg Kroah-Hartman
2019-08-11  7:43   ` Christoph Hellwig
2019-08-11  7:50     ` Greg Kroah-Hartman
2019-08-11 13:43       ` Hans de Goede
2019-08-11 13:49         ` Greg Kroah-Hartman
2019-08-12 11:22       ` Christoph Hellwig
2019-08-12 13:44         ` Gao Xiang
2019-08-11  9:00     ` Gao Xiang
2019-08-29 15:05     ` Hans de Goede [this message]
2019-08-30 16:43       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8495f31-5975-d4b1-1dd4-28d01b594a9a@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).