* [PATCH 1/1] f2fs: check total_segments from devices in raw_super
@ 2019-09-23 4:22 sunqiuyang
2019-09-23 7:04 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: sunqiuyang @ 2019-09-23 4:22 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel, jaegeuk, yuchao0
Cc: sunqiuyang
From: Qiuyang Sun <sunqiuyang@huawei.com>
For multi-device F2FS, we should check if the sum of total_segments from
all devices matches segment_count.
Signed-off-by: Qiuyang Sun <sunqiuyang@huawei.com>
---
fs/f2fs/super.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 04788a6..9a09d59 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2602,6 +2602,21 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
return -EFSCORRUPTED;
}
+ if (RDEV(0).path[0]) {
+ block_t dev_seg_count = le32_to_cpu(RDEV(0).total_segments);
+ int i = 1;
+
+ while (i < MAX_DEVICES && RDEV(i).path[0]) {
+ dev_seg_count += le32_to_cpu(RDEV(i).total_segments);
+ i++;
+ }
+ if (segment_count != dev_seg_count) {
+ f2fs_info(sbi, "Segment count (%u) mismatch with total segments from devices (%u)",
+ segment_count, dev_seg_count);
+ return -EFSCORRUPTED;
+ }
+ }
+
if (secs_per_zone > total_sections || !secs_per_zone) {
f2fs_info(sbi, "Wrong secs_per_zone / total_sections (%u, %u)",
secs_per_zone, total_sections);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] f2fs: check total_segments from devices in raw_super
2019-09-23 4:22 [PATCH 1/1] f2fs: check total_segments from devices in raw_super sunqiuyang
@ 2019-09-23 7:04 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2019-09-23 7:04 UTC (permalink / raw)
To: sunqiuyang, linux-kernel, linux-fsdevel, linux-f2fs-devel, jaegeuk
On 2019/9/23 12:22, sunqiuyang wrote:
> From: Qiuyang Sun <sunqiuyang@huawei.com>
>
> For multi-device F2FS, we should check if the sum of total_segments from
> all devices matches segment_count.
>
> Signed-off-by: Qiuyang Sun <sunqiuyang@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-23 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23 4:22 [PATCH 1/1] f2fs: check total_segments from devices in raw_super sunqiuyang
2019-09-23 7:04 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).