From: Hannes Reinecke <hare@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>, Jens Axboe <axboe@fb.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux FSDEVEL Mailinglist <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] block: bio: introduce BIO_ALLOCED flag and check it in bio_free
Date: Fri, 22 Mar 2019 15:10:53 +0100 [thread overview]
Message-ID: <dbc9d01f-bd14-ff91-d9bd-11109f470e2e@suse.de> (raw)
In-Reply-To: <20190322131346.20169-4-jthumshirn@suse.de>
On 3/22/19 2:13 PM, Johannes Thumshirn wrote:
> When we're submitting a bio from stack and this ends up being split, we
> call bio_put(). bio_put() will eventually call bio_free() if the reference
> count drops to 0. But freeing the bio is wrong, as it was never allocated
> out of the bio's mempool.
>
> Flag each normally allocated bio as 'BIO_ALLOCATED' and skip freeing if the
> flag isn't set.
>
> Fixes: 189ce2b9dcc3 ("block: fast-path for small and simple direct I/O requests")
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> block/bio.c | 4 ++++
> include/linux/blk_types.h | 1 +
> 2 files changed, 5 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Although I do question the 'Fixes' tag here; without the first two this
patch would be pretty pointless, so I'd rather have all 3 marked with
'Fixes'.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2019-03-22 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:13 [PATCH v2 0/3] add flag for tracking bio allocation Johannes Thumshirn
2019-03-22 13:13 ` [PATCH v2 1/3] block: bio: kill BIO_SEG_VALID flag Johannes Thumshirn
2019-03-22 14:01 ` Christoph Hellwig
2019-03-25 8:02 ` Johannes Thumshirn
2019-03-22 14:06 ` Hannes Reinecke
2019-03-22 22:00 ` Jens Axboe
2019-03-23 19:31 ` Jens Axboe
2019-03-25 13:32 ` Johannes Thumshirn
2019-03-22 22:40 ` Ming Lei
2019-03-22 13:13 ` [PATCH v2 2/3] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX Johannes Thumshirn
2019-03-22 14:01 ` Christoph Hellwig
2019-03-22 14:07 ` Hannes Reinecke
2019-03-22 13:13 ` [PATCH v2 3/3] block: bio: introduce BIO_ALLOCED flag and check it in bio_free Johannes Thumshirn
2019-03-22 14:02 ` Christoph Hellwig
2019-03-22 14:05 ` Hannes Reinecke
2019-03-22 21:30 ` Keith Busch
2019-03-22 23:04 ` Ming Lei
2019-03-22 14:10 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc9d01f-bd14-ff91-d9bd-11109f470e2e@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).