From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org> Cc: Daniel Rosenberg <drosen@google.com>, Jonathan Corbet <corbet@lwn.net>, <linux-f2fs-devel@lists.sourceforge.net>, <linux-doc@vger.kernel.org>, <linux-api@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, <kernel-team@android.com> Subject: Re: [f2fs-dev] [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups Date: Mon, 29 Jul 2019 15:22:21 +0800 [thread overview] Message-ID: <fa07a09d-92c9-4e0b-7c2b-e87771273dce@huawei.com> (raw) In-Reply-To: <20190729062735.GA98839@jaegeuk-macbookpro.roam.corp.google.com> On 2019/7/29 14:27, Jaegeuk Kim wrote: > On 07/28, Chao Yu wrote: >> On 2019-7-24 7:05, Daniel Rosenberg via Linux-f2fs-devel wrote: >>> /* Flags that are appropriate for regular files (all but dir-specific ones). */ >>> #define F2FS_REG_FLMASK (~(F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL)) >> >> We missed to add F2FS_CASEFOLD_FL here to exclude it in F2FS_REG_FLMASK. > > Applied. > >> >>> @@ -1660,7 +1660,16 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) >>> return -EPERM; >>> >>> oldflags = fi->i_flags; >>> + if ((iflags ^ oldflags) & F2FS_CASEFOLD_FL) { >>> + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) >>> + return -EOPNOTSUPP; >>> + >>> + if (!S_ISDIR(inode->i_mode)) >>> + return -ENOTDIR; >>> >>> + if (!f2fs_empty_dir(inode)) >>> + return -ENOTEMPTY; >>> + } > > Modified like this: > @@ -1665,6 +1665,13 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) > if (IS_NOQUOTA(inode)) > return -EPERM; > > + if ((iflags ^ fi->i_flags) & F2FS_CASEFOLD_FL) { > + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) > + return -EOPNOTSUPP; > + if (!f2fs_empty_dir(inode)) > + return -ENOTEMPTY; > + } > + > > Note that, directory is checked by above change. > > I've uploaded in f2fs.git, so could you check it out and test a bit? I've checked it out, it looks good to me now, and later I will test this new version. Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks, > > Thanks, > >> >> I applied the patches based on last Jaegeuk's dev branch, it seems we needs to >> adjust above code a bit. Otherwise it looks good to me. >> >> BTW, it looks the patchset works fine with generic/556 testcase. >> >> Thanks, > . >
next prev parent reply other threads:[~2019-07-29 7:22 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-23 23:05 [PATCH v4 0/3] Casefolding in F2FS Daniel Rosenberg 2019-07-23 23:05 ` [PATCH v4 1/3] fs: Reserve flag for casefolding Daniel Rosenberg 2019-07-28 0:36 ` [f2fs-dev] " Chao Yu 2019-07-23 23:05 ` [PATCH v4 2/3] f2fs: include charset encoding information in the superblock Daniel Rosenberg 2019-07-28 0:45 ` [f2fs-dev] " Chao Yu 2019-07-23 23:05 ` [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups Daniel Rosenberg 2019-07-28 0:55 ` [f2fs-dev] " Chao Yu 2019-07-29 6:27 ` Jaegeuk Kim 2019-07-29 7:22 ` Chao Yu [this message] 2019-07-29 14:57 ` Chao Yu 2019-07-31 17:57 ` Nathan Chancellor 2019-08-01 1:11 ` Chao Yu 2019-08-01 4:05 ` Jaegeuk Kim 2019-08-21 13:15 ` [f2fs-dev] " Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fa07a09d-92c9-4e0b-7c2b-e87771273dce@huawei.com \ --to=yuchao0@huawei.com \ --cc=chao@kernel.org \ --cc=corbet@lwn.net \ --cc=drosen@google.com \ --cc=jaegeuk@kernel.org \ --cc=kernel-team@android.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --subject='Re: [f2fs-dev] [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).