* [PATCH] cramfs: fix usage on non-MTD device
@ 2019-10-19 19:24 Nicolas Pitre
2019-10-21 13:45 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Pitre @ 2019-10-19 19:24 UTC (permalink / raw)
To: Al Viro; +Cc: Maxime Bizon, David Howells, linux-fsdevel
From: Maxime Bizon <mbizon@freebox.fr>
When both CONFIG_CRAMFS_MTD and CONFIG_CRAMFS_BLOCKDEV are enabled, if
we fail to mount on MTD, we don't try on block device.
Fixes: 74f78fc5ef43 ("vfs: Convert cramfs to use the new mount API")
Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
---
fs/cramfs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
index d12ea28836a5..2f04024c3588 100644
--- a/fs/cramfs/inode.c
+++ b/fs/cramfs/inode.c
@@ -958,8 +958,8 @@ static int cramfs_get_tree(struct fs_context *fc)
if (IS_ENABLED(CONFIG_CRAMFS_MTD)) {
ret = get_tree_mtd(fc, cramfs_mtd_fill_super);
- if (ret < 0)
- return ret;
+ if (!ret)
+ return 0;
}
if (IS_ENABLED(CONFIG_CRAMFS_BLOCKDEV))
ret = get_tree_bdev(fc, cramfs_blkdev_fill_super);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cramfs: fix usage on non-MTD device
2019-10-19 19:24 [PATCH] cramfs: fix usage on non-MTD device Nicolas Pitre
@ 2019-10-21 13:45 ` David Howells
2019-10-21 14:04 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2019-10-21 13:45 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: dhowells, Al Viro, Maxime Bizon, linux-fsdevel
Nicolas Pitre <nico@fluxnic.net> wrote:
> From: Maxime Bizon <mbizon@freebox.fr>
>
> When both CONFIG_CRAMFS_MTD and CONFIG_CRAMFS_BLOCKDEV are enabled, if
> we fail to mount on MTD, we don't try on block device.
>
> Fixes: 74f78fc5ef43 ("vfs: Convert cramfs to use the new mount API")
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cramfs: fix usage on non-MTD device
2019-10-21 13:45 ` David Howells
@ 2019-10-21 14:04 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2019-10-21 14:04 UTC (permalink / raw)
To: David Howells; +Cc: Nicolas Pitre, Maxime Bizon, linux-fsdevel
On Mon, Oct 21, 2019 at 02:45:39PM +0100, David Howells wrote:
> Nicolas Pitre <nico@fluxnic.net> wrote:
>
> > From: Maxime Bizon <mbizon@freebox.fr>
> >
> > When both CONFIG_CRAMFS_MTD and CONFIG_CRAMFS_BLOCKDEV are enabled, if
> > we fail to mount on MTD, we don't try on block device.
> >
> > Fixes: 74f78fc5ef43 ("vfs: Convert cramfs to use the new mount API")
> >
> > Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> > Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
>
> Acked-by: David Howells <dhowells@redhat.com>
FWIW, the thing that worries me here is the possibility of
side effects on fs_context in case if fill_super fails really
late... OTOH, cramfs one seems to be safe in that respect.
OK, will apply, but that's fairly brittle and needs to be
documented. If we *ever* grow non-trivial options parsing
there, that'll be a serious landmine. If something gets
transferred from fs_context into a superblock, which
fails later in setup and takes that object with it, the
second part (get_tree_bdev()) would be in trouble.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-21 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 19:24 [PATCH] cramfs: fix usage on non-MTD device Nicolas Pitre
2019-10-21 13:45 ` David Howells
2019-10-21 14:04 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).