* [PATCH] pinctrl: nomadik:remove unneeded variable
@ 2020-03-30 7:56 Ding Xiang
2020-04-16 7:56 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2020-03-30 7:56 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, linux-kernel
ret is unneeded, just return 0.
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 95f864d..4c56483 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1340,8 +1340,6 @@ struct nmk_cfg_param {
static int nmk_dt_pin_config(int index, int val, unsigned long *config)
{
- int ret = 0;
-
if (nmk_cfg_params[index].choice == NULL)
*config = nmk_cfg_params[index].config;
else {
@@ -1351,7 +1349,7 @@ static int nmk_dt_pin_config(int index, int val, unsigned long *config)
nmk_cfg_params[index].choice[val];
}
}
- return ret;
+ return 0;
}
static const char *nmk_find_pin_name(struct pinctrl_dev *pctldev, const char *pin_name)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: nomadik:remove unneeded variable
2020-03-30 7:56 [PATCH] pinctrl: nomadik:remove unneeded variable Ding Xiang
@ 2020-04-16 7:56 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-04-16 7:56 UTC (permalink / raw)
To: Ding Xiang; +Cc: open list:GPIO SUBSYSTEM, linux-kernel
On Mon, Mar 30, 2020 at 9:59 AM Ding Xiang
<dingxiang@cmss.chinamobile.com> wrote:
> ret is unneeded, just return 0.
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-16 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 7:56 [PATCH] pinctrl: nomadik:remove unneeded variable Ding Xiang
2020-04-16 7:56 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).