* [PATCH] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-08-13 11:14 Hanks Chen
2020-08-19 23:43 ` Sean Wang
0 siblings, 1 reply; 3+ messages in thread
From: Hanks Chen @ 2020-08-13 11:14 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger
Cc: linux-mediatek, linux-gpio, linux-arm-kernel, linux-kernel,
CC Hwang, sin_jieyang, Hanks Chen
check mtk_is_virt_gpio input parameter,
virtual gpio need to support eint mode.
add error handler for the ko case
to fix this boot fail:
pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
Singed-off-by: sin_jieyang <sin_jieyang@mediatek.com>
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index c53e2c391e32..27ab9c512ae1 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
+ /* if the GPIO is not supported for eint mode */
+ if (desc->eint.eint_m == EINT_NA)
+ return virt_gpio;
+
if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
virt_gpio = true;
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
2020-08-13 11:14 [PATCH] pinctrl: mediatek: check mtk_is_virt_gpio input parameter Hanks Chen
@ 2020-08-19 23:43 ` Sean Wang
2020-08-20 11:21 ` Hanks Chen
0 siblings, 1 reply; 3+ messages in thread
From: Sean Wang @ 2020-08-19 23:43 UTC (permalink / raw)
To: Hanks Chen
Cc: Linus Walleij, Matthias Brugger,
moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM, linux-arm Mailing List, lkml, CC Hwang,
sin_jieyang
Hi Hanks,
On Thu, Aug 13, 2020 at 4:14 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
>
> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
>
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
it is better we post the complete call stack when the failure occurs
>
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: sin_jieyang <sin_jieyang@mediatek.com>
signed-off-by with the full name
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index c53e2c391e32..27ab9c512ae1 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
>
> desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
>
> + /* if the GPIO is not supported for eint mode */
> + if (desc->eint.eint_m == EINT_NA)
s/NO_EINT_SUPPORT/EINT_NA/ to align with pinctrl/mediatek/pinctrl-mtk-mt*.h uses
> + return virt_gpio;
> +
> if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
> virt_gpio = true;
>
> --
> 2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
2020-08-19 23:43 ` Sean Wang
@ 2020-08-20 11:21 ` Hanks Chen
0 siblings, 0 replies; 3+ messages in thread
From: Hanks Chen @ 2020-08-20 11:21 UTC (permalink / raw)
To: Sean Wang
Cc: Linus Walleij, Matthias Brugger,
moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM, linux-arm Mailing List, lkml, CC Hwang,
sin_jieyang
On Wed, 2020-08-19 at 16:43 -0700, Sean Wang wrote:
> Hi Hanks,
>
> On Thu, Aug 13, 2020 at 4:14 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
> >
> > check mtk_is_virt_gpio input parameter,
> > virtual gpio need to support eint mode.
> >
> > add error handler for the ko case
> > to fix this boot fail:
> > pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> > lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
>
> it is better we post the complete call stack when the failure occurs
>
> >
> > Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> > Singed-off-by: sin_jieyang <sin_jieyang@mediatek.com>
>
> signed-off-by with the full name
Got it, I'll update it in next version.
>
> > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> > ---
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index c53e2c391e32..27ab9c512ae1 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
> >
> > desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
> >
> > + /* if the GPIO is not supported for eint mode */
> > + if (desc->eint.eint_m == EINT_NA)
>
> s/NO_EINT_SUPPORT/EINT_NA/ to align with pinctrl/mediatek/pinctrl-mtk-mt*.h uses
Got it, I'll fix it in next version.
Thanks for your reply
Hanks
>
> > + return virt_gpio;
> > +
> > if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
> > virt_gpio = true;
> >
> > --
> > 2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-20 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-13 11:14 [PATCH] pinctrl: mediatek: check mtk_is_virt_gpio input parameter Hanks Chen
2020-08-19 23:43 ` Sean Wang
2020-08-20 11:21 ` Hanks Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).